Skip to content

πŸ› dashboard: point operator-reference help marks at the section sub-pages - #15890

Merged
clubanderson merged 3 commits into
v5from
scanner/fix-15540
Nov 2, 2026
Merged

clubanderson merged 3 commits into
v5from
scanner/fix-15540

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Dashboard settings help marks linked to the operator-reference index, which is becoming a stub of anchors, so operators needed a second click. The 24 marks now point at the section sub-pages that hold the explanation, and dashboardDocsHrefFromPath accepts / in the page path (still only [\w-] segments, no ..). static-src and the built index.html carry the same hunk. Tests: the help-link anchor check resolves sub-page paths, and a new test rejects the stub target.

Depends on #15731 (the sub-pages and anchors only exist there; the link-check test fails until it lands).

Closes #15540

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2026
clubanderson pushed a commit that referenced this pull request Oct 30, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16247 ✨ Show the Activity Monitor item count and delta cue in the monitor header same files src/pkg/dashboard/static-src/js/sections.js
src/pkg/dashboard/static/index.html
#16241 ✨ Kiosk 'Request a Hive' CTA badge for Twitch streams + channel metadata script same files src/pkg/dashboard/static/index.html
#16228 πŸ› dashboard: align contributor presence counts and person IDs same files src/pkg/dashboard/static/index.html
#16240 ✨ feat: name the sentinel's flagged paths and rules in the decision dialog and hive comment same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

DEFER β€” stacked on #15731. Converting to draft until it lands.

test (dashboard 4/4) / test (dashboard shuffle 2/3) fail only in TestSettingHelpMarksAreDocsLinks: it resolves each help mark to src/docs/<page>.md, and the 24 retargeted marks point at operator-reference/{README,runtime-and-quota,sweeps-and-operations} β€” pages that exist only in #15731 (the operator-reference split; #15516 was closed and re-authored there). coverage is red only because those shards are.

Checked against #15731's head (b0f3a4a): all 24 page/anchor pairs resolve, and this branch merges cleanly into current v5. Nothing in this PR can turn that test green before the split merges; the earlier changelog-fragment-guard failure is already fixed on this head (38eb03e).

Next step: once #15731 merges, rebase this branch on v5 and mark it ready for review.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 38eb03e

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot removed the stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it label Oct 30, 2026
hivecommons-hive Bot and others added 3 commits November 2, 2026 10:26
…b-pages

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the change against the tree at ed5a4f2; this looks correct to me.

  • Every retargeted help mark resolves. I extracted all seven settingHelpMark('operator-reference/…', '<anchor>') pairs from static-src/js/config-*.js at this head and checked them against src/docs/operator-reference/: README.md (label-driven-approval, notable-fields, app-self-merge-sweep-auto_merge ← heading at README.md:374), runtime-and-quota.md (github-api-quota), and sweeps-and-operations.md (delivery-sla, github-api-budget-governor, suspicious-activity-alerts-sentinel) all have matching headings.
  • dashboardDocsHref (sections.js:169-172) interpolates page directly into src/docs/${page}.md, so a slash-bearing page needs no other change; the dashboardDocsHrefFromPath regex widening at sections.js:174 is the only parser that had to learn sub-paths, and the new test asserts it.
  • static/index.html is regenerated in the same commit (25/25 lines), so the bundled dashboard matches static-src.

Minor, not a defect: two changelog fragments land for one change (fixed-15540.md describes the behaviour; fixed-15890.md only restates the PR title). A maintainer may want to drop the second when merging.

Comment only; I have not approved or changed anything.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit b11d139 into v5 Nov 2, 2026
86 of 89 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15540 branch November 2, 2026 16:12
clubanderson added a commit that referenced this pull request Nov 2, 2026
…he stale-draft rule (#16248)

* πŸ› github: don't let prow's WIP mirror label shield hive drafts from the stale-draft rule

fetchPRsWithDetails checked exempt labels before the draft branch, and
PermanentExemptLabels prefix-matches do-not-merge, so the
do-not-merge/work-in-progress label prow adds to every draft filtered every
hive-authored draft as "Exempt label". The 48h stale-draft rule never ran,
the scanner never saw the PR in "YOUR STALE DRAFT PRs", and the linked issue
stayed suppressed as covered_by_open_pr β€” a deadlock (#15890/#15540).

A draft whose only exempt label is the WIP mirror now falls through to the
draft branch; any other do-not-merge/* or configured exempt label still
filters it.

Closes #16246

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* docs: refresh RankActionableIssues line citation after client.go shift

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (docs-currency): Dashboard help marks still land on index stub page (advisory, unchanged)

1 participant