Repository navigation
π dashboard: point operator-reference help marks at the section sub-pages - #15890
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
DEFER β stacked on #15731. Converting to draft until it lands.
Checked against #15731's head ( Next step: once #15731 merges, rebase this branch on π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
β¦b-pages Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
38eb03e to
ed5a4f2
Compare
There was a problem hiding this comment.
Read the change against the tree at ed5a4f2; this looks correct to me.
- Every retargeted help mark resolves. I extracted all seven
settingHelpMark('operator-reference/β¦', '<anchor>')pairs fromstatic-src/js/config-*.jsat this head and checked them againstsrc/docs/operator-reference/:README.md(label-driven-approval,notable-fields,app-self-merge-sweep-auto_mergeβ heading atREADME.md:374),runtime-and-quota.md(github-api-quota), andsweeps-and-operations.md(delivery-sla,github-api-budget-governor,suspicious-activity-alerts-sentinel) all have matching headings. dashboardDocsHref(sections.js:169-172) interpolatespagedirectly intosrc/docs/${page}.md, so a slash-bearing page needs no other change; thedashboardDocsHrefFromPathregex widening atsections.js:174is the only parser that had to learn sub-paths, and the new test asserts it.static/index.htmlis regenerated in the same commit (25/25 lines), so the bundled dashboard matchesstatic-src.
Minor, not a defect: two changelog fragments land for one change (fixed-15540.md describes the behaviour; fixed-15890.md only restates the PR title). A maintainer may want to drop the second when merging.
Comment only; I have not approved or changed anything.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦he stale-draft rule (#16248) * π github: don't let prow's WIP mirror label shield hive drafts from the stale-draft rule fetchPRsWithDetails checked exempt labels before the draft branch, and PermanentExemptLabels prefix-matches do-not-merge, so the do-not-merge/work-in-progress label prow adds to every draft filtered every hive-authored draft as "Exempt label". The 48h stale-draft rule never ran, the scanner never saw the PR in "YOUR STALE DRAFT PRs", and the linked issue stayed suppressed as covered_by_open_pr β a deadlock (#15890/#15540). A draft whose only exempt label is the WIP mirror now falls through to the draft branch; any other do-not-merge/* or configured exempt label still filters it. Closes #16246 Signed-off-by: Andrew Anderson <andy@clubanderson.com> * docs: refresh RankActionableIssues line citation after client.go shift Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Dashboard settings help marks linked to the operator-reference index, which is becoming a stub of anchors, so operators needed a second click. The 24 marks now point at the section sub-pages that hold the explanation, and dashboardDocsHrefFromPath accepts
/in the page path (still only[\w-]segments, no..). static-src and the built index.html carry the same hunk. Tests: the help-link anchor check resolves sub-page paths, and a new test rejects the stub target.Depends on #15731 (the sub-pages and anchors only exist there; the link-check test fails until it lands).
Closes #15540
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88