Repository navigation
π Show boundary blocking as demonstrated enforcement, not a bad grade - #16231
Conversation
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Evidence bundle `#16231377d5bf` sha256:4c13d87bdb91985869a990b1a3b8dfed1c000004fc59c51df29a048e0ec9e3b6 β download from the dashboard or `hivectl review evidence #16231`. |
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
CI caught a missing |
|
Exact-head CI update ( |
There was a problem hiding this comment.
Read the diff against the v5 tree plus the consumers of the boundary grade. Looks correct to me; the body matches the code.
src/pkg/evidence/grade.go:466-475βGradeBoundarynow always returnsNoGrade(...). The only caller issrc/pkg/dashboard/evidence_cards.go:84, and nothing inpkg/evidence,pkg/dashboardorpkg/hubaggregates card letters into an overall score, so demoting this card toEnoughData:falsechanges only this card's badge, not any fleet/hive total.pctShare(grade.go) already returnsβforden <= 0, so the new reason strings are safe whenTotalWrites == 0β the removedTotalWrites < GradeMinNearly return was the only guard, and it is not needed.static-src/js/evidence.js:463-470, 506-510special-caseboundary-enforcementin both the explainer rubric and the panel pill, and the droppedEV_BLOCKED_STRONG/FAIRconstants have no remaining references.static/index.htmlcarries the same 23-line change, so the generated bundle is in sync with source.- Hub (
evidence_report.go:132,evidence_findings.go:268-276,assets/dashboard.html) was already "Not graded"; this aligns the wording and makes the spoke card agree with it.src/docs/review-evidence.mdgrade tables updated in both the server and client-fallback sections.
No findings.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
/approve Owner-requested, agent-assisted decision under @clubanderson's explicit delegation for this batch; this is not a separate independent human review. Reviewed the current diff and surrounding source at the exact commit below. Inspected head: Accept this boundary-observation semantics change: one or more blocked writes demonstrates enforcement on those attempts; zero is unobserved, not failed. Sentinel detections stay informational and bypass/false-positive limitations remain explicit. Reviewed canonical grade/dashboard/hub paths and matching regression changes; current technical CI is green. This is presentation/measurement policy, not removal of enforcement. The existing author claim stays. This PR is authored by the stored account. I am not submitting an impossible native self-approval or pretending this is a separate human review. |
Summary
Validation
No production configuration or deployment changes.