Skip to content

πŸ› Show boundary blocking as demonstrated enforcement, not a bad grade - #16231

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
fix/boundary-enforcement-evidence-20261102
Nov 2, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
fix/boundary-enforcement-evidence-20261102

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

  • Replace refusal-rate letter grades with ungraded enforcement observations: any actual block demonstrates exercise on that attempt; zero means not observed.
  • Preserve blocked counts, observed-write denominators, coverage notices and informational Sentinel detections. No new score, threshold, configuration or claim of bypass/false-positive absence.
  • Align spoke cards/explainers and hub findings/reports; regenerate dashboard HTML from source.

Validation

  • Added focused Go and UI regressions for 77/652 blocked, one block, zero, low samples, Sentinel-only, missing counters and partial coverage.
  • Formatting and static generation completed. Per AGENTS.md, tests/build/lint/docs guards run only in CI.
  • Independent precommit code review completed; fixed its server/client finding parity issue.

No production configuration or deployment changes.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 2, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16228 πŸ› dashboard: align contributor presence counts and person IDs same files src/pkg/dashboard/static/index.html
#15890 πŸ› dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 3/4)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Evidence bundle `#16231377d5bf` sha256:4c13d87bdb91985869a990b1a3b8dfed1c000004fc59c51df29a048e0ec9e3b6 β€” download from the dashboard or `hivectl review evidence #16231`.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

CI caught a missing formatNumber dependency in the extended Node regression harness (dashboard 3/4); fixed in a follow-up DCO commit. No production code change was needed. Awaiting exact-head CI and genuine owner review/approval; no gates bypassed.

@clubanderson

Copy link
Copy Markdown
Member Author

Exact-head CI update (377d5bf06dde0aab4cfbc14383d6551185bbd1f8): all dashboard shards (including three shuffle shards), all hub shards and all rest shards passed; golangci-lint and changelog guard passed. The previously failing boundary rendering harness now passes. No local tests/build/lint/docs guards were run. Remaining automation is still progressing. Tide explicitly requires genuine approved and lgtm labels; this PR has not been merged or deployed and no approvals/gates were bypassed.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the v5 tree plus the consumers of the boundary grade. Looks correct to me; the body matches the code.

  • src/pkg/evidence/grade.go:466-475 β€” GradeBoundary now always returns NoGrade(...). The only caller is src/pkg/dashboard/evidence_cards.go:84, and nothing in pkg/evidence, pkg/dashboard or pkg/hub aggregates card letters into an overall score, so demoting this card to EnoughData:false changes only this card's badge, not any fleet/hive total.
  • pctShare (grade.go) already returns β€” for den <= 0, so the new reason strings are safe when TotalWrites == 0 β€” the removed TotalWrites < GradeMinN early return was the only guard, and it is not needed.
  • static-src/js/evidence.js:463-470, 506-510 special-case boundary-enforcement in both the explainer rubric and the panel pill, and the dropped EV_BLOCKED_STRONG/FAIR constants have no remaining references. static/index.html carries the same 23-line change, so the generated bundle is in sync with source.
  • Hub (evidence_report.go:132, evidence_findings.go:268-276, assets/dashboard.html) was already "Not graded"; this aligns the wording and makes the spoke card agree with it. src/docs/review-evidence.md grade tables updated in both the server and client-fallback sections.

No findings.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 8ad8a05 into v5 Nov 2, 2026
78 of 79 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/boundary-enforcement-evidence-20261102 branch November 2, 2026 15:09
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@clubanderson

Copy link
Copy Markdown
Member Author

/approve

Owner-requested, agent-assisted decision under @clubanderson's explicit delegation for this batch; this is not a separate independent human review. Reviewed the current diff and surrounding source at the exact commit below.

Inspected head: 377d5bf06dde0aab4cfbc14383d6551185bbd1f8.

Accept this boundary-observation semantics change: one or more blocked writes demonstrates enforcement on those attempts; zero is unobserved, not failed. Sentinel detections stay informational and bypass/false-positive limitations remain explicit. Reviewed canonical grade/dashboard/hub paths and matching regression changes; current technical CI is green. This is presentation/measurement policy, not removal of enforcement. The existing author claim stays.

This PR is authored by the stored account. I am not submitting an impossible native self-approval or pretending this is a separate human review. /approve, where present, records owner direction through Prow; an eligible reviewer still supplies the genuine lgtm/review path. No durable ownership, unrelated hold, CI gate or branch protection is removed. No local Hive suite/build/vet was run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant