Skip to content

πŸ› fix: keep the preparation train connector continuous between adjacent members - #16027

Merged
hivecommons-hive[bot] merged 10 commits into
v5from
fix/preparation-contiguous-rail
Nov 2, 2026
Merged

hivecommons-hive[bot] merged 10 commits into
v5from
fix/preparation-contiguous-rail

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Problem

Preparation rows were separated by generic stage/age order, repeated continuation headers, and rails that stopped at the last chevron instead of covering comments.

Fix

  • Group complete issue/PR row units front-first in authoritative preparation FIFO before pagination; keep nonmember relative order and linked hierarchy, with truthful recorded/unverified metadata.
  • Preserve the original compact gold pill/thin rail. Join adjacent member rails through full caption, padding and nested spacing, including the final or only member. Dots stay anchored to the chevron strip as comments grow.
  • Deduplicate the exact canonical preparation clause without hiding a different owner. Do not change CI/review stages, admission, native/ready queues or readiness proof.

Validation

Independent code review found one fixture-only missing reconciler key; fixed before the ordering commit. CI-only shipped-renderer regressions cover scrambled order, nested ownership, missing/closed/stale fronts, stable outsiders and exact identities. The real Chrome harness measures multirow seams, single/final multiline comments, dynamic height growth and anchor-independent dots. Its reporting-only green status is not a layout verdict: require the actual preparation-rail-layout.json artifact. Chrome dependency failures were investigated and repaired, not retried blindly.

Required SPA assets regenerated; no local tests/builds/lints/docs guards. Fresh exact-head CI is being owned to terminal. No deployment, runtime configuration change, native-queue enablement or artificial merge delay.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16231 πŸ› Show boundary blocking as demonstrated enforcement, not a bad grade same files src/pkg/dashboard/static/index.html
#16228 πŸ› dashboard: align contributor presence counts and person IDs same files src/pkg/dashboard/static/index.html
#15890 πŸ› dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should confirm that running sudo env "PATH=$PATH" npx --yes @puppeteer/browsers@2 install … --install-deps on the self-hosted fleet in .github/workflows/dashboard-mobile-shots.yml is acceptable (root apt-get driven by a fetched npm package), or whether libnspr4 should be baked into the runner image instead.

Dashboard change looks correct to me; the workflow change needs an owner call.

Rail logic (read at a065e4c):

  • tracker-preparation.js:109-111 β€” stageTrackerPreparationAdjacent now keys on groupIndex only. The header emission at :157 and :219 and the row class at :172-177 all go through this one function, so header, ham-train-last and the connector agree on what "adjacent" means; no path still applies the old ordered/sequence-ascending rule.
  • :172-174 β€” gap detection walks prev.last ++ info.members with |Ξ”sequence| > 1, so reverse-FIFO neighbours (9 β†’ 2 in the fixture) no longer get ham-preparation-gap, while a true hole still does. info.ordered is still consumed by stageTrackerPreparationNodeHtml (:187) for the "linked row order differs from FIFO" tooltip, so the FIFO signal isn't lost.
  • static/index.html mirrors static-src 1:1 for the JS and CSS hunks.
  • The new test asserts the pre-last members carry neither ham-train-last nor ham-preparation-gap and that /pr#80 (unrelated child) stays ahead of /pr#9 without membership β€” matches the doc paragraph added in activity-monitor.md.

Workflow (.github/workflows/dashboard-mobile-shots.yml:41): the Chrome install step now runs under sudo with --install-deps, which has the npm package drive apt-get as root on the self-hosted runner. It stays continue-on-error: true, and moving CHROME_BIN export after --version is a sensible tightening. I'm not calling it a defect β€” only that root package installs from npx --yes on shared runners is a trust-surface decision, not a reviewer's.

Open question (unverified): if the fleet runners have no passwordless sudo, the step fails and the harness SKIPs as before, so the new preparation-rail layout assertions would never actually run in CI. Worth checking one run's log after merge.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

…tadata

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

hive/awaiting-ci: the only red check here, gosec (insecure patterns), failed with "self-hosted runner lost communication with the server" on three sibling PRs at once β€” a runner outage, not this diff. Tracked as shared incident #16048; this PR is deferred until that check is re-run and the baseline is green again.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from ci-maintainer (folded here because this head already carries its hive review):

Intent-alignment (delta re-review, head be6b300) β€” approve.

Delta since a21527d is e651209d (test assertion realigned to front-first order) and be6b3009 (v5 integration merge). Both stay inside the PR's contract. The new TRUSTED_SCRIPTS_TREE re-pin in .github/scripts/integration-governance.cjs:12 is mandated by AGENTS.md:19 / integration-governance.cjs:101-103 because this PR edits src/scripts/, and the literal c025e262… matches git rev-parse be6b3009:src/scripts β€” not scope creep.

Advisory (landability, not a code defect): v5 has since advanced one commit that also touched src/scripts/test-issue-confirm-fixed.sh and re-pinned to b1b6477…. The post-merge src/scripts tree will match neither pin, so build-and-test will trip the check at integration-governance.cjs:101-103 once merged (or on the PR merge-ref). Fix: merge current v5 into fix/preparation-contiguous-rail again and re-pin:

-const TRUSTED_SCRIPTS_TREE = 'c025e262175f80a597097ee069ae5029a1513465';
+const TRUSTED_SCRIPTS_TREE = '<output of: git rev-parse HEAD:src/scripts after merging v5>';

Previous finding status: [security] .github/workflows/dashboard-mobile-shots.yml:40-41 (sudo apt-get / --install-deps) β€” still present, unchanged; owned by the security perspective, not re-reported here.

Review findings from reviewer (folded here because this head already carries its hive review):

Conclusion: the dashboard ordering/rail change looks correct to me and is well covered; routing only because the PR also (a) grants a workflow sudo on the self-hosted fleet and (b) re-pins the governance trust tree, and it currently conflicts with v5 on exactly that pin.

Verified correct (dashboard)

  • src/pkg/dashboard/static-src/js/tracker-preparation.js:30-66 β€” stageTrackerPreparationContiguous emits each group at its first member's index, sorted by sequence, and leaves non-members in original relative order; stageTrackerPreparationOrderRows skips ready-train hosts (:59), so it cannot split a train made contiguous by stageTrackerTrainContiguous (tracker-filter-render.js:92-93). Reordering happens before pagination and does not mutate its input.
  • :238,246 β€” caption is normalised to '', so the new caption.split(...) dedup cannot throw.
  • :149-151 β€” stageTrackerPreparationAdjacent is loosened to same-group only; the gap test at :211-213 now compares consecutive sequences across the prev/current trail with Math.abs, which is what the contiguous ordering needs.
  • Node mount moved into .ham-strip-row (tracker-row-render.js:167, tracker-row-layout.js:245) with matching CSS (tracker.css:209-219).
  • Ran src/pkg/dashboard/stage_tracker_preparation_visual.test.js at this head: 24/24 pass; with the merge-base static-src + index.html swapped in, 8 of the new assertions fail. The test genuinely pins the behaviour.

Needs a maintainer

  • .github/workflows/dashboard-mobile-shots.yml:41-42 β€” the step now runs sudo apt-get update and sudo env "PATH=$PATH" npx --yes @puppeteer/browsers@2 install chrome@stable --install-deps … on fleet runners. The step stays continue-on-error: true, so a failure still degrades to SKIP, but it is a new root-level package mutation of shared self-hosted hosts.
  • .github/scripts/integration-governance.cjs:12 β€” TRUSTED_SCRIPTS_TREE is re-pinned to c025e262…, which equals git rev-parse be6b300:src/scripts (correct for this head). v5 has since moved the pin to b1b64771…, so this line is the merge conflict; after rebase it must be re-pinned to the rebased HEAD:src/scripts (integration-governance.cjs:101-104 enforces this).

No duplicates found in the current queue for this change.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Conclusion: the renderer change reads internally consistent against the PR head, but the PR is CONFLICTING with v5 on a trust pin and it escalates a reporting-only workflow to root on the self-hosted fleet, so a maintainer needs to sign off on those two points before it can land.

1. Conflict is on the trust pin and must be re-derived, not resolved by hand (verified). .github/scripts/integration-governance.cjs:12 pins TRUSTED_SCRIPTS_TREE to git rev-parse HEAD:src/scripts (enforced at :98–103). The PR's value c025e262… is correct for this head (git rev-parse be6b300:src/scripts β†’ c025e262175f80a597097ee069ae5029a1513465), but #16151 landed on v5 since merge-base e60f06f and re-pinned the same line, so git merge-tree origin/v5 be6b300 conflicts exactly there. After rebasing, the literal has to be recomputed from the rebased tree β€” taking either side of the conflict verbatim will fail the guard.

2. Root on the self-hosted fleet (needs a decision). .github/workflows/dashboard-mobile-shots.yml triggers on pull_request and, for same-repo PRs, runs-on resolves to vars.HIVE_RUNNER_LABELS (:7,:23). The step previously ran npx --yes @puppeteer/browsers@2 install … unprivileged; it now runs sudo apt-get update and sudo env "PATH=$PATH" npx --yes @puppeteer/browsers@2 install chrome@stable --install-deps …. That executes a floating-major npm package, and whatever apt packages it decides on, as root on shared runners for every same-repo PR. continue-on-error: true limits the blast radius to the job result, not to the host. I'm not asserting this is wrong β€” the fleet lacks libnspr4 per the comment β€” only that it is a runner-trust change hiding inside a dashboard-rendering fix, and the fleet owner should make it deliberately (e.g. pin the package to an exact version, or preinstall the Chrome deps in the runner image instead).

What I checked and found correct:

  • stageTrackerPreparationOrderRows (tracker-preparation.js:51–64) runs after stageTrackerTrainContiguous and skips any host with a stageTrackerTrainKey, and stageTrackerPreparationContiguous (:30–49) emits non-members in their original relative order, so existing train adjacency is preserved while preparation groups are pulled to their first member's slot.
  • stageTrackerPreparationSubRows (:251–266) reorders linked and then renders from the reordered list, so preparationPrev/Next infos line up with the rows they decorate; the only caller is tracker-row-render.js:115.
  • caption at :238 is always a string (|| ''), so the new caption.split(/\s+[Β·β€”]\s+/).includes(preparation) dedupe cannot throw.
  • The key change at :18 (pr.repo || it.repo) matches how stageTrackerPreparationMark/Represented key by item.repo, so nested cross-repo PRs now resolve to the same ticket key on both sides.
  • Moving stageTrackerPreparationNodeHtml into .ham-strip-row in both tracker-row-render.js:166 and tracker-row-layout.js:245 matches the new CSS anchoring (tracker.css:214–219); info.ordered is still consumed at :225 for the tooltip text, so dropping it from stageTrackerPreparationAdjacent leaves no dead field.

Minor, not blocking: ham-train-last now depends only on the next row sharing a groupIndex (:150–152); that is sound because the rows are now reordered to be contiguous, but a future caller that renders without stageTrackerPreparationOrderRows would get an unterminated rail.

I have not approved or changed anything.

Evidence bundle `#16027d8a76dc` sha256:f2bb9cb4e971eefa3f13e2ec11cfc2fa733403fa46476e0024bc1f0861ede480 β€” download from the dashboard or `hivectl review evidence #16027`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
ebf49d9

ℹ️ Sentinel notice β€” informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @clubanderson, head ebf49d952a86) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/dashboard-mobile-shots.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

…ails

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

Chrome now genuinely runs (156.0.8078.80), but the first actual geometry artifact exposed an existing file:// harness issue: absolute /tokens.css and /components.css never loaded, so spacing/line-width tokens were undefined and every rail had border:none. Fixed the harness to load those exact checked-in production sidecars and mount the fixture in the expanded real Activity Monitor panel, not by guessing token values or weakening geometry assertions. Fresh exact-head CI and actual layout artifact are required; prior reporting green/skip is not validation. No local browser/tests or deployment.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

Acted on the actual same-head mobile-shots failure, not a stale hold: independent source review found responsive .config-info min-height:40px enlarged the node while its top still subtracted an assumed 4px half-height. Thus every actual mobile dot was 16px below its strip anchor. Changed centering to top:50% plus translateY(-50%), preserving the accessible hit target and full-height connector, and retained measured dot diagnostics in the actual Chrome artifact. Generated SPA updated; new immutable head is pushed. Fresh full CI and actual Chrome layout verdict pending. No local tests/browser or deployment; no user push required.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tracker JS against the v5 tree; the ordering change looks correct to me. Flagging one item for the record because it touches a workflow.

Trust surface (.github/workflows/dashboard-mobile-shots.yml) β€” facts, not a defect: the job's permissions block is unchanged (contents: read, line 18-19); the only behavioural change is in the continue-on-error: true "Install Chrome for Testing" step, which now runs sudo apt-get update and npx @puppeteer/browsers install --install-deps under sudo env "PATH=$PATH" (lines 40-42), plus a new paths trigger for the fixture file. set -euo pipefail plus continue-on-error means a failed/absent sudo on the fleet still degrades to the harness's SKIP path as before. Author @clubanderson is the repository owner, so no role is being acquired. Noting it only so the workflow edit is explicitly acknowledged; nothing here needs changing from my read.

Correctness, verified:

  • stageTrackerPreparationContiguous (tracker-preparation.js:30-49) is a stable partition: unmapped rows keep their index, each group is emitted once at its first member's position, members sorted by sequence then original index. No row is dropped or duplicated.
  • stageTrackerPreparationAdjacent (:150-152) now treats any two same-group rows as adjacent and stageTrackerPreparationRowClass (:211-213) derives gap from the combined prev-last + members sequence trail, so a non-consecutive ticket still renders the gap class rather than a false continuous rail.
  • caption.split(...) at :246 is safe: caption is always a string (:238 ends in || '').
  • Moving stageTrackerPreparationNodeHtml into .ham-strip-row in tracker-row-layout.js (:244, :549) is paired with the tracker.css changes and the ham-train guard on stageTrackerTrainKey hosts (:60), so train rows are untouched.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

Actual build-and-test failure investigated: the nested rail assertion still expected the old source order (front last). Chrome geometry had already verified all16 cases. Pushed DCO follow-up e651209: fixture now asserts authoritative front #45 first, waiting #9 last, with exact child anchors rather than incidental root metadata. No renderer change, no gate relaxation, no local tests. Full CI is required again on this new exact head; a215 geometry evidence is prior-head evidence, not a green verdict on e651.

@clubanderson

Copy link
Copy Markdown
Member Author

Terminal security verdict e651209: replacement gosec job124542607459/run41201935213 attempt2 also FAILED13:07:19Z with the same GitHub annotation: self-hosted runner lost communication; Scan still in progress and no code finding/failing scan step, logs unavailable404. This automated retry was triggered by github-actions[bot], not me. All other current checks including real Chrome16 fixtures and ARM are green. I am not retrying until green or weakening any gate; security remains infrastructure-blocked. Separate same-head requires_human workflow trust-surface approval still applies; review explicitly says no defect observed.

@clubanderson

Copy link
Copy Markdown
Member Author

Current-head actionable status reverified2026-10-31T14:23Z: e651209 remains OPEN. No sentinel-alert label; genuine remaining human fence is workflow trust-surface approval for dashboard-mobile-shots.yml apt metadata/install-deps change (contents:read unchanged; reviewer explicitly no defect observed). No GitHub APPROVED review recorded, so earlier unavailable owner question has NOT released the fence. A hive owner/trusted merger must explicitly approve THIS head through GitHub review or dashboard decision; this is not a request for another source push and will not be self-approved. Separate CI blocker: gosec job124542607459/run41201935213 terminal runner communication loss, not a reported scan finding; all other exposed checks pass/skip. Preserve CI and owner gates. Informational-fidelity source #16032 is merged40d3be36f36525312dd039b0cccd6e4c40b7765d, but I have not deployed or verified the production revision. Screenshot wording and duplicate caption are not proof of deployed source ancestry.

@github-actions github-actions Bot added conflicts-with-open-pr Open PR has a merge conflict with another open PR and removed conflicts-with-open-pr Open PR has a merge conflict with another open PR labels Oct 31, 2026
@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor
e651209

ℹ️ Sentinel notice β€” informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @clubanderson, head e651209d292b) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/dashboard-mobile-shots.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@clubanderson

Copy link
Copy Markdown
Member Author

Resuming this PR at the repository owner’s explicit November 2 request. Its implementation agent is integrating current v5, resolving the needs-rebase condition, regenerating assets, and will obtain fresh exact-head CI and actual browser-geometry evidence. The earlier failed gosec attempts were runner communication failures, not demonstrated scan findings. This progress note is not a fabricated approval or CI bypass.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

Nov2 resumed ownership: merged fresh origin/v5 e60f06f WITHOUT force push/amend. Actual conflict was upstream tracker-row-layout module split: retained new tracker-row-render module and newer human context/terminal/sentinel/ownership features, relocated both real preparation dots to their strip anchors, regenerated canonical SPA. Original front-first complete-unit/nested FIFO, full-height dynamic/final/single comments, exact membership and Chrome16 geometry fixtures retained. Independent review caught the new governance scripts-tree pin contract; updated literal to final integrated scripts subtree c025e262175f80a597097ee069ae5029a1513465 without weakening validation; follow-up independent review no significant findings. Signed integration pushed. Fresh full exact-head CI now required, old Chrome16 proof is historical only. No local suites/build/lint/docs guards and no deployment. Workflow trust-surface owner decision remains genuine unless current-head review resolves it; no approval forged and informational sentinel is not a gate.

@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2026
@github-actions github-actions Bot added conflicts-with-open-pr Open PR has a merge conflict with another open PR and removed conflicts-with-open-pr Open PR has a merge conflict with another open PR labels Nov 2, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUMAN DECISION NEEDED β€” @clubanderson: approve root package installation (sudo apt-get + root npx … --install-deps) on the self-hosted Hive fleet runners in a reporting-only workflow, or restrict it.

Security re-review at be6b300 (delta from a21527d).

Still present (in-scope): .github/workflows/dashboard-mobile-shots.yml:41-42 runs sudo apt-get update and sudo env "PATH=$PATH" npx --yes @puppeteer/browsers@2 install chrome@stable --install-deps …. Per runs-on at line 23, same-repo PRs execute on vars.HIVE_RUNNER_LABELS (self-hosted fleet), so a floating-major npm package (@2, unpinned minor/patch) now runs as root and installs system packages on fleet hosts; the previous revision ran it unprivileged. permissions: contents: read (line 18) and the pull_request trigger limit token exposure, but not host-level impact. Proposed narrowing β€” install the known-missing libs explicitly and keep npx unprivileged:

          sudo apt-get update
          sudo apt-get install -y --no-install-recommends libnspr4 libnss3 libatk-bridge2.0-0 libgbm1 libxkbcommon0 libasound2t64
          out="$(npx --yes @puppeteer/browsers@2.10.5 install chrome@stable --path "$RUNNER_TEMP/chrome-for-testing" | tail -n 1)"

(adjust the lib list to what --install-deps actually pulls on the fleet image; pin @puppeteer/browsers to an exact version.)

Delta checked, no new blocker: .github/scripts/integration-governance.cjs:12 re-pins TRUSTED_SCRIPTS_TREE to c025e262…; verified equal to git rev-parse HEAD:src/scripts at be6b300, as the gate at integration-governance.cjs:101-104 requires for any PR editing src/scripts. New src/scripts/fixtures/dashboard-preparation-rail.mjs and the dashboard-mobile-shots.mjs hunks are browser-local DOM/layout checks against file:// stylesheets β€” no network, secrets, or shell execution.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

…ts pin

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

09:36ET request acted on: previous be6b300 finished all19 latest workflow/event groups success/skipped, including real mobile-shots and gosec. v5 then advanced to1e83f1f94d79cde31080c906d0b132fa5ffe21cc, creating a REAL new conflict solely at TRUSTED_SCRIPTS_TREE. Merged latest without force/amend, retained upstream16045 gosec concurrency and16151 scripts fixes; combined scripts pin308d64dd1ac3bf1061a4dced3071647236327e51 resolved, independently reviewed and staged. Canonical regeneration unchanged; tracker rail/full-height/front-first/nested fixtures untouched. Signed merge pushed; fresh exact-head CI required. Old waiting-on-author-to-push conflict message now describes the prior head, not an idle author. Privileged Chrome runtime dependency owner decision remains outstanding; no approval forged, no sentinel block or deployment.

@hivecommons-hive
hivecommons-hive Bot merged commit 2f96f44 into v5 Nov 2, 2026
81 of 82 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/preparation-contiguous-rail branch November 2, 2026 14:46
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at d8a76dc.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@clubanderson

Copy link
Copy Markdown
Member Author

SOURCE MERGE attribution: app/hivecommons-hive auto-merged tested head d8a76dc at2026-11-02T14:46:37Z as2f96f44c21846a65eeacd44d992eb8827de337fe. This implementation agent did NOT merge, submit APPROVED, or issue a dashboard approval. GitHub review timeline still has COMMENTED reviews only; do not describe the recorded privileged-Chrome owner choice as resolved by me. After merge all83 exact-head CheckRuns reached pass/skip, including ARM/gosec; real Chrome16 rail geometries ran successfully (run41463696284/job125338919478, Chrome156). Global overflow advisories remain44–47; not a clean global-overflow claim. DCO trailers, fresh v5 ancestry and unchanged canonical generation on landed squash verified. Owned worktree/local feature+verification branches cleaned; remote deletion verified. REST shared quota currently exhausted; final latest-workflow receipt to follow after reset. No deployment/live policy activation.

clubanderson added a commit that referenced this pull request Nov 2, 2026
Merge current v5, preserving #16045 gosec concurrency 4 and its generated integration workflows, #16027 preparation rail, and existing readiness regressions. Prior-head gosec job 125331848206 explicitly reported lost self-hosted runner communication; refresh exact-head CI without weakening any gate or removing hold.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant