Repository navigation
Conversation
Expose the persisted abandoned count without changing rankings, and append columns to the dashboard and contribute landing standings. Cover JSON values, legacy zero defaults, and both renderers. Hive-Run: hivecommons#15796 Hive-Plan: issue-15796-leaderboard-columns Hive-Spec: issue-15796#acceptance Signed-off-by: mendezr <mendezr@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
|
@mendezr this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: optional-check-failing:test (dashboard 4/4) |
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
There was a problem hiding this comment.
Not a duplicate of #15802 or #15863 — this is the leaderboard layer from #15796. Two sequencing facts a maintainer should know before merging:
src/pkg/dashboard/contribute_profiles.go:192-193addsAbandoned intwith a one-line comment; #15802 and #15863 add the same field at the same spot with a different six-line comment plusAbandonedPRs. Textually different hunks at the same location → this PR conflicts with both of them, whichever lands first. Thecontribute_leaderboard.go:20/:69changes are fine and theLeaderboardEntry.Abandonedhunk is byte-identical to the one in #15865, so those two merge cleanly together.buildLeaderboardWithInputscopiesp.Abandonedinto the row, but nothing onv5writes it until #15802 merges — the column is zero for every contributor until then (as the body already states).
Suggested: after #15802 lands, rebase and drop this PR's ContributorProfile.Abandoned declaration so the core PR's field (with the append-only AbandonedPRs records) is the single definition.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the tree at 0c0aa58. This looks correct to me.
LeaderboardEntry.Abandonedis populated fromp.AbandonedinbuildLeaderboardWithInputs(contribute_leaderboard.go:69); no ranking input changes.- Header and row both emit eight children in the same order (
contribute_landing.go:3309adds the stat afterlb-spark,:3356adds the header after Trend), so the mobilenth-childplacement at:1556-1557keeps header over column. Sort keyabandonedfalls back to0. go build ./pkg/dashboard ./cmd/hiveclean at this head.
One integration note: your Abandoned field comment differs from #15802's, so when #15802 lands first (it should) the contribute_profiles.go conflict should resolve to #15802's declaration, which also adds AbandonedPRs. Not a duplicate of #15802 or #15863 — I diffed all three.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15842:4/6:0/0:main.go,contribute_landing.go,contribute_leaderboard.go,contributors.js,+4 |
|
stage 080-awaiting-merge-admission → 050-review-pending: base-refresh:queued-behind#15868 |
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Ready for a human merge: verdict approved @0c0aa58, 57/57 checks green, DCO yes, soak 10m0s elapsed. Blocked only by The hive never approves on your behalf: |
Share heartbeat and task-status row conversion, merge abandoned counts across public spokes, and document the additive wire field. Include the prerequisite dashboard row field shared with #15859; profile population remains in that PR. Hive-Run: #15799 Hive-Plan: 15799-heartbeat-and-hub-leaderboard Hive-Spec: issue-15799#acceptance Signed-off-by: mendezr <mendezr@users.noreply.github.com> Co-authored-by: mendezr <mendezr@users.noreply.github.com>
|
Supersede failed: the hive could not open a fresh PR with these commits. Merging Files changed on both sides:
Rebase this branch onto |
|
Merge relay refused this fork PR (contributor-lane policy; author tier none) and it is now CONFLICTING with v5 after #15802 (core adoption accounting, which owns 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Summary
Fixes #15796
abandonedto leaderboard JSON, including explicit zero for legacy profiles, without changing ranking or existing fields.Dependency / integration
Core adoption accounting is in open PR #15802. This PR includes only its prerequisite
ContributorProfile.Abandoned intJSON field so it builds independently on v5; it does not implement adoption accounting. When integrating #15802, retain a singleAbandonedfield together with that PR's records and reconciliation logic. Until the core writer lands, existing profiles display zero.Validation
gofmt -lon changed Go files: clean.— hive: backend=pi model=openai-codex/gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:cdd39862e