Skip to content

✨ feature: add abandoned counts to contributor leaderboards - #15859

Closed
mendezr wants to merge 2 commits into
hivecommons:v5from
mendezr:feat/abandoned-leaderboards-15796
Closed

mendezr wants to merge 2 commits into
hivecommons:v5from
mendezr:feat/abandoned-leaderboards-15796

Conversation

@mendezr

@mendezr mendezr commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #15796

  • Add abandoned to leaderboard JSON, including explicit zero for legacy profiles, without changing ranking or existing fields.
  • Append an Abandoned column to dashboard and contribute-landing leaderboards, including sortable landing headers and mobile placement.
  • Add regression coverage for persisted profile values, unchanged ranks, and both shipped JavaScript renderers.

Dependency / integration

Core adoption accounting is in open PR #15802. This PR includes only its prerequisite ContributorProfile.Abandoned int JSON field so it builds independently on v5; it does not implement adoption accounting. When integrating #15802, retain a single Abandoned field together with that PR's records and reconciliation logic. Until the core writer lands, existing profiles display zero.

Validation

  • gofmt -l on changed Go files: clean.
  • Tests not run locally per AGENTS.md; CI is the test verdict. Added API and Node-backed renderer tests (with static column assertions when Node is unavailable).

— hive: backend=pi model=openai-codex/gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: cdd39862e

Expose the persisted abandoned count without changing rankings, and append columns to the dashboard and contribute landing standings. Cover JSON values, legacy zero defaults, and both renderers.

Hive-Run: hivecommons#15796
Hive-Plan: issue-15796-leaderboard-columns
Hive-Spec: issue-15796#acceptance
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15871 🐛 fix: stage tracker gives immediate Let-hive-decide feedback and says why a human is wanted same files src/pkg/dashboard/static/index.html
#15888 ✨ ioscan: accept omp as a tool-less classifier CLI backend same files src/pkg/dashboard/static/index.html
#15892 🐛 fix: preserve merge notifications across reloads and show countdown same files src/pkg/dashboard/static/index.html
#15849 ✨ Show online ClankeR IDs on the Contributors count pill same files src/pkg/dashboard/static-src/js/contributors.js
src/pkg/dashboard/static/index.html
#15853 ✨ Complete native GitHub queue CI and policy integration same files src/pkg/dashboard/static/index.html
#15890 🐛 dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html
#15877 ✨ feature: show abandoned counts on contributor cards and status same files src/pkg/dashboard/contribute_profiles.go
src/pkg/dashboard/static-src/js/contributors.js
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@mendezr this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test (dashboard 4/4)
  • test (dashboard shuffle 1/3)
  • test (rest 3/4)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 072-returned-to-contributor: optional-check-failing:test (dashboard 4/4)

Signed-off-by: mendezr <mendezr@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a duplicate of #15802 or #15863 — this is the leaderboard layer from #15796. Two sequencing facts a maintainer should know before merging:

  • src/pkg/dashboard/contribute_profiles.go:192-193 adds Abandoned int with a one-line comment; #15802 and #15863 add the same field at the same spot with a different six-line comment plus AbandonedPRs. Textually different hunks at the same location → this PR conflicts with both of them, whichever lands first. The contribute_leaderboard.go:20 / :69 changes are fine and the LeaderboardEntry.Abandoned hunk is byte-identical to the one in #15865, so those two merge cleanly together.
  • buildLeaderboardWithInputs copies p.Abandoned into the row, but nothing on v5 writes it until #15802 merges — the column is zero for every contributor until then (as the body already states).

Suggested: after #15802 lands, rebase and drop this PR's ContributorProfile.Abandoned declaration so the core PR's field (with the append-only AbandonedPRs records) is the single definition.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at 0c0aa58. This looks correct to me.

  • LeaderboardEntry.Abandoned is populated from p.Abandoned in buildLeaderboardWithInputs (contribute_leaderboard.go:69); no ranking input changes.
  • Header and row both emit eight children in the same order (contribute_landing.go:3309 adds the stat after lb-spark, :3356 adds the header after Trend), so the mobile nth-child placement at :1556-1557 keeps header over column. Sort key abandoned falls back to 0.
  • go build ./pkg/dashboard ./cmd/hive clean at this head.

One integration note: your Abandoned field comment differs from #15802's, so when #15802 lands first (it should) the contribute_profiles.go conflict should resolve to #15802's declaration, which also adds AbandonedPRs. Not a duplicate of #15802 or #15863 — I diffed all three.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-5 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15842:4/6:0/0:main.go,contribute_landing.go,contribute_leaderboard.go,contributors.js,+4

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 050-review-pending: base-refresh:queued-behind#15868

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@mendezr this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch is behind the base and Hive cannot update it; enable "allow edits by maintainers" or rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @0c0aa58, 57/57 checks green, DCO yes, soak 10m0s elapsed. Blocked only by role/untrusted (no trusted-author role).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

hivecommons-hive Bot added a commit that referenced this pull request Oct 30, 2026
Share heartbeat and task-status row conversion, merge abandoned counts across public spokes, and document the additive wire field. Include the prerequisite dashboard row field shared with #15859; profile population remains in that PR.

Hive-Run: #15799
Hive-Plan: 15799-heartbeat-and-hub-leaderboard
Hive-Spec: issue-15799#acceptance

Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Co-authored-by: mendezr <mendezr@users.noreply.github.com>
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersede failed: the hive could not open a fresh PR with these commits. Merging v5 into the copy branch hive/adopt-15859 (at 0c0aa58de739) stopped on a git conflict, so no superseding PR was opened and this PR stays open.

Files changed on both sides:

  • src/pkg/dashboard/contribute_landing.go
  • src/pkg/dashboard/contribute_leaderboard.go
  • src/pkg/dashboard/contribute_profiles.go
  • src/pkg/dashboard/static-src/js/contributors.js
  • src/pkg/dashboard/static/index.html

Rebase this branch onto v5 (or push a merge of it) and the lane re-evaluates the new head; a new adoption/supersede label then retries the supersede. Reason: supersede-conflict.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merge relay refused this fork PR (contributor-lane policy; author tier none) and it is now CONFLICTING with v5 after #15802 (core adoption accounting, which owns ContributorProfile.Abandoned) and #15894 (hub leaderboard carry-through) merged. @mendezr please rebase feat/abandoned-leaderboards-15796 onto origin/v5, drop this PR's duplicate Abandoned field in favour of the one #15802 landed, and re-push; a maintainer merge is then needed. Hive cannot push to the fork.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Superseded by hive: re-authored as #15895 with the same commits and sign-off because the author's clanker is offline. This PR is closed; if #15895 fails, hive reopens it.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Add an abandoned column to the dashboard and contribute-landing leaderboards

1 participant