Skip to content

πŸ› Keep informational security notices separate from real human decision gates - #16032

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
fix/tracker-informational-sentinel
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
fix/tracker-informational-sentinel

Conversation

@clubanderson

Copy link
Copy Markdown
Member

What changed

The tracker previously used sentinel_alert for both a real blocking label and a verified trusted-author informational notice. Decision rendering treated both as an open security gate.

  • Add typed sentinel_notice to the existing root/linked payload and canonical/inline adapters, using the existing verified observation and live configured label.
  • Keep informational notices visible, but do not replace the real reviewer question with a sentinel gate or author fallback.
  • Quote a reviewer's question as reviewer provenance. A mentioned login is not an assignment or exclusive authority; no ownership policy is inferred or changed.
  • Preserve genuine blocking labels and coexisting reviewer questions.

Validation and boundaries

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2026
@clubanderson

Copy link
Copy Markdown
Member Author

Integrated landed #16011 source95eafcdfa, preserving human_attention, canonical linked identities, Copy/Close hooks and head-aware waits; regenerated SPA from resolved source. Informational notices now also use informational accessible labels/tint and do not supply a blocking-security approval preface. A reviewer-mentioned login remains a quoted suggestion, never an assignment or exclusive authority; actor.login remains unknown unless independently supplied. Actual configured blocking labels retain their gate and warning. Exact-head full CI restarted on this pushed integration head; no decisions or live configuration changed.

@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16043 ✨ feat(dashboard): add a Matrix tab to the Activity Monitor header same files src/pkg/dashboard/static/index.html
#16037 πŸ› fix: stop inferring idle external PR owners from missing Hive actors same files src/docs/dashboard-sections/activity-monitor.md
src/pkg/dashboard/static/index.html
#16027 πŸ› fix: keep the preparation train connector continuous between adjacent members same files src/docs/dashboard-sections/activity-monitor.md
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-row-layout.js
src/pkg/dashboard/static/index.html
#15890 πŸ› dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html
#16046 ✨ feat(matrix): add Ghost coder and Terminal effects to the dashboard renderer same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree around the change; the core of this looks correct to me.

Why the derivation is sound. stageTrackerSentinel (src/pkg/dashboard/stage_tracker.go:1109-1151) only sets alert without the configured label when a bundle finding has f.Notice set β€” the trusted-author path its own doc-comment calls "comment, never the label". So SentinelNotice = SentinelAlert && !hasLabel at stage_tracker_build.go:406-408 is precisely the notice-only case, and the old decisionForPR blocker text ("will not merge until a person removes the sentinel-alert label", stage_tracker_decision_pr.go:146) was telling operators to remove a label that was never applied. Fixing that is a real correctness improvement, not just presentation. Linked-PR mirroring (stage_tracker_links.go:325) and both JS adapters carry the new field; every added static-src line is present in static/index.html. go build ./pkg/dashboard/ passes on f7906fb.

One stale comment (low). stage_tracker_build.go:409-412 still says the trusted-author notice "stays truthful for the gate word and the Decide… preface", but this PR removes notices from stageTrackerSentinelPreface (tracker-actions.js:1462) and from stageTrackerSentinelInLane. Worth updating the comment so the next reader isn't misled.

Open question, not a defect. stage_tracker_decision_pr.go:32 now also suppresses the gate when Reason is literally sentinel / ContributorLaneReasonSentinelBlocked as long as SentinelNotice is true. That requires a notice finding and a sentinel-blocked lane reason and no label β€” a contributor-lane block on a trusted-author PR β€” which I could not construct from the producers I read, so I'm noting it rather than claiming it. If it can't happen, fine; if it can, the lane reason should probably still win.

PR body matches the diff. Not approving β€” that is a human's signature.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson

Copy link
Copy Markdown
Member Author

Exact-head observer correctly stopped when Hive preparation advanced this branch from f7906fb to cbcddb4 at12:46:06Z. GitHub attributes this to app/hivecommons-hive merging current v5, not a local push. Compare shows current-base changes only; informational-notice source remains intact. Prior f790 verdict is not carried forward. Adopting/verifying the new head and owning its full fresh CI; no manual merge or deployment.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the Go and JS at cbcddb4 against the v5 tree rather than the diff alone. The change holds together:

  • stage_tracker.go:1137-1141 is the only path that sets SentinelAlert without the live label (a Notice finding in the verified bundle), so the derivation at stage_tracker_build.go:406-408 (SentinelAlert && !label present) identifies exactly the trusted-author notice and nothing else. DecisionNeeded is computed afterwards at :451, so decisionForPR sees the flag.
  • In decisionForPR the reviewer-question case (stage_tracker_decision_pr.go:62) already outranks case sentinel: (:105); the real effect of :32 is on the later case sentinel: at :145, which otherwise prints "will not merge until a person removes the sentinel-alert label" for a PR that does not carry that label. That blocker text was false for notice-only PRs; it is correct now, and TestStageTrackerSentinelNoticePreservesActualReviewerDecision also keeps it for the labelled case (:69-71).
  • The linked-PR copy at stage_tracker_links.go:325 and the two JS adapters in tracker-row-layout.js are the only propagation sites; the other SentinelAlert assignment (api_repo_item_decide_delegated.go:687) is on the delegated-decision input struct, label-driven, and unaffected.

Looks correct to me.

One open question, not a defect: stageTrackerDecisionWhy (stage_tracker_actor.go:308) prefers the reviewer's question over humanizeStageReason(it.Reason) only when SentinelNotice is set. A non-notice PR at 085 with a reviewer question still gets the humanized lane reason first. If that narrowing is deliberate (keep this PR scoped to the notice case), fine; if the general case was also meant to quote the reviewer, the gate is one condition wider.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the tree at cbcddb4 (stage_tracker.go:1109-1150, stage_tracker_build.go:403-452, stage_tracker_decision_pr.go:15-150, stage_tracker_actor.go:135-236,305-320, and the four static-src/js consumers). Looks correct to me.

The defect this fixes is real. stageTrackerSentinel (stage_tracker.go:1139-1144) promotes alert=true from a notice-only evidence finding with no label on the PR. On main, decisionForPR then takes case sentinel: and emits the blocker "The hive will not merge until a person removes the sentinel-alert label" (stage_tracker_decision_pr.go:146) for a PR that never carried that label, and the asker becomes the sentinel rather than the reviewer whose question actually parked it. SentinelNotice = SentinelAlert && !hasLabel (stage_tracker_build.go:406-408) is computed before DecisionNeeded/StageActor (:451-452), so the gating at stage_tracker_decision_pr.go:32 sees it.

Checked and holding:

  • Label-on path unchanged: TestStageTrackerSentinelFlag PR 109 asserts !SentinelNotice with a live label, and the acknowledged-by path returns before the notice promotion (stage_tracker.go:1134-1138), so an acknowledged bundle never becomes a notice.
  • The delegated-decide input at api_repo_item_decide_delegated.go:684-689 builds SentinelAlert from labels only, so it is not affected by the notice promotion and needs no SentinelNotice.
  • JS: stageTrackerSentinelInLane/AsSuffix are the only feeders of the ham-sentinel chevron class (tracker-row-strip.js:61, tracker-row.js:63,73), and the chip at :288-290 now renders for the notice case with the info tint. stageTrackerSentinelPreface excludes notices so Approve is not danger-prefaced for an informational finding.
  • Both linked_prs adapters (tracker-row-layout.js:65,491) carry sentinel_notice, and the generated static/index.html matches static-src.

One suggestion, not a defect: stageTrackerDecisionWhy (stage_tracker_actor.go:308-312) quotes the reviewer's question only when SentinelNotice is set. A non-sentinel PR parked at 085 with a reviewer question still gets the humanized lane clause instead of the question, so the two 085 rows read differently for the same AskedBy. If that asymmetry is intended as scope control for this PR, fine; otherwise dropping the it.SentinelNotice && guard is a one-line follow-up.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

hive/awaiting-ci: rebased onto v5 (9616018 β†’ f3db3d9) to clear the conflict in src/pkg/dashboard/static-src/js/tracker-row-layout.js and src/pkg/dashboard/static/index.html (linked-PR adapter field lists); kept both v5's new fields (state/terminal_merge/merged_by/human_attention) and the PR's sentinel_notice. The former merge commit f7906fb ('preserve landed human clarity…') carried real changes (notice CSS, preface filter, chip aria-label, test asserts); it is preserved as a regular commit with the same author/message. Net PR diff unchanged. Authorship and sign-off unchanged. CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: f3db3d92f

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#16032f3db3d9` sha256:9a4f2b8ac2494d1f1e5d77fb74e8adf716143d8609e2f7c20869d5f80a82e4b8 β€” download from the dashboard or `hivectl review evidence #16032`.

Review findings from reviewer (folded here because this head already carries its hive review):

Read this against the tree at f3db3d9, not just the diff. Looks correct to me.

  • SentinelNotice is derived in stage_tracker_build.go:406-408 as SentinelAlert && !<live label>, which is exactly the one path in stageTrackerSentinel (stage_tracker.go:1136-1141) that promotes an alert without a label: the bundle's Notice findings. A label-only or label+evidence PR can never become a notice, and the existing TestStageTrackerSentinelFlag now pins that for PRs 109/110/112.
  • decisionForPR (stage_tracker_decision_pr.go:32) already ranked verdict.DecisionQuestion above the sentinel case before this change, so the only behavioural delta is that a notice-only row no longer falls into the sentinel question/blocker ("remove the sentinel-alert label") when it has no reviewer question β€” a blocker that was unactionable there anyway, since there was no label to remove.
  • Nested rows: stage_tracker_links.go:325 copies the flag and the three JS adapters (tracker-row-layout.js:66,493, tracker-row-strip.js:290) carry it through; stageTrackerSentinelPreface and InLane/AsSuffix now exclude notices, so the Approve confirm no longer leads with a ⚠ preface for them.

One note, not a defect: stageTrackerDecisionWhy (stage_tracker_actor.go:308-312) prefers "reviewer question: …" over the humanized lane reason only when SentinelNotice is set. A non-notice row with the same reviewer question still gets the lane reason first. Intentional scoping is fine; just flagging the asymmetry in case it was meant to be general.

@clubanderson

Copy link
Copy Markdown
Member Author

Prior immutable cbcddb4 reached all17 latest applicable workflow groups terminal success/skipped and all79 CheckRun contexts pass/skip. Hive then refreshed base again to9616018d9a06fe5c3f94662acc9306f3f60d7e1e, adding landed merge-toast0a4aa3d and Matrix API d5a7c57 via a bot merge. This is not a local push; I am preserving the canonical banner repo helper/asset and observing fresh CI on961, not labeling the new head green from cbc.

@clubanderson

Copy link
Copy Markdown
Member Author

FINAL immutable fresh-base CI receipt9616018d9a06fe5c3f94662acc9306f3f60d7e1e: all17 latest applicable workflow groups terminal SUCCESS/SKIPPED and all79 CheckRun contexts pass/skip, including full Go/Node/lint/docs/security/images and ARM. This is the refreshed head containing canonical landed banner repo helper and Matrix API, not prior cbc/f790 evidence. Owned worktree fast-forwarded/regenerated unchanged. No manual source merge or deployment by me; source remains Hive-managed.

… gates

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…bility

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot force-pushed the fix/tracker-informational-sentinel branch from 9616018 to f3db3d9 Compare October 31, 2026 13:39
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is back in your court (stage/071-needs-author). Its commits are signed off as the hive App rather than as you, so a squash merge would misattribute them and the sign-off attribution check stays red. No hive agent can rewrite a contributor's commits β€” the fix is yours:

  • 2 commits are signed off as the hive App instead of you, so a squash merge would misattribute them β€” set git config user.email to your own address, then run git rebase --exec 'git commit --amend --no-edit --reset-author -s' HEAD~2 && git push --force-with-lease

Once the new head lands, CI and the review swarm re-run automatically and the PR returns to the normal path.

@clubanderson

Copy link
Copy Markdown
Member Author

GitHub force-push timeline attributes9616018β†’f3db3d92f0aff274c22a067eccdaa5a6371dd79a to hivecommons-hive at13:39:57Z. Rebased onto current v5; owned notice patch remains15 files/123 additions, no invented dependency on an unmerged feature. Fresh CI required onf3db; prior961 terminal79-check/17-group receipt remains immutable historical evidence only.

@hivecommons-hive
hivecommons-hive Bot merged commit 40d3be3 into v5 Oct 31, 2026
80 of 81 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-informational-sentinel branch October 31, 2026 13:55
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at f3db3d9.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the v5 tree plus the callers. This looks correct to me.

What I verified:

  • SentinelNotice (stage_tracker_build.go:406-408) is alert && !live-label. The only way stageTrackerSentinel (stage_tracker.go:1109-1150) promotes alert without the label is a Notice finding in the verified bundle; the acknowledged path returns the label-only alert, so an acknowledged notice can never flip to sentinel_notice: true. Consistent with the label-only PR 109 / evidence PR 110 assertions added to TestStageTrackerSentinelFlag.
  • The new !it.SentinelNotice && guard in decisionForPR (stage_tracker_decision_pr.go:32) also covers the "sentinel" and contributor-lane:sentinel-blocked reasons. Both are derived from the live label (automerge_contributor_lane.go:537-539 via labelBlockReason), so when either reason is present the label is present and SentinelNotice is false β€” the guard cannot suppress a genuine lane gate.
  • JS side: with stageTrackerSentinelInLane/AsSuffix now false for notices, stageTrackerSentinelChipHtml renders the (info-tinted) chip instead of relying on the chevron word, so the notice stays visible at 085/071/072 as the body says. stageTrackerSentinelPreface excluding notices matches the Go-side gate change.
  • stageTrackerDecisionWhy (stage_tracker_actor.go:308-312) only re-orders reviewer-question-before-lane-reason when SentinelNotice is set, so non-notice rows are unchanged.

Body matches the diff; no scope beyond the stated change.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson

Copy link
Copy Markdown
Member Author

Final immutable source receipt: Hive auto-merged tested head f3db3d9 at2026-10-31T13:55:43Z as40d3be36f36525312dd039b0cccd6e4c40b7765d (app/hivecommons-hive). ARM completed after merge; final observed82 exact-head CheckRuns all pass/skip, all20 latest workflow/event groups success/skipped. DCO trailers verified, squash ancestor of freshly fetched origin/v5, canonical generation on the landed squash unchanged. Independent reviews caught and fixed exact-string adapter fixture plus prior human-attention integration; notice remains informational, real label/human decisions remain gates, reviewer-named person stays quoted provenance not exclusive authority. Owned worktree/local branch cleaned; remote branch auto-deletion verified. No deployment or policy activation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant