Skip to content

✨ feat(dashboard): add a Matrix tab to the Activity Monitor header - #16043

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-16042
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-16042

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

RFC #15862 lists a header Matrix tab as an entry point; until now the only way in was typing ?kiosk=1&view=matrix. The tab is gated on the existing enabled signal (exposed as an additive matrixEnabled status boolean) so hives that never turned Matrix on see no change.

Part of #15862.
Closes #16042

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@hanthor

… dashboard.matrix is enabled

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16027 🐛 fix: keep the preparation train connector continuous between adjacent members same files src/pkg/dashboard/static/index.html
#16046 ✨ feat(matrix): add Ghost coder and Terminal effects to the dashboard renderer same files src/docs/streaming-the-activity-monitor.md
src/pkg/dashboard/static/index.html
#15890 🐛 dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: pushed 3af8e60 — TestSettingsDialogReferencesEveryHiveYAMLLeaf requires allowlist entries to be removed once the Settings UI references the key; the PR now references dashboard.matrix.enabled, so its stale allowlist entry is removed. CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 3af8e60db

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#160437aa7373` sha256:ba513579fd5a669ae14c9c7d96c055731427946e94247a3140231e506e26c5f7 — download from the dashboard or `hivectl review evidence #16043`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
…lowlist

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 31, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (read at head 3af8e60, which supersedes the fc09fb4 I was dispatched on; the only delta is the allowlist drop).

1. The settings-parity gate is now satisfied by a Go comment, not a Settings control — restore the allowlist entry and reword the comment.
TestSettingsDialogReferencesEveryHiveYAMLLeaf builds its "Settings UI corpus" from static/index.html plus every .go file in pkg/dashboard (settings_parity_test.go:45-62), then uses a standalone-path match (settingsParityReferenced, :69-89). The new doc comment at server.go:3743 — // MatrixEnabled mirrors dashboard.matrix.enabled so the header can show — is the only standalone occurrence of that leaf anywhere in the corpus (static/index.html has zero). That is what made the test fail with "allowlist still contains … the Settings UI now references it", and commit 3af8e60 answered by deleting the allowlist line (settings_parity_allowlist.txt:185). Net effect: dashboard.matrix.enabled is now recorded as covered by the Settings UI while no control exists, and a future PR that adds the control will no longer be reminded to remove its allowlist entry — the gate is silently weakened for this leaf.
Fix: reword the comment to avoid the literal path (e.g. "mirrors the Matrix enabled flag") and put the allowlist line back (its "nothing reads it yet" note can be updated to "surfaced via statusWithWebhooks.MatrixEnabled, no Settings control yet").

2. (advisory) MatrixEnabled mirrors .Enabled, every server-side Matrix gate uses .Active().
server.go:3722 sets MatrixEnabled: s.currentMatrixConfig().Enabled, but /api/matrix/lines and the SSE nudge reject unless cfg.Active() (api_matrix.go:30,65,74,95), where Active() = Enabled && len(Repos) > 0 (config/dashboard_matrix.go:21-23). With enabled: true and no repos, the header shows a Matrix tab that lands on a view whose lines API refuses. #16042 does say "gated on the existing enabled signal", so this is the hive's call; Active() would match the backend and still pass TestHandleStatus_MatrixEnabledFlag (it sets Repos: ["org/repo"]).

Otherwise the wiring checks out: currentMatrixConfig() falls back to the observer's stored cfg when deps is nil (api_matrix.go:41-55), so the test's MatrixObserver(...) path is valid for both branches; refresh.js:487-490 only toggles when the field is a boolean, so older spokes behind a newer hub keep the tab hidden; check-api-reference-citations.sh passes at this head.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
…tab on Active()

The MatrixEnabled doc comment spelled out the literal yaml leaf path, which
the settings-parity corpus (static/index.html + pkg/dashboard/*.go) counted
as a Settings reference and led to the allowlist line being dropped even
though no Settings control exists. Reword the comment and restore the entry.

Also derive the /api/status flag from MatrixConfig.Active() (enabled with at
least one repo) so the header tab only appears when /api/matrix/lines and the
SSE nudge will actually serve it.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at the head, not just the diff. Looks correct to me:

  • currentMatrixConfig() (src/pkg/dashboard/api_matrix.go:41) already prefers deps.Config.Dashboard.Matrix and falls back to the observer-loaded config, and /api/matrix/lines 404s on !cfg.Active() (api_matrix.go:95-96), so matrixEnabled: s.currentMatrixConfig().Active() in server.go:3722 is the same predicate that gates the endpoint the tab links to — the tab can't show on a hive that would 404 it.
  • The issue asked to reuse an existing browser-visible signal if one existed; I checked boot.js and the pre-PR server.go and there was none (boot.js only reads the URL query), so the additive status field is the right branch of #16042.
  • static/index.html is in sync with static-src (go run ./pkg/dashboard/webstatic/gen … -check passes at this head), go build ./pkg/dashboard/ is clean, and check-api-reference-citations.sh still verifies after the server.go line shift.
  • settings_parity_allowlist.txt entry updated so the parity test keeps passing with the new reader.

CI is green at this head apart from the still-running arm64 build/gosec. No findings.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 31, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 8994269 into v5 Oct 31, 2026
95 of 103 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16042 branch October 31, 2026 15:01
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/ci-infra: the red native-queue-policy run on 7aa7373 (job 124571391794) exited with #16043: head/base moved, draft, closed, or held — the v5 tip advanced while the policy was validating exact-head evidence; the policy's own test suite passed (fail 0). Not caused by this diff; deferring until the check re-evaluates against the current base.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Add a Matrix tab to the Activity Monitor header, shown only when dashboard.matrix is enabled

0 participants