Repository navigation
Description
Symptom
Hive-authored draft PRs deadlock: the scanner parks a PR as draft ("DEFER β stacked on #N"), prow's wip plugin mirrors the draft state with do-not-merge/work-in-progress, and from then on no lane ever revisits the PR or its issue.
Observed on #15890 / #15540 (sat in "PR in progress" for 2 days):
- 2026-10-30T21:16Z β scanner opens π dashboard: point operator-reference help marks at the section sub-pagesΒ #15890 for Review backlog (docs-currency): Dashboard help marks still land on index stub page (advisory, unchanged)Β #15540.
- 21:36:57Z β
hivecommons-hiveconverts it to draft; comment: "DEFER β stacked on π docs: split the operator referenceΒ #15731. Converting to draft until it landsβ¦ once π docs: split the operator referenceΒ #15731 merges, rebase this branch on v5 and mark it ready for review." - 21:37:02Z β
kubestellar-prowaddsdo-not-merge/work-in-progress(wip plugin mirror of the draft bit). - 2026-10-31T01:19:30Z β π docs: split the operator referenceΒ #15731 merges. Nothing happens on π dashboard: point operator-reference help marks at the section sub-pagesΒ #15890 afterwards (no commits, no comments, no label changes) until a human intervened on 2026-11-02.
- Spoke tracker (
/api/repos/hivecommons/hive/items/15890):bucket: "filtered",bucket_reason: "Exempt label", stage 0, actor caption "draft β waits for the author to mark it ready for review" (the author is the hive)./api/statusstale_drafts: null. - Spoke tracker for Review backlog (docs-currency): Dashboard help marks still land on index stub page (advisory, unchanged)Β #15540:
bucket: claimed_by_pr, decisioncovered_by_open_pr, reason "Open hive-authored PR π dashboard: point operator-reference help marks at the section sub-pagesΒ #15890 already claims this issue". Logs: onlysuppressing issue already claimed by a hive PRandautomerge skip reason=draft.
Mechanism
src/pkg/github/client.go fetchPRsWithDetails:
if c.isExempt(labels) { β¦ "Exempt label"; continue }runs beforeif pr.GetDraft() { β¦ staleDrafts = append(...) }(app-authored,CreatedAt>staleDraftAfter= 48h).
PermanentExemptLabels = []string{"do-not-merge"} is a prefix match, so do-not-merge/work-in-progress exempts the PR at step 1 and step 2 never runs. Since prow adds that label to every draft, every hive-authored draft is shielded from the hive's own stale-draft rule, and the "YOUR STALE DRAFT PRs" kick section (pkg/scheduler/lane_messages.go) is never populated.
Meanwhile the linked issue is suppressed as covered_by_open_pr, so the issue lane won't re-dispatch either β deadlock until a human notices.
Secondary: the "DEFER β stacked on #N" convention is free text; nothing re-kicks when #N merges. The stale-draft nag is the only backstop, and it is the one being bypassed.
Fix
Let a draft whose only exempt label is the prow WIP mirror fall through to the draft branch (so stale-draft surfacing works), while a real do-not-merge/hold etc. on a draft still exempts it. Small change in fetchPRsWithDetails + tests in stale_draft_test.go. PR to follow.
Activity