Skip to content

🐛 fix: stage tracker gives immediate Let-hive-decide feedback and says why a human is wanted - #15871

Merged
hivecommons-hive[bot] merged 18 commits into
v5from
scanner/fix-15773
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 18 commits into
v5from
scanner/fix-15773

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Let hive decide gathers the PR live for seconds with no sign anything happened, so operators click again or assume it is broken; covered issue rows repeat the PR's decision button; and the person marker on a chevron never says what the person is wanted for. The button and row now show the tracker's own working vocabulary until the preview opens, a covered issue defers to its PR row with a passive chip, and the human next-move tooltip falls back to the row's reason.

Part of #15773 — the client-side half (busy button, covered-issue chip, human-why tooltip); the plan cache/prefetch, skeleton preview, scroll-to-PR caption and the no-👤-without-a-reason test stay open on the issue.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

…ys why a human is wanted

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15970 ✨ feat: dim stale display-mode boards and add density=tv, burn-in shift and reduced motion CONFLICT src/pkg/dashboard/static-src/js/tracker-filter-render.js
src/pkg/dashboard/static/index.html
#15849 ✨ Show online ClankeR IDs on the Contributors count pill same files src/pkg/dashboard/static/index.html
#15890 🐛 dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
…d test fixtures

Seven dashboard test fixtures lift stageTrackerActorTip by name without
stageTrackerHumanWhy, so the shuffle job failed with ReferenceError.
Follow the file's existing guarded-helper pattern and regenerate index.html.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:Sign-off survives the squash

@hivecommons-hive hivecommons-hive Bot added stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the v5 merge-base (85e9ec7) plus the callers; this looks correct to me.

What I verified:

  • stageTrackerPRListedOwnRow keys off _stageTrackerRows, which tracker-filter-render.js:99 sets before the page's row HTML is built (:152-158); stageTrackerAdoptOrphanPRs (tracker-row-layout.js:276) only rewrites drawn_under and adds no top-level rows, so the "PR has its own row" check can't miss a drawn row.
  • The preview pend (tracker-actions.js stageTrackerDelegatePreview) is tagged busy='decide:delegate' and cleared in finally, and stageTrackerLeadBusySync only touches a lead whose data-ham-act matches, restoring aria-disabled/title from the saved dataset — a lead rendered disabled stays disabled afterwards. stageTrackerPendingKeys, stageTrackerClearPending and stageTrackerActingCaption all exist at the signatures used.
  • stage_tracker_actor.go:204 reaches stageTrackerDecisionWhy only for 085/045; ReadyForHumanMerge keeps its non-empty "a maintainer merges it", so the client fallback to human_merge_reason_text in stageTrackerActorTip never fires there and #15394's "say only who moves" is preserved.
  • stage_tracker_decide_feedback_test.go covers the CSS rule, pend tagging, busy/restore, the covered-issue chip and both why fallbacks.

No findings. Not a request for changes.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent alignment (read at head 8c3280e): the busy button, pend tagging and the human-why tooltip fallback do what the body says, and the body honestly leaves B / skeleton / scroll / the no-👤-test open on #15773. One in-scope gap:

The covered-issue chip does not fire in the case #15773 actually reports. The owner's example is #15503, a secondary issue "under #15502" covered by PR #15759. The server nests a PR under its lowest listed issue (src/pkg/dashboard/stage_tracker_links.go:359-360), and outside the Pull requests view stageTrackerVisible drops a nested PR from the rows (static-src/js/tracker-filter.js:219), so _stageTrackerRows never contains #15759 while #15502 is listed. stageTrackerPRListedOwnRow (static-src/js/tracker-actions.js:505-509) therefore returns false for #15503, and stageTrackerParkedNestedPRs/stageTrackerDecisionTarget (tracker-actions.js:197-212) still resolve #15503's lead to PR #15759 regardless of drawn_under. #15503 draws no sub-row either (tracker-row-layout.js:270 filters linked PRs to stageTrackerLinkedDrawnHere), so the subRows branch at tracker-actions.js:513 never applies. Net: #15503 and #15502 both keep a live Let hive decide button — the exact duplicate the issue describes — and the new test even pins this ("the issue keeps its button when no sub-row is drawn (one covering PR)", stage_tracker_decide_feedback_test.go). The chip only appears in the narrow case where the covering PR is a top-level row beside the issue, which is not the reported layout.

Requested change: in stageTrackerLeadActionOnRow, also return the passive chip when the target PR is in item.linked_prs with a drawn_under naming a different issue that is among ctx.rows (i.e. !stageTrackerLinkedDrawnHere(lp, item) and that issue is drawn) — the decision then lives on #15502's row and #15503 reads "decision pending on #15759". Add that fixture to TestStageTrackerCoveredIssueDropsPRChipNode and soften the changelog/body claim if the general single-covering-PR case is deliberately left for later.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
…ys the decision reason once

- stageTrackerLeadActionOnRow: a secondary covered issue (hive#15503 under
  #15502) whose PR is drawn_under another listed issue renders the passive
  "decision pending on #N" chip instead of a second Let hive decide button;
  the chip names the row that draws the PR. Fixture added to
  TestStageTrackerCoveredIssueDropsPRChipNode.
- stageTrackerTooltip: when the 035 next-move why repeats the caption, the
  Next move line keeps only who moves; the chevron hover keeps the whole why.
- stageTrackerLeadBusySync stashes label/title/disabled in data-ham-*
  attributes like the rest of tracker-*.js; the node DOM stub drops dataset.
- activity-monitor.md documents the server-side 035 why (lane reason, else
  decision_needed.question) and reads "Hive deciding…" like the code.

Hive-Fix-Attempt: 5/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 31, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 31, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at d3aece9, callers included. Looks correct to me; three things I checked specifically:

  • Render ordering. tracker-filter-render.js:99 assigns _stageTrackerRows from page.rows before the row loop at :158 calls stageTrackerRowHtml, so ctx.rows (tracker-row-layout.js:203) sees this render's rows, not the previous one's. Group headers ({group} without item, tracker-row-layout.js:422) are dropped by the .filter(Boolean). The only other stageTrackerRowHtml caller is the sound-preview sample (tracker-sound.js:728), where a stale/null rows list just means no passive chip — harmless.
  • Busy button is not re-clickable. stageTrackerLeadBusySync sets aria-disabled="true" and the lead click handler at tracker-actions.js:809 returns on exactly that attribute, so the double-click the body describes is closed; the saved data-ham-was-disabled restores a legitimately disabled lead afterwards. The pend is tagged 'decide:delegate' and the sync only busies a button whose data-ham-act matches, so other row actions are untouched.
  • Go side. joinClause (stage_tracker_caption.go:750) and humanizeStageReason (:304) already exist; stageTrackerDecisionWhy falls back to DecisionNeeded.Question and then to the bare phrase, matching the activity-monitor.md text.

Body ↔ diff agree, including the explicit "Part of #15773" remainder. Note for whoever merges: the conflicts-with-open-pr label is real — #15969/#15970 also edit tracker-filter-render.js and static/index.html, so whichever lands second will need a rebase.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against the v5 tree. Looks correct to me; nothing blocking.

What I checked that the change depends on:

  • stageTrackerClearPending (tracker-actions.js:1987-1990 at base) already re-runs stageTrackerPendingSync, so when the preview's tagged pend clears, stageTrackerLeadBusySync sees on=false, isBusy=true and restores the saved label / aria-disabled / title. The finally in stageTrackerDelegatePreview guarantees that clear even when a plan fetch throws.
  • The lead button is rendered with data-ham-act inside .ham-row-head (tracker-actions.js:514, tracker-row-layout.js:230/238/540), so the new :scope > .ham-row-head .ham-lead-act[data-ham-act] selector finds it on both rows and sub-rows.
  • _stageTrackerRows is assigned in tracker-filter-render.js before stageTrackerRowHtml runs for the page (line ~155), so ctx.rows is populated when stageTrackerLeadActionOnRow reads it; linked_prs[].drawn_under is a real server field (stage_tracker.go:755, set at stage_tracker_links.go:394).
  • The tooltip dedupe compares against lines[1], which is item.caption || item.reason in the non-held branch (tracker-row-strip.js:211); in the held branch an exact match against the Author line is impossible, so the worst case is no dedupe.
  • Go side: joinClause already inserts —, so the why reads a human decision is owed — workflow path exactly as the doc now describes.

(I cannot approve; this is a comment.)

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 31, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 31, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 31, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against v5 at merge-base fd50502 and the callers; looks correct to me. CI is fully green at 4055a6c (only tide pending), make's static check (webstatic/gen … -check) passes, and go build ./pkg/dashboard/ is clean.

What I verified:

  • Busy button. stageTrackerDelegatePreview (tracker-actions.js:1620-1629) opens a pend tagged busy: 'decide:delegate' and clears it in finally, so a failed/thrown fetch in stageTrackerFetchDelegatePlan still releases the button. stageTrackerActionBase (tracker-words.js:378) only rewrites reroute ids, so stageTrackerActingCaption('decide:delegate:preview') really resolves to "Asking the hive…" while the confirmed action keeps "Hive deciding…". The lead click handler (tracker-actions.js:809) already bails on aria-disabled="true", so the busy state blocks a double-fire without new wiring. stageTrackerPendingSync is also called after every render (tracker-filter-render.js:173), so a re-rendered button gets its busy state back; :scope > .ham-row-head … stops a parent row from busying a sub-row's button.
  • Passive chip. stageTrackerPRDrawnUnderOther reads linked_prs[].drawn_under which stage_tracker_links.go does populate; _stageTrackerRows is set from the drawn page before rows render, so an off-page PR correctly leaves the button on the issue.
  • Go side. stageTrackerDecisionWhy → humanizeStageReason / DecisionNeeded.Question via joinClause (stage_tracker_caption.go:750) — no behaviour change when both are empty.

One low-severity observation, not a blocker: the client fallback stageTrackerHumanWhy (tracker-row.js:206-208) appends raw item.reason (e.g. a slug like workflow-path) rather than a humanized clause, so on an old payload without stage_actor the tooltip may read Next move: human — workflow-path. The strip dedup at tracker-row-strip.js:221 then won't match the caption either. Only reachable on stale payloads, and the Go actor now sets why for 035/045, so fine to leave.

Intent vs #15773: the body is explicit that this is the client half and lists B (plan cache/prefetch) and the skeleton preview as remaining. Note that D's visible rendering after the chevron word ("PR in progress · #15759 needs a decision") is also not in this diff — only the tooltip half of D lands — so that should stay on the issue's open list too.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#158714055a6c` sha256:8a8bad13d68d60d90cd294724c9bf1f9acce3a57be58e9500afa0526b534c430 — download from the dashboard or `hivectl review evidence #15871`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants