Repository navigation
✨ feat: name the sentinel's flagged paths and rules in the decision dialog and hive comment - #16240
Merged
Merged
Conversation
…ialog, tracker payload and hive comment The Let hive decide dialog's sentinel line read only "changes 1 sensitive path(s)", which left the operator unable to decide. Tracker rows now carry sentinel_details (rule, summary, bounded paths, more_paths) from the head's evidence bundle or the sweep's recorded findings; /api/sentinel serves the same per-finding paths; the dialog's Details and chip tooltip list them; the delegated "reviewed, intended" comment names the files after the reason. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Nov 2, 2026
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16237
What
The Let hive decide dialog's sentinel line stopped at "changes 1 sensitive path(s)". Operator feedback: "knowing what the sensitive path(s) (and files) are in this alert dialog would really help me make a decision". This PR names the files and the rule that fired, everywhere the finding is summarised.
Changes
API payload
/api/tracker, and the mirrored nested-PR sub-rows) gainsentinel_details:[{ rule, summary, paths[], more_paths }], one entry per finding for the PR's current head. Paths are sorted and bounded to 10 per finding;more_pathscounts the rest. Source: the head's verified review evidence bundle, falling back to the sweep's own recorded findings (RecordSentinelFinding). Nothing is re-fetched from GitHub./api/sentinelrows gainfindingswith the same shape (the ring now stores paths, not only rule names).Dialog
(+N more)after the tenth path. The paths stay behind Details; the visible dialog budget is unchanged.Hive comment
Docs / changelog
src/docs/dashboard-sections/activity-monitor.md(Sentinel alert section) andchangelog.d/added-16237-sentinel-paths-in-decision.md.Tests
sentinel_details_test.go: bound + sort + text rendering; ring →/api/sentinel→delegatedSentinelReason; bundle-first/ring-fallback forstageTrackerSentineland the JSON shape.+N more, Details paragraph and chip title carry the lines, paths not in the visible text.go test ./pkg/dashboard/ ./pkg/github/(full dashboard package incl. ratchets),node --test pkg/dashboard/*.test.js,go vet,make dashboard-gen-check,check-api-reference-citations.shall pass.