Repository navigation
🐛 dashboard: align contributor presence counts and person IDs - #16228
Conversation
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Looks correct to me. The diff does what the body says: one What I verified against the tree at
One note, not a blocker: the sidebar pill now first paints when the deferred init chain reaches
|
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
Addressed the first CI findings: refreshed the 54 shifted API citations with the existing fixer and updated the dashboard tooltip contracts to assert usernames rather than the old relay IDs, preserving escaping/focus/hover/navigation coverage. Added failure-while-open portal coverage and made the fake DOM textContent setter reflect browser escaping so that assertion exercises the actual refresh path. Fresh exact-head CI is required; no checks bypassed. |
|
Current head 847e870 has all required contexts green, including native-queue-policy, build-and-test, coverage, lint and security checks; both server-tests and link/citation checks now pass. The remaining failed optional ARM contributor build is a dependency-download transport error: proxy.golang.org returned HTTP/2 INTERNAL_ERROR while downloading golang.org/x/text@v0.43.0 (job 125333169263), not a compiler error in this PR. No new author commit is justified for that failure. Preserve checks; retry the failed job when its parent workflow permits it. |
There was a problem hiding this comment.
Read the diff against v5 plus the callers; looks correct to me. Each claim in the body checks out against the code:
- Same snapshot.
handleContributorsListnow returnscontributorPoolbuilt from the sameprofilesslice whose.Onlineit just computed (contribute_admin.go:84,103), andrefresh.jsno longer overwrites the badge from/api/status.fetchContributorsis still started from_deferredInitand polled everyCONTRIBUTOR_POLL_MS(10s) (shimmy-handlers.js:110), so the sidebar badge keeps refreshing without the Contributors section being open. Both routes hang off the same mux (api_contribute.go:340,server.go:1651), so no viewer-vs-admin access difference is introduced. - Back-compat.
OnlineIDs/online_idsis retained and still populated (api_contribute.go:97,153);online_loginsis additive./api/statusstill callsBuildContributorPoolStatus()(server.go:2682), which now routes through the sharedcontributorPoolStatus. - Empty roster.
profiles == nil → []ContributorProfile{}(contribute_admin.go:71) makescontributorsserialize as[], which the newArray.isArrayguard infetchContributorsrequires — without it, deleting the last contributor would have hit the catch branch and shown "unavailable". - Stale responses.
_contributorFetchIDis compared afterawait res.json()and again incatch, so a slow earlier response cannot clobber a newer one. - Case-variant heartbeats.
onlineContributorIDsnow keeps the latest timestamp per lower-cased login (api_contribute.go:194-197) instead of last-map-iteration-wins.
node --test src/pkg/dashboard/nav_count_delta.test.js dashboard/test/config-tooltip.test.js → 29/29 pass at 847e870. Go tests are CI-only on this host; build-and-test and server-tests are green on this head. The arm64 image builds are still pending/re-running and are unrelated to this diff.
Not approving — that is a human's signature — but I have no findings.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
/approve Owner-requested, agent-assisted decision under @clubanderson's explicit delegation for this batch; this is not a separate independent human review. Reviewed the current diff and surrounding source at the exact commit below. Inspected head: The production diff at the refreshed head remains byte-identical to the inspected canonical diff: roster/cards/badge share one presence snapshot; usernames are normalized/deduplicated without changing relay-count identity; failure marks presence unavailable and a stale response cannot overwrite a newer poll. Preserve escaping/focus/hover contracts and the author’s durable preparation ownership. Current refreshed head still has CI in progress; the older 847e870 green comment is NOT this head’s evidence. This approval direction does not mark preparation-ready, displace a train seat, or authorize merging pending checks. This PR is authored by the stored account. I am not submitting an impossible native self-approval or pretending this is a separate human review. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
Resolved the actual v5 conflict and pushed DCO merge d57b915. Started from the latest remote PR head d975782, preserved intervening updates, reconciled the conflicting generated citation rows with upstream route documentation, and regenerated the canonical dashboard from static-src. The contributor presence behavior is unchanged: roster/cards/counts share one snapshot and tooltips list person logins only. Fresh exact-head CI is required; older-head green checks are not this commit’s proof. No empty commit, forced push, workflow/protection change or local test suite. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
/api/contributorsresponse, not an independently cached/api/statuspool.Review and validation
Independent pre-commit review identified an empty-roster regression; corrected it and added backend/frontend coverage. Added same-snapshot, person-only tooltip, multiple-session/login, stale-response, failed-refresh and zero-roster regressions. Regenerated the canonical dashboard asset and formatted Go changes. Repository policy is CI-only: no local test/build/lint suites were run. Fresh PR CI is the executable verdict.
No production deployment is included.