Repository navigation
✨ Show the Activity Monitor item count and delta cue in the monitor header - #16247
Conversation
The sidebar badge next to Activity Monitor (count plus the ↑+N/↓−N delta cue) is invisible in kiosk, popout, display and fullscreen modes. Bind the same count/delta writer to a second target — a pill in the section card header — so the number and its animation are visible in every chrome-less view. navCountDelta is wrapped by navCountBind(ids, ...) which updates all bound targets from one source; the pill is 22px in kiosk/chrome-less views and respects prefers-reduced-motion via the existing rule. Closes #16243 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
…ar ratchet
Fold countHtml into the title string instead of inserting a new slot, so
TestGovernorSettingsButtonStaysNextToHeaderControls still finds
${title}${dashboardSectionHelpMark(id)}${settings}${subtitle}.
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
The style ratchet counts raw font-size declarations; the pill now uses --fs-2xl (24px) and its inline cue --fs-lg in kiosk/chrome-less views. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #16243
What
The sidebar badge beside Activity Monitor (item count + the ↑+N / ↓−N delta cue) disappears in kiosk (
?kiosk=1), popout (?popout=1), display (?display=1) and browser-fullscreen modes because the sidebar is hidden. This PR puts the same live count — same number, same delta animation — in the monitor's own header as a small pill (HIVE ACTIVITY MONITOR [57 ↑ +3]), so it is visible in every view, including the ordinary dashboard.How
nav-count-delta.js: newnavCountBind(ids, count, label, live)wrapsnavCountDeltaand writes text/title/data-zeroto every bound target;STAGE_TRACKER_COUNT_BADGE_IDSlists sidebar + header pill. Missing elements (kiosk has no sidebar) are skipped.stageTrackerSidebarCountsUnknownresets both.tracker-filter-render.js: the single call site now feeds both pills from the samecounts.badge/counts.badgeTitle— semantics unchanged.sections.js: section card header gains an optionalcountHtmlslot; the Activity Monitor config supplies#activity-monitor-header-badge..ham-header-countpill shares the sidebar's[data-count-delta]::aftercue rules (cue rides inline inside the pill);body.kiosk-mode/body.ham-chromelesssize it to 22px for 1920×1080 streams. Existingprefers-reduced-motionrule covers it. No inline styles.nav_count_delta.test.js— header pill receives identical count/delta classes as the sidebar badge; works with the sidebar element absent (kiosk).streaming-the-activity-monitor.md; changelog fragment.Verification
make dashboard-gen && make dashboard-gen-checknode --test pkg/dashboard/*.test.js→ 221 pass↑ +3renders inline.