Skip to content

✨ Show the Activity Monitor item count and delta cue in the monitor header - #16247

Merged
clubanderson merged 3 commits into
v5from
feat/activity-monitor-header-count-16243
Nov 2, 2026
Merged

clubanderson merged 3 commits into
v5from
feat/activity-monitor-header-count-16243

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Closes #16243

What

The sidebar badge beside Activity Monitor (item count + the ↑+N / ↓−N delta cue) disappears in kiosk (?kiosk=1), popout (?popout=1), display (?display=1) and browser-fullscreen modes because the sidebar is hidden. This PR puts the same live count — same number, same delta animation — in the monitor's own header as a small pill (HIVE ACTIVITY MONITOR [57 ↑ +3]), so it is visible in every view, including the ordinary dashboard.

How

  • nav-count-delta.js: new navCountBind(ids, count, label, live) wraps navCountDelta and writes text/title/data-zero to every bound target; STAGE_TRACKER_COUNT_BADGE_IDS lists sidebar + header pill. Missing elements (kiosk has no sidebar) are skipped. stageTrackerSidebarCountsUnknown resets both.
  • tracker-filter-render.js: the single call site now feeds both pills from the same counts.badge / counts.badgeTitle — semantics unchanged.
  • sections.js: section card header gains an optional countHtml slot; the Activity Monitor config supplies #activity-monitor-header-badge.
  • CSS: .ham-header-count pill shares the sidebar's [data-count-delta]::after cue rules (cue rides inline inside the pill); body.kiosk-mode / body.ham-chromeless size it to 22px for 1920×1080 streams. Existing prefers-reduced-motion rule covers it. No inline styles.
  • Tests: nav_count_delta.test.js — header pill receives identical count/delta classes as the sidebar badge; works with the sidebar element absent (kiosk).
  • Docs: one sentence in streaming-the-activity-monitor.md; changelog fragment.

Verification

  • make dashboard-gen && make dashboard-gen-check
  • node --test pkg/dashboard/*.test.js → 221 pass
  • Headless Chrome 1920×1080 screenshots of normal / kiosk / popout / display with a fixture payload: pill reads 22px in chrome-less views, no collision with help mark / gear / Matrix tab; delta cue ↑ +3 renders inline.

The sidebar badge next to Activity Monitor (count plus the ↑+N/↓−N delta
cue) is invisible in kiosk, popout, display and fullscreen modes. Bind the
same count/delta writer to a second target — a pill in the section card
header — so the number and its animation are visible in every chrome-less
view. navCountDelta is wrapped by navCountBind(ids, ...) which updates all
bound targets from one source; the pill is 22px in kiosk/chrome-less views
and respects prefers-reduced-motion via the existing rule.

Closes #16243

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 2, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16228 🐛 dashboard: align contributor presence counts and person IDs same files src/pkg/dashboard/nav_count_delta.test.js
src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (rest 3/4)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

…ar ratchet

Fold countHtml into the title string instead of inserting a new slot, so
TestGovernorSettingsButtonStaysNextToHeaderControls still finds
${title}${dashboardSectionHelpMark(id)}${settings}${subtitle}.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
The style ratchet counts raw font-size declarations; the pill now uses
--fs-2xl (24px) and its inline cue --fs-lg in kiosk/chrome-less views.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson merged commit 00b9133 into v5 Nov 2, 2026
83 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/activity-monitor-header-count-16243 branch November 2, 2026 16:18
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity Monitor: item count and ↑/↓ delta not visible in kiosk, pop-out, display and full-screen modes

1 participant