Skip to content

🐛 fix(dashboard): reuse repository chips in merge notifications - #16033

Merged
clubanderson merged 1 commit into
v5from
fix/merge-toast-repo
Oct 31, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/merge-toast-repo

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Reuse the tracker repository chip in merge notification headers, including palette, compact name, filter action, accessibility state and escaping.
  • Resolve repository identity only from the event; enrich ledger metadata by full repository and PR number so same-number PRs cannot borrow another repository’s title or GitHub link.
  • Preserve Show row, Open on GitHub, All merges, previews and countdown behavior. Omit unknown identity rather than guessing the current repo.

Validation

  • Read-only code review: no significant findings.
  • Added regression coverage for colliding PR numbers across repositories, matching event metadata, unchanged links/actions, absent and short identities, escaping and preview behavior.
  • Regenerated shipped dashboard; gofmt reports no changes.
  • No local suite/build/lint/docs guards run; CI is the sole verdict. Holding for full applicable exact-head terminal CI before guarded squash merge.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16036 🐛 fix: show verified external merges at the terminal tracker step same files src/pkg/dashboard/stage_tracker_cues_test.go
src/pkg/dashboard/static-src/js/tracker-merged.js
src/pkg/dashboard/static/index.html
#16027 🐛 fix: keep the preparation train connector continuous between adjacent members same files src/pkg/dashboard/static/index.html
#16037 🐛 fix: stop inferring idle external PR owners from missing Hive actors same files src/pkg/dashboard/static/index.html
#16032 🐛 Keep informational security notices separate from real human decision gates same files src/pkg/dashboard/static/index.html
#15890 🐛 dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html

@clubanderson

Copy link
Copy Markdown
Member Author

/hold

Holding for the exact source head’s full applicable CI matrix to reach a terminal verdict before guarded squash merge. No local test/build/lint verdict is substituted.

@kubestellar-prow kubestellar-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2026
@clubanderson

Copy link
Copy Markdown
Member Author

/hold

Waiting for the exact source head’s full applicable CI matrix to reach a terminal verdict before guarded squash merge.

@clubanderson

Copy link
Copy Markdown
Member Author

Source/CI owner update: Copilot merge-toast dispatch retains ownership through full terminal CI and guarded exact-head squash merge.

Current source head: fb77581. Dashboard/shuffle shards and build-and-test (including Node regression suites) have passed. Only linux/arm64 build is still running. The sole reported failure is native-queue-policy, whose exact-head annotation is “#16033: head/base moved, draft, closed, or held”; this PR is intentionally /hold pending full CI. No code/fixture failure has been reported, and no speculative code change was made based on the dashboard caption. Will release hold once the remaining build succeeds, await fresh policy verdict, and merge guarded by the exact source SHA. No deployment.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree, not just the diff — this looks correct to me.

  • The new strict owner/name match in stageTrackerMergeBanner (src/pkg/dashboard/static-src/js/tracker-merged.js:985) replaces the old name-only stageTrackerMergedIdent lookup. That is safe because both ledger producers already owner-qualify repo before it reaches merged.recent: merged_ledger_server.go:107 (qualify(snap.Repo)) and merged_ledger.go:388-390 (audit path). So no title/lane/URL enrichment is lost by the tighter comparison.
  • stageTrackerMergeBannerRepo only falls back to key/url when the event carries no slashed repo, and never reads _primaryRepo or the active filter — the chip ctx only uses those for primary/active styling, same as stageTrackerRepoChipHtml at tracker-row-layout.js:359-365.
  • static/index.html hunk is byte-identical to the tracker-merged.js hunk (checked by diffing both).
  • node --test stage_tracker_merge_banner_countdown.test.js passes 7/7 on fb77581; the file cannot load against v5 (the pick() regexes for the new helpers throw), so the added coverage does fail without the change.

PR body matches what the diff does. No findings. Not approving — that's a human's signature; the do-not-merge/hold is the author's own gate.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson

Copy link
Copy Markdown
Member Author

/hold cancel
/lgtm
/approve

Exact source head fb77581: all applicable source CI is terminal and green, including the final linux/arm64 build. Read-only precommit code review found no significant issues. Releasing the deliberate hold; awaiting fresh native-queue-policy before exact-head guarded admin squash merge. No deployment.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@clubanderson: you cannot LGTM your own PR.

Details

In response to this:

/hold cancel
/lgtm
/approve

Exact source head fb77581: all applicable source CI is terminal and green, including the final linux/arm64 build. Read-only precommit code review found no significant issues. Releasing the deliberate hold; awaiting fresh native-queue-policy before exact-head guarded admin squash merge. No deployment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2026
@clubanderson
clubanderson merged commit 0a4aa3d into v5 Oct 31, 2026
91 of 100 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/merge-toast-repo branch October 31, 2026 12:49
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@clubanderson

Copy link
Copy Markdown
Member Author

Merged via explicit admin squash guarded by --match-head-commit fb77581.

Source receipt: tested head fb77581; merge commit 0a4aa3d; merged by clubanderson at 2026-10-31T12:49:17Z. Latest check per workflow/name: 66 SUCCESS, 12 SKIPPED, zero non-green/nonterminal checks. Fresh native-queue-policy SUCCESS (run 41202659277/job 124541384160) supersedes the deliberate hold failure. Final ARM64 build SUCCESS (run 41200744934/job 124535893752). External DCO and dco status SUCCESS; Tide retains a legacy pending status, not an outstanding source test. No local suite/build/lint/docs guards run; no live deployment or browser-geometry claim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant