Repository navigation
🐛 fix(dashboard): reuse repository chips in merge notifications - #16033
Conversation
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
/hold Holding for the exact source head’s full applicable CI matrix to reach a terminal verdict before guarded squash merge. No local test/build/lint verdict is substituted. |
|
/hold Waiting for the exact source head’s full applicable CI matrix to reach a terminal verdict before guarded squash merge. |
|
Source/CI owner update: Copilot merge-toast dispatch retains ownership through full terminal CI and guarded exact-head squash merge. Current source head: fb77581. Dashboard/shuffle shards and build-and-test (including Node regression suites) have passed. Only linux/arm64 build is still running. The sole reported failure is native-queue-policy, whose exact-head annotation is “#16033: head/base moved, draft, closed, or held”; this PR is intentionally /hold pending full CI. No code/fixture failure has been reported, and no speculative code change was made based on the dashboard caption. Will release hold once the remaining build succeeds, await fresh policy verdict, and merge guarded by the exact source SHA. No deployment. |
There was a problem hiding this comment.
Read the tree, not just the diff — this looks correct to me.
- The new strict owner/name match in
stageTrackerMergeBanner(src/pkg/dashboard/static-src/js/tracker-merged.js:985) replaces the old name-onlystageTrackerMergedIdentlookup. That is safe because both ledger producers already owner-qualifyrepobefore it reachesmerged.recent:merged_ledger_server.go:107(qualify(snap.Repo)) andmerged_ledger.go:388-390(audit path). So no title/lane/URL enrichment is lost by the tighter comparison. stageTrackerMergeBannerRepoonly falls back tokey/urlwhen the event carries no slashed repo, and never reads_primaryRepoor the active filter — the chip ctx only uses those for primary/active styling, same asstageTrackerRepoChipHtmlattracker-row-layout.js:359-365.static/index.htmlhunk is byte-identical to thetracker-merged.jshunk (checked by diffing both).node --test stage_tracker_merge_banner_countdown.test.jspasses 7/7 onfb77581; the file cannot load against v5 (thepick()regexes for the new helpers throw), so the added coverage does fail without the change.
PR body matches what the diff does. No findings. Not approving — that's a human's signature; the do-not-merge/hold is the author's own gate.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
/hold cancel Exact source head fb77581: all applicable source CI is terminal and green, including the final linux/arm64 build. Read-only precommit code review found no significant issues. Releasing the deliberate hold; awaiting fresh native-queue-policy before exact-head guarded admin squash merge. No deployment. |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
Merged via explicit admin squash guarded by --match-head-commit fb77581. Source receipt: tested head fb77581; merge commit 0a4aa3d; merged by clubanderson at 2026-10-31T12:49:17Z. Latest check per workflow/name: 66 SUCCESS, 12 SKIPPED, zero non-green/nonterminal checks. Fresh native-queue-policy SUCCESS (run 41202659277/job 124541384160) supersedes the deliberate hold failure. Final ARM64 build SUCCESS (run 41200744934/job 124535893752). External DCO and dco status SUCCESS; Tide retains a legacy pending status, not an outstanding source test. No local suite/build/lint/docs guards run; no live deployment or browser-geometry claim. |
Summary
Validation