Repository navigation
✨ feature: add opt-in Matrix Rain and Cascade display - #16020
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Implement the kiosk-only renderer, shared SSE nudge subscription, authorized line pulls, pause and reduced-motion views, and source/freshness labels. Hive-Run: #15936 Hive-Plan: #15936 Phase 2 browser renderer Hive-Spec: #15936#acceptance-criteria Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
- Guard hiveMatrixStart in boot.js inline script block to satisfy syntax-check no-undef - Route matrix poll timer through dashboardSetInterval to keep bare interval ratchet intact - Use type-scale tokens and scoped CSS properties in matrix.css to satisfy style ratchet Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
c034aff to
e64557d
Compare
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: rebased onto v5 (branch was 2 commits behind; the lone failing test TestEventTriggersRejectInvalidAndUnpersistedRules lives in a file this PR does not touch and was fixed on v5; native-queue-policy was evaluating the closed #15984 through the shared SHA). Author commits kept intact. CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#16020e64557d` sha256:5bee0f478e6dbcfcc02f1f8f2d3b38be75dc0fea4bbb6c5c82a9fb2993870551 — download from the dashboard or `hivectl review evidence #16020`. |
There was a problem hiding this comment.
Read at e64557d against the v5 tree. Looks correct to me against #15936's constraints; one thing worth knowing for sequencing.
- Isolation:
boot.jsonly setswindow.HIVE_MATRIXwhenkiosk && view === 'matrix', and both thematrix-modebody class andhiveMatrixStart()are inside that guard;sse-bootstrap.jsattacheshiveMatrixAttach(source)under the same flag, reusing the existing/api/eventsEventSource rather than opening a second one — per #15936 ("no change to?kiosk=1withoutview=matrix", "do not open a second one"). - No HTML sink: every line-content write in
matrix.jsistextContent(:38, :87, :89) or canvas; there is noinnerHTMLin the file. - Endpoint:
/api/matrix/lineshas no route insrc/pkg/dashboard/*.goon v5 today — the server side is sibling #15935 (open as fork PR #15977, currentlydirty). That is by design per #15936, andmatrix.js:162handles the404with the spec'd "Matrix mode is not enabled on this hive" notice. Net effect if this merges first: the view renders only that notice until #15935 lands. Not a defect, just the dependency to keep in mind when sequencing — and when #15935 does land,src/docs/streaming-the-activity-monitor.md(see #16025) will need its "pending" wording flipped.
Not approving — that's a human's signature.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Rebased onto v5: the close-read decision enum is already documented there by #16012, so that hunk is dropped. The Matrix section no longer claims the renderer is pending (#16020 may land without a docs change); instead it states the renderer as a dependency and adds an activation-checklist step to confirm the deployed build serves view=matrix before scale-up, as issue #16003 asks. Fixes #16003 Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Rebased onto v5: the close-read decision enum is already documented there by #16012, so that hunk is dropped. The Matrix section no longer claims the renderer is pending (#16020 may land without a docs change); instead it states the renderer as a dependency and adds an activation-checklist step to confirm the deployed build serves view=matrix before scale-up, as issue #16003 asks. Fixes #16003 Hive-Fix-Attempt: 1/6 Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Supersedes #15984 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).
Closes #15936
This branch is #15984's head
c034aff23a7das pushed by @thatguywob (forkthatguywob/hive), unchanged. Last lane reason on the original:check-failing:coverage.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.