Skip to content

✨ feature: add opt-in Matrix Rain and Cascade display - #16020

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
hive/adopt-15984
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
hive/adopt-15984

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15984 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).

Closes #15936

This branch is #15984's head c034aff23a7d as pushed by @thatguywob (fork thatguywob/hive), unchanged. Last lane reason on the original: check-failing:coverage.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15890 🐛 dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html
#16028 🐛 fix(automerge): time-box adopted-PR rebase attempts and re-home when exhausted same files src/pkg/dashboard/static/index.html
#16027 🐛 fix: keep the preparation train connector continuous between adjacent members same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
Implement the kiosk-only renderer, shared SSE nudge subscription, authorized line pulls, pause and reduced-motion views, and source/freshness labels.

Hive-Run: #15936
Hive-Plan: #15936 Phase 2 browser renderer
Hive-Spec: #15936#acceptance-criteria
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
- Guard hiveMatrixStart in boot.js inline script block to satisfy syntax-check no-undef
- Route matrix poll timer through dashboardSetInterval to keep bare interval ratchet intact
- Use type-scale tokens and scoped CSS properties in matrix.css to satisfy style ratchet

Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: rebased onto v5 (branch was 2 commits behind; the lone failing test TestEventTriggersRejectInvalidAndUnpersistedRules lives in a file this PR does not touch and was fixed on v5; native-queue-policy was evaluating the closed #15984 through the shared SHA). Author commits kept intact. CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: e64557df2

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#16020e64557d` sha256:5bee0f478e6dbcfcc02f1f8f2d3b38be75dc0fea4bbb6c5c82a9fb2993870551 — download from the dashboard or `hivectl review evidence #16020`.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read at e64557d against the v5 tree. Looks correct to me against #15936's constraints; one thing worth knowing for sequencing.

  • Isolation: boot.js only sets window.HIVE_MATRIX when kiosk && view === 'matrix', and both the matrix-mode body class and hiveMatrixStart() are inside that guard; sse-bootstrap.js attaches hiveMatrixAttach(source) under the same flag, reusing the existing /api/events EventSource rather than opening a second one — per #15936 ("no change to ?kiosk=1 without view=matrix", "do not open a second one").
  • No HTML sink: every line-content write in matrix.js is textContent (:38, :87, :89) or canvas; there is no innerHTML in the file.
  • Endpoint: /api/matrix/lines has no route in src/pkg/dashboard/*.go on v5 today — the server side is sibling #15935 (open as fork PR #15977, currently dirty). That is by design per #15936, and matrix.js:162 handles the 404 with the spec'd "Matrix mode is not enabled on this hive" notice. Net effect if this merges first: the view renders only that notice until #15935 lands. Not a defect, just the dependency to keep in mind when sequencing — and when #15935 does land, src/docs/streaming-the-activity-monitor.md (see #16025) will need its "pending" wording flipped.

Not approving — that's a human's signature.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

hivecommons-hive Bot added a commit that referenced this pull request Oct 31, 2026
Rebased onto v5: the close-read decision enum is already documented there
by #16012, so that hunk is dropped. The Matrix section no longer claims
the renderer is pending (#16020 may land without a docs change); instead
it states the renderer as a dependency and adds an activation-checklist
step to confirm the deployed build serves view=matrix before scale-up,
as issue #16003 asks.

Fixes #16003

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot merged commit 9046921 into v5 Oct 31, 2026
81 of 82 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-15984 branch October 31, 2026 12:24
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

hivecommons-hive Bot added a commit that referenced this pull request Oct 31, 2026
Rebased onto v5: the close-read decision enum is already documented there
by #16012, so that hunk is dropped. The Matrix section no longer claims
the renderer is pending (#16020 may land without a docs change); instead
it states the renderer as a dependency and adds an activation-checklist
step to confirm the deployed build serves view=matrix before scale-up,
as issue #16003 asks.

Fixes #16003

Hive-Fix-Attempt: 1/6

Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Add Matrix Rain and Cascade renderer behind ?kiosk=1&view=matrix

1 participant