Repository navigation
✨ Show online ClankeR IDs on the Contributors count pill - #15849
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:build-and-test |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
There was a problem hiding this comment.
Correctness review (head d245f2b)
1. CI regression: TestHelpTooltipsUseBodyFixedPortal11269 fails — src/pkg/dashboard/modal_tooltip_regression_test.go:95.
The PR rewrites the capture-phase scroll listener in static-src/js/tooltips-dialogs.js:167 to (e) => { if (configTooltipIsOpen() && !configTooltipOwns(e.target)) hideConfigTooltip(); } (so the long-list tooltip survives scrolling inside the portal), but the existing anchoring guard still string-matches the old literal. Dashboard shards 3/4 and shuffle 1/3 fail with tooltip anchoring regression guard missing "window.addEventListener('scroll', () => { if (configTooltipIsOpen()) hideConfigTooltip(); }, true)". The behavior change itself is sound (configTooltipOwns(document) is false, so page scroll still dismisses: tooltips-dialogs.js:39-44); only the guard needs updating:
"window.addEventListener('scroll', (e) => { if (configTooltipIsOpen() && !configTooltipOwns(e.target)) hideConfigTooltip(); }, true)",
(replace the 'scroll' entry at modal_tooltip_regression_test.go:95)
Checked and OK: setSidebarPairBadge resets textContent before the new tooltip span is appended, so tooltips don't accumulate across status updates (knowledge.js:219, contributors.js:502-508); OnlineIDs is always a non-nil slice so the empty state encodes []; sort is already imported in api_contribute.go. I could not read the changelog-fragment-guard / relative links job logs — please confirm those are unrelated to this branch.
— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Reviewed (security) — no blocking findings.
Advisory (low): online_ids is added to ContributorPoolStatus (src/pkg/dashboard/api_contribute.go:98), which is embedded in the cached StatusPayload (server.go:643, filled at server.go:2650). /api/snapshot is a public path (server.go:2356) and handleSnapshotAPI serves that cached status verbatim with no field stripping (api_snapshot.go:24-33), so when Hub.AutoSnapshot is on, the list of currently-online contributor IDs becomes visible without a dashboard session. IDs are opaque c-<6 hex> values (contribute_profiles.go:412) and gate nothing on their own (admin lookups by ID sit behind authenticated /api/contributors/...), so this is information disclosure only, not a credential leak — noting for awareness rather than requesting a change. Client-side rendering is safe: every ID goes through esc() before innerHTML (contributors.js:527; esc at debug-logs.js:469-478).
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
hive/awaiting-ci (scanner): failing on d245f2b: 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
CI follow-through correction: the failures were caused by this PR, not owner action. The tooltip-scroll improvement changed the shared listener but its existing Go source-contract test still pinned the old listener; the dashboard/shuffle failures then cascaded to aggregate test and coverage. Adding online IDs also shifted 54 API route citations, failing both docs links and changelog guards. Updated the exact contract to retain outside-scroll dismissal while permitting tooltip-list scrolling, and ran the CI-authorized citation fixer (54 rewritten, zero unresolved). No checks or coverage requirements weakened. Pushed a signed correction and am monitoring the new head through CI completion; no merge/deployment. |
|
Follow-through update: correction e3c4cc2 had no failing checks but eight required contexts never started because the PR became merge-conflicted against advancing v5 (one API-citation hunk). Refreshed only this feature branch from origin/v5, resolved that citation overlap with the authorized fixer, and regenerated the dashboard from the combined canonical static-src. No changes were taken from PR #15866 or its branch. New signed head: 9462072. All 14 focused tooltip JavaScript checks still pass. Continuing exact-new-head CI monitoring; not claiming readiness. |
|
Addendum to the FIX_DIFF triage above (same failing run, no new push since): the harness fix needs more than Also a correction to point 2 above: Not pushing: branch is not hive-authored. hive/awaiting-ci: author fix pending. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
8f9a478 to
0ff4ed1
Compare
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…ement Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
/api/status.contributorPoolfeed; add onlyonline_ids, derived from the exact profile/heartbeat predicate previously used by the numerator. The numerator remains registered contributors with a live socket heartbeat within the configured presence window (15m default), not number of sessions; denominator remains registered profiles. Multiple sessions do not duplicate IDs.Validation
make dashboard-gen: regenerated canonical static-src bundle.node --test dashboard/test/config-tooltip.test.js: 14 passed.git diff --checkand touched Go formatting: clean.Fixes #15848