Repository navigation
✨ feat(dashboard): replace Matrix presentation with Code activity - #16500
thatguywob wants to merge 9 commits into
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Keeps the operator index.html style ratchet at its baseline: the reader's raw font-size, padding and border-radius values become var() tokens. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Hive-Run: hivecommons#16476 Hive-Plan: reader-source-cutover Hive-Spec: code-activity#published-checkpoints Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Reuse the authorized sentinel observer for complete add/remove regions with whole-region filtering, bounds, continuation and policy epochs. Keep code memory-only, clear stale policy data, and label buffered snapshots and explicit replay in the reader. Hive-Run: hivecommons#16476 Hive-Plan: reader-source-cutover Hive-Spec: code-activity#published-checkpoints Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Hive-Run: hivecommons#16477 Hive-Plan: reader-source-cutover Hive-Spec: code-activity#cutover Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Retire the decorative code display and expose one Code activity toolbar entry opening the published-checkpoint reader in a new tab. Update saved display links, compatibility guidance and toolbar regression coverage without changing capture defaults or authorization. Hive-Run: hivecommons#16477 Hive-Plan: reader-source-cutover Hive-Spec: code-activity#cutover Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
11e3baa
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #16500 waits for #16492 (changes_requested) and #16499 (needs human) to land and is then rebased to the single cutover commit 5b94ff6, or whether the three stacked PRs merge as one unit via this PR.
Routing this to a maintainer rather than reviewing the cutover line-by-line. Facts I verified at head 11e3baa:
- Carries
sentinel-alertand modifies a deploy manifest:src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34changes the ConfigMap patchDASHBOARD_PATHfrom/?kiosk=1&view=matrix&sound=offto/?kiosk=1&view=reader&sound=off. That is the only deploy change and it is a query-string edit on an overlay the body says stays at zero replicas — but the sentinel label means a person signs off on deploy edits, not me. - Stacked on two unmerged PRs and includes their commits. The commit list contains
8692bfeaa(the head of #16492, which currently carries a hivechanges_requestedverdict) and0bc67d5bf(#16499,requires_human). The actual cutover is the single commit5b94ff6db; the other 8 commits are prerequisites plus merge commits. Reviewing this diff as-is means re-reviewing code the hive has already asked to change on #16492. - CI is red on this head:
test (dashboard 2/4),test (dashboard 4/4),test (dashboard shuffle 3/3),test (rest 2/4),coverage,mobile-shots, andSign-off survives the squash/native-queue-policyall failed. The sign-off failure is consistent with the embedded merge commits (22a58ccfa,8692bfeaa) not carrying DCO trailers, which a squash would drop. - Body and diff agree on scope (38 files: Matrix renderer/CSS/JS removal, topbar/boot/refresh rewiring, docs, config comments, deprecated
/api/matrix/linesanddashboard.matrix.*names kept). I did not find a body claim the diff fails to implement at the file level, but I did not trace the 1.7k-line JS/Go change given the stacking problem above.
My recommendation: hold this until #16492 and #16499 land, then rebase so the PR is only 5b94ff6db; review the cutover then. If instead the three are meant to merge as one unit, this PR should be the one reviewed and the other two closed — but that is a sequencing call for the owner.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Closing as superseded by #16514, which adopted this branch (body states 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Closes #16477
Code activity becomes the sole code display: the Activity Monitor topbar opens the published-checkpoint reader in a new tab, and the Matrix rain/cascade/ghost/terminal renderers, styles and saved presentation options are retired. The separate stream overlay points to the reader while remaining at zero replicas. Capture stays default-off with the existing authorization and public allowlist boundaries.
Depends on #16492 (reader) and #16499 (published-checkpoint source); merge those in that order before this cutover. This branch starts from upstream/v5 and includes their prerequisite commits for a complete reviewable implementation. The cutover itself is commit 5b94ff6; it updates navigation, display URLs, operator/API documentation and config comments, preserves the deprecated internal
/api/matrix/linesanddashboard.matrix.*names, and adds the changelog fragment.Validation: regenerated
static/index.htmlwithgo generate ./pkg/dashboard/webstatic/;gofmt -lon changed Go files andgit diff --checkwere clean. Tests now follow the actual shipped toolbar href to boot the reader, verify status-driven entry visibility, and reject retired Matrix assets. Existing reader lifecycle, source and authorization coverage remains. Tests were not run locally: AGENTS.md reserves execution for CI. No deployment or broadcast activation was performed.— hive: backend=codex model=gpt-6.1-sol effort=medium
🐝 Hive Agent:
contributor| SHA:5b94ff6db