Skip to content

✨ feat(dashboard): replace Matrix presentation with Code activity - #16500

Closed
thatguywob wants to merge 9 commits into
hivecommons:v5from
thatguywob:scanner/code-activity-cutover-16477
Closed

thatguywob wants to merge 9 commits into
hivecommons:v5from
thatguywob:scanner/code-activity-cutover-16477

Conversation

@thatguywob

Copy link
Copy Markdown
Contributor

Closes #16477

Code activity becomes the sole code display: the Activity Monitor topbar opens the published-checkpoint reader in a new tab, and the Matrix rain/cascade/ghost/terminal renderers, styles and saved presentation options are retired. The separate stream overlay points to the reader while remaining at zero replicas. Capture stays default-off with the existing authorization and public allowlist boundaries.

Depends on #16492 (reader) and #16499 (published-checkpoint source); merge those in that order before this cutover. This branch starts from upstream/v5 and includes their prerequisite commits for a complete reviewable implementation. The cutover itself is commit 5b94ff6; it updates navigation, display URLs, operator/API documentation and config comments, preserves the deprecated internal /api/matrix/lines and dashboard.matrix.* names, and adds the changelog fragment.

Validation: regenerated static/index.html with go generate ./pkg/dashboard/webstatic/; gofmt -l on changed Go files and git diff --check were clean. Tests now follow the actual shipped toolbar href to boot the reader, verify status-driven entry visibility, and reject retired Matrix assets. Existing reader lifecycle, source and authorization coverage remains. Tests were not run locally: AGENTS.md reserves execution for CI. No deployment or broadcast activation was performed.

— hive: backend=codex model=gpt-6.1-sol effort=medium


🐝 Hive Agent: contributor | SHA: 5b94ff6db

hivecommons-hive Bot and others added 8 commits November 3, 2026 19:30
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Keeps the operator index.html style ratchet at its baseline: the reader's
raw font-size, padding and border-radius values become var() tokens.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Hive-Run: hivecommons#16476
Hive-Plan: reader-source-cutover
Hive-Spec: code-activity#published-checkpoints
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Reuse the authorized sentinel observer for complete add/remove regions with whole-region filtering, bounds, continuation and policy epochs. Keep code memory-only, clear stale policy data, and label buffered snapshots and explicit replay in the reader.

Hive-Run: hivecommons#16476
Hive-Plan: reader-source-cutover
Hive-Spec: code-activity#published-checkpoints
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Hive-Run: hivecommons#16477
Hive-Plan: reader-source-cutover
Hive-Spec: code-activity#cutover
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Retire the decorative code display and expose one Code activity toolbar entry opening the published-checkpoint reader in a new tab. Update saved display links, compatibility guidance and toolbar regression coverage without changing capture defaults or authorization.

Hive-Run: hivecommons#16477
Hive-Plan: reader-source-cutover
Hive-Spec: code-activity#cutover
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • relative links and anchors resolve
    Review asks:
  • 2 commits are signed off as the hive App instead of you, so a squash merge would misattribute them — set git config user.email to your own address, then run git rebase --exec 'git commit --amend --no-edit --reset-author -s' HEAD~4 && git push --force-with-lease

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • Sign-off survives the squash
  • native-queue-policy
    Review asks:
  • 2 commits are signed off as the hive App instead of you, so a squash merge would misattribute them — set git config user.email to your own address, then run git rebase --exec 'git commit --amend --no-edit --reset-author -s' HEAD~5 && git push --force-with-lease

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16456 ✨ feat(github): enforce pin-only exception in merge-request relay same files src/docs/operator-reference/README.md
src/pkg/config/config.go
#16593 🐛 Activity Monitor: person-owed PR steps light PR in progress, not Merge queue same files src/pkg/dashboard/static/index.html
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity same files changelog.d/changed-16477-code-activity-cutover.md
src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml
src/docs/api-reference/dashboard-misc.md
src/docs/dashboard.md
src/docs/operator-reference/README.md
src/docs/streaming-the-activity-monitor.md
src/pkg/config/config.go
src/pkg/config/dashboard_matrix.go
src/pkg/dashboard/kiosk_cta.test.js
src/pkg/dashboard/matrix_header_tab_test.go
src/pkg/dashboard/matrix_ui_test.go
src/pkg/dashboard/reader_ui_test.go
src/pkg/dashboard/static-src/css/matrix.css
src/pkg/dashboard/static-src/html/topbar.html
src/pkg/dashboard/static-src/js/boot.js
src/pkg/dashboard/static-src/js/matrix.js
src/pkg/dashboard/static-src/js/refresh.js
src/pkg/dashboard/static-src/js/sse-bootstrap.js
src/pkg/dashboard/static-src/manifest.txt
src/pkg/dashboard/static/index.html
src/pkg/dashboard/webstatic/dashboard_script_test.go

@hivecommons-hive

Copy link
Copy Markdown
Contributor
11e3baa

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @thatguywob, head 11e3baa5da2d) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml
  • remote_code_execution — adds a remote-fetch-and-execute, decoded payload, reverse shell or embedded credential (Adds curl|sh, eval of encoded payloads, reverse shells or embedded private keys)
    • src/pkg/dashboard/checkpoint_source_test.go

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether #16500 waits for #16492 (changes_requested) and #16499 (needs human) to land and is then rebased to the single cutover commit 5b94ff6, or whether the three stacked PRs merge as one unit via this PR.

Routing this to a maintainer rather than reviewing the cutover line-by-line. Facts I verified at head 11e3baa:

  • Carries sentinel-alert and modifies a deploy manifest: src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34 changes the ConfigMap patch DASHBOARD_PATH from /?kiosk=1&view=matrix&sound=off to /?kiosk=1&view=reader&sound=off. That is the only deploy change and it is a query-string edit on an overlay the body says stays at zero replicas — but the sentinel label means a person signs off on deploy edits, not me.
  • Stacked on two unmerged PRs and includes their commits. The commit list contains 8692bfeaa (the head of #16492, which currently carries a hive changes_requested verdict) and 0bc67d5bf (#16499, requires_human). The actual cutover is the single commit 5b94ff6db; the other 8 commits are prerequisites plus merge commits. Reviewing this diff as-is means re-reviewing code the hive has already asked to change on #16492.
  • CI is red on this head: test (dashboard 2/4), test (dashboard 4/4), test (dashboard shuffle 3/3), test (rest 2/4), coverage, mobile-shots, and Sign-off survives the squash / native-queue-policy all failed. The sign-off failure is consistent with the embedded merge commits (22a58ccfa, 8692bfeaa) not carrying DCO trailers, which a squash would drop.
  • Body and diff agree on scope (38 files: Matrix renderer/CSS/JS removal, topbar/boot/refresh rewiring, docs, config comments, deprecated /api/matrix/lines and dashboard.matrix.* names kept). I did not find a body claim the diff fails to implement at the file level, but I did not trace the 1.7k-line JS/Go change given the stacking problem above.

My recommendation: hold this until #16492 and #16499 land, then rebase so the PR is only 5b94ff6db; review the cutover then. If instead the three are meant to merge as one unit, this PR should be the one reviewed and the other two closed — but that is a sequencing call for the owner.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

⚠️ Hold-gate mergeability: this PR has a real conflict with its base

This PR is hold-gated and has fallen behind its base branch. The hive tried to merge the base in to keep it mergeable while it waits on review, but that merge conflicts and the hive cannot resolve it automatically.

It will stay held and will NOT merge on its own even once reviewed — removing hold alone will not be enough. Someone will need to merge or rebase the base branch in by hand (or resolve the conflict another way) before this PR can merge.

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closing as superseded by #16514, which adopted this branch (body states Supersedes #16500), re-applies the cutover commit with @thatguywob's Signed-off-by preserved, and carries the same Closes #16477. This PR is labelled needs-rebase and conflicts with its base; #16514 is the rebased continuation. Triage recorded in #16581.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sentinel-alert size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Cutover: Code activity supersedes and retires the Matrix code-view entry point (part 3/3 of #16137)

1 participant