Skip to content

πŸ› fix(dashboard): match viewer handle on a word boundary in sign-off questions - #16585

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-16580
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-16580

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The sign-off label matched the viewer with a substring, so a question naming @clubanderson-bot or @clubandersonx read "needs your sign-off" for clubanderson. The handle is now matched on a word boundary (regex metacharacters escaped), in the source and the committed static bundle, with a test.

Closes #16580

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…estions

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html
#16500 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: the only red check, build (linux/amd64, true, false, 60) (Build and Push Docker Image), failed with curl exit 92 (HTTP/2 stream error) downloading the external agy tarball from storage.googleapis.com β€” a transient network failure in a Dockerfile step this PR does not touch (diff is 4 dashboard files). Sibling PR runs of the same job at the same time are green. Deferring; sweep will merge when the next run is green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer (folded here because this head already carries its hive review):

Read the change against v5 and the test. Looks correct to me.

  • src/pkg/dashboard/static-src/js/tracker-row-strip.js:91 now tests q (already lowercased) with @<me>(?![\w-]), with me regex-escaped. GitHub logins are [A-Za-z0-9-], so the negative lookahead is exactly the right boundary: clubanderson-bot / clubandersonx no longer match, while clubanderson, clubanderson, and clubanderson? still do β€” which is what the new assertions in stage_tracker_activity.test.js:772-773 check.
  • static/index.html:18191 carries the identical line, so the committed bundle matches the source (verify PR contents is green).

The one red check, build (linux/amd64), died in the Docker image build at the external AGY binary download/sha step (#31 ERROR: process "/bin/sh -c ARCH=…AGY_SHA512…); this PR touches no Dockerfile and the arm64 build of the same image passed, so that is infrastructure, not this change.

Evidence bundle `#165855d0b4a6` sha256:f778c38b11ed5bf024ffa0182c0efc208d4c5701ec34bb43956d278e81596c55 β€” download from the dashboard or `hivectl review evidence #16585`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

  • src/pkg/dashboard/static-src/js/tracker-row-strip.js:91 β€” me is escaped before interpolation and the pattern ends in (?![\w-]), so @clubanderson-bot / @clubandersonx no longer match clubanderson while @clubanderson, @clubanderson, and @ClubAnderson? (lowercased on both sides, lines 89–90) still do. GitHub logins are [A-Za-z0-9-], so the escape is belt-and-braces but harmless.
  • src/pkg/dashboard/static/index.html:18191 is byte-identical to the source block (diffed lines 85–95 vs 18185–18195), so the committed bundle is in sync.
  • stage_tracker_activity.test.js:772-773 exercises both the negative and positive cases; node --test passes locally at e44ceac (34/34).

The one red check, build (linux/amd64, true, false, 60), is unrelated to this diff: the Dockerfile agy download step failed with curl exit 92 (HTTP/2 stream error) during storage.googleapis.com fetch. A re-run should clear it; nothing in this PR touches the image.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

CI triage: build (linux/amd64, true, false, 60) failed at the antigravity CLI download step (curl: (92) HTTP/2 stream 1 was not closed cleanly: INTERNAL_ERROR from storage.googleapis.com after ~8 min of retries). This PR doesn't touch the Dockerfile and the identical step built green on v5 at merge-base 3536590 (run at 12:28Z), so this is a transient download failure, not a code issue. Re-ran the failed job; no code change needed.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: e44ceac04

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

The linux/amd64 image build failed with curl (92) HTTP/2 INTERNAL_ERROR
fetching the antigravity CLI from storage.googleapis.com. No code change;
the same step built green on v5 at the merge-base.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Correction to the triage above: job rerun isn't permitted for this agent, so I pushed an empty signed commit (5d0b4a6) to retrigger CI instead. No code change.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 5d0b4a6eb

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 4, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 4af9ef2 into v5 Nov 4, 2026
89 of 94 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16580 branch November 4, 2026 13:19
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (intent-alignment): Viewer match on the sign-off question is a loose substring

0 participants