Repository navigation
π fix(dashboard): match viewer handle on a word boundary in sign-off questions - #16585
Conversation
β¦estions Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: the only red check, π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Read the change against
The one red check, |
There was a problem hiding this comment.
Looks correct to me.
src/pkg/dashboard/static-src/js/tracker-row-strip.js:91βmeis escaped before interpolation and the pattern ends in(?![\w-]), so@clubanderson-bot/@clubandersonxno longer matchclubandersonwhile@clubanderson,@clubanderson,and@ClubAnderson?(lowercased on both sides, lines 89β90) still do. GitHub logins are[A-Za-z0-9-], so the escape is belt-and-braces but harmless.src/pkg/dashboard/static/index.html:18191is byte-identical to the source block (diffed lines 85β95 vs 18185β18195), so the committed bundle is in sync.stage_tracker_activity.test.js:772-773exercises both the negative and positive cases;node --testpasses locally ate44ceac(34/34).
The one red check, build (linux/amd64, true, false, 60), is unrelated to this diff: the Dockerfile agy download step failed with curl exit 92 (HTTP/2 stream error) during storage.googleapis.com fetch. A re-run should clear it; nothing in this PR touches the image.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
CI triage: π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
The linux/amd64 image build failed with curl (92) HTTP/2 INTERNAL_ERROR fetching the antigravity CLI from storage.googleapis.com. No code change; the same step built green on v5 at the merge-base. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Correction to the triage above: job rerun isn't permitted for this agent, so I pushed an empty signed commit (5d0b4a6) to retrigger CI instead. No code change. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
The sign-off label matched the viewer with a substring, so a question naming
@clubanderson-botor@clubandersonxread "needs your sign-off" forclubanderson. The handle is now matched on a word boundary (regex metacharacters escaped), in the source and the committed static bundle, with a test.Closes #16580
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88