Repository navigation
π fix: avoid empty reader catch-up pulls for filtered lines - #16576
Conversation
Report whether another allowed line remains in a matrix page and use that signal to finish reader catch-up without an empty follow-up request. Keep the global sequence and legacy-server fallback. Hive-Run: #16530 Hive-Plan: issue-16530 Hive-Spec: #16530 Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
The reader moved to format=regions on v5 (#16513), so the client half of this fix is superseded; the API change still lands for /api/matrix/lines. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Intent alignment (head eca144d) β approve, with one advisory.
The server half of #16530's suggested remedy is implemented correctly: SinceMatching now looks one kept line past limit and reports it (src/pkg/dashboard/matrix_source.go:402-411), and TestHandleMatrixLines_MoreCountsOnlyAllowedLines covers the filtered-tail case ("only hidden lines" β more=false).
Advisory: no client reads the new more field, and the client defect the issue describes is already gone at this head.
src/pkg/dashboard/static-src/js/reader.js:193requestsformat=regions, whichsrc/pkg/dashboard/api_matrix.go:102-104routes tohandleCheckpointRegionsβcheckpoints.since(src/pkg/dashboard/checkpoint_source.go:289-315). That path never callsSinceMatching, and it pages precisely (Seq= last consumed region, line 309;reader.js:211compares it tolatest), so the extra empty pull from the issue'sreturned < seqguess (545733creader.js:195-196) no longer occurs.src/pkg/dashboard/static-src/js/matrix.js:299hits the pushed-lines path but does not page and ignoresmore.
Net: this PR is a safe, additive API field with no observable change for the issue's symptom. Fine to land; just be aware "Fixes #16530" closes an issue whose cited mechanism was already removed by the regions refactor, and the changelog's "clients β¦ can stop without an empty follow-up request" describes a capability no in-tree client uses yet.
β hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Style review @ Changelog claims a client benefit nothing in-tree realises. Requested change (pick one, no human needed): either reword the fragment as a plain API addition β e.g. Review findings from Correctness review @ eca144d β server change is correct; the contract (#16530) is only half-closed.
In-scope gap β nothing can discover or use
Requested change: extend the Review findings from Head What changed since Re-verified the server half against the tree:
Still true, for the record (not a blocker): no in-tree client reads Review findings from Conclusion: the server change is correct, but at this head nothing consumes it. The defect #16530 describes was removed from What I verified (tree at
Gap between body/changelog and diff: Either outcome is fine with me; it is a scope call, not a defect. I have not closed or approved anything. Evidence bundle `#165767b45059` sha256:18e43a175e1d9a4fa3dce6148b70802b02929fbe57d44373dd286ce41b277a14 β download from the dashboard or `hivectl review evidence #16576`. |
No in-tree client reads `more` yet, so describe it where paging guidance lives (the /api/matrix/lines API-reference row) and record the change as an API addition rather than a client fix. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Head 7b45059 β looks correct to me; the one prior ask is resolved.
What changed since eca144d is docs-only: changelog.d/fixed-reader-filtered-catch-up.md is replaced by changelog.d/added-16530-matrix-lines-more.md, which now records the change as an API addition (/api/matrix/lines returns more) rather than a client fix, and src/docs/api-reference/dashboard-misc.md:59 documents more on the endpoint row where the paging guidance already lives. scripts/check-api-reference-citations.sh passes at this head.
Server code re-read, unchanged from the reviewed head:
src/pkg/dashboard/matrix_source.go:402-411β the scan no longer stops atlimit; it keeps walking and returnsmore=trueon the first kept line past the page, so filtered-out tail entries never produce a truemore. The only other caller,Since(matrix_source.go:386), discards the third return. The ring is capped atmatrixBacklogCap = 2000(matrix_source.go:22), so the full walk per request is negligible.src/pkg/dashboard/api_matrix_test.go:419-457covers truncated / full-final / short-final / hidden-tail / caught-up cases against the handler with the allowlist filter in place.
Additive field, no behaviour change for existing clients. Ready for an approver; I have not approved anything.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #16569 (adopted in place, re-homed because a hive commit on the contributor branch cannot carry a squash-safe sign-off; original commits by @thatguywob preserved).
Fixes #16530
This branch is #16569's head
eca144d2426eas pushed by @thatguywob (forkthatguywob/hive), unchanged. Last lane reason on the original:reviewer-verdict:changes_requested.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Sign-off attribution: the original PR would squash the App's signed fixes as the contributor. This App-authored superseder keeps every original commit and sign-off unchanged and attributes the squash to the App instead. DCO and all merge gates still apply here.