Skip to content

✨ feat(dashboard): replace Matrix presentation with Code activity - #16609

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-16477
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-16477

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Closes #16477
Part of #16137 (epic; this is the final child, but the epic stays open — the hive closes it once all children are done).
Supersedes #16514 (and the earlier attempt #16500). Fixes #16563.

Why

The maintainer chose option B on #16137: the published-checkpoint reader replaces the Matrix code view (pushed lines only, no workspace/pre-push capture, no broader permissions, no anonymous kiosk access, no auto-enablement), implemented in this order: reader → source → cutover. Parts 1 (#16475 / #16492) and 2 (#16476 / #16513) are merged on v5. That leaves this cutover: replace the side-by-side Matrix entry with a single Code activity entry and retire the decorative renderers. #16514 included the whole stack; this branch starts fresh from v5 and carries only the part-3 changes.

Compatibility (renames are avoided; old names become aliases):

  • The single topbar entry keeps the element id oc-matrix-tab, so existing selectors and the status.matrixEnabled visibility toggle in refresh.js keep working. It now links to ?kiosk=1&view=reader (new tab, rel="noopener"). The temporary oc-reader-tab from part 1 is folded into it, so the two entries no longer sit side by side.
  • ?kiosk=1&view=matrix is now a deprecated alias that boots the reader. Saved display URLs keep working instead of quietly falling back to the plain Activity Monitor.
  • /api/matrix/lines, dashboard.matrix.* and config/dashboard_matrix.go are unchanged and documented as deprecated names. There is no config break, and the default stays off.

Deploy overlay (src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml): left untouched on purpose. It is a replicas: 0 overlay that only an owner can activate. Its DASHBOARD_PATH=/?kiosk=1&view=matrix&sound=off now opens Code activity through the alias above. That is the smallest change that keeps the old URL from 404ing or falling back, and it leaves no deploy decision to make here. The streaming doc and deploy README say this.

Docs: dashboard.md, api-reference/dashboard-misc.md, streaming-the-activity-monitor.md and operator-reference/README.md now describe the source semantics (published PR checkpoints only) and the activation status (opt-in, default off). The /api/matrix/lines API table row now carries the "(deprecated name, see Published-checkpoint regions)" marker (Refs #16563; that item belongs to its human claimant and is not closed here).

Tests: matrix_header_tab_test checks the actual toolbar entry: exactly one entry, view=reader, new tab, label "Code activity". matrix_ui_test checks that the retired assets/hooks are gone and runs the shipped status handler on #oc-matrix-tab. reader_ui_test follows the shipped toolbar href and asserts that view=matrix activates the reader. kiosk_cta and webstatic tests now refer to the reader. static/index.html was regenerated with the go:generate concat tool (-check clean). The docs and API citation checkers report no drift.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@hanthor

Cutover (part 3/3 of #16137): the Activity Monitor topbar entry #oc-matrix-tab
becomes a single Code activity entry opening the published-checkpoint reader
in a new tab, and the decorative Matrix renderers, styles and boot/SSE hooks
are retired. Saved ?kiosk=1&view=matrix URLs alias to the reader; the
/api/matrix/lines and dashboard.matrix.* names stay supported as deprecated
aliases. Default stays off.

Closes #16477

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
53aef34

ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head 53aef349c8a2) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • src/deploy/stream/README.md

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 5d0b4a6eb

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

Review findings from reviewer (folded here because this head already carries its hive review):

Read the tree at 53aef34, not just the diff. This looks correct to me; nothing blocking.

What I verified:

  • Alias works end to end. static-src/js/boot.js:41 sets HIVE_READER for view === 'reader' || view === 'matrix'; static-src/js/reader.js:8,13 gate hiveReaderAttach/hiveReaderStart on that flag only, so ?kiosk=1&view=matrix (still the value in deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34) boots the reader rather than falling back to the plain monitor.
  • No dangling references to the retired renderer. grep -rn 'HIVE_MATRIX\|hiveMatrix\|matrix-mode\|oc-reader-tab\|matrix\.css\|matrix\.js' src on the PR head returns only the tests that assert absence and unrelated cadence_matrix/governor-matrix names. static-src/js/sse-bootstrap.js no longer calls hiveMatrixAttach, so removing matrix.js from manifest.txt cannot leave an undefined-function call.
  • Generated page is in sync. go generate ./pkg/dashboard/... on the PR head leaves git status clean.
  • Status toggle keeps working. static-src/js/refresh.js:483 still targets #oc-matrix-tab, the id the single topbar entry retains in static-src/html/topbar.html:28; server.go:3784 still emits matrixEnabled.
  • CTA test assertion is backed by real CSS. kiosk_cta.test.js:32 now expects body.reader-mode #kiosk-cta {…}; that exact rule exists at static-src/css/reader.css:26 (already on v5) and appears once in static/index.html.
  • No trust-surface change. No Go handler, auth path, config default or workflow changes; dashboard.matrix stays default-off and /api/matrix/lines is untouched. Docs (dashboard.md, streaming-the-activity-monitor.md, api-reference/dashboard-misc.md) describe exactly the behaviour the code has.

Body vs diff: consistent — the body's compatibility claims (retained oc-matrix-tab id, view=matrix alias, overlay left untouched, no config rename) all match the code.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the diff against v5 at ca73017 plus the callers. Looks correct to me; one body nit below.

Verified

  • static-src/js/boot.js:39–41 — HIVE_READER now also fires on view=matrix, and sse-bootstrap.js / refresh.js:482–484 no longer reference HIVE_MATRIX or oc-reader-tab. A grep of the PR tree finds no remaining hiveMatrixStart / hiveMatrixAttach / matrix-mode / matrix.css / matrix.js references outside the tests that assert they are gone (governor-matrix.css in manifest.txt:20 is the unrelated governor grid).
  • topbar.html:28 keeps id="oc-matrix-tab" + hidden, so the status.matrixEnabled toggle in refresh.js still gates visibility; rel="noopener" accompanies the new target="_blank".
  • The untouched overlay's DASHBOARD_PATH=/?kiosk=1&view=matrix&sound=off lands on the reader via the alias, and reader_ui_test.go now runs exactly that query plus the shipped toolbar href.
  • Ran go run ./gen -src ../static-src -out ../static/index.html -check and go build ./pkg/dashboard/... ./pkg/config/... on the head: both clean. (Dashboard test shards are green in CI; I can't run go test here.)

Body nit (low): the first line says Fixes #16563, which is a closing keyword, while the Docs paragraph says "Refs #16563; … not closed here". The diff does carry #16563's only ask — the (deprecated name, …) marker on the /api/matrix/lines row at src/docs/api-reference/dashboard-misc.md:59 — so closing it on merge is the right outcome and the prose is what's stale. Suggest dropping the "not closed here" sentence so the body and the link semantics agree; nothing in the code needs to change.

Evidence bundle `#16609ca73017` sha256:77696e070fcfce46b91571a08dcf97756c490b5f3bbe5f475efe85c5efe98b2d — download from the dashboard or `hivectl review evidence #16609`.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16607 ✨ feat(github): enforce pin-only exception in merge-request relay same files src/docs/operator-reference/README.md
src/pkg/config/config.go
#16598 ✨ Auto-decide reviewer scope questions on hive-authored green PRs same files src/pkg/config/config.go
src/pkg/dashboard/server.go
#16600 ✨ Activity Monitor chevrons: active-with-text / icon-only spec, ring glyph, workflow-approval stall caption same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me — read at 53aef34 against origin/v5 (one commit, 23 files; an earlier stale-base diff suggested extra files, which was my local checkout, not the PR).

What I verified in the tree, not just the diff:

  • No dangling references. After matrix.js/matrix.css leave the manifest, HIVE_MATRIX, hiveMatrixStart, hiveMatrixAttach, matrix-mode and oc-reader-tab appear nowhere in src/ outside the two tests that assert their absence (matrix_ui_test.go:12-17, matrix_header_tab_test.go:34). sse-bootstrap.js:31 no longer calls a function that no longer exists.
  • Alias is complete. boot.js:41 sets HIVE_READER for view=matrix too, and reader.js does not parse view itself, so the saved DASHBOARD_PATH=/?kiosk=1&view=matrix&sound=off in the untouched hive-hosted-matrix overlay boots the reader as the body says.
  • Kiosk CTA rule exists. kiosk_cta.test.js:33 now asserts body.reader-mode #kiosk-cta …; that rule is really at static-src/css/reader.css:26.
  • Generated page is in sync. Re-ran go generate in pkg/dashboard/webstatic on the head; git status is clean.
  • Visibility toggle preserved. refresh.js:482-484 still hides/shows #oc-matrix-tab from status.matrixEnabled, and the anchor keeps hidden by default (topbar.html:28).

CI dashboard/agent/rest shards and relative links and anchors resolve are green; only tide is pending. Nothing I would hold this on.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at ca73017 (not just the diff). Looks correct to me.

What I verified

  • static-src/js/boot.js:41 is now the only place that decides the code view: HIVE_READER = kiosk && (view === 'reader' || view === 'matrix'). HIVE_MATRIX, hiveMatrixStart/hiveMatrixAttach, matrix-mode, oc-reader-tab, js/matrix.js and css/matrix.css have no remaining references anywhere under src/ except the tests that assert their absence (matrix_ui_test.go:12-17, matrix_header_tab_test.go:34). sse-bootstrap.js:31 keeps only the reader attach, so nothing dereferences a removed global.
  • refresh.js:482-484 still toggles #oc-matrix-tab from status.matrixEnabled; topbar.html:28 keeps that id, so the existing visibility path is unchanged. reader.css:26 already carries the body.reader-mode #kiosk-cta lift that kiosk_cta.test.js:34 now asserts.
  • go run ./gen -src ../static-src -out ../static/index.html -check in pkg/dashboard/webstatic is clean at this head, so static/index.html matches static-src/.
  • The only live view=matrix consumer is deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34, which the alias at boot.js:41 now serves; reader_ui_test.go scenario ?kiosk=1&view=matrix&sound=off covers exactly that URL.
  • docs/api-reference/dashboard-misc.md:59 now carries the deprecation marker that #16563 asked for, so that finding is fully addressed by this diff.

One body nit (no code change needed): the header says Fixes #16563, which will close it on merge (base v5 is the default branch), while the Docs paragraph says "Refs #16563 … not closed here". The diff does fix it completely, so Fixes is the right keyword — just drop the contradictory sentence so a maintainer isn't left wondering which is intended.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed the role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) label Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot removed the stage/050-review-pending Review swarm requested; awaiting a verdict for the current head label Nov 4, 2026
clubanderson added a commit that referenced this pull request Nov 4, 2026
… v5 regions doc section

unparkStageThatStays (v6 #14218) seeded the post-un-park label set with
approved-direction unconditionally. v5 #16579 now derives needs-human beside
the ack as held human work (stage None) rather than a 045 park, so for a kept
lifecycle needs-human — where the ack is withheld — the helper misreported
the hive's stage/045 as lifting and the reply said "still on the issue"
instead of "stays". Only seed the ack when acknowledge is set.

Fixes TestSweepLabelDrivenHiveApproveKeptNeedsHumanKeepsStage (test rest 3/4).

Also re-add the "Published-checkpoint regions" prose section from v5 #16609
to api-reference/dashboard-misc.md, dropped by the row-only conflict
resolution; fixes the broken #published-checkpoint-regions anchor
(relative links and anchors resolve).

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

0 participants