Repository navigation
✨ feat(dashboard): replace Matrix presentation with Code activity - #16609
Conversation
Cutover (part 3/3 of #16137): the Activity Monitor topbar entry #oc-matrix-tab becomes a single Code activity entry opening the published-checkpoint reader in a new tab, and the decorative Matrix renderers, styles and boot/SSE hooks are retired. Saved ?kiosk=1&view=matrix URLs alias to the reader; the /api/matrix/lines and dashboard.matrix.* names stay supported as deprecated aliases. Default stays off. Closes #16477 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
53aef34
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Review findings from Read the tree at 53aef34, not just the diff. This looks correct to me; nothing blocking. What I verified:
Body vs diff: consistent — the body's compatibility claims (retained Review findings from Read the diff against v5 at Verified
Body nit (low): the first line says |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Looks correct to me — read at 53aef34 against origin/v5 (one commit, 23 files; an earlier stale-base diff suggested extra files, which was my local checkout, not the PR).
What I verified in the tree, not just the diff:
- No dangling references. After
matrix.js/matrix.cssleave the manifest,HIVE_MATRIX,hiveMatrixStart,hiveMatrixAttach,matrix-modeandoc-reader-tabappear nowhere insrc/outside the two tests that assert their absence (matrix_ui_test.go:12-17,matrix_header_tab_test.go:34).sse-bootstrap.js:31no longer calls a function that no longer exists. - Alias is complete.
boot.js:41setsHIVE_READERforview=matrixtoo, andreader.jsdoes not parseviewitself, so the savedDASHBOARD_PATH=/?kiosk=1&view=matrix&sound=offin the untouchedhive-hosted-matrixoverlay boots the reader as the body says. - Kiosk CTA rule exists.
kiosk_cta.test.js:33now assertsbody.reader-mode #kiosk-cta …; that rule is really atstatic-src/css/reader.css:26. - Generated page is in sync. Re-ran
go generateinpkg/dashboard/webstaticon the head;git statusis clean. - Visibility toggle preserved.
refresh.js:482-484still hides/shows#oc-matrix-tabfromstatus.matrixEnabled, and the anchor keepshiddenby default (topbar.html:28).
CI dashboard/agent/rest shards and relative links and anchors resolve are green; only tide is pending. Nothing I would hold this on.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the tree at ca73017 (not just the diff). Looks correct to me.
What I verified
static-src/js/boot.js:41is now the only place that decides the code view:HIVE_READER = kiosk && (view === 'reader' || view === 'matrix').HIVE_MATRIX,hiveMatrixStart/hiveMatrixAttach,matrix-mode,oc-reader-tab,js/matrix.jsandcss/matrix.csshave no remaining references anywhere undersrc/except the tests that assert their absence (matrix_ui_test.go:12-17,matrix_header_tab_test.go:34).sse-bootstrap.js:31keeps only the reader attach, so nothing dereferences a removed global.refresh.js:482-484still toggles#oc-matrix-tabfromstatus.matrixEnabled;topbar.html:28keeps that id, so the existing visibility path is unchanged.reader.css:26already carries thebody.reader-mode #kiosk-ctalift thatkiosk_cta.test.js:34now asserts.go run ./gen -src ../static-src -out ../static/index.html -checkinpkg/dashboard/webstaticis clean at this head, sostatic/index.htmlmatchesstatic-src/.- The only live
view=matrixconsumer isdeploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34, which the alias atboot.js:41now serves;reader_ui_test.goscenario?kiosk=1&view=matrix&sound=offcovers exactly that URL. docs/api-reference/dashboard-misc.md:59now carries the deprecation marker that #16563 asked for, so that finding is fully addressed by this diff.
One body nit (no code change needed): the header says Fixes #16563, which will close it on merge (base v5 is the default branch), while the Docs paragraph says "Refs #16563 … not closed here". The diff does fix it completely, so Fixes is the right keyword — just drop the contradictory sentence so a maintainer isn't left wondering which is intended.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
… v5 regions doc section unparkStageThatStays (v6 #14218) seeded the post-un-park label set with approved-direction unconditionally. v5 #16579 now derives needs-human beside the ack as held human work (stage None) rather than a 045 park, so for a kept lifecycle needs-human — where the ack is withheld — the helper misreported the hive's stage/045 as lifting and the reply said "still on the issue" instead of "stays". Only seed the ack when acknowledge is set. Fixes TestSweepLabelDrivenHiveApproveKeptNeedsHumanKeepsStage (test rest 3/4). Also re-add the "Published-checkpoint regions" prose section from v5 #16609 to api-reference/dashboard-misc.md, dropped by the row-only conflict resolution; fixes the broken #published-checkpoint-regions anchor (relative links and anchors resolve). Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Closes #16477
Part of #16137 (epic; this is the final child, but the epic stays open — the hive closes it once all children are done).
Supersedes #16514 (and the earlier attempt #16500). Fixes #16563.
Why
The maintainer chose option B on #16137: the published-checkpoint reader replaces the Matrix code view (pushed lines only, no workspace/pre-push capture, no broader permissions, no anonymous kiosk access, no auto-enablement), implemented in this order: reader → source → cutover. Parts 1 (#16475 / #16492) and 2 (#16476 / #16513) are merged on v5. That leaves this cutover: replace the side-by-side Matrix entry with a single Code activity entry and retire the decorative renderers. #16514 included the whole stack; this branch starts fresh from v5 and carries only the part-3 changes.
Compatibility (renames are avoided; old names become aliases):
oc-matrix-tab, so existing selectors and thestatus.matrixEnabledvisibility toggle in refresh.js keep working. It now links to?kiosk=1&view=reader(new tab,rel="noopener"). The temporaryoc-reader-tabfrom part 1 is folded into it, so the two entries no longer sit side by side.?kiosk=1&view=matrixis now a deprecated alias that boots the reader. Saved display URLs keep working instead of quietly falling back to the plain Activity Monitor./api/matrix/lines,dashboard.matrix.*andconfig/dashboard_matrix.goare unchanged and documented as deprecated names. There is no config break, and the default stays off.Deploy overlay (
src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml): left untouched on purpose. It is areplicas: 0overlay that only an owner can activate. ItsDASHBOARD_PATH=/?kiosk=1&view=matrix&sound=offnow opens Code activity through the alias above. That is the smallest change that keeps the old URL from 404ing or falling back, and it leaves no deploy decision to make here. The streaming doc and deploy README say this.Docs: dashboard.md, api-reference/dashboard-misc.md, streaming-the-activity-monitor.md and operator-reference/README.md now describe the source semantics (published PR checkpoints only) and the activation status (opt-in, default off). The
/api/matrix/linesAPI table row now carries the "(deprecated name, see Published-checkpoint regions)" marker (Refs #16563; that item belongs to its human claimant and is not closed here).Tests: matrix_header_tab_test checks the actual toolbar entry: exactly one entry, view=reader, new tab, label "Code activity". matrix_ui_test checks that the retired assets/hooks are gone and runs the shipped status handler on
#oc-matrix-tab. reader_ui_test follows the shipped toolbar href and asserts thatview=matrixactivates the reader. kiosk_cta and webstatic tests now refer to the reader.static/index.htmlwas regenerated with thego:generateconcat tool (-checkclean). The docs and API citation checkers report no drift.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@hanthor