Skip to content

πŸ› Activity Monitor: keep stage chevrons a one-line band - #16556

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-16551
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-16551

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The mobile-shots tracker-header-geometry probe is correct and unchanged: it measures every stage chevron at 44px where the one-line budget is 20.144px (1.3 Γ— 10.88px line + 2 Γ— sp-1 + 2 Γ— line-width).

Cause. 44 = 40 + 2 Γ— sp-1. On (max-width: 640px), ((pointer: coarse) and (max-width: 820px)), responsive.css turns every .config-info into a --tap-target (40px) square with min-height: 40px and a drawn ::before ring. The chevron's wrapper is .ham-chevron-info.config-info. Its tracker.css rule resets width and height but not min-height, so on phones and tablets each chevron with an info wrapper grows to 44px. The artifacts show the pattern: 768px (coarse) fails on every row, and 844px and wider pass the height check. Rows without an info wrapper also pass. The responsive rule is older than the five Activity Monitor commits. #16487's own mobile-shots run was already red, so no single commit in 9754607…afaa0df introduced this.

Fix. .ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decision now sets min-height: 0, and .ham-chevron-info.config-info::before is content: none, so the chevron no longer gets the tap-target ring. Content is unchanged: counts, verdict words and pills stay in the one-line clamp. --ham-chevron-text-lines stays 1. static/index.html is regenerated by byte-exact concatenation, and stage_tracker_activity.test.js pins both rules.

Not addressed. The row-15 "caption and icons are horizontally centred" failure also appears at 844px, where the height check passes, so it has a different cause. The copy box sits 14px right of centre, which is about the width of one 12px icon plus the gap. It may still fail after this PR.

Closes #16551

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

… wrapper no longer grows the cell)

On phones and coarse-pointer tablets responsive.css gives every .config-info
a 40px --tap-target min-height and a drawn ring. The chevron's
.ham-chevron-info.config-info wrapper reset width/height but not min-height,
so every chevron grew to 40px + 2*sp-1 = 44px instead of one 20px line.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16553 πŸ› fix: expose deferred PR fixer queue positions same files src/pkg/dashboard/static/index.html
#16492 ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) CONFLICT src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16554 πŸ› Activity Monitor: a 071/072 row with a pushed or checking head keeps its CI track lit same files src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/static/index.html
#16541 πŸ› fix: route undeliverable fixer kicks to fallback agents same files src/pkg/dashboard/static/index.html
#16513 ✨ feat(dashboard): feed published checkpoint diff regions to Code activity CONFLICT src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16500 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity CONFLICT src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer (folded here because this head already carries its hive review):

Read the fix against the tree at afaa0df β€” looks correct to me.

Why the override holds. responsive.css:347-353 gives .config-info (specificity 0,1,0) min-height: var(--tap-target) and :373 draws the ::before ring (0,1,1). The existing tracker.css:435 rule for .ham-chevron-info.config-info (0,2,0) already overrode width/height but not min-height, so the 40px floor survived β€” exactly the 44 = 40 + 2Β·sp-1 the probe measured. The new min-height: 0 and .ham-chevron-info.config-info::before { content: none } (0,2,1) out-rank both responsive rules regardless of bundle order, so this does not depend on CSS concatenation order. Every chevron wrapper does carry config-info (tracker-row-strip.js:191,342,346), so the rule reaches them all.

Verified locally: go run ./pkg/dashboard/webstatic/gen … -check exits 0 on 5ab8819 (index.html in sync); node --test stage_tracker_activity.test.js 33/33.

Open question (not a defect): mobile-shots is still red on this head. The body predicts the row-15 centring failure survives this PR; I could not read the job log through the proxy to confirm the 44px height failure itself is gone. Worth a glance at the artifact before merge.

Not a duplicate of #16554 despite conflicts-with-open-pr: that PR changes tracker-row-strip.js (CI track on 071/072 rows); the only overlap is adjacent insertions in stage_tracker_activity.test.js, which should auto-merge or need a trivial rebase.

Evidence bundle `#165565ab8819` sha256:91f9094911f770151dc1d870797ce13610367b0ee2537c43b38491ce79e2a3e4 β€” download from the dashboard or `hivectl review evidence #16556`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at v5. The mechanism in the body checks out and the fix is the minimal override; looks correct to me.

  • static-src/css/responsive.css:346-352 (inside the phone / coarse-pointer media block) gives every .config-info width/height/min-width/min-height: var(--tap-target) (40px, base.css:37), and :373-381 draws the ring on .config-info::before with position: absolute.
  • The existing chevron rule at tracker.css:435 already overrode width, height and min-width but not min-height β€” that is the one property that was still inflating the chevron. Adding min-height: 0 at specificity (0,2,0) beats the (0,1,0) responsive rule regardless of load order.
  • The wrapper is a <span class="ham-chevron-info config-info"> (tracker-row-strip.js:191,342,346) with position: static from the tracker rule, so the absolute ::before ring was positioning against some ancestor; content: none at (0,2,1) over (0,1,1) removes it cleanly. .ham-chevron-decision never has .config-info, so it needs no ::before override.
  • Ran node --test stage_tracker_activity.test.js on this head: 33/33 pass; with v5 tracker.css restored the clamped-copy test fails on the two new assertions, so the rules are pinned.
  • static/index.html:1769 carries the identical hunk.

On the conflicts-with-open-pr label: I test-merged this with #16554 (the other open PR touching stage_tracker_activity.test.js) and it merged clean, so that label likely refers to a different PR or is stale.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 10b3459 into v5 Nov 4, 2026
94 of 102 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16551 branch November 4, 2026 05:31
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026
hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
…ir children

tracker-header-geometry failed 'row 15 caption and icons are horizontally
centred in the chevron' at every viewport <= 1100px (the max-width media
block shows .ham-active-ico on each lit chevron). When that icon sits in
.ham-active-ico-wrap { display: contents } the wrapper has no client rects,
so the probe's visible() dropped the 12px icon + gap from the centring
union while the chevron was visually centred. Flatten display: contents
wrappers to the children that actually take flex space.

Shared v5 baseline failure (#16551 residual after #16556).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
…s its CI track lit (#16554)

* πŸ› Activity Monitor: a 071/072 row with a pushed or checking head keeps its CI track lit

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* πŸ› mobile-shots: geometry probe measures box-less icon wrappers by their children

tracker-header-geometry failed 'row 15 caption and icons are horizontally
centred in the chevron' at every viewport <= 1100px (the max-width media
block shows .ham-active-ico on each lit chevron). When that icon sits in
.ham-active-ico-wrap { display: contents } the wrapper has no client rects,
so the probe's visible() dropped the 12px icon + gap from the centring
union while the chevron was visually centred. Flatten display: contents
wrappers to the children that actually take flex space.

Shared v5 baseline failure (#16551 residual after #16556).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[shared-ci] mobile-shots failing across hivecommons/hive

0 participants