Repository navigation
π Activity Monitor: keep stage chevrons a one-line band - #16556
Conversation
β¦ wrapper no longer grows the cell) On phones and coarse-pointer tablets responsive.css gives every .config-info a 40px --tap-target min-height and a drawn ring. The chevron's .ham-chevron-info.config-info wrapper reset width/height but not min-height, so every chevron grew to 40px + 2*sp-1 = 44px instead of one 20px line. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Read the fix against the tree at Why the override holds. Verified locally: Open question (not a defect): Not a duplicate of #16554 despite |
There was a problem hiding this comment.
Read the tree at v5. The mechanism in the body checks out and the fix is the minimal override; looks correct to me.
static-src/css/responsive.css:346-352(inside the phone / coarse-pointer media block) gives every.config-infowidth/height/min-width/min-height: var(--tap-target)(40px,base.css:37), and:373-381draws the ring on.config-info::beforewithposition: absolute.- The existing chevron rule at
tracker.css:435already overrodewidth,heightandmin-widthbut notmin-heightβ that is the one property that was still inflating the chevron. Addingmin-height: 0at specificity (0,2,0) beats the (0,1,0) responsive rule regardless of load order. - The wrapper is a
<span class="ham-chevron-info config-info">(tracker-row-strip.js:191,342,346) withposition: staticfrom the tracker rule, so the absolute::beforering was positioning against some ancestor;content: noneat (0,2,1) over (0,1,1) removes it cleanly..ham-chevron-decisionnever has.config-info, so it needs no::beforeoverride. - Ran
node --test stage_tracker_activity.test.json this head: 33/33 pass; with v5tracker.cssrestored the clamped-copy test fails on the two new assertions, so the rules are pinned. static/index.html:1769carries the identical hunk.
On the conflicts-with-open-pr label: I test-merged this with #16554 (the other open PR touching stage_tracker_activity.test.js) and it merged clean, so that label likely refers to a different PR or is stale.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
β¦ir children
tracker-header-geometry failed 'row 15 caption and icons are horizontally
centred in the chevron' at every viewport <= 1100px (the max-width media
block shows .ham-active-ico on each lit chevron). When that icon sits in
.ham-active-ico-wrap { display: contents } the wrapper has no client rects,
so the probe's visible() dropped the 12px icon + gap from the centring
union while the chevron was visually centred. Flatten display: contents
wrappers to the children that actually take flex space.
Shared v5 baseline failure (#16551 residual after #16556).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
β¦s its CI track lit (#16554) * π Activity Monitor: a 071/072 row with a pushed or checking head keeps its CI track lit Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π mobile-shots: geometry probe measures box-less icon wrappers by their children tracker-header-geometry failed 'row 15 caption and icons are horizontally centred in the chevron' at every viewport <= 1100px (the max-width media block shows .ham-active-ico on each lit chevron). When that icon sits in .ham-active-ico-wrap { display: contents } the wrapper has no client rects, so the probe's visible() dropped the 12px icon + gap from the centring union while the chevron was visually centred. Flatten display: contents wrappers to the children that actually take flex space. Shared v5 baseline failure (#16551 residual after #16556). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The mobile-shots
tracker-header-geometryprobe is correct and unchanged: it measures every stage chevron at 44px where the one-line budget is 20.144px (1.3 Γ 10.88px line + 2 Γ sp-1 + 2 Γ line-width).Cause. 44 = 40 + 2 Γ sp-1. On
(max-width: 640px), ((pointer: coarse) and (max-width: 820px)),responsive.cssturns every.config-infointo a--tap-target(40px) square withmin-height: 40pxand a drawn::beforering. The chevron's wrapper is.ham-chevron-info.config-info. Itstracker.cssrule resetswidthandheightbut notmin-height, so on phones and tablets each chevron with an info wrapper grows to 44px. The artifacts show the pattern: 768px (coarse) fails on every row, and 844px and wider pass the height check. Rows without an info wrapper also pass. The responsive rule is older than the five Activity Monitor commits. #16487's own mobile-shots run was already red, so no single commit in 9754607β¦afaa0df introduced this.Fix.
.ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decisionnow setsmin-height: 0, and.ham-chevron-info.config-info::beforeiscontent: none, so the chevron no longer gets the tap-target ring. Content is unchanged: counts, verdict words and pills stay in the one-line clamp.--ham-chevron-text-linesstays 1.static/index.htmlis regenerated by byte-exact concatenation, andstage_tracker_activity.test.jspins both rules.Not addressed. The row-15 "caption and icons are horizontally centred" failure also appears at 844px, where the height check passes, so it has a different cause. The copy box sits 14px right of centre, which is about the width of one 12px icon plus the gap. It may still fail after this PR.
Closes #16551
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88