Skip to content

✨ feat(dashboard): replace Matrix presentation with Code activity - #16514

Closed
hivecommons-hive[bot] wants to merge 10 commits into
v5from
hive/adopt-16500
Closed

hivecommons-hive[bot] wants to merge 10 commits into
v5from
hive/adopt-16500

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Supersedes #16500 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).

Closes #16477

Stack: part 3 of 3 — stacked on #16492 (changed-paragraph reader kiosk view) and #16513 (feed published checkpoint diff regions to Code activity). This branch is rebased on v5 and includes the full #16492 and #16513 content, so it should merge after those two land (or be reviewed for the Code-activity commits only).

What this part adds

Last lane reason on the original: hive-signoff-attribution.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16598 ✨ Auto-decide reviewer scope questions on hive-authored green PRs same files src/pkg/config/config.go
#16456 ✨ feat(github): enforce pin-only exception in merge-request relay same files src/docs/operator-reference/README.md
src/pkg/config/config.go
#16600 ✨ Activity Monitor chevrons: active-with-text / icon-only spec, ring glyph, workflow-approval stall caption same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author
b62eedb

ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head b62eedb2893d) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml
  • test_removal — removes 147 test lines while adding 45 (Deletes test files or guts test coverage)
    • src/pkg/dashboard/kiosk_cta.test.js
    • src/pkg/dashboard/matrix_header_tab_test.go
    • src/pkg/dashboard/matrix_ui_test.go
    • src/pkg/dashboard/reader_ui_test.go
    • src/pkg/dashboard/webstatic/dashboard_script_test.go

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether #16514 merges as the single unit that lands the whole Code-activity stack (making #16513 and #16492 no-ops), or whether it waits for #16492 and #16513 to land and is then rebased to the cutover commit 5b94ff6 alone.

Decision needed: @clubanderson should decide whether #16514 merges as the single unit that lands the whole Code-activity stack (making #16513 and #16492 no-ops), or whether it waits for #16492 and #16513 to land and is then rebased to the cutover commit 5b94ff6db alone.

This is the hive adoption of #16500; head 11e3baa5da2d is the same commit the hive already routed to you on #16500, so I am not re-deriving the review — the findings there stand for this PR number. What I re-verified on this head:

  • Deploy manifest edit (sentinel class): src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34 sets DASHBOARD_PATH to /?kiosk=1&view=reader&sound=off. It is a query-string change only, but it is a deploy overlay and belongs to a person to sign off.
  • Still stacked on two other open PRs. The commit list (gh api pulls/16514/commits) contains 8692bfeaa (head of #16492, hive verdict changes_requested) and 0bc67d5bf/696bdccbb (the content of #16513, adopted from #16499). Comparing 45ed859 (#16513 head) to 11e3baa: this branch is ahead by exactly 70ae27071, 5b94ff6db, 11e3baa5d. So #16514 ⊇ #16513 ⊇ #16492; only one of the three should be the merge vehicle, and the body of #16500 asked for the prerequisites first.
  • Sign-off / CI: the two embedded merge commits (22a58ccfa, 8692bfeaa) carry no DCO trailer, which is why Sign-off survives the squash and native-queue-policy are red here as they were on #16500. A rebase onto v5 that drops the merge commits fixes that regardless of which sequencing you choose.

I have not closed or labelled anything.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer (folded here because this head already carries its hive review):

The code half of this cutover is consistent and I found no defect in it; I am routing it to a person because it touches a deploy manifest, and the PR it adopts (#16500) carried sentinel-alert.

Verified from the tree at b62eedb

  • Removing js/matrix.js, css/matrix.css and the HIVE_MATRIX boot path leaves no dangling references: grep over src/pkg, src/cmd, src/deploy, src/docs for hiveMatrixStart|hiveMatrixAttach|HIVE_MATRIX|matrix-mode|oc-matrix-tab|view=matrix|matrix.js|matrix.css finds only css/governor-matrix.css (an unrelated stylesheet) and the deprecation sentence in src/docs/dashboard.md:615.
  • refresh.js:482-484 still hides/shows #oc-reader-tab from data.matrixEnabled, and topbar.html:28 keeps the same href, so the status-driven entry visibility is intact; the only behavioural change there is target="_blank" rel="noopener".
  • go generate ./pkg/dashboard/webstatic/ reproduces static/index.html byte-for-byte, so the committed bundle matches static-src.
  • MatrixConfig (src/pkg/config/dashboard_matrix.go) and dashboard.matrix.* keys are unchanged apart from comments — config compatibility is preserved as the body claims.
  • Stack prerequisites ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) #16492 and ✨ feat(dashboard): feed published checkpoint diff regions to Code activity #16513 are both merged.

Why a human is needed
src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34 changes the stream overlay's DASHBOARD_PATH from view=matrix to view=reader. .github/CODEOWNERS:21 places src/deploy/** under clubanderson hanthor Danathar, and the original #16500 was labelled sentinel-alert. The edit is a single URL parameter in an overlay the body says stays at zero replicas, and it is the right value once view=matrix no longer exists — but confirming that is an owner call, not mine.

I could not run the Go test suite here; matrix_ui_test.go, matrix_header_tab_test.go and reader_ui_test.go are updated to the new toolbar shape and CI should be the arbiter on those.

If #16500 is not going to be revived, it could be closed in favour of this PR; I have not closed anything.

Review findings from adjudicator-2 (folded here because this head already carries its hive review):

Security re-review at 7ca1769 (delta from 11e3baa): no new security findings.

  • The PR-authored delta is a CSS min-height tweak (static-src/css/tracker.css:416,424), a history→retained rename in static-src/js/reader.js:46-222, and test synchronization changes (checkpoint_source_test.go:242-263, matrix_persist_test.go:28). The remaining delta files (fossa, crux proxy, heartbeat, fleetreport) are v5 merges, not PR changes.
  • Prior security note on src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34 — still present, no longer blocking: it is a view=matrix→view=reader query-string retarget on an overlay that stays replicas: 0 (line 23) and keeps the owner-only header (lines 1-4). [scanner] Cutover: Code activity supersedes and retires the Matrix code-view entry point (part 3/3 of #16137) #16477 explicitly lists "display links … updated in one cutover" as acceptance criteria, and the reader endpoint remains behind the existing RoleRead gate (src/pkg/dashboard/api_matrix.go:95-101 → api_checkpoint.go:12), so no permission broadening or anonymous kiosk access is introduced. The sentinel notice at 11e3baa already records the sensitive-path touch for audit.

hive/awaiting-ci: rebased onto the refreshed #16513 head (hive/adopt-16499) after #16492 merged — only this PR's own three commits remain on top; #16513 content shows until it merges. CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Conclusion: the cutover code looks correct to me at 277c188; the only thing I will not sign off alone is the deploy-overlay line.

Read at head 277c188 (tree, not just diff). Facts verified:

Body vs diff: matches. "The separate stream overlay points to the reader while remaining at zero replicas" is exactly kustomization.yaml:34 and nothing else under deploy/.

Open item for the maintainer only: src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34 is the single deploy change (a query-string value in a ConfigMap patch). The sentinel flagged that same path on #16500 and the label was never removed by a human before this adoption; this PR does not carry the label. I am not asserting a problem — it is a one-line URL edit consistent with #16477's "display links updated" criterion — but a deploy manifest sign-off belongs to a person, not me. Once confirmed, I have nothing else blocking.

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

🔧 docker (hub) failed on d70b63b with a transient infrastructure error — proxy.golang.org returned stream error: INTERNAL_ERROR fetching github.com/klauspost/compress@v1.20.3 during go build (log). No dependency changes in this PR; pushed an empty signed commit (7ca1769) to retrigger CI. DEFER on infra.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 7ca176958

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Needs a decision, not a merge:

Your options:

  • Re-author from scratch — Re-author in the tracker (or add the adoption/supersede label): the hive opens a fresh PR for the same issue from the current base and closes this one as superseded.
  • Hand it to a person — reply /hive decision <who or what to change> or push to the branch yourself; the hive steps back while a human owns it.
  • Close as not planned — close the PR (or Close as not planned under Decide… in the tracker) when the change is no longer wanted.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Re-authoring: the hive's fixer gave up on this PR after 6 attempts on b62eedb2893d. Closing it as superseded; the hive opens a fresh PR for #16477 from the current v5 on its next cycle. Nothing from this branch is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Cutover: Code activity supersedes and retires the Matrix code-view entry point (part 3/3 of #16137)

1 participant