Repository navigation
✨ feat(dashboard): replace Matrix presentation with Code activity - #16514
hivecommons-hive[bot] wants to merge 10 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
b62eedb
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #16514 merges as the single unit that lands the whole Code-activity stack (making #16513 and #16492 no-ops), or whether it waits for #16492 and #16513 to land and is then rebased to the cutover commit 5b94ff6 alone.
Decision needed: @clubanderson should decide whether #16514 merges as the single unit that lands the whole Code-activity stack (making #16513 and #16492 no-ops), or whether it waits for #16492 and #16513 to land and is then rebased to the cutover commit 5b94ff6db alone.
This is the hive adoption of #16500; head 11e3baa5da2d is the same commit the hive already routed to you on #16500, so I am not re-deriving the review — the findings there stand for this PR number. What I re-verified on this head:
- Deploy manifest edit (sentinel class):
src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml:34setsDASHBOARD_PATHto/?kiosk=1&view=reader&sound=off. It is a query-string change only, but it is a deploy overlay and belongs to a person to sign off. - Still stacked on two other open PRs. The commit list (
gh api pulls/16514/commits) contains8692bfeaa(head of #16492, hive verdictchanges_requested) and0bc67d5bf/696bdccbb(the content of #16513, adopted from #16499). Comparing45ed859(#16513 head) to11e3baa: this branch is ahead by exactly70ae27071,5b94ff6db,11e3baa5d. So #16514 ⊇ #16513 ⊇ #16492; only one of the three should be the merge vehicle, and the body of #16500 asked for the prerequisites first. - Sign-off / CI: the two embedded merge commits (
22a58ccfa,8692bfeaa) carry no DCO trailer, which is whySign-off survives the squashandnative-queue-policyare red here as they were on #16500. A rebase ontov5that drops the merge commits fixes that regardless of which sequencing you choose.
I have not closed or labelled anything.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from The code half of this cutover is consistent and I found no defect in it; I am routing it to a person because it touches a deploy manifest, and the PR it adopts (#16500) carried Verified from the tree at
Why a human is needed I could not run the Go test suite here; If #16500 is not going to be revived, it could be closed in favour of this PR; I have not closed anything. Review findings from Security re-review at
hive/awaiting-ci: rebased onto the refreshed #16513 head (hive/adopt-16499) after #16492 merged — only this PR's own three commits remain on top; #16513 content shows until it merges. CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Conclusion: the cutover code looks correct to me at Read at head
Body vs diff: matches. "The separate stream overlay points to the reader while remaining at zero replicas" is exactly Open item for the maintainer only: Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
|
🔧 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Needs a decision, not a merge:
Your options:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Re-authoring: the hive's fixer gave up on this PR after 6 attempts on |
Supersedes #16500 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).
Closes #16477
Stack: part 3 of 3 — stacked on #16492 (changed-paragraph reader kiosk view) and #16513 (feed published checkpoint diff regions to Code activity). This branch is rebased on
v5and includes the full #16492 and #16513 content, so it should merge after those two land (or be reviewed for the Code-activity commits only).What this part adds
c762b38✨ feat(dashboard): replace Matrix presentation with Code activity (original author's work from ✨ feat(dashboard): replace Matrix presentation with Code activity #16500,Signed-off-bypreserved)9a59dcfci: retrigger after transient proxy.golang.org failure in docker (hub)0d4c382docs(dashboard): point kiosk CTA comment at reader.css660eef0/0c8fc1f— cherry-picks of the ✨ feat(dashboard): feed published checkpoint diff regions to Code activity #16513 review fixes (545c6a4,754b688):policyMuis anRWMutexso concurrent sweep/webhook observers share the read lock instead of dropping each other, andsetConfigskips the write-lock when the policy is unchanged.Last lane reason on the original:
hive-signoff-attribution.