Skip to content

✨ activity: collapse finished CI/Review chevrons to pass/fail icons; route "Needs human" notes through the hive-note tuck - #16584

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
activity-chevron-icons-20261104
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
activity-chevron-icons-20261104

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Two Activity-page UX fixes from Andy's screenshots (chevron strip under src/pkg/dashboard/static-src/). Kept as one PR: both regenerate static/index.html and share the Go test-harness JS lifts.

Fix 1 — finished CI / Review chevrons collapse to a pass/fail icon

tracker-row-strip.js stageTrackerActivityTrackHtml: when the stage has a settled verdict (passing/approved → data-verdict="pass", failing/changes_requested → data-verdict="fail") the copy span gets ham-track-verdict and renders only the flask / eye icon; the former words (CI 11/11 passed, CI 7/11 · 2 failed · test not reported, failing check names, Review 5/5 · 1 changes requested) stay in the existing tooltip (title, aria-label, in-app .ham-chevron-tip). Colours come from the existing .ham-activity-track.done / .failing tokens — no new hex. In-progress, missing and awaiting-human (human_decision, amber) states keep their text. Only CSS added: .ham-track-verdict .ham-ico { margin-right: 0; stroke-width: 2 } — no geometry/height change (#16471 not reintroduced; tracker-header-geometry.js harness updated to accept empty words on verdict cells).

Fix 2 — "Needs human:" lines linger as static rows

Root cause: PR #16011 (95eafcd, 2026-10-31) introduced stageTrackerHumanContextHtml, which draws "Needs human / Current blocker / Next move / Claimed by / optional delegation" as <div class="cue-event ham-human-context"> with animation: none — intentionally persistent so the requirement stayed readable — bypassing the stageTrackerEventHtml tuck path hive notes use.

Middle ground implemented: tracker-motion.js gains a _stageTrackerHumanNotes map plus stageTrackerHumanNote* helpers sharing the refactored stageTrackerNoteLineHtml with hive lines; tracker-human-attention.js routes all five emitters through stageTrackerHumanContextLine. Lines open, tuck left into the ⬡ icon after the same 30 s on the shared timer, re-open on click, keep the View PR #n link (now in the tooltip + body), are keyed by row + text hash so re-renders never re-open them, and are pruned when the row leaves the payload. The item's Let hive decide ▸ / Sentinel alert controls are untouched and still carry the decision state.

Tests

  • stage_tracker_activity.test.js, stage_tracker_remediation_chevron.test.js: verdict icon/tooltip assertions.
  • New Go TestStageTrackerHumanNoteTucksLikeHiveNote (stage_tracker_note_tuck_test.go): open → tuck at 30 s → click re-opens → re-render stays tucked → View link preserved.
  • node --test src/pkg/dashboard/*.test.js: 302/302 pass. make dashboard-gen output committed. gofmt -l clean.

Changelog: changelog.d/changed-activity-chevron-verdict-icons.md, changelog.d/fixed-activity-needs-human-hive-note.md.

…route "Needs human" notes through the hive-note tuck

Fix 1: when a CI or Review stage reaches a settled verdict the chevron
renders only its icon (green pass / red fail, existing status tokens);
the words move into the tooltip and aria-label. In-progress and
awaiting-human states keep today's text. Chevron geometry unchanged.

Fix 2: PR #16011 (95eafcd) drew "Needs human" context as a static
.ham-human-context row with animation: none so the requirement stayed
readable. Middle ground: those lines now ride the shared hive-note
tuck machinery (open 30 s, slide-left into the ⬡ icon, click to
re-open, keyed by row+text so re-renders never re-open them), while
the row's Let hive decide / Sentinel alert controls keep the decision
state.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16583 ✨ Hive re-authors its own fixer-exhausted PRs; re-author pill becomes adopt same files src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html
#16585 🐛 fix(dashboard): match viewer handle on a word boundary in sign-off questions same files src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html
#16500 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html

@hivecommons-hive
hivecommons-hive Bot merged commit d42ec31 into v5 Nov 4, 2026
82 of 83 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the activity-chevron-icons-20261104 branch November 4, 2026 12:52
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#165848a69857` sha256:c5b83d324d40c9c400ce64e2299dde9f5a457f8f6aa01a7842501f939b266b09 — download from the dashboard or `hivectl review evidence #16584`.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 8a69857.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me (read at 8a69857).

  • tracker-row-strip.js:162-163 already define finished as passing|approved and finding as failing|changes_requested, both gated on matches (current head), so verdict at :198 collapses exactly the settled states and leaves pending/running/not-reported/sign-off wording intact; the count words survive in fullTip.
  • The human-requirement notes reuse the hive-note shape unchanged: stageTrackerNoteOpen / Toggled / Shift / NextDue (tracker-motion.js:220-252) only read at, openAt, tucked, which {who:'human', row, text, at} satisfies. stageTrackerHumanNotesNext prunes on notes[k].row against stageTrackerStateMap, and both are keyed by stageTrackerItemKey (tracker-merged.js:2, tracker-motion.js:77), so pruning matches. The human: key prefix keeps stageTrackerNoteEventSet from writing into the wrong map.
  • One behaviour to be aware of, not a defect: with auto-tuck off, stageTrackerHumanNoteHtml returns '' after STAGE_TRACKER_EVENT_MS, so a "Needs human: …" line disappears entirely after two minutes in that tab (the row's Let-hive-decide / Sentinel controls remain). That matches the stated intent and the old hive-line life; flagging only so it is a conscious choice.

node --test on stage_tracker_activity.test.js + stage_tracker_remediation_chevron.test.js passes (45/45); all checks green.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant