Repository navigation
✨ activity: collapse finished CI/Review chevrons to pass/fail icons; route "Needs human" notes through the hive-note tuck - #16584
Conversation
…route "Needs human" notes through the hive-note tuck Fix 1: when a CI or Review stage reaches a settled verdict the chevron renders only its icon (green pass / red fail, existing status tokens); the words move into the tooltip and aria-label. In-progress and awaiting-human states keep today's text. Chevron geometry unchanged. Fix 2: PR #16011 (95eafcd) drew "Needs human" context as a static .ham-human-context row with animation: none so the requirement stayed readable. Middle ground: those lines now ride the shared hive-note tuck machinery (open 30 s, slide-left into the ⬡ icon, click to re-open, keyed by row+text so re-renders never re-open them), while the row's Let hive decide / Sentinel alert controls keep the decision state. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 8a69857. |
There was a problem hiding this comment.
Looks correct to me (read at 8a69857).
tracker-row-strip.js:162-163already definefinishedaspassing|approvedandfindingasfailing|changes_requested, both gated onmatches(current head), soverdictat:198collapses exactly the settled states and leaves pending/running/not-reported/sign-off wording intact; the count words survive infullTip.- The human-requirement notes reuse the hive-note shape unchanged:
stageTrackerNoteOpen/Toggled/Shift/NextDue(tracker-motion.js:220-252) only readat,openAt,tucked, which{who:'human', row, text, at}satisfies.stageTrackerHumanNotesNextprunes onnotes[k].rowagainststageTrackerStateMap, and both are keyed bystageTrackerItemKey(tracker-merged.js:2,tracker-motion.js:77), so pruning matches. Thehuman:key prefix keepsstageTrackerNoteEventSetfrom writing into the wrong map. - One behaviour to be aware of, not a defect: with auto-tuck off,
stageTrackerHumanNoteHtmlreturns''afterSTAGE_TRACKER_EVENT_MS, so a "Needs human: …" line disappears entirely after two minutes in that tab (the row's Let-hive-decide / Sentinel controls remain). That matches the stated intent and the old hive-line life; flagging only so it is a conscious choice.
node --test on stage_tracker_activity.test.js + stage_tracker_remediation_chevron.test.js passes (45/45); all checks green.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Two Activity-page UX fixes from Andy's screenshots (chevron strip under
src/pkg/dashboard/static-src/). Kept as one PR: both regeneratestatic/index.htmland share the Go test-harness JS lifts.Fix 1 — finished CI / Review chevrons collapse to a pass/fail icon
tracker-row-strip.jsstageTrackerActivityTrackHtml: when the stage has a settled verdict (passing/approved→data-verdict="pass",failing/changes_requested→data-verdict="fail") the copy span getsham-track-verdictand renders only the flask / eye icon; the former words (CI 11/11 passed,CI 7/11 · 2 failed · test not reported, failing check names,Review 5/5 · 1 changes requested) stay in the existing tooltip (title,aria-label, in-app.ham-chevron-tip). Colours come from the existing.ham-activity-track.done/.failingtokens — no new hex. In-progress, missing and awaiting-human (human_decision, amber) states keep their text. Only CSS added:.ham-track-verdict .ham-ico { margin-right: 0; stroke-width: 2 }— no geometry/height change (#16471 not reintroduced;tracker-header-geometry.jsharness updated to accept empty words on verdict cells).Fix 2 — "Needs human:" lines linger as static rows
Root cause: PR #16011 (95eafcd, 2026-10-31) introduced
stageTrackerHumanContextHtml, which draws "Needs human / Current blocker / Next move / Claimed by / optional delegation" as<div class="cue-event ham-human-context">withanimation: none— intentionally persistent so the requirement stayed readable — bypassing thestageTrackerEventHtmltuck path hive notes use.Middle ground implemented:
tracker-motion.jsgains a_stageTrackerHumanNotesmap plusstageTrackerHumanNote*helpers sharing the refactoredstageTrackerNoteLineHtmlwith hive lines;tracker-human-attention.jsroutes all five emitters throughstageTrackerHumanContextLine. Lines open, tuck left into the ⬡ icon after the same 30 s on the shared timer, re-open on click, keep theView PR #nlink (now in the tooltip + body), are keyed by row + text hash so re-renders never re-open them, and are pruned when the row leaves the payload. The item's Let hive decide ▸ / Sentinel alert controls are untouched and still carry the decision state.Tests
stage_tracker_activity.test.js,stage_tracker_remediation_chevron.test.js: verdict icon/tooltip assertions.TestStageTrackerHumanNoteTucksLikeHiveNote(stage_tracker_note_tuck_test.go): open → tuck at 30 s → click re-opens → re-render stays tucked → View link preserved.node --test src/pkg/dashboard/*.test.js: 302/302 pass.make dashboard-genoutput committed.gofmt -lclean.Changelog:
changelog.d/changed-activity-chevron-verdict-icons.md,changelog.d/fixed-activity-needs-human-hive-note.md.