Repository navigation
🐛 Activity Monitor: never more than two lit chevrons; unreported CI is pending, not amber - #16545
Conversation
…s pending, not amber Rows lit three chevrons (PR in progress + "CI 7/11 · test not reported" + a decided review), and a row waiting on its contributor lit CI although nothing was running — checks not reported are simply not scheduled. - stageTrackerTrackRunning: a CI / Review track is amber only on motion evidence on the current head (check-run in_progress/queued, reviewer running/queued, or the backend active flag); never while the row waits on a person (071/072 waiting_owner, hold, needs-human). - Words without motion (missing/unknown/skipped, swarm requested, re-review pending) wear the new .pending class: current-phase text, muted field. - Both tracks running: the stage chevron is settled-current (bright words, no amber, no pulse) and its tooltip says it waits on CI and review. - Tests: every rows fixture asserts count(lit) <= 2 (prelude wrapper); cases for #16509 (one lit), #16268 waiting_owner (exactly one lit) and three-qualify (tracks win); node shapes in the remediation chevron test; existing expectations moved from active to pending where nothing runs. Fixes #16540 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Read the diff against What I verified:
Conflict to be aware of: #16542 (by One open question, not a defect: |
- CSS: .done / .failing / .pending / .decided on a CI or Review track are words in their colour (green pass, red finding, muted pending) on the muted field — only a running track (.active) is filled. A PR-in-progress row with changes requested shows exactly one filled chevron. - Go: stageTrackerCountPerspectives zeroes perspectives_done when the swarm is unassigned (requested / queued), so "Review 5/5 · swarm requested" cannot occur; total falls back to the configured set. - Tests: Go count case (#16539 shape), rows fixture (#16456 row → 1 lit), node shapes + CSS pins; lift the new helpers in the human-attention test (runtime-tests failure on this PR). Refs #16540 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Conclusion: the mechanism looks correct to me and matches the invariant in #16540; one low-severity gap worth a follow-up commit, and a heads-up that #16542 is a parallel implementation of the same fix.
Read tracker-row-strip.js at 6b8c730 against the callers. stageTrackerTrackRunning (:115-121) gating active behind running/queued or the backend active flag, and settled winning over running in the class chain at :156, correctly produce the #16509 and #16268 shapes; keeping active and adding ham-settled-current alongside (:259) preserves the .ham-seg.active.ham-sentinel / .ham-remediation-* selectors at tracker.css:294/356. Dashboard, shuffle and coverage jobs are green on this head.
One gap (low): stageTrackerWaitingOnPerson at :101-110 returns true for every 071/072 row. But tracker-row-anchor.js:29 deliberately anchors a 071/072 row at column 50 when item.push.state is pushed/checking — the contributor pushed and checks are running on that head. On such a row stageTrackerTrackRunning('ci') is now always false, so a genuinely running CI track renders pending (muted) under a lit column-50 chevron, and the words "CI running" lose their motion. That is still within the ≤2 rule (stage + one track), so the fix is one clause: exempt push.state in ['pushed','checking'] from the 071/072 branch, the way #16542 does at its :102-103. Suggestion, not a blocker.
Overlap: #16542 makes the same change for #16540 (same base, same pending / settled-current / running / waiting-on-person shape) but additionally changes stage_tracker_activity.go and relocates the active phase to chevron 30, which is what fails its dashboard tests. I've flagged that one as the candidate to close; the decision is yours as issue author.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #16540
Problem (two operator screenshots)
Invariant (JS,
tracker-row-strip.js)activeclass.stageTrackerTrackRunning(item, kind)is true only on motion evidence on the current head: CIrunning/queued, Reviewreviewing/adjudicating/assigned, or the backendactiveflag. If both run, the stage chevron isham-settled-current(bright words, no amber, no pulse; tooltip leads "Waiting on CI and review, both running"). One running → stage + that track may both be lit.missing/unknown/skippedCI, "swarm requested", "re-review pending" wear a newpendingclass: current-phase words on a muted field, never amber.stageTrackerWaitingOnPerson: 071/072,waiting_owner, hold, needs-human) → tracks are never amber, only the stage chevron.Go CI derivation already sets
Activeonly forin_progresscheck-runs; untouched (CI-counts work is in flight elsewhere).Tests
stageTrackerRowHtmlso every fixture assertscount(lit) ≤ 2per strip.stage_tracker_ui_rows_test.go: 🐛 fix: bound cluster health collection within heartbeat budget #16509 row → 1 lit; 🐛 fix(acmm): recognize install and boot E2E workflows #16268waiting_owner+ CI 7/11 unreported + review approved → exactly 1 lit; three-qualify → 2 lit, stage chevron settled-current.stage_tracker_remediation_chevron.test.js: same three shapes + queued CI while waiting on a person stays pending.stage_tracker_activity.test.js: expectations movedactive→pendingwhere nothing runs; the three-concurrent test now expects 2 pulses + settled-current.go test ./pkg/dashboard/green (full),make dashboard-gen && make dashboard-gen-check, gofmt/vet clean.Changelog:
changelog.d/fixed-two-lit-chevrons.md.Also in this PR (operator follow-ups, same issue)
A) Filled = "where the item is / what moves". A CI/Review track is filled (amber) only while running.
.done(green words),.failing(red words + glyph),.pending/.decided(muted words) sit on the muted chevron field — no red/green fills. PR #16456 row (PR in progress · changes requested, CI 11/11, Review 5/5 changes) → exactly one filled chevron (fixture). Same for needs-human/held rows.B) "Review 5/5 · swarm requested" (PR #16539):
stageTrackerCountPerspectivesnow zeroesperspectives_donewhile the swarm isunassigned(requested/queued), total falling back to the configured set →Review 0/5 · swarm requested, pending, unfilled. Go table case added.CI fix:
stage_tracker_human_attention.test.jslifts the newstageTrackerWaitingOnPerson/stageTrackerTrackRunninghelpers (runtime-tests failure).node --test src/pkg/dashboard/*.test.js301/301 locally;go test ./pkg/dashboard/green;make dashboard-gen-checkclean.