Skip to content

🐛 Activity Monitor: never more than two lit chevrons; unreported CI is pending, not amber - #16545

Merged
clubanderson merged 2 commits into
v5from
fix/two-lit-chevrons
Nov 4, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/two-lit-chevrons

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Fixes #16540

Problem (two operator screenshots)

Invariant (JS, tracker-row-strip.js)

  1. ≤ 2 lit chevrons, ever. Lit = the stage chevron's active fill (not when settled-current) or a CI/Review track in the active class.
  2. Tracks win. stageTrackerTrackRunning(item, kind) is true only on motion evidence on the current head: CI running/queued, Review reviewing/adjudicating/assigned, or the backend active flag. If both run, the stage chevron is ham-settled-current (bright words, no amber, no pulse; tooltip leads "Waiting on CI and review, both running"). One running → stage + that track may both be lit.
  3. Unreported ≠ running. missing/unknown/skipped CI, "swarm requested", "re-review pending" wear a new pending class: current-phase words on a muted field, never amber.
  4. Waiting on a person (stageTrackerWaitingOnPerson: 071/072, waiting_owner, hold, needs-human) → tracks are never amber, only the stage chevron.
  5. 🐛 dashboard: CI/Review chevrons show pass/total and perspectives done/total, lit while in progress #16494 kept: both tracks lit with words when both truly run; never icon-only.

Go CI derivation already sets Active only for in_progress check-runs; untouched (CI-counts work is in flight elsewhere).

Tests

  • Rows fixture prelude wraps stageTrackerRowHtml so every fixture asserts count(lit) ≤ 2 per strip.
  • stage_tracker_ui_rows_test.go: 🐛 fix: bound cluster health collection within heartbeat budget #16509 row → 1 lit; 🐛 fix(acmm): recognize install and boot E2E workflows #16268 waiting_owner + CI 7/11 unreported + review approved → exactly 1 lit; three-qualify → 2 lit, stage chevron settled-current.
  • stage_tracker_remediation_chevron.test.js: same three shapes + queued CI while waiting on a person stays pending.
  • stage_tracker_activity.test.js: expectations moved active → pending where nothing runs; the three-concurrent test now expects 2 pulses + settled-current.
  • go test ./pkg/dashboard/ green (full), make dashboard-gen && make dashboard-gen-check, gofmt/vet clean.

Changelog: changelog.d/fixed-two-lit-chevrons.md.

Also in this PR (operator follow-ups, same issue)

A) Filled = "where the item is / what moves". A CI/Review track is filled (amber) only while running. .done (green words), .failing (red words + glyph), .pending / .decided (muted words) sit on the muted chevron field — no red/green fills. PR #16456 row (PR in progress · changes requested, CI 11/11, Review 5/5 changes) → exactly one filled chevron (fixture). Same for needs-human/held rows.

B) "Review 5/5 · swarm requested" (PR #16539): stageTrackerCountPerspectives now zeroes perspectives_done while the swarm is unassigned (requested/queued), total falling back to the configured set → Review 0/5 · swarm requested, pending, unfilled. Go table case added.

CI fix: stage_tracker_human_attention.test.js lifts the new stageTrackerWaitingOnPerson/stageTrackerTrackRunning helpers (runtime-tests failure). node --test src/pkg/dashboard/*.test.js 301/301 locally; go test ./pkg/dashboard/ green; make dashboard-gen-check clean.

…s pending, not amber

Rows lit three chevrons (PR in progress + "CI 7/11 · test not reported" +
a decided review), and a row waiting on its contributor lit CI although
nothing was running — checks not reported are simply not scheduled.

- stageTrackerTrackRunning: a CI / Review track is amber only on motion
  evidence on the current head (check-run in_progress/queued, reviewer
  running/queued, or the backend active flag); never while the row waits
  on a person (071/072 waiting_owner, hold, needs-human).
- Words without motion (missing/unknown/skipped, swarm requested, re-review
  pending) wear the new .pending class: current-phase text, muted field.
- Both tracks running: the stage chevron is settled-current (bright words,
  no amber, no pulse) and its tooltip says it waits on CI and review.
- Tests: every rows fixture asserts count(lit) <= 2 (prelude wrapper);
  cases for #16509 (one lit), #16268 waiting_owner (exactly one lit) and
  three-qualify (tracks win); node shapes in the remediation chevron test;
  existing expectations moved from active to pending where nothing runs.

Fixes #16540

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16544 🐛 Activity Monitor: show Let hive decide beside the lead; action pills read as buttons same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16542 🐛 fix: limit Activity Monitor chevrons to observed motion CONFLICT src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/stage_tracker_advisory_test.go
src/pkg/dashboard/stage_tracker_motion_test.go
src/pkg/dashboard/stage_tracker_new_test.go
src/pkg/dashboard/stage_tracker_remediation_chevron.test.js
src/pkg/dashboard/stage_tracker_repo_grouping_test.go
src/pkg/dashboard/stage_tracker_ui_prelude_test.go
src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html
#16541 🐛 fix: route undeliverable fixer kicks to fallback agents same files src/pkg/dashboard/static/index.html
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16500 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html
#16513 ✨ feat(dashboard): feed published checkpoint diff regions to Code activity same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16492 ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16546 🐛 fix: expose deferred PR fixer queue positions same files src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • build-and-test

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the diff against 218785a plus the callers in tracker-row-strip.js and the rows prelude. This looks correct to me.

What I verified:

  • stageTrackerTrackRunning (tracker-row-strip.js:114-120) only returns true on current-head evidence (a.head === item.head) with running/queued (CI) or reviewing/adjudicating/assigned (Review) or the backend active flag, and is forced false by stageTrackerWaitingOnPerson. The class chain at line ~156 keeps done → failing → done decided ahead of active, so a red check never turns amber and the 🐛 fix: bound cluster health collection within heartbeat budget #16509 human_decision row stays done decided (covered by the existing assertion at stage_tracker_ui_rows_test.go:691).
  • item.hold / item.needs_human are the fields the file already reads at tracker-row-strip.js:92 (stageTrackerHiveOwnsRepair), and NeedsHuman is emitted at stage_tracker.go:71 — so stageTrackerWaitingOnPerson follows the existing shape rather than inventing one.
  • The ≤2 invariant is enforced on every fixture by wrapping stageTrackerRowHtml in the prelude (stage_tracker_ui_prelude_test.go:204-207), not just the three new 🐛 Activity Monitor rows light three chevrons; unreported CI checks render amber #16540 rows; the litChevrons regex excludes ham-settled-current so the "both tracks running" case counts 2. Dashboard CI is green on this head (the mobile-shots / runtime-tests / build-and-test reds also fail identically on unrelated PRs, so they look environmental).

Conflict to be aware of: #16542 (by thatguywob, gpt-6.1-sol) is a parallel implementation of #16540 on the same base and edits the same hunks with different semantics (it also relocates the active column 50 → 30 for waiting-on-person rows, which breaks stage_tracker_ui_rows_test.go:332). Only one can merge; I've recommended on #16542 that this one survive.

One open question, not a defect: stageTrackerTrackRunning doesn't consult observed_at, so a state: 'running' observation older than the freshness window (stale at line ~141) still renders the active class (without the pulse). The pre-change code was amber for any text, so this isn't a regression — just noting the title's "observed motion" is stricter than the class gate.

- CSS: .done / .failing / .pending / .decided on a CI or Review track are
  words in their colour (green pass, red finding, muted pending) on the
  muted field — only a running track (.active) is filled. A PR-in-progress
  row with changes requested shows exactly one filled chevron.
- Go: stageTrackerCountPerspectives zeroes perspectives_done when the swarm
  is unassigned (requested / queued), so "Review 5/5 · swarm requested"
  cannot occur; total falls back to the configured set.
- Tests: Go count case (#16539 shape), rows fixture (#16456 row → 1 lit),
  node shapes + CSS pins; lift the new helpers in the human-attention test
  (runtime-tests failure on this PR).

Refs #16540

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion: the mechanism looks correct to me and matches the invariant in #16540; one low-severity gap worth a follow-up commit, and a heads-up that #16542 is a parallel implementation of the same fix.

Read tracker-row-strip.js at 6b8c730 against the callers. stageTrackerTrackRunning (:115-121) gating active behind running/queued or the backend active flag, and settled winning over running in the class chain at :156, correctly produce the #16509 and #16268 shapes; keeping active and adding ham-settled-current alongside (:259) preserves the .ham-seg.active.ham-sentinel / .ham-remediation-* selectors at tracker.css:294/356. Dashboard, shuffle and coverage jobs are green on this head.

One gap (low): stageTrackerWaitingOnPerson at :101-110 returns true for every 071/072 row. But tracker-row-anchor.js:29 deliberately anchors a 071/072 row at column 50 when item.push.state is pushed/checking — the contributor pushed and checks are running on that head. On such a row stageTrackerTrackRunning('ci') is now always false, so a genuinely running CI track renders pending (muted) under a lit column-50 chevron, and the words "CI running" lose their motion. That is still within the ≤2 rule (stage + one track), so the fix is one clause: exempt push.state in ['pushed','checking'] from the 071/072 branch, the way #16542 does at its :102-103. Suggestion, not a blocker.

Overlap: #16542 makes the same change for #16540 (same base, same pending / settled-current / running / waiting-on-person shape) but additionally changes stage_tracker_activity.go and relocates the active phase to chevron 30, which is what fails its dashboard tests. I've flagged that one as the candidate to close; the decision is yours as issue author.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit afaa0df into v5 Nov 4, 2026
83 of 86 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/two-lit-chevrons branch November 4, 2026 04:40
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Activity Monitor rows light three chevrons; unreported CI checks render amber

1 participant