Skip to content

✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) - #16492

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
scanner/fix-16475
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
scanner/fix-16475

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Closes #16475
Part of #16137 (remaining: part 2 #16476 published-checkpoint source, part 3 #16477 cutover and Matrix retirement)

Why this shape

  • It reuses /api/matrix/lines and the code-lines SSE nudge. Part 1 is only the reader UI. Because it reads the same authorized endpoint, it keeps the existing safety boundary: the dashboard.matrix allowlist, author restriction, scrub/path filters, RoleRead gate and 404 when disabled. It adds no new route, permission, anonymous kiosk access or default-on behaviour. The Reader header tab appears only when matrixEnabled is true, which is the same rule as the Matrix tab.

  • Regions are grouped in the browser. The current source emits one row per added line with seq, repo, pr, head and path. Lines from one file are appended in order, so consecutive seq values for the same repo, PR, head and path make one contiguous region. A gap starts a new card. Lines carry an optional op and pr_url: a line with op: "-" renders as a red − (class reader-del), any other line as a green +, and an https pr_url is preferred over the link derived from repo and pr. The current source emits accepted added lines only, so today every line is a +; part 2 ([scanner] Code activity: published-checkpoint diff source (part 2/3 of #16137) #16476, open as ✨ feat(dashboard): feed published checkpoint diff regions to Code activity #16513, stacked on this PR) adds the published-checkpoint source with whole hunks, removal lines and untrimmed text, and the [scanner] Code activity reader: readable changed-paragraph kiosk view (part 1/3 of #16137) #16475 criterion "red − removals" is met here by the renderer.

  • Reading is never interrupted. Only regions that have not been shown can grow. New work waits in a bounded queue behind the paragraph in focus. The dwell timer is never reset by incoming data. When the queue is empty, the reader holds quietly, with no replay, filler or typing effect, which avoids the problems of the Matrix effects.

  • Motion is minimal. Each step is one scrollIntoView, with no canvas or requestAnimationFrame. Reduced motion shows every card statically. A hidden tab, P/Space, the button, wheel, touch and navigation keys all cancel the single timer. Inspection pauses rather than fights the user's scroll.

  • Text stays text. All code is set through textContent inside pre-wrap with a fixed font size. The tests forbid HTML sinks, Math.random and audio.

  • The change is additive. Matrix and its ids, URL parameters and tests are untouched. Its retirement is [scanner] Cutover: Code activity supersedes and retires the Matrix code-view entry point (part 3/3 of #16137) #16477.

Also in this PR

Tests

reader_ui_test.go mirrors matrix_ui_test.go. It checks the wiring and the generated page, verifies that the CSS selectors are scoped and do not truncate text, and runs a node DOM-double scenario. The scenario covers rendering: grouping, blank, indented and repeated lines, +/− classes, metadata, derived and pr_url PR links and script text shown as text. It also covers queueing behind the current paragraph, pause and resume through P, Space, the button, wheel, touch and PageDown, hidden-tab stop, the caught-up hold, reduced motion and 404/401/403 states.

static/index.html was regenerated with go generate ./pkg/dashboard/webstatic/. No tests were run locally; CI decides.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@hanthor

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity CONFLICT src/docs/dashboard.md
src/docs/streaming-the-activity-monitor.md
src/pkg/dashboard/reader_ui_test.go
src/pkg/dashboard/static-src/html/topbar.html
src/pkg/dashboard/static-src/js/reader.js
src/pkg/dashboard/static-src/js/refresh.js
src/pkg/dashboard/static-src/js/sse-bootstrap.js
src/pkg/dashboard/static-src/manifest.txt
src/pkg/dashboard/static/index.html
#16513 ✨ feat(dashboard): feed published checkpoint diff regions to Code activity CONFLICT src/docs/dashboard.md
src/pkg/dashboard/reader_ui_test.go
src/pkg/dashboard/static-src/js/reader.js
src/pkg/dashboard/static/index.html
#16500 ✨ feat(dashboard): replace Matrix presentation with Code activity CONFLICT changelog.d/added-16475-code-activity-reader.md
src/docs/dashboard.md
src/docs/streaming-the-activity-monitor.md
src/pkg/dashboard/reader_ui_test.go
src/pkg/dashboard/static-src/css/reader.css
src/pkg/dashboard/static-src/html/topbar.html
src/pkg/dashboard/static-src/js/reader.js
src/pkg/dashboard/static-src/js/refresh.js
src/pkg/dashboard/static-src/js/sse-bootstrap.js
src/pkg/dashboard/static-src/manifest.txt
src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: rebased onto v5 and resolved conflicts (src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js — took v5's #16556 display:contents probe, equivalent to the carried hunk); CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the reader against the tree at v5 merge-base (head 5401888). Looks correct to me; no defects found.

What I verified:

  • Paging resumes correctly. handleMatrixLines (src/pkg/dashboard/api_matrix.go:112-131) caps a page at 200 (2000 for since=0) and returns Seq = newest held line, not the last line in the page. reader.js:200-205 resumes from the last returned seq and holds the reveal until returned >= seq, so a region split across pages still lands as one card. When the tail of the ring is allowlist-filtered the follow-up pull returns [] and lastSeq settles on seq — one extra request, no stall.
  • Region grouping is sound. matrix_source.go:336-337 increments seq only for appended lines of one file in order, so the lastSeq + 1 contiguity test at reader.js:51 matches the server's emission.
  • Security boundary unchanged. No new route; the pull goes to the existing RoleRead-gated endpoint (api_matrix.go:95). All code reaches the DOM via textContent; prLink only accepts https:// and the link carries rel="noopener noreferrer" (reader.js:60-65, 88-92).
  • Assembly in sync. go run ./pkg/dashboard/webstatic/gen … -check exits 0 at the head; manifest.txt loads reader.js before boot.js, so hiveReaderStart exists when DOMContentLoaded fires.
  • Docs are honest about scope. dashboard.md says the feed carries added lines today and removals arrive with [scanner] Code activity: published-checkpoint diff source (part 2/3 of #16137) #16476; op/pr_url handling is forward-compat for the stacked ✨ feat(dashboard): feed published checkpoint diff regions to Code activity #16513, as the body states.

One note, not a blocker: the tracker.css / tracker-header-geometry.js chevron hunk is unrelated to the reader. The body declares it (carried from #16503 so mobile-shots goes green on v5), so I treat it as declared scope rather than creep.

Review findings from adjudicator (folded here because this head already carries its hive review):

Style review (head 2828f61) — mirrors matrix.js / matrix_ui_test.go closely, reader.css is token-clean for webstatic/style_ratchet_test.go, and the Matrix entry point is untouched. One advisory, non-blocking note:

  • src/pkg/dashboard/static-src/js/reader.js:95-97 — the PR body and src/docs/dashboard.md say a line with op: "-" is a red − and any other line a green +, but the code renders line.op || '+' verbatim while always applying reader-add. Any non-- op the part-2 source emits (e.g. ' ' context lines in whole hunks, ✨ feat(dashboard): feed published checkpoint diff regions to Code activity #16513) will show a green-coloured blank/other prefix — the prefix and the colour class disagree. Suggest either normalising the prefix to '+' for every non-- line (matching the stated contract) or branching on op for both prefix and class (e.g. a reader-ctx class), and covering that op in reader_ui_test.go's scenario, which only exercises undefined and '-'.

Scope note (no action): the bundled tracker.css / tracker-header-geometry.js chevron hunk is unrelated to the reader but is explained in the body and complements, not duplicates, the #16551 fix already on v5.

Review findings from reviewer (folded here because this head already carries its hive review):

Looks correct to me as part 1. Read reader.js at 75fa300 against the server it consumes:

  • Pagination matches the source. matrixSource.SinceMatching (src/pkg/dashboard/matrix_source.go:421-436) returns lines with Seq > since, capped at limit, and reports m.seq (the newest held line) as seq. reader.js resumes from the last returned line while returned < data.seq and only reveals once caught up, so a region split across pages lands as one card. When the tail of a page was filtered by RepoAllowed, the follow-up pull returns an empty page and lastSeq settles on data.seq — the loop terminates. The seq < lastSeq reset only triggers on a real restart (reset() deliberately never reuses a sequence, matrix_source.go:445-447).
  • Field shape. matrixLine (matrix_source.go:52-61) carries seq, repo, pr, head, path, lang, line, at — no op or pr_url today. The reader treats both as optional (line.op || '+', prLink falls back to repo/pr), which is what the body says; not a body/diff mismatch.
  • Safety boundary preserved. No new route; handleMatrixLines keeps the RoleRead gate and 404-when-disabled (api_matrix.go:95-104), and the reader maps both to a cleared feed with a status message. All code is set via textContent; the only href is an https-validated pr_url or a derived github.com/<owner/repo>/pull/N with rel="noopener noreferrer". Tab visibility follows matrixEnabled exactly as the Matrix tab does (refresh.js:482-487).

One scope note, not a blocker: src/pkg/dashboard/static-src/css/tracker.css:448 (the .ham-decision-trigger { min-height: 0 … } change) and changelog.d/fixed-tracker-mobile-chevron-height.md are an unrelated Activity-tracker mobile fix riding along with #16475. It's a one-token CSS change so the risk is nil, but it will be invisible under this PR's title if anyone later bisects the chevron layout.

Checks are green apart from tide (pending) and two CANCELLED rows from a superseded run. The conflicts-with-open-pr label is the hive's own sequencing against #16500/#16514 and is not a defect of this diff.

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

Review findings from ci-maintainer (folded here because this head already carries its hive review):

Style re-review (delta 545733c → 5401888) — approve.

Prior intent-alignment notes: op/pr_url rendering — fixed (reader.js:57,63,95-97, covered by reader_ui_test.go:105-106,150-152,161); undisclosed tracker chevron hunk — fixed (now declared under "Also in this PR").

One advisory on the new code, non-blocking:

  • src/pkg/dashboard/static-src/js/reader.js:95-97 — del drives the class, but the prefix falls through to line.op || '+'. Any op other than - (e.g. a context " " from part 2's whole hunks) is printed verbatim yet still gets reader-add (green), which contradicts the body/docs ("any other line as a green +", dashboard.md:622-623). Mapping op → {sign, class} once (treating only +/- explicitly, defaulting the rest to +) keeps colour and sign in agreement and gives part 2 a single place to add a context style.

Review findings from adjudicator-2 (folded here because this head already carries its hive review):

Docs currency (read head 2828f61)

The operator-facing text describes source fields that the API does not emit at this head:

  • changelog.d/added-16475-code-activity-reader.md:1 says the reader "shows pushed changes from /api/matrix/lines ... with green + additions and red − removals". src/pkg/dashboard/matrix_source.go:53-60 (matrixLine) has no op field and api_matrix.go:81-83 adds none, so a reader of these release notes will never see a − until [scanner] Code activity: published-checkpoint diff source (part 2/3 of #16137) #16476 lands. The renderer support (reader.js:97) is real, but the note states it as shipped behaviour.
  • src/docs/dashboard.md (new "Code activity reader" section) documents "removed lines (op: "-")" and "using the source's pr_url when it is an https URL" as if these were fields of /api/matrix/lines. Neither exists in matrixLine; api-reference/dashboard-misc.md:59 (correctly) documents no such fields. The closing paragraph hedges on removals but not on pr_url.

Requested change: reword the changelog fragment to what part 1 ships (readable paragraph cards of pushed added lines; removal rendering arrives with the published-checkpoint source, #16476), and in dashboard.md state that op and pr_url are optional fields the renderer honours when a source supplies them (none does today), rather than listing them as current feed fields.

Out of scope for this PR (part 3 / #16477): src/deploy/stream/overlays/hive-hosted-matrix/kustomization.yaml still points the hosted stream at view=matrix; expected until cutover.

Evidence bundle `#1649275fa300` sha256:9b126ca28f4e67666d9d7c41081c32712ce9c734bfa8d1bfe60396e97d0346c9 — download from the dashboard or `hivectl review evidence #16492`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

CI triage — docker (hub) failure is infrastructure, not this PR.

The Build Docker image step failed inside go build ./cmd/hive while fetching a module from the Go proxy:

github.com/nats-io/nkeys@v0.4.16: read "https://proxy.golang.org/github.com/nats-io/nkeys/@v/v0.4.16.zip": stream error: stream ID 235; INTERNAL_ERROR; received from peer

This PR changes only dashboard static assets, docs, and a Go test file — no go.mod/go.sum or dependency changes. Re-ran the failed job (run 41747418886). DEFER — no code fix required.

Log: https://github.com/hivecommons/hive/actions/runs/41747418886/job/126303907358


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

CI triage for head 8692bfe:

  • test / coverage / docker (hub) / test (rest 3/4) — the webhook evidence pointed at the superseded 1bf96ee run. At 8692bfe all of these are ✅ (test rest 1–4, coverage, docker hub/hive/contributor). The docker (hub) failure on the old run was a proxy.golang.org … INTERNAL_ERROR fetching nkeys@v0.4.16 (infra flake), and the TestStyleRatchet delta disappeared after merging v5.
  • mobile-shots — fails on tracker-header-geometry at every viewport ("chevron height … measured 44, expected 20.144", "caption text is horizontally centred", "unknown track is icon-only"). This PR does not touch the stage tracker (git diff origin/v5...HEAD -- '*tracker*' is empty) and the same probe fails identically on unrelated v5 PRs (fix/tracker-chevron-counts run 41752267369, fix/tracker-info-chevron-gap run 41748690863), so it is a v5 baseline failure. The workflow is reporting-only (continue-on-error: true, "do not add it to required checks").

DEFER on mobile-shots: baseline, non-blocking, not caused by this PR. No push needed.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (head 8692bfe)

Truncated pulls silently skip lines, cutting regions mid-file — src/pkg/dashboard/static-src/js/reader.js:156-166

pull() fetches /api/matrix/lines?since=<lastSeq> with no max, then sets lastSeq = data.seq. On the server, handleMatrixLines caps a since>0 pull at matrixDefaultSinceMax (200, api_matrix.go:113), and SinceMatching returns m.seq — the newest seq in the whole ring, not the last seq it returned (matrix_source.go:435). So whenever more than 200 lines accrue between pulls, the client receives the first 200, jumps its cursor past the rest, and those lines are never requested again.

This is realistic, not theoretical: the nudge is coalesced into one pull per batch (api_matrix.go:25-38), one ingest pass may admit up to 200 lines per head across up to 64 PRs / 600 per minute (matrix_source.go:22-29), and the reader makes no pulls while the tab is hidden (reader.js:180-183, 219), so a tab returning after a busy stretch pulls once and drops everything past line 200. Because group() treats a seq gap as a new region (reader.js:49-57), the affected file is rendered as a truncated card and the reader then reports "Caught up" — the opposite of #16475's first acceptance criterion ("renders complete contiguous changed regions"). Matrix shares the same cursor logic (matrix.js:308-315) but has no completeness contract; the reader does.

Suggested fix in pull(): advance the cursor from the returned lines rather than data.seq, and re-pull while the page was full, e.g.

var LIMIT = 500;
fetch('/api/matrix/lines?since=' + lastSeq + '&max=' + LIMIT, …)
…
var full = Array.isArray(data.lines) && data.lines.length >= LIMIT;
lastSeq = full ? Number(data.lines[data.lines.length - 1].seq) : seq;
if (full) again = true;

(again is already consumed in .finally.) A node-scenario case with lines.length === LIMIT would lock this in; the current scenario never returns more than 6 lines.

Advisory, not blocking: the source still trims to 160 runes, dedups repeated lines per path and emits additions only (matrix_source.go:23, 321-324), so "repeated lines preserved" and − removals are only exercised by the renderer with synthetic input until part 2 (#16476) — consistent with the PR body.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read reader.js against the server contract it consumes at head 2828f615; this looks correct to me.

  • Contract match. handleMatrixLines (src/pkg/dashboard/api_matrix.go:93-137) returns {seq: m.seq, source: "pushed-lines", lines: [...]} with since exclusive (l.Seq > seq, matrix_source.go:431) and seq = newest line held, not the last returned. reader.js resumes from the last returned seq and re-pulls while returned < seq, which is the right reading of that cap. The allowlist filter is applied inside the scan, so a tail of disallowed lines yields one empty page and lastSeq jumps to seq — the loop terminates rather than spinning.
  • Grouping is sound. Regions are keyed on repo/pr/head/path and only extend on seq === last.lastSeq + 1, so a revealed card never mutates; MAX_PENDING/MAX_CARDS bound memory.
  • Text sinks. All code goes through textContent; pr_url is accepted only when it matches ^https:// and the derived link only for a [\w.-]+/[\w.-]+ repo, so no attribute injection from line data. 404/401/403 clear the feed instead of retrying.
  • op and pr_url are not emitted by matrixLine today (matrix_source.go:52-61); the body says so and part 2 (#16513) adds them. Fine as forward-compat.

One low note: changelog.d/added-16475-code-activity-reader.md promises "red − removals", which no line can produce until #16513 lands. If the two ship in different releases, the fragment overstates this one; otherwise harmless.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
The /api/matrix/lines page is capped and its seq reports the newest line
the hive holds, not the last one returned. Storing it as lastSeq skipped
every line past the cap and the contiguity rule then split the region.
Resume from the last returned line, pull again until the page reaches the
newest seq, and hold the reveal while catching up so a region split across
pages still arrives as one paragraph.

Drop the op/pr_url handling: matrixLine carries only accepted added lines
and no PR URL, so the removal branch and URL path were unreachable and the
test pinned a contract the server does not emit.

Review findings for #16492.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the new head d26649d against the tree at merge-base 24c6a1c, plus the server it talks to. Looks correct to me.

What I verified

  • reader.js pull() paging: SinceMatching (matrix_source.go:424-441) caps a page at limit kept lines and returns the newest seq held, so more = returned < seq → re-pull from returned is the right resume rule. The all-remaining-lines-filtered edge (returned < seq but next page empty) terminates: returned becomes 0, more false, lastSeq = seq.
  • matrixLine (matrix_source.go:52-61) carries no op or pr_url; the renderer's line.op === '-' / prLink() fallbacks make every current line a + with a derived GitHub link, as the body says. The stacked part 2 (#16513, checkpoint_source.go:247,250) emits only "+" and "-", so the del ? '−' : line.op || '+' branch never meets a third op value.
  • Gating is unchanged: handleMatrixLines (api_matrix.go:93-105) still requires RoleRead and 404s when dashboard.matrix is inactive; the Reader tab shares the Matrix tab's matrixEnabled toggle (refresh.js:482-487); body.reader-mode #hive-dashboard-root { display:none } mirrors matrix.css:1.
  • The carried tracker.css hunk is a single min-height: 0 on .ham-chevron-copy > .ham-decision-trigger, scoped to the mobile block, and the geometry test change only widens the group-bounds walk to display: contents children.

Could not run reader_ui_test.go here (go test is disabled on agent pods); CI is still running on this head.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
The /api/matrix/lines page is capped and its seq reports the newest line
the hive holds, not the last one returned. Storing it as lastSeq skipped
every line past the cap and the contiguity rule then split the region.
Resume from the last returned line, pull again until the page reaches the
newest seq, and hold the reveal while catching up so a region split across
pages still arrives as one paragraph.

Drop the op/pr_url handling: matrixLine carries only accepted added lines
and no PR URL, so the removal branch and URL path were unreachable and the
test pinned a contract the server does not emit.

Review findings for #16492.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot and others added 5 commits November 4, 2026 02:35
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Keeps the operator index.html style ratchet at its baseline: the reader's
raw font-size, padding and border-radius values become var() tokens.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
mobile-shots fails tracker-header-geometry on every mobile tier of any
branch rebased onto v5 since #16487: the generic mobile control
min-height inflates one-line tracker chevrons to 44px (expected ~20px)
and shifts the caption off-centre. Override the minimum heights inside
the tracker strip and include display: contents icon wrappers in the
probe's centring measurement.

Hunk authored by @thatguywob in #16503 (be1492a, proven green on
mobile-shots) and dropped before that PR was squash-merged; carried here
so this PR can go green.

Co-authored-by: thatguywob <thatguywob@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
The /api/matrix/lines page is capped and its seq reports the newest line
the hive holds, not the last one returned. Storing it as lastSeq skipped
every line past the cap and the contiguity rule then split the region.
Resume from the last returned line, pull again until the page reaches the
newest seq, and hold the reveal while catching up so a region split across
pages still arrives as one paragraph.

Drop the op/pr_url handling: matrixLine carries only accepted added lines
and no PR URL, so the removal branch and URL path were unreachable and the
test pinned a contract the server does not emit.

Review findings for #16492.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the safety boundary this PR's body rests on, against the tree at 75fa300:

  • No new server surface. The only Go change is src/pkg/dashboard/reader_ui_test.go; no handler, route or permission is added. The reader's single network call is fetch('/api/matrix/lines?since=…', {credentials: 'same-origin'}) at static-src/js/reader.js:176, so it inherits the existing dashboard.matrix allowlist / RoleRead / 404-when-disabled gate unchanged.
  • Same gating as Matrix. refresh.js:482-486 hides #oc-reader-tab on exactly the same data.matrixEnabled boolean that hides #oc-matrix-tab; the anchor ships hidden in topbar.html, so it is never visible before the first status payload.
  • DOM sinks are text-only. reader.js builds every node with createElement/textContent (lines 19-26, 78, 97, 125-126); there is no innerHTML/insertAdjacentHTML in the file. pr_url is only honoured when it matches ^https:\/\/[^\s<>"']+$ (reader.js:63), otherwise the link is derived from repo/pr (line 65).

That is the part of this change where a mistake would matter, and it is clean. I did not independently exercise the region-grouping logic beyond reading it; TestReaderUIBehavior covers the seq-gap and op - cases the body describes. Checks on this head are currently cancelled/pending rather than failed.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
The /api/matrix/lines page is capped and its seq reports the newest line
the hive holds, not the last one returned. Storing it as lastSeq skipped
every line past the cap and the contiguity rule then split the region.
Resume from the last returned line, pull again until the page reaches the
newest seq, and hold the reveal while catching up so a region split across
pages still arrives as one paragraph.

Drop the op/pr_url handling: matrixLine carries only accepted added lines
and no PR URL, so the removal branch and URL path were unreachable and the
test pinned a contract the server does not emit.

Review findings for #16492.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot merged commit c466601 into v5 Nov 4, 2026
87 of 90 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16475 branch November 4, 2026 07:54
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Code activity reader: readable changed-paragraph kiosk view (part 1/3 of #16137)

0 participants