Repository navigation
✨ feat(dashboard): feed published checkpoint diff regions to Code activity - #16499
thatguywob wants to merge 7 commits into
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Keeps the operator index.html style ratchet at its baseline: the reader's raw font-size, padding and border-radius values become var() tokens. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Hive-Run: hivecommons#16476 Hive-Plan: reader-source-cutover Hive-Spec: code-activity#published-checkpoints Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Reuse the authorized sentinel observer for complete add/remove regions with whole-region filtering, bounds, continuation and policy epochs. Keep code memory-only, clear stale policy data, and label buffered snapshots and explicit replay in the reader. Hive-Run: hivecommons#16476 Hive-Plan: reader-source-cutover Hive-Spec: code-activity#published-checkpoints Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
45ed859
|
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
There was a problem hiding this comment.
Decision needed: @hanthor should decide whether to clear the sentinel-alert label on #16499 (the flagged file is a scrubber negative-fixture list, not executable content) and whether this PR should wait for #16492 to merge and then rebase to the part-2 delta only.
Routing to a maintainer rather than judging this alone: the PR carries sentinel-alert, and it also currently fails CI for reasons that are its own.
Sentinel hit — what the flagged file actually contains. src/pkg/dashboard/checkpoint_source_test.go (new) holds a bad := []string{…} list of negative fixtures for the region scrubber: a bare -----BEGIN PRIVATE KEY----- header with no key body, a password: …/token = … placeholder, a control byte, an invalid UTF-8 byte and an over-long line. Nothing is fetched, decoded or executed. Some header literals later in the same file reached me masked by a scrubber, so I could not read them; a human should glance at the raw file. Decision is @hanthor's (approver) — I have not touched the label.
Not a duplicate of #16492. 16499 contains 16492 byte-for-byte in 9 of its 13 files (same changelog.d/added-16475-code-activity-reader.md, reader.css, boot.js, refresh.js, sse-bootstrap.js, manifest.txt, faq.html, topbar.html, streaming-the-activity-monitor.md) and extends reader.js, reader_ui_test.go, dashboard.md and index.html. The body says so ("Depends on #16492… includes that reader prerequisite"). So they conflict in the merge-queue sense: landing this one makes #16492 a no-op, landing #16492 first forces a rebase here. Sequencing is a maintainer call; the body itself asks for 16492 first.
CI failures caused by this diff (head 45ed859, job test (dashboard 4/4) and test (rest 2/4)):
TestCheckpointAPIAuthColdAndEpoch— the PR's own new test panics (checkpoint_source_test.go:226via:237, outer frame:260). It fails on first run, so it was never green.TestDashboardHistoryPushSitesAreCapped—index.html:7520(reader.jsgroup()):history.push(item); pending.push(item);is followed by a lines/bytes eviction loop rather thancapHistory(history)or.slice(-N), which is what the repository ratchet requires textually. Semantically bounded, but the guard will stay red until the push site uses the sanctioned form.TestSleepRatchet— two newtime.Sleep(time.Millisecond)calls in test code (diff lines 864, 1062) push the count to 197 over the 195 baseline; the repo convention is to wait on channels/timeouts in tests.
Body claim worth a maintainer's eye: "bounds browser history" is implemented by the eviction loop above, which is fine, but "Tests were not run locally" plus a failing self-authored test suggests the Go side was not exercised. I have not reviewed the source-integration logic in checkpoint_source.go / api_checkpoint.go in depth; with the test red there is no point until it passes.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Closes #16476
Feeds the Code activity reader complete published PR diff regions through the existing authorized sentinel patch observer. Additions and removals retain indentation, blank lines and repeats; unsafe text on either side drops the whole region. No new poller, workspace capture, permission expansion or automatic enablement.
Depends on #16492 (part 1). This branch starts from upstream/v5 and includes that reader prerequisite so the source integration is reviewable end to end. Merge the reader first; part 3 (#16477) still owns navigation cutover and Matrix retirement.
format=regions, including continuationseq,latest, policyepoch, source stage, actual PR links and ingest freshness.no-storeeven on auth failures, and retains only sequence hints on SSE. Deletion-only checkpoints also nudge the reader.Validation:
gofmt -lon changed Go files produced no output;git diff --checkpassed. Added regression coverage for region data and boundaries, secrets on additions/removals, incomplete diffs, continuation, rate and eviction limits, policy transitions and stale queues, cold source/auth behavior, memory-only history, reader paging, replay and browser bounds. Tests were not run locally because AGENTS.md reserves execution for CI.— hive: backend=codex model=gpt-6.1-sol effort=medium
🐝 Hive Agent:
contributor| SHA:0bc67d5bf