Skip to content

πŸ› Activity Monitor: a 071/072 row with a pushed or checking head keeps its CI track lit - #16554

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-16552
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
scanner/fix-16552

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

#16545's stageTrackerWaitingOnPerson treats every 071/072 row as waiting on a person, muting CI/Review even though tracker-row-anchor.js already treats push.state pushed/checking heads as in motion (anchored at column 50). The predicate now exempts 071/072 rows with those push states, using the same item.push.state access. static/index.html is regenerated from static-src.

Test: a new fixture in stage_tracker_activity.test.js asserts a 071/072 row with push.state pushed/checking and a running check renders the CI track active, while one with no push in flight stays non-active.

Closes #16552

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…s its CI track lit

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity CONFLICT src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js
#16492 ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) CONFLICT src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js
#16500 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html
#16553 πŸ› fix: expose deferred PR fixer queue positions CONFLICT src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js
#16513 ✨ feat(dashboard): feed published checkpoint diff regions to Code activity CONFLICT src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer (folded here because this head already carries its hive review):

Read the change against the tree at afaa0df β€” looks correct to me.

Verified. The new exemption in stageTrackerWaitingOnPerson (tracker-row-strip.js:105) uses the same item.push && ['pushed','checking'].includes(item.push.state) test that tracker-row-anchor.js:29 already uses to anchor the row at column 50, so the predicate and the anchor now agree on what "in motion" means. The backend does emit those states (stage_tracker_push.go:30,32, serialised as push at stage_tracker.go:589). stageTrackerTrackRunning still requires a.head === item.head and a running/queued check, so the exemption alone never lights a track. Rows with a hold or needs_human are still caught by the line above.

Locally: gen -check exits 0 on 4459a89 (index.html in sync); node --test stage_tracker_activity.test.js 34/34.

Info, not a defect: the anchor at tracker-row-anchor.js:28 additionally requires !item.code_activity && !item.merge_gate && !item.merge_train before honouring the push state; the new predicate does not. In practice the next line (waiting_owner on the current head) covers the code-activity case, so I don't see a visible divergence β€” noting it only so the two stay in sync if either grows.

Not a duplicate of #16556 (which carries conflicts-with-open-pr): that PR is CSS-only (chevron min-height). The overlap is two adjacent insertions in stage_tracker_activity.test.js; whichever lands second may need a trivial rebase.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

The #16552 fix looks correct to me; one sequencing note on the second commit.

Predicate (static-src/js/tracker-row-strip.js:107, mirrored in static/index.html:17920). The new exemption is byte-for-byte the anchor rule at tracker-row-anchor.js:29 (item.push && ['pushed','checking'].includes(item.push.state)), so the strip and the column-50 anchor now agree on what "contributor already pushed, checks running" means. The state strings match stage_tracker_push.go:30-32. The needs_human / on_hold / hold short-circuit above it is untouched, so a held 071/072 row with a pushed head still mutes β€” that is the right precedence. Ran node --test stage_tracker_activity.test.js at 7c360fa: the new #16552 case passes, and its "no push in flight stays settled" branch guards the regression direction.

Commit b4cd0ca (webstatic/testdata/tracker-header-geometry.js:274-279). This is the shared-v5 mobile-shots baseline repair (#16551), not part of #16552. The logic is sound β€” .ham-active-ico-wrap { display: contents } (tracker.css:417) has no client rects so visible() at line 10 drops it, and flattening to children fixes the centring union. But the overlap table above shows the same file conflicting with #16553, #16513, #16492 and #16514, i.e. the identical hunk is being carried in several open PRs; whichever merges first will make the rest conflict. Suggestion for the hive: land the geometry repair once on v5 via #16551 and rebase this PR to only the #16552 hunks. Not a defect, purely sequencing.

Changelog fragment and index.html regeneration are in place.

Evidence bundle `#165547c360fa` sha256:20dc2d7d43123fae36e5fb50bcd1b6d75f2dadc3d0e62d6529f6363aa6ebcd9a β€” download from the dashboard or `hivectl review evidence #16554`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at v5, not just the diff. Looks correct to me.

  • stageTrackerWaitingOnPerson (static-src/js/tracker-row-strip.js:101-108) has exactly one caller, stageTrackerTrackRunning at :118, so the exemption only affects whether a CI/Review track may light β€” nothing else keys off the 071/072 short-circuit.
  • The new predicate mirrors tracker-row-anchor.js:29 verbatim (item.push && ['pushed','checking'].includes(item.push.state)), so a row that anchors at column 50 as "in motion" is now also allowed to light its track. Same evidence, same read.
  • Head-pinning is preserved: stageTrackerTrackRunning still requires a.head === item.head before consulting the predicate, so a stale push record cannot light a track for CI that ran on a different head.
  • Ran node --test stage_tracker_activity.test.js on this head: 34/34 pass. Restored v5 tracker-row-strip.js under the new test: the #16552 test fails and only that one β€” the test pins the behaviour.
  • static/index.html:17910 carries the identical hunk to static-src.

Merges cleanly with #16556 locally (both touch the same test file at adjacent hunks, no conflict).

Minor, not blocking: tracker-words.js:257 already defines stageTrackerPushedBack(item) with this exact meaning ("the row is the hive's again: pushed/checking"); reusing it would keep the pushed/checking list in one place. Fine to leave as-is since it matches the anchor literally.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026
…ir children

tracker-header-geometry failed 'row 15 caption and icons are horizontally
centred in the chevron' at every viewport <= 1100px (the max-width media
block shows .ham-active-ico on each lit chevron). When that icon sits in
.ham-active-ico-wrap { display: contents } the wrapper has no client rects,
so the probe's visible() dropped the 12px icon + gap from the centring
union while the chevron was visually centred. Flatten display: contents
wrappers to the children that actually take flex space.

Shared v5 baseline failure (#16551 residual after #16556).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

Read the tree at 7c360fa. The new condition in stageTrackerWaitingOnPerson (static-src/js/tracker-row-strip.js:106) uses the identical item.push && ['pushed','checking'].includes(item.push.state) test that tracker-row-anchor.js:29 already uses to anchor those rows at column 50, so the strip and the anchor now agree. The track still only lights on real evidence: stageTrackerTrackRunning (tracker-row-strip.js:116-121) first requires a.head === item.head and a running/queued state, so a pushed head whose checks have not reported stays settled β€” consistent with #16540's rule. static/index.html:17918 carries the same regenerated line. Ran stage_tracker_activity.test.js at the head; the new #16552 case passes for both stages and both push states, and the no-push control stays non-active.

One note for the maintainer, not a defect: the PR body describes only the predicate change, but the second commit (b4cd0ca) also changes webstatic/testdata/tracker-header-geometry.js:274-279 so the centring probe flattens display: contents wrappers (.ham-active-ico-wrap, tracker.css:417) to their children. Its commit message explains it as a shared v5 baseline failure (#16551 residual); the recursion is sound and scoped to the copy.parentElement === info branch. Mentioning it so nobody is surprised that a strip-predicate PR touches the geometry probe.

Nothing blocking from my side. The conflicts-with-open-pr label is against #16514 on the webstatic probe files, not this predicate.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit d6c434f into v5 Nov 4, 2026
83 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-16552 branch November 4, 2026 07:03
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Activity Monitor: 071/072 rows with a pushed/checking head still mute a running CI track

0 participants