Repository navigation
π Activity Monitor: a 071/072 row with a pushed or checking head keeps its CI track lit - #16554
Conversation
β¦s its CI track lit Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Read the change against the tree at Verified. The new exemption in Locally: Info, not a defect: the anchor at Not a duplicate of #16556 (which carries Review findings from The #16552 fix looks correct to me; one sequencing note on the second commit. Predicate ( Commit Changelog fragment and index.html regeneration are in place. Evidence bundle `#165547c360fa` sha256:20dc2d7d43123fae36e5fb50bcd1b6d75f2dadc3d0e62d6529f6363aa6ebcd9a β download from the dashboard or `hivectl review evidence #16554`. |
There was a problem hiding this comment.
Read the tree at v5, not just the diff. Looks correct to me.
stageTrackerWaitingOnPerson(static-src/js/tracker-row-strip.js:101-108) has exactly one caller,stageTrackerTrackRunningat:118, so the exemption only affects whether a CI/Review track may light β nothing else keys off the 071/072 short-circuit.- The new predicate mirrors
tracker-row-anchor.js:29verbatim (item.push && ['pushed','checking'].includes(item.push.state)), so a row that anchors at column 50 as "in motion" is now also allowed to light its track. Same evidence, same read. - Head-pinning is preserved:
stageTrackerTrackRunningstill requiresa.head === item.headbefore consulting the predicate, so a stale push record cannot light a track for CI that ran on a different head. - Ran
node --test stage_tracker_activity.test.json this head: 34/34 pass. Restored v5tracker-row-strip.jsunder the new test: the#16552test fails and only that one β the test pins the behaviour. static/index.html:17910carries the identical hunk tostatic-src.
Merges cleanly with #16556 locally (both touch the same test file at adjacent hunks, no conflict).
Minor, not blocking: tracker-words.js:257 already defines stageTrackerPushedBack(item) with this exact meaning ("the row is the hive's again: pushed/checking"); reusing it would keep the pushed/checking list in one place. Fine to leave as-is since it matches the anchor literally.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦ir children
tracker-header-geometry failed 'row 15 caption and icons are horizontally
centred in the chevron' at every viewport <= 1100px (the max-width media
block shows .ham-active-ico on each lit chevron). When that icon sits in
.ham-active-ico-wrap { display: contents } the wrapper has no client rects,
so the probe's visible() dropped the 12px icon + gap from the centring
union while the chevron was visually centred. Flatten display: contents
wrappers to the children that actually take flex space.
Shared v5 baseline failure (#16551 residual after #16556).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Looks correct to me.
Read the tree at 7c360fa. The new condition in stageTrackerWaitingOnPerson (static-src/js/tracker-row-strip.js:106) uses the identical item.push && ['pushed','checking'].includes(item.push.state) test that tracker-row-anchor.js:29 already uses to anchor those rows at column 50, so the strip and the anchor now agree. The track still only lights on real evidence: stageTrackerTrackRunning (tracker-row-strip.js:116-121) first requires a.head === item.head and a running/queued state, so a pushed head whose checks have not reported stays settled β consistent with #16540's rule. static/index.html:17918 carries the same regenerated line. Ran stage_tracker_activity.test.js at the head; the new #16552 case passes for both stages and both push states, and the no-push control stays non-active.
One note for the maintainer, not a defect: the PR body describes only the predicate change, but the second commit (b4cd0ca) also changes webstatic/testdata/tracker-header-geometry.js:274-279 so the centring probe flattens display: contents wrappers (.ham-active-ico-wrap, tracker.css:417) to their children. Its commit message explains it as a shared v5 baseline failure (#16551 residual); the recursion is sound and scoped to the copy.parentElement === info branch. Mentioning it so nobody is surprised that a strip-predicate PR touches the geometry probe.
Nothing blocking from my side. The conflicts-with-open-pr label is against #16514 on the webstatic probe files, not this predicate.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
#16545's
stageTrackerWaitingOnPersontreats every 071/072 row as waiting on a person, muting CI/Review even thoughtracker-row-anchor.jsalready treatspush.statepushed/checkingheads as in motion (anchored at column 50). The predicate now exempts 071/072 rows with those push states, using the sameitem.push.stateaccess.static/index.htmlis regenerated fromstatic-src.Test: a new fixture in
stage_tracker_activity.test.jsasserts a 071/072 row withpush.statepushed/checking and a running check renders the CI trackactive, while one with no push in flight stays non-active.Closes #16552
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88