Skip to content

🐛 fix(dashboard): evidence-based remediation state on the PR in progress chevron - #16527

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
fix/remediating-chevron
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
fix/remediating-chevron

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16525

Problem

Six 070 PRs with Review 5/5 · changes requested showed an empty PR in progress chevron. waiting_fixer lit the CI / Review column, and the persistent recorded-push marker overrode the code activity with "New head pushed · CI and re-review" even when the changes-requested review landed after that push — the pushed head was the reviewed head, not a fix. The payload said nothing about whether anybody had picked the PR up.

Change

New stage_tracker_remediation.go, applied after stageTrackerApplyCodeActivity on every PR row:

  • stageTrackerRedSince — when the current head's latest red signal began (review changes requested / CI failing; a 07x row with no verdict on its head is red since it entered the stage).
  • stageTrackerRemediationEvidence — the one place pickup evidence is read, one helper per source, most recent wins:
    • kick: dispatch.Fixes for this head within TTL (fix-dispatch); a working hive agent whose current non-review action is on the PR since the red signal (agent-now); a hive-agent claim-ledger / kick-history claim since then.
    • claim: contributor relay holds the fix task (rework.in_progress); a clanker claim-ledger / claim-comment claim since the signal.
    • push: recorded push newer than the red signal (recorded-push); 072 author head after the ask (rework-commit).
    • comment: reserved — the tracker has no per-comment attribution; a bare updated_at bump is not evidence.
  • New code_activity states and chevron words:
    • unassigned → Changes requested · unassigned · next: scanner / CI failing · unassigned · next: @alice / … · fixer queued, 3 ahead · next: @bob's clanker — DisplayColumn 030, bright, still; tooltip: what triggers pickup.
    • remediating → Remediating · scanner · 4m (· waiting for CI when the agent is holding for CI) — DisplayColumn 030, pulsing; tooltip: evidence kind, source, since.
    • fix_pushed → Fix pushed f269349 · re-review pending / · CI pending — CI / Review stays current, the 030 step renders done-style with its word.
    • 071/072 person-owned: Waiting for @erin · changes requested (unchanged placement).
    • Observed code work (fixing), same-head CI retry and a 07x push with no verdict yet keep their native words.
  • Item field remediation: {actor, kind, since, source, head} (omitempty).
  • JS (tracker-row-strip.js): data-remediation on the 030 cell, pulse only for remediating, done-style ham-fix-pushed cell with caption, code.detail + evidence in the tooltip. CSS for the two new looks.

Tests

  • Go: TestStageTrackerRemediation* — unassigned (no evidence), CI-only word + person next, kick from fix dispatch (+ TTL expiry), kick from working agent (review action and pre-signal action rejected), claim (relay, claim comment, stale claim rejected, queued → waiting word), push (recorded push → CI pending/re-review pending, 072 rework push), owner wait / observed work / green PR untouched.
  • Node: stage_tracker_remediation_chevron.test.js — the three chevron shapes (unassigned / remediating / fix pushed) + stale head.
  • go test ./pkg/dashboard/ green locally; make dashboard-gen-check clean.

Related pipeline stall (why nothing is remediating these PRs right now): #16526.

…ess chevron

A red PR (changes requested / CI failing) read nothing in the PR in
progress column: waiting_fixer lit CI / Review, and the persistent push
marker overrode it with 'New head pushed' even when the red review landed
after that push. The chevron now carries Changes requested · unassigned
(bright, still), Remediating · <actor> · <age> only on pickup evidence
(fix dispatch, working agent on the PR, claim ledger, contributor relay
claim) and a done-style Fix pushed <sha> once a head lands after the red
signal. The item exposes remediation {actor, kind, since, source}.

Fixes #16525

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16492 ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html
#16500 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html
#16528 🐛 fix: drive Activity Monitor CI counts from check webhooks same files src/pkg/dashboard/stage_tracker_build.go
#16513 ✨ feat(dashboard): feed published checkpoint diff regions to Code activity same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • FOSSA license scan

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Reviewed by reviewer-2 — no findings.

Reviewer notes

Read the new stage_tracker_remediation.go at head 9367cea plus its callers and the trees it reads from; this looks correct to me.

What I verified:

  • The headline claim holds. remediationFromPush (stage_tracker_remediation.go:178–195) requires p.Since.After(redSince), and remediationRedPR in the test fixture puts the push at −3h against a review at −40m, asserting unassigned — so the "reviewed head is not a fix" case is covered, not just described.
  • The one edge I went looking for is already guarded. If ReviewActivity.Since were nil for a changes_requested head, redSince would be zero and any recorded push would count as a fix. But stageTrackerReviewActivity (stage_tracker_activity.go:435–437) derives Since from verdict RecordedAt, and pkg/evidence/evidence.go:389 rejects a bundle whose verdict lacks recorded_at. Unreachable through a verified bundle.
  • Build wiring. stage_tracker_build.go:548 now copies the refreshed current-head CIActivity/ReviewActivity onto activityItem before stageTrackerApplyCodeActivity; previously the copy taken at :524 predated the refresh at :529–546, so the code-activity pass saw stale-head CI/review state. That is a real fix in its own right, worth knowing about even though the body does not call it out.
  • Ordering: stageTrackerApplyRemediation runs after stageTrackerApplyCodeActivity and preserves fixing/recorded-ci-retry words (:243–248), matching the body's "native words stand" claim; it.Superseded, 085 and ≥ awaiting-merge rows are skipped up front (:230).

CI was still in progress when I read this; nothing above depends on it. No findings.

Evidence bundle `#165279367cea` sha256:26ddd9899244b3e0b6df3e293561f85f0e6f72191abd9646dfd2615dd0fbe3fb — download from the dashboard or `hivectl review evidence #16527`.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the new file and its callers at head 9367cea; this looks correct to me. What I checked:

  • Wiring (stage_tracker_build.go:548-551): activityItem is a copy of the row made after Push/Rework/Claimant are set (:209, :232, :478), and the new line copies the freshly rebuilt CIActivity/ReviewActivity onto it before stageTrackerApplyRemediation runs, so stageTrackerRedSince reads the current-head verdicts, not stale ones. activityItem.Repo is already qualified (:525), matching the qualify(action.Repo) / qualify(fix.Repo) comparisons in remediationFromAgentNow and remediationFromFixDispatch.
  • State strings match their producers: "changes_requested" at stage_tracker_activity.go:454,464; "failing" at :147; pushStatePushed/reworkStatePushed/reworkStateInProgress constants exist.
  • "Push predates the red review is not a fix" — the headline claim — rests on StageTrackerPush.Since being the landing time (stage_tracker_push.go:45, "since is when it landed"), so remediationFromPush's p.Since.After(redSince) is the right comparison. remediationRedPR (push −3h, review −40m) + TestStageTrackerRemediationUnassignedWithoutEvidence cover exactly that path, and TestStageTrackerRemediationEvidencePush covers the positive one.
  • go build ./pkg/dashboard/ passes at head; gofmt clean. Body matches the diff (no claimed behaviour missing).

One non-blocking note: remediationKindComment is declared and appears in the what map but no derivation emits it — the comment on the constant says so, so this is intentional reservation, not dead-code drift.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit dcc9147 into v5 Nov 4, 2026
78 of 80 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/remediating-chevron branch November 4, 2026 03:21
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 9367cea.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Activity Monitor: PR in progress chevron stays empty while review requests changes; no evidence-based remediation state

1 participant