Repository navigation
🐛 Activity Monitor: say whose sign-off a parked review needs and lead with Approve - #16578
Conversation
… with Approve Rows parked on a policy sign-off ask (fork workflow change needing owner sign-off) read "Review 5/5 · awaiting human decision" with only "Let hive decide" inline, and captioned "Recommendation recorded" after a park-keeping verdict that recorded no recommendation. - Review chevron: "needs your sign-off" when the ask names the viewer, else "needs owner sign-off"; tooltip carries the question. - Server marks the first enabled decide:approve as lead for reviewer/ sentinel asks in human_decision when CI is not failing, so the row shows "Approve ▸" then "Let hive decide ▸". - Row action results carry the delegate verdict; the pend caption says "Recommendation recorded" only for recommend-only verdicts, otherwise "Your decision needed". Fixes #16577 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
docs-currency (read at head e1ad8b2)
The operator docs for the activity monitor still describe the pre-#16577 lead ordering that this PR changes.
src/docs/dashboard-sections/activity-monitor.md:436 says the lead button is [Let hive decide] on Needs human decision, and the state table at :606 lists "PR at 085 Needs human decision | Let hive decide · Approve · Give direction · …". With stageTrackerLeadApproveForSignOff (src/pkg/dashboard/stage_tracker_decision_pr.go:223-249, wired at stage_tracker_build.go:477) a reviewer/sentinel sign-off ask with reviews done and CI not failing now marks decide:approve as lead, so the row reads Approve ▸ then Let hive decide ▸ — the changelog fragment says so, the docs do not.
| PR at 085 *Needs human decision* | Let hive decide · Approve · Give direction · Close as superseded · Close as won't fix · Hold (unchanged). When the park is a policy sign-off ask from a reviewer or the security check (e.g. a fork's workflow change), the reviews on this head are done (`review_activity.state` `human_decision` / `approved`) and CI is not failing, the server marks **Approve** as the lead instead, so the row and menu read **Approve ▸** then **Let hive decide ▸**; a red CI, or an ask that already chose its lead (Re-author, Close as superseded), keeps the old order ([#16577](https://github.com/hivecommons/hive/issues/16577)). The review chevron on such a row reads *Review 5/5 · needs your sign-off* when the question names you, else *needs owner sign-off*, with the question in its tooltip. |
and at :436, [Let hive decide] on Needs human decision → [Let hive decide] (or [Approve] on a policy sign-off ask with CI not failing, #16577) on Needs human decision.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Evidence bundle `#16578e1ad8b2` sha256:11df4a77ba81ad4848d105be7d2932f6cded49c5c1bd0a5fb74239e6d4e9f23e — download from the dashboard or `hivectl review evidence #16578`.Review findings from Correctness review (head e1ad8b2). Read the diff plus One low edge case, with a fix: Viewer match is a substring test — |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at e1ad8b2. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Rows parked on a policy sign-off ask (fork workflow change needing owner
sign-off) read "Review 5/5 · awaiting human decision" with only "Let hive
decide" inline, and captioned "Recommendation recorded" after a
park-keeping verdict that recorded no recommendation.
else "needs owner sign-off"; tooltip carries the question.
sentinel asks in human_decision when CI is not failing, so the row
shows "Approve ▸" then "Let hive decide ▸".
"Recommendation recorded" only for recommend-only verdicts, otherwise
"Your decision needed".
Fixes #16577
Signed-off-by: Andrew Anderson andy@clubanderson.com