Skip to content

🐛 Activity Monitor: say whose sign-off a parked review needs and lead with Approve - #16578

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/signoff-lead
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/signoff-lead

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Rows parked on a policy sign-off ask (fork workflow change needing owner
sign-off) read "Review 5/5 · awaiting human decision" with only "Let hive
decide" inline, and captioned "Recommendation recorded" after a
park-keeping verdict that recorded no recommendation.

  • Review chevron: "needs your sign-off" when the ask names the viewer,
    else "needs owner sign-off"; tooltip carries the question.
  • Server marks the first enabled decide:approve as lead for reviewer/
    sentinel asks in human_decision when CI is not failing, so the row
    shows "Approve ▸" then "Let hive decide ▸".
  • Row action results carry the delegate verdict; the pend caption says
    "Recommendation recorded" only for recommend-only verdicts, otherwise
    "Your decision needed".

Fixes #16577

Signed-off-by: Andrew Anderson andy@clubanderson.com

… with Approve

Rows parked on a policy sign-off ask (fork workflow change needing owner
sign-off) read "Review 5/5 · awaiting human decision" with only "Let hive
decide" inline, and captioned "Recommendation recorded" after a
park-keeping verdict that recorded no recommendation.

- Review chevron: "needs your sign-off" when the ask names the viewer,
  else "needs owner sign-off"; tooltip carries the question.
- Server marks the first enabled decide:approve as lead for reviewer/
  sentinel asks in human_decision when CI is not failing, so the row
  shows "Approve ▸" then "Let hive decide ▸".
- Row action results carry the delegate verdict; the pend caption says
  "Recommendation recorded" only for recommend-only verdicts, otherwise
  "Your decision needed".

Fixes #16577

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html
#16500 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency (read at head e1ad8b2)

The operator docs for the activity monitor still describe the pre-#16577 lead ordering that this PR changes.

src/docs/dashboard-sections/activity-monitor.md:436 says the lead button is [Let hive decide] on Needs human decision, and the state table at :606 lists "PR at 085 Needs human decision | Let hive decide · Approve · Give direction · …". With stageTrackerLeadApproveForSignOff (src/pkg/dashboard/stage_tracker_decision_pr.go:223-249, wired at stage_tracker_build.go:477) a reviewer/sentinel sign-off ask with reviews done and CI not failing now marks decide:approve as lead, so the row reads Approve ▸ then Let hive decide ▸ — the changelog fragment says so, the docs do not.

| PR at 085 *Needs human decision* | Let hive decide · Approve · Give direction · Close as superseded · Close as won't fix · Hold (unchanged). When the park is a policy sign-off ask from a reviewer or the security check (e.g. a fork's workflow change), the reviews on this head are done (`review_activity.state` `human_decision` / `approved`) and CI is not failing, the server marks **Approve** as the lead instead, so the row and menu read **Approve ▸** then **Let hive decide ▸**; a red CI, or an ask that already chose its lead (Re-author, Close as superseded), keeps the old order ([#16577](https://github.com/hivecommons/hive/issues/16577)). The review chevron on such a row reads *Review 5/5 · needs your sign-off* when the question names you, else *needs owner sign-off*, with the question in its tooltip. |

and at :436, [Let hive decide] on Needs human decision → [Let hive decide] (or [Approve] on a policy sign-off ask with CI not failing, #16577) on Needs human decision.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

Evidence bundle `#16578e1ad8b2` sha256:11df4a77ba81ad4848d105be7d2932f6cded49c5c1bd0a5fb74239e6d4e9f23e — download from the dashboard or `hivectl review evidence #16578`.

Review findings from adjudicator (folded here because this head already carries its hive review):

Correctness review (head e1ad8b2). Read the diff plus stage_tracker_build.go, stage_tracker_decision_pr.go, row_action_result.go, stage_tracker_decided.go, api_repo_item_decision.go, tracker-row-strip.js. Ordering in buildStageTracker is right (DecisionNeeded/CIActivity/ReviewActivity are all derived before stageTrackerLeadApproveForSignOff(&it) at stage_tracker_build.go:477); every park-keeping verdict that reaches rowActionRecommended (owner-only / operator-action / recommend-only, row_action_result.go:182-190) has an entry in STAGE_TRACKER_PARK_KEPT_ACTING, and the server leaves decided.acting empty for those (stage_tracker_decided.go:165-172), so the JS fallback is actually reached. The new Approve consequence matches what decide:approve does on a PR (api_repo_item_decision.go:31-36). No blockers.

One low edge case, with a fix:

Viewer match is a substring test — static-src/js/tracker-row-strip.js:89-91 (mirrored in static/index.html:18189-18191): q.indexOf('@' + me) >= 0 makes a question naming clubanderson-bot or clubandersonx read "needs your sign-off" to clubanderson. GitHub logins are [A-Za-z0-9-], so a trailing boundary check is enough:

          const me = typeof window !== 'undefined' && window._hiveUser ? String(window._hiveUser).toLowerCase() : '';
          const mine = !!me && new RegExp('@' + me.replace(/[.*+?^${}()|[\]\\]/g, '\\$&') + '(?![a-z0-9-])').test(q);

@hivecommons-hive
hivecommons-hive Bot merged commit 4fc4ff1 into v5 Nov 4, 2026
87 of 90 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/signoff-lead branch November 4, 2026 12:16
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at e1ad8b2.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Activity Monitor: sign-off ask row says "awaiting human" with 5/5 reviews good and leads with "Let hive decide"

1 participant