Repository navigation
Conversation
This was referenced Oct 29, 2026
ofriw
marked this pull request as ready for review
October 29, 2026 15:12
This was referenced Oct 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and dependency
Layer 11/11 of the verified replacement for #66 / stack #80. Base: #90. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.
Contract and migration
Runner behavior: failures across runtimes now produce a nonzero combined exit. --fail-on-skip/GOATDB_FAIL_ON_SKIP reject skipped runs without mislabeling skips. GOATDB_TEST_TIMEOUT_MS must be an integer 1..2147483647; invalid values fail explicitly. Runtime floors are Deno2.3.3 and Node24. All earlier breaking/data notices remain applicable.
Verification —
9e9a759f944a590450380f541e7e8cd9b619451dVerified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.
Exact-tip repeat: 34 functional commands passed, with zero FAIL progress. Paths24/24; enabled checkout package1/1; npm scripts19/19 plus consumer tsc; npm archive55 required files; native Deno TS/JS and Node ESM disposal; clean JSR dry-run; two fresh/stable asset builds per version. Full suites include HTTP35 on Deno/Node and NodeHTTP6 on Node. No gate failure was waived.
Review boundary
All 49 source commits in
2be88b35..23d6c6d0were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.
Stack: https://github.com/goatplatform/goatdb/stack/92