Skip to content

test(ci): enforce runtime floors and report honest outcomes (11/11) - #91

Closed
ofriw wants to merge 3 commits into
rs/http-after-clifrom
rs/ci-final
Closed

ofriw wants to merge 3 commits into
rs/http-after-clifrom
rs/ci-final

Conversation

@ofriw

@ofriw ofriw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Scope and dependency

Layer 11/11 of the verified replacement for #66 / stack #80. Base: #90. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.

  • Pin CI to floor Deno2.3.3 and Node24; gate browser, package/archive/types and generated asset freshness. Verify current and floor locally; keep publish checks on a clean committed tree.
  • Collect all runtime failures and report explicit skips; --fail-on-skip remains strict. CLI/worker/browser displays never label skips as pass or fail.
  • Validate worker timeouts and report heartbeat/active-test context. Add real subprocess and browser UI contracts without new mocks.
  • Fix browser event payload typing with an erased unknown annotation; no runtime delta from the independently reviewed display fix.

Contract and migration

Runner behavior: failures across runtimes now produce a nonzero combined exit. --fail-on-skip/GOATDB_FAIL_ON_SKIP reject skipped runs without mislabeling skips. GOATDB_TEST_TIMEOUT_MS must be an integer 1..2147483647; invalid values fail explicitly. Runtime floors are Deno2.3.3 and Node24. All earlier breaking/data notices remain applicable.

Verification — 9e9a759f944a590450380f541e7e8cd9b619451d

Verified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.

Suite Current and floor (each)
Deno 756 total / 754 pass / 2 skip / 0 fail
Node 756 total / 743 pass / 13 skip / 0 fail
Browser 440 total / 438 pass / 2 skip / 0 fail

Exact-tip repeat: 34 functional commands passed, with zero FAIL progress. Paths24/24; enabled checkout package1/1; npm scripts19/19 plus consumer tsc; npm archive55 required files; native Deno TS/JS and Node ESM disposal; clean JSR dry-run; two fresh/stable asset builds per version. Full suites include HTTP35 on Deno/Node and NodeHTTP6 on Node. No gate failure was waived.

Review boundary

All 49 source commits in 2be88b35..23d6c6d0 were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.

Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.

Stack: https://github.com/goatplatform/goatdb/stack/92

@ofriw
ofriw added this pull request to stack #92 October 29, 2026 15:09
@ofriw ofriw changed the title rs/ci final test(ci): enforce runtime floors and report honest outcomes (11/11) Oct 29, 2026
@ofriw
ofriw marked this pull request as ready for review October 29, 2026 15:12
@ofriw ofriw closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant