Repository navigation
Conversation
This was referenced Oct 27, 2026
ofriw
force-pushed
the
pr/66-codec-storage
branch
from
October 27, 2026 10:59
f21e876 to
ceb6c48
Compare
ofriw
force-pushed
the
pr/66-infra-cli-ci-npm
branch
from
October 27, 2026 10:59
07f00cd to
7702032
Compare
This was referenced Oct 27, 2026
Closed
ofriw
force-pushed
the
pr/66-infra-cli-ci-npm
branch
from
October 27, 2026 12:17
7702032 to
44e22d4
Compare
Split from 9808cd9: CI and publish workflows pin deno v2.3.3, probe native using/Symbol.dispose, and add the type-check task they call. The codec tests and runtime build targets from that commit belong to the codec/storage PR.
(cherry picked from commit 46dec8c)
(cherry picked from commit 726b11c)
(cherry picked from commit 6b62c37)
(cherry picked from commit 6a3e62f)
…om compile() (cherry picked from commit 020983d)
(cherry picked from commit 94b75ee)
(cherry picked from commit a6be659)
(cherry picked from commit 893da13)
…ect all runtime failures (cherry picked from commit dccccc6)
(cherry picked from commit a0ab11a)
ofriw
force-pushed
the
pr/66-infra-cli-ci-npm
branch
from
October 27, 2026 12:37
44e22d4 to
bfabbea
Compare
(cherry picked from commit e405bf2)
(cherry picked from commit d610ba8)
(cherry picked from commit 9d47382)
(cherry picked from commit e19c5e0)
(cherry picked from commit 685852c)
lib.dom types postMessage as a window API, so checking the worker module failed on the transfer list. Cast once at the runtime boundary, where the worker runtime does accept a transfer list.
A test that could not run used to return early and look passed, hiding lost coverage. Add a skip sentinel, classify every outcome in one shared runTestCase used by the suite runner, the filtered runner and the worker runner, and count skips separately from passes and failures. --fail-on-skip (GOATDB_FAIL_ON_SKIP) turns a skip into a non-zero exit across Deno, Node and the browser. The runtime-specific test wrappers now skip explicitly.
ofriw
force-pushed
the
pr/66-infra-cli-ci-npm
branch
from
October 27, 2026 12:53
bfabbea to
32774b3
Compare
Collaborator
Author
|
Superseded by the reviewed, fully verified replacement stack: https://github.com/goatplatform/goatdb/stack/92
Each complete replacement tip passed full Deno + Node + browser suites on current Deno2.9.1 and actual floor2.3.3, with Node24.14.1 and Playwright1.64.1. Exact tip hashes, scope, dependencies, gates and breaking/data notices are in the new PR bodies. Final tip9e9a759f has 0 failures on all six full runs; the 49-source-commit content audit and independent review passed. Remote Actions status is separate from these measured local gates. Review bottom-up. This replaces the old split, not just its last diff. No PR was merged, no issue was edited, and original remote branches are retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of the #66 split: infrastructure, CLI, CI and npm packaging.
Base is
pr/66-codec-storage(#74), notmain.tests/cli-template-utils.tsuses the worker-backedreadDirwrapper that #74 introduces. Retarget tomainonce #74 lands.What changed
Test runner: skips are visible, and can fail the run. A test that could not run used to
returnearly and look passed. Now:skipTest(reason)throws a sentinel; one sharedrunTestCaseclassifies every outcome forTestSuite.run, the filteredTestsRunner.run, and the TUI worker runner.TestResult.skippedandTestSummary.skippedare reported separately; a skip is never a pass and never counts as a failure.printSummaryprints the skip count and the reasons.--fail-on-skip(GOATDB_FAIL_ON_SKIP) turns a skip into a non-zero exit on Deno, Node and the browser (the browser receives it through the injected config).denoTest/nodeTest/serverTest) now skip explicitly instead of passing silently.Test runner diagnostics.
GOATDB_TEST_TIMEOUT_MSis validated (integer,1..2^31-1) and names the active suite/test, elapsed time and heartbeat age on timeout; workers heartbeat every 10 s; a failing runtime no longer hides the other runtimes' results.npm. A shared production manifest, public entrypoint type checks (
scripts/check-npm-entrypoints.ts,tsconfig.npm.json), archive-content verification (deno task verify:npm-archive), declared runtime deps (chokidar, fast-check, react-dom), andengines.node >= 24.CLI.
compile()appends.exefor Windows targets and returns the compiled path;goatdb initships dotfile templates from the published package (plaingitignore/npmrcnames mapped back), installs Deno deps as^ranges in one bounded call, and exits non-zero when installation fails. Templates are copied byscripts/copy-cli-templates.ts.CI. Deno floor pinned to v2.3.3 with a native
using/Symbol.disposeprobe, Playwright installed and pinned on the Node job, committed assets verified fresh, Deno test failures now fail the run, and the npm archive and path contract are checked.Runtime helpers.
getEnvVaruses the runtime id and typed config; invalid hardware config reports a validation error;loggingentry imports are type-only.Verification
deno task checkclean, including the worker module.deno task verify:npm-archiveOK;npm run check:npm-typesOK (18 tests).TestFrameworkcovers: a skip is neither pass nor failure,printSummarylists skips, the flag turns skips into exit 1, and the real CLI exits non-zero only with the flag.Stack
Base #74.
pr/66-path-branding(last in the stack) builds on this branch.Stack position
Third layer of GitHub stack #80 (
main ← #74 ← #75 ← #76 ← #77 ← #78).readDirwrapper used bytests/cli-template-utils.ts) and fix(server): graceful, awaitable, race-free HTTP stop (2/5 of #66) #75 (the narrow Node server type that thislayer's
deno task checkand JSR/npm gates require).gh stack checkout 76.