Skip to content

fix(json-log): reject directory reads and worker-death requests (7/11) - #87

Closed
ofriw wants to merge 1 commit into
rs/58-6-encoder-and-fingerprintfrom
rs/jsonlog-worker-errors
Closed

ofriw wants to merge 1 commit into
rs/58-6-encoder-and-fingerprintfrom
rs/jsonlog-worker-errors

Conversation

@ofriw

@ofriw ofriw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Scope and dependency

Layer 7/11 of the verified replacement for #66 / stack #80. Base: #86. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.

  • Make directory reads fail with EISDIR across Deno, Node and browser adapters.
  • Reject pending requests when the JSON-log worker dies; allow clean worker respawn.
  • Verify real filesystem/worker contracts and regenerate bundled assets.

Contract and migration

Behavior: directory reads now reject instead of returning empty bytes on affected platforms. Worker failures are visible errors instead of requests that hang. No new store or wire format.

Verification — 6653d4d0c53d5815fe424e815a2c9a90c6eaad71

Verified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.

Suite Current Floor
Deno 704/704 704/704
Node 704/704 704/704
Browser 408/408 408/408

All reported cases passed. Before #91 the inherited runner counts some runtime-gated early returns as passes; these totals do not claim explicit skip accounting. Summaries and nonzero counts were checked, not exit status alone.

Review boundary

All 49 source commits in 2be88b35..23d6c6d0 were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.

Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.

Stack: https://github.com/goatplatform/goatdb/stack/92

Apply EISDIR identity across Deno, Node, and OPFS and keep DB-open errors intact. Reject pending requests on worker failure and allow the next call to respawn. Co-locate real file/worker contracts and rebuild worker assets; strict worker I/O already belongs to L3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant