Skip to content

refactor(core-types): use field dispatch and reject legacy refs (2/11) - #82

Closed
ofriw wants to merge 1 commit into
rs/58-1-type-opsfrom
rs/58-2-legacy-delete
Closed

ofriw wants to merge 1 commit into
rs/58-1-type-opsfrom
rs/58-2-legacy-delete

Conversation

@ofriw

@ofriw ofriw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Scope and dependency

Layer 2/11 of the verified replacement for #66 / stack #80. Base: #81. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.

  • Route core field behavior through the shared dispatch table and delete dead legacy code.
  • Keep legacy rejection and deletion atomic, with ingress tests that verify rejected source data is not mutated.

Contract and migration

Breaking: legacy rich-text RefMarker/RefNode values now throw on read, normalize and serialize instead of being stripped. Back up first. Migrate with a release that supports those values, or remove affected data and re-sync.

Verification — 8db5b1f43bfbde9f1b6ef1eae9417e3d1f53e513

Verified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.

Suite Current Floor
Deno 647/647 647/647
Node 647/647 647/647
Browser 355/355 355/355

All reported cases passed. Before #91 the inherited runner counts some runtime-gated early returns as passes; these totals do not claim explicit skip accounting. Summaries and nonzero counts were checked, not exit status alone.

Review boundary

All 49 source commits in 2be88b35..23d6c6d0 were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.

Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.

Stack: https://github.com/goatplatform/goatdb/stack/92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant