Skip to content

refactor(codec): make decoder ownership disposable (4/11) - #84

Closed
ofriw wants to merge 1 commit into
rs/58-3-date-epochfrom
rs/58-4-decoder-pool
Closed

ofriw wants to merge 1 commit into
rs/58-3-date-epochfrom
rs/58-4-decoder-pool

Conversation

@ofriw

@ofriw ofriw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Scope and dependency

Layer 4/11 of the verified replacement for #66 / stack #80. Base: #83. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.

  • Add owned decoder lifetimes and pool contracts, including parent/child disposal and reacquisition.
  • Export OwnedDecoder; include disposable libraries, correct lowering targets and a benchmark without unmeasured performance claims.

Contract and migration

Behavior: bare __rId refs without an enclosing reference table now throw; objects with additional fields remain user data. Disposed decoders reject reads until acquired again; parent disposal releases only its owned children. finalize() remains a disposal alias. Node runtime floor is 24. Native Deno TS/JS and Node ESM disposal paths are verified.

Verification — bca2c3a6b830bb3442bb5e476d319cec412c2468

Verified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.

Suite Current Floor
Deno 689/689 689/689
Node 689/689 689/689
Browser 396/396 396/396

All reported cases passed. Before #91 the inherited runner counts some runtime-gated early returns as passes; these totals do not claim explicit skip accounting. Summaries and nonzero counts were checked, not exit status alone.

Additional gates: native floor TS/JS disposal, native Node ESM disposal, npm JS/declarations build and consumer tsc (skipLibCheck=false).

Review boundary

All 49 source commits in 2be88b35..23d6c6d0 were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.

Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.

Stack: https://github.com/goatplatform/goatdb/stack/92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant