Skip to content

refactor(schema): derive ValueType mappings from CoreType (5/11) - #85

Closed
ofriw wants to merge 1 commit into
rs/58-4-decoder-poolfrom
rs/58-5-typing
Closed

ofriw wants to merge 1 commit into
rs/58-4-decoder-poolfrom
rs/58-5-typing

Conversation

@ofriw

@ofriw ofriw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Scope and dependency

Layer 5/11 of the verified replacement for #66 / stack #80. Base: #84. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.

  • Use one frozen ValueType-to-CoreType map, with exhaustive typing and a never fallback.
  • Co-locate registry/mapping contracts, align ES2024 config, and add the public-plus-worker check task.

Contract and migration

No new wire-format change in this layer. The Date/epoch and disposal contracts from earlier layers remain. Encoder behavior and fingerprint tests stay in #86.

Verification — ab0a8fc2fb73bd73f1776f0c1d1004cc9564fa96

Verified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.

Suite Current Floor
Deno 691/691 691/691
Node 691/691 691/691
Browser 398/398 398/398

All reported cases passed. Before #91 the inherited runner counts some runtime-gated early returns as passes; these totals do not claim explicit skip accounting. Summaries and nonzero counts were checked, not exit status alone.

Review boundary

All 49 source commits in 2be88b35..23d6c6d0 were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.

Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.

Stack: https://github.com/goatplatform/goatdb/stack/92

Co-locate registry enumeration and mapping contracts with the typing change. Finish the ES2024 config and public-plus-worker check gate. Preserve earlier layer scopes and tool pins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant