Repository navigation
Conversation
ofriw
force-pushed
the
pr/66-stack-base
branch
from
October 27, 2026 10:55
f0b2f3a to
957afb9
Compare
ofriw
force-pushed
the
pr/66-path-branding
branch
from
October 27, 2026 10:55
f159a19 to
f2f7a2b
Compare
ofriw
force-pushed
the
pr/66-stack-base
branch
from
October 27, 2026 10:59
957afb9 to
2179a53
Compare
ofriw
force-pushed
the
pr/66-path-branding
branch
from
October 27, 2026 10:59
f2f7a2b to
140450f
Compare
This was referenced Oct 27, 2026
Closed
ofriw
force-pushed
the
pr/66-path-branding
branch
from
October 27, 2026 12:17
140450f to
469d859
Compare
ofriw
force-pushed
the
pr/66-jsonlog-worker
branch
from
October 27, 2026 12:37
6434cde to
cbb6d13
Compare
ofriw
force-pushed
the
pr/66-path-branding
branch
from
October 27, 2026 12:37
469d859 to
56e3841
Compare
(cherry picked from commit fdb1b95)
(cherry picked from commit 56379e2)
(cherry picked from commit e393394)
(cherry picked from commit 171dd00)
Store roots are now branded POSIX paths at ingress. An empty or root path normalizes to '.' or a root, both of which logout() would delete recursively, so reject them at construction and carry the normalized contract in the type. Required by the path-branding work: before this, db.ts kept unbranded strings and the branded FileImpl contract did not type-check.
ofriw
force-pushed
the
pr/66-jsonlog-worker
branch
from
October 27, 2026 12:53
cbb6d13 to
42cd69f
Compare
ofriw
force-pushed
the
pr/66-path-branding
branch
from
October 27, 2026 12:53
56e3841 to
23d6c6d
Compare
Collaborator
Author
|
Superseded by the reviewed, fully verified replacement stack: https://github.com/goatplatform/goatdb/stack/92
Each complete replacement tip passed full Deno + Node + browser suites on current Deno2.9.1 and actual floor2.3.3, with Node24.14.1 and Playwright1.64.1. Exact tip hashes, scope, dependencies, gates and breaking/data notices are in the new PR bodies. Final tip9e9a759f has 0 failures on all six full runs; the 49-source-commit content audit and independent review passed. Remote Actions status is separate from these measured local gates. Review bottom-up. This replaces the old split, not just its last diff. No PR was merged, no issue was edited, and original remote branches are retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of the #66 split: branded POSIX paths, plus the store-path guard that the branding requires.
Base is
pr/66-stack-base, a scratch integration branch holding #74 + #75 + #76 + #77. Retarget this PR tomainonce those four land. The base branch exists only so this PR can be reviewed and tested as one unit; it is not meant to be merged.What changed
Paths are branded.
path.parsePath()returns aPosixPath; the brand is carried throughFileImpl, the json-log worker protocol, the runtime adapters, the CLI anddb/db.ts. Normalization happens once, at ingress, instead of at every call site.Containment is structural.
path.isWithin(parent, child)replacesstartsWithchecks.startsWithmatched sibling prefixes (/data/foovs/data/foobar) and mixed separators.Store path must be absolute and non-root.
''normalizes to'.'and'/'/'C:/'passisAbsolute, butlogout()recursively removes_basePath. Both are rejected atDBInstanceConfigconstruction (and byServer), with the normalized contract carried in the type.CLI tests are contract tests. Registry-flow tests were replaced by checkout and path-guard tests: the CLI runs as a user would run it, and assertions target generated files and resolved modules instead of internal registry calls.
cli-path-normalization,path-boundaries,path-propertyandno-registry-dependencycover the new contracts;deno task test:pathsruns the path suites.Compile-path fixes. The compile test resolves the vendor root without
Deno.realPath, and the CLI project root is derived from thedeno infograph roots.Verification
deno task checkclean;deno publish --dry-runOK;npm run build:npm(tsup + DTS) OK; fmt clean on all changed files; assets clean.FC_SEED=42 deno task test:paths23/23.git range-diff), and the only files not carried over are the README/AGENTS/docs/example edits, which this project forbids changing without an explicit request.Notes
docs,README.md,AGENTS.mdand the example READMEs from the original branch are intentionally not included.009c48destore-path guard ("F" in the original plan) is folded in here: the branded_basePathis what makes this branch type-check.Stack position
Top layer of GitHub stack #80 (
main ← #74 ← #75 ← #76 ← #77 ← #78).mainautomatically when the layers below land.
gh stack checkout 78.