Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: denoland/setup-deno@v2
with:
deno-version: v2.x
deno-version: v2.3.3 # floor: native explicit resource management (V8); see denoland/deno#29282

- uses: actions/setup-node@v4
with:
Expand All @@ -30,6 +30,13 @@ jobs:
- name: Install npm dependencies
run: rm -rf node_modules && npm install

- name: Type check and runtime floor probe
run: |
deno task check
deno eval 'using x = { [Symbol.dispose]() {} };'
# deno eval defaults to TypeScript; --ext=js guards the native JS path.
deno eval --ext=js 'using x = { [Symbol.dispose]() {} };'

- name: Build npm artifact
run: npm run build:npm

Expand Down
45 changes: 41 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,23 @@ jobs:
- name: Setup Deno
uses: denoland/setup-deno@v2
with:
deno-version: v2.x
deno-version: v2.3.3 # floor: native explicit resource management (V8); see denoland/deno#29282

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '24.x'

- name: Type check
run: deno task check

- name: Runtime floor probe (TypeScript)
run: deno eval 'using x = { [Symbol.dispose]() {} };'

- name: Runtime floor probe (native JavaScript)
# deno eval defaults to TypeScript; --ext=js guards the native JS path.
run: deno eval --ext=js 'using x = { [Symbol.dispose]() {} };'

- name: Path contract pre-check
run: deno task test:paths
env:
Expand Down Expand Up @@ -60,6 +70,23 @@ jobs:
- name: Validate JSR package
run: deno publish --dry-run

system-assets-check:
name: System Assets Freshness
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Setup Deno
uses: denoland/setup-deno@v2
with:
deno-version: v2.3.3 # floor: native explicit resource management (V8); see denoland/deno#29282

- name: Rebuild system assets
run: deno task build

- name: Verify system assets are fresh
run: git diff --exit-code -- system-assets/assets.json

docs-build:
name: Docs Build
runs-on: ubuntu-latest
Expand All @@ -69,7 +96,7 @@ jobs:
- name: Setup Deno
uses: denoland/setup-deno@v2
with:
deno-version: v2.x
deno-version: v2.3.3 # floor: native explicit resource management (V8); see denoland/deno#29282

- name: Setup Node.js
uses: actions/setup-node@v4
Expand Down Expand Up @@ -155,7 +182,7 @@ jobs:
- name: Setup Deno
uses: denoland/setup-deno@v2
with:
deno-version: v2.x
deno-version: v2.3.3 # floor: native explicit resource management (V8); see denoland/deno#29282

- name: Setup Node.js
uses: actions/setup-node@v4
Expand All @@ -171,7 +198,17 @@ jobs:
playwright-

- name: Install Playwright browsers and system dependencies
run: deno run -A npm:playwright@^1.48.0 install --with-deps chromium
# Runs under Node, not Deno: Playwright's downloader passes a `lookup`
# option that Deno's node:http does not implement. Tests still run on Deno.
# Version comes from deno.json so the install and the test runner cannot drift.
# deno.json must stay strict JSON (no comments): the probe reads it with require().
run: |
PLAYWRIGHT_VERSION=$(node -e "console.log(require('./deno.json').imports.playwright.split('@').pop().replace(/^[\^~]/, ''))")
if [ -z "$PLAYWRIGHT_VERSION" ]; then
echo '::error::Could not parse the playwright version from deno.json imports.playwright (expected e.g. npm:playwright@1.64.1)'
exit 1
fi
npx --yes "playwright@${PLAYWRIGHT_VERSION}" install --with-deps chromium

- name: Run browser tests
run: deno task test --runtime=browser
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ temp_bench_*
.chunkhound.json
.mcp.json

# Agent harness state (local only)
.pi/

# API docs build artifacts
docs/api.json

Expand Down
19 changes: 14 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
check keeps `logout()` from recursively removing the process working
directory.
- Unified `Date` wire format and commit checksum (0.7.0). Typed fields now
encode as `{ "__t": "D", "__v": <epoch-seconds> }`, not a bare number.
Dates carry their tag in every checksum position. The typed-field checksum
changes from `416277608` to `1391363808`. Older stores fail fast on open.
Back up the store before removal or re-sync. Mixed-version fleets are not
supported; typed-field decode rejects bare-number dates from older peers.
encode as `{ "__t": "D", "__v": <epoch-seconds> }`, not a bare number. Dates
carry their tag in every checksum position. The typed-field checksum changes
from `416277608` to `1391363808`. Older stores fail fast on open. Back up the
store before removal or re-sync. Epoch guards protect local stores only.
Mixed-version fleets are not supported; typed-field decode rejects bare-number
dates from older peers and skips those commits.
- Non-`typeSafe` strings can collide with tagged Dates (for example,
`"41700000000"`). Use `typeSafe` checksums for untrusted input.
- Legacy rich-text refs (`RefMarker` leaves or `RefNode` elements) now throw
Expand Down Expand Up @@ -82,6 +83,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
a runtime-dependent boolean.
- `coreValueEquals` is symmetric when `objectFilterFields` inspects its object.
The second comparison loop previously passed the wrong object to the filter.
- The test runner no longer stops at the first failing runtime. Deno, Node and
browser results are all collected, and the process exits non-zero with the
combined failures.

### Added

Expand All @@ -101,6 +105,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),

### Changed

- `GOATDB_TEST_TIMEOUT_MS` now sets the whole-worker timeout and is validated
strictly: non-integer values and values outside `1` to `2147483647` abort the
run with an explicit error instead of silently using the 5-minute default.
Workers send a heartbeat every 10 seconds, and a timeout reports the active
suite and test, the test's elapsed time and the last heartbeat age.
- `goatdb init` on Deno now requests `react`, `react-dom`, `yargs` and
`@types/react` as `^` ranges and installs all dependencies in one `deno add`
call, bounded by a 180s timeout. Exact pins let a transitive peer resolve a
Expand Down
5 changes: 5 additions & 0 deletions base/browser-runner.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { kMinuteMs, kSecondMs } from './date.ts';
import { ProcessManager } from './process-manager.ts';
import { getEnvVar } from './os.ts';

/**
* Options for running browser-based tests or benchmarks.
Expand Down Expand Up @@ -121,6 +122,10 @@ export async function runBrowserTests(
if (options.benchmark) {
env['GOATDB_BENCHMARK'] = options.benchmark;
}
const failOnSkip = getEnvVar('GOATDB_FAIL_ON_SKIP');
if (failOnSkip) {
env['GOATDB_FAIL_ON_SKIP'] = failOnSkip;
}

// Start debug server with HTTPS using the appropriate entry point
const serverArgs = [
Expand Down
Loading
Loading