Skip to content

feat(storage)!: unify tagged Dates and guard the storage epoch (3/11) - #83

Closed
ofriw wants to merge 1 commit into
rs/58-2-legacy-deletefrom
rs/58-3-date-epoch
Closed

ofriw wants to merge 1 commit into
rs/58-2-legacy-deletefrom
rs/58-3-date-epoch

Conversation

@ofriw

@ofriw ofriw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Scope and dependency

Layer 3/11 of the verified replacement for #66 / stack #80. Base: #82. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.

  • Apply tagged Date encoding/checksums and the 0.7.0 storage epoch as one change.
  • Protect marker ownership: ignore unrelated files, reject known GoatDB artifacts without a valid marker, and give backup-first errors.
  • Move strict file operations behind the worker boundary so browser OPFS can open stores; preserve filesystem error identity.

Contract and migration

Breaking: typed Dates now encode as { "__t": "D", "__v": <epoch-seconds> }, not bare numbers. Typed-field checksums change. Older stores fail fast: back up before removal or re-sync. Mixed-version fleets are unsupported; old bare-number typed Dates are rejected. Non-typeSafe strings can collide with Date checksums; use typeSafe checksums for untrusted input. Recursive mkdir now rejects on failure. Map-Date encoding and its pinned fingerprint follow in #86.

Verification — 4a95bed2d2bb134f260020890486bfba089a867e

Verified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.

Suite Current Floor
Deno 669/669 669/669
Node 669/669 669/669
Browser 376/376 376/376

All reported cases passed. Before #91 the inherited runner counts some runtime-gated early returns as passes; these totals do not claim explicit skip accounting. Summaries and nonzero counts were checked, not exit status alone.

Review boundary

All 49 source commits in 2be88b35..23d6c6d0 were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.

Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.

Stack: https://github.com/goatplatform/goatdb/stack/92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant