Repository navigation
Conversation
ofriw
force-pushed
the
pr/66-codec-storage
branch
from
October 27, 2026 10:59
f21e876 to
ceb6c48
Compare
ofriw
force-pushed
the
pr/66-jsonlog-worker
branch
from
October 27, 2026 10:59
4665926 to
71bfb89
Compare
This was referenced Oct 27, 2026
Closed
ofriw
force-pushed
the
pr/66-jsonlog-worker
branch
from
October 27, 2026 12:09
71bfb89 to
69d3bfe
Compare
ofriw
changed the base branch from
pr/66-codec-storage
to
pr/66-infra-cli-ci-npm
October 27, 2026 12:09
ofriw
force-pushed
the
pr/66-jsonlog-worker
branch
from
October 27, 2026 12:17
69d3bfe to
6434cde
Compare
ofriw
force-pushed
the
pr/66-infra-cli-ci-npm
branch
from
October 27, 2026 12:17
7702032 to
44e22d4
Compare
ofriw
force-pushed
the
pr/66-jsonlog-worker
branch
from
October 27, 2026 12:37
6434cde to
cbb6d13
Compare
ofriw
force-pushed
the
pr/66-infra-cli-ci-npm
branch
from
October 27, 2026 12:37
44e22d4 to
bfabbea
Compare
…OPFS (cherry picked from commit 54862a4)
A dead worker never answers, so an in-flight request waited forever and a DB open could hang. Wire the error and exit events (onerror/onmessageerror in the browser) to fail the worker: log through logging/, reject every pending request with the cause, drop the handle so the next call spawns a fresh worker, and terminate best effort. Worker creation and postMessage failures now reject their own request. A response with no pending request logs a warning instead of asserting, because a restart makes that race reachable.
ofriw
force-pushed
the
pr/66-infra-cli-ci-npm
branch
from
October 27, 2026 12:53
bfabbea to
32774b3
Compare
ofriw
force-pushed
the
pr/66-jsonlog-worker
branch
from
October 27, 2026 12:53
cbb6d13 to
42cd69f
Compare
Collaborator
Author
|
Superseded by the reviewed, fully verified replacement stack: https://github.com/goatplatform/goatdb/stack/92
Each complete replacement tip passed full Deno + Node + browser suites on current Deno2.9.1 and actual floor2.3.3, with Node24.14.1 and Playwright1.64.1. Exact tip hashes, scope, dependencies, gates and breaking/data notices are in the new PR bodies. Final tip9e9a759f has 0 failures on all six full runs; the 49-source-commit content audit and independent review passed. Remote Actions status is separate from these measured local gates. Review bottom-up. This replaces the old split, not just its last diff. No PR was merged, no issue was edited, and original remote branches are retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of the #66 split: json-log worker durability.
Base is
pr/66-codec-storage(#74), notmain.What changed
Directory reads fail with
EISDIR. Reading a directory used to return empty bytes on Windows, so a corrupt store looked like an empty file. Deno, Node and OPFS now raise one sharedEISDIRidentity, which the storage-epoch guard can classify (isNotFoundchecks name/code).A dead worker no longer hangs the process. The worker is the only owner of file I/O, so a crashed worker used to leave every pending request unresolved and a DB open never settled. Now:
error/exit(Node) andonerror/onmessageerror(browser) callfailWorker: log vialogging/, reject every pending request with the cause, clear the handle so the next call spawns a fresh worker, terminate best effort.terminate()emitsexitasynchronously, after a replacement may already be serving.postMessagefailures reject the request they belong to.failJSONLogWorkerForTestsis the test hook.Verification
deno task checkclean (including the worker module).JsonLogWorkerIOcovers: the pending read rejects with the worker failure and the next read respawns,EISDIRidentity, existing store-open error identity, and that the module logs throughlogging/with noconsole.*.assets.jsonrebuilt for the changed worker bundle.Stack
Base #74; sibling of #76.
Stack position
Fourth layer of GitHub stack #80 (
main ← #74 ← #75 ← #76 ← #77 ← #78).directly below it).
gh stack checkout 77.