Skip to content

fix(cli): verify npm artifacts and checkout-linked compile fixtures (9/11) - #89

Closed
ofriw wants to merge 2 commits into
rs/path-brandingfrom
rs/cli-after-path
Closed

ofriw wants to merge 2 commits into
rs/path-brandingfrom
rs/cli-after-path

Conversation

@ofriw

@ofriw ofriw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Scope and dependency

Layer 9/11 of the verified replacement for #66 / stack #80. Base: #88. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.

  • Restore packaged dotfile scaffolds; fail explicitly on dependency installation errors; use compatible React dependency ranges.
  • Return the real compiled executable path, including Windows .exe; verify actual Deno and Node SEA binaries.
  • Check npm entrypoints, templates, consumer types and the real archive; migrate all new paths to the existing branded boundary.
  • Restore the source no-registry-command guard with real checkout scanning; share the graph parser and retain worker-backed walking.

Contract and migration

API: compile() now returns Promise; callers that ignore the result need no change. Failed dependency installation now exits nonzero. Inherited Date/epoch, path and Node24 notices apply. The command guard is a bounded static detector, not proof that all network access is absent.

Verification — c09b313597d58b7a64ef966e8c98d52653b58373

Verified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.

Suite Current Floor
Deno 703/703 703/703
Node 703/703 703/703
Browser 434/434 434/434

All reported cases passed. Before #91 the inherited runner counts some runtime-gated early returns as passes; these totals do not claim explicit skip accounting. Summaries and nonzero counts were checked, not exit status alone.

Additional gates on both versions: paths24/24; enabled package1/1; npm scripts19/19 plus consumer tsc; archive55 required files; clean JSR dry-run; registry boundary2/2 server and1/1 browser.

Review boundary

All 49 source commits in 2be88b35..23d6c6d0 were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.

Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.

Stack: https://github.com/goatplatform/goatdb/stack/92

ofriw added 2 commits October 29, 2026 14:15
Final ninth replacement layer on f332f65. Squash CLI source branch 54bf92ee (71c54d4, 06c160b, 12c956c, c435ac2, CLI subsets of 8b3aef9/9df42768, and 10a18e2/0badaea0/39035b22 contracts). Shared compiler, worker, logging and floor prerequisites are inherited, not reapplied.

Resolve 25dbbfb/23d6c6d0 path residuals in new npm scripts and CLI fixtures: branded worker-backed I/O, semantic graph containment, and shared tests/deno-info.ts. Preserve L8 walk/static/property guards and generated assets rebuilt identically on both runtimes. Omit the registry static guard by explicit coordinator direction; retain checkout-linked compile and real built-package contracts.

Verified full suites sequentially on Deno 2.9.1 and actual 2.3.3: Deno 701/701, Node 24 701/701, browser 433/433 each. Path 24/24, package-enabled 1/1, npm type/script 19/19, public/worker checks, npm archives and JSR dry runs pass. Changed TS lint is clean (baseline 10 findings); optional fixture check retains the inherited system-info logging diagnostic owned by CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant