Skip to content

fix(codec): encode nested values before pinning epoch fingerprint (6/11) - #86

Closed
ofriw wants to merge 1 commit into
rs/58-5-typingfrom
rs/58-6-encoder-and-fingerprint
Closed

ofriw wants to merge 1 commit into
rs/58-5-typingfrom
rs/58-6-encoder-and-fingerprint

Conversation

@ofriw

@ofriw ofriw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Scope and dependency

Layer 6/11 of the verified replacement for #66 / stack #80. Base: #85. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.

  • Correct nested cyclical decoder creation and encode Dictionary values, including Dates in map fields.
  • Add real store-reopen and wire contracts before pinning epoch 1 fingerprint aca89293fe85f54d4e3e3f65fb80d41a.
  • Preserve the source fingerprint; do not regenerate it to fit changed behavior.

Contract and migration

Data notice: earlier commits with Dates in map fields can remain corrupted and must be re-created. The Date/epoch breaking notice in #83 applies.

Verification — 359e1232f140322def60aebfa35932d1e0e8e470

Verified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.

Suite Current Floor
Deno 697/697 697/697
Node 697/697 697/697
Browser 404/404 404/404

All reported cases passed. Before #91 the inherited runner counts some runtime-gated early returns as passes; these totals do not claim explicit skip accounting. Summaries and nonzero counts were checked, not exit status alone.

Review boundary

All 49 source commits in 2be88b35..23d6c6d0 were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.

Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.

Stack: https://github.com/goatplatform/goatdb/stack/92

Keep cyclical decoder children and encode Dictionary values through the shared codec. Co-locate the four roundtrip contracts, real store reopen regression, and unchanged aca89293fe85f54d4e3e3f65fb80d41a epoch fingerprint. Safe-owned-store guards already belong to L3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant