Skip to content

refactor(path)!: brand POSIX paths and reject unsafe store roots (8/11) - #88

Closed
ofriw wants to merge 1 commit into
rs/jsonlog-worker-errorsfrom
rs/path-branding
Closed

ofriw wants to merge 1 commit into
rs/jsonlog-worker-errorsfrom
rs/path-branding

Conversation

@ofriw

@ofriw ofriw commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Scope and dependency

Layer 8/11 of the verified replacement for #66 / stack #80. Base: #87. Review and integrate bottom-up; each complete PR tip passes all runtimes without a later unpublished fix.

  • Apply branded paths, semantic containment and normalized absolute non-root DB ingress atomically.
  • Add static boundaries, graph-root/Windows-8.3 contracts and seeded properties; retain worker-owned file I/O.
  • Run pure browser path properties (1000 cases/property); fromFileUrl is pure URL conversion and is now available there.

Contract and migration

Breaking: DBInstanceConfig.path rejects relative, empty and filesystem-root paths. Resolve at the call site, for example ${Deno.cwd()}/data. Normalized absolute paths prevent logout from recursively removing the working directory. New CLI files are migrated in #89; no future layer is needed to check this tip.

Verification — f332f6580b6cc02540fba29cb46705a8949c44b6

Verified locally on this exact tip with current Deno 2.9.1 and the actual floor 2.3.3 executable, Node 24.14.1, and Playwright 1.64.1/Chromium. The full Deno, Node and browser suites ran separately for each Deno version. Public+worker checks and repeated generated-asset builds passed on both versions. These are measured local gates, not a claim that remote Actions have completed.

Suite Current Floor
Deno 697/697 697/697
Node 697/697 697/697
Browser 433/433 433/433

All reported cases passed. Before #91 the inherited runner counts some runtime-gated early returns as passes; these totals do not claim explicit skip accounting. Summaries and nonzero counts were checked, not exit status alone.

Additional gates: test:paths24/24 on both versions; real native-separator worker reopen; actual compiled binary --help; stable assets.

Review boundary

All 49 source commits in 2be88b35..23d6c6d0 were independently audited across this replacement; the final combined tree also passed review. Intentional departures are co-located: real verification prerequisites, browser path coverage, restored registry guard, portable HTTP tests, and truthful skip display. No binary codec or protected AGENTS/CLAUDE/README changes.

Changed-code checks passed without new diagnostics or suppressions. Inherited broader lint/test-fixture type errors remain; this is not a repository-wide lint/typecheck-clean claim. The final broader changed-file lint has 23 inherited diagnostics. No remote merge or issue edit is part of this replacement.

Stack: https://github.com/goatplatform/goatdb/stack/92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant