Skip to content

πŸ› fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion - #17171

Closed
Karibhou wants to merge 2 commits into
hivecommons:v5from
Karibhou:fix/17150-design-issue-rfc-landed
Closed

Karibhou wants to merge 2 commits into
hivecommons:v5from
Karibhou:fix/17150-design-issue-rfc-landed

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #17150

What changed

An open issue labelled proposal or kind/design with no live claim now derives a new issue-only stage, stage/018-open-for-discussion, instead of stage/010-actionable. The Activity monitor shows it as Open for discussion in the Actionable column, and the caption names the label. It stays claimable: a claim stages it 020/030 as on any other issue.

Area Change
stagelabels Adds OpenForDiscussion (018, no dwell limit, label description is 100 chars or fewer). IsRegression treats leaving 018 like leaving any other parking stage: never a regression.
stageengine Adds IssueFacts.DiscussionLabel. The new unclaimedIssueStage applies it in the actionable and reporter-triage buckets, and to an umbrella issue whose claim isn't staged. The reason is open for discussion: <label>. issueProgress now books 040 β†’ 018 under hive/partially-addressed as progress. Adds the 018 edges to the transition table and the mermaid diagram (they're kept in sync by TestTransitionTableMatchesDiagram). Adds ReasonDiscussionLabel for presentation code.
pkg/github resolveIssueLabelFacts resolves the label. The claim gate is unchanged. New test rows show that proposal, kind/design and the 018 label are not refused.
dashboard Column, short word, phrase, actor, human-ask and caption for 018. The blocked-by guard uses < 020 for "before a claim". JS words/anchor/detour are updated, index.html is regenerated, and the shared trackerrow asset, RequiredGlobals and hub activity.js all carry STAGE_TRACKER_OPEN_FOR_DISCUSSION = 18. Node harnesses that already lifted STAGE_TRACKER_POSSIBLY_EXISTS now lift the new constant too.
docs Stage-labels table and diagram, a stage-engine-plan amendment, governor-thresholds, the activity-monitor stage table, CONTRIBUTING, and a changelog fragment.

Precedence: likely-done, hold, blocked, parks (045/017) and a covering PR still outrank 018. 018 outranks the untriaged 015, because a person owns the next step either way. 018 doesn't settle triage, so needs-triage stays on.

Queue depth: the governor counts the enumerated issue queue (actionable.Issues.Count), not stage labels. So 018 issues still count toward actionable queue depth. governor-thresholds.md now says so.

Acceptance criteria

Testing

Per AGENTS.md, I didn't run the Go test suite locally; CI is the verdict.

  • gofmt -l is clean on the changed files.
  • Regenerated index.html with go run ./pkg/dashboard/webstatic/gen.
  • Throwaway smoke program, since deleted: go run, which compiled pkg/github, pkg/stageengine, pkg/stagelabels and pkg/dashboard. Output:
  • Node smoke on the generated index.html:
    • stageTrackerAnchor(18) β†’ 10 (Actionable column)
    • STAGE_TRACKER_ACTIVE_WORD[18] = "Open for discussion"
    • stageTrackerHeadline = "Open for discussion"
    • phrase "open for discussion", actor human
  • I hand-appended the issue-stage golden fixture rows in canonical order: 12 covered.json rows for the new Table stage, identical to the 017 rows because both are below 040, plus 7 regressions.json rows. CI's TestIssueStageGoldens checks them byte for byte.

β€” hive: backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: 91e8bfbad

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • mobile-shots

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

CI triage (scanner, PR-local): test (dashboard 4/4) / dashboard shuffle 1/3, 2/3 fail in TestStageTrackerRemediationJavaScript and TestStageTrackerActivityJavaScript with ReferenceError: STAGE_TRACKER_OPEN_FOR_DISCUSSION is not defined (15/37 node subtests red). runtime-tests goes down with the same shard.

Cause: static/index.html now references STAGE_TRACKER_OPEN_FOR_DISCUSSION in issueColumnFor / the detour check, and the Go-driven test files were updated via jsConstLine(t, html, "STAGE_TRACKER_OPEN_FOR_DISCUSSION"), but the two standalone node harnesses hard-code their constants and were not:

  • src/pkg/dashboard/stage_tracker_activity.test.js:22
  • src/pkg/dashboard/stage_tracker_remediation_chevron.test.js:27

Fix: extend both lines to

const STAGE_TRACKER_ISSUE_DECISION_COLUMN = 10, STAGE_TRACKER_TRIAGE_NEEDED = 15, STAGE_TRACKER_POSSIBLY_EXISTS = 17, STAGE_TRACKER_OPEN_FOR_DISCUSSION = 18;

(stage_tracker_adopted_column.test.js / stage_tracker_fixing_column.test.js pick constants from the HTML via pick(/const STAGE_TRACKER_…/) β€” adding an OPEN_FOR_DISCUSSION pick there would be the more drift-proof route if you prefer.) Head is in your fork, so the hive cannot push this.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency (read at head 91e8bfbad)

The doc surfaces touched here agree with the code: the caption quoted in src/docs/dashboard-sections/activity-monitor.md:71 matches stage_tracker_caption.go (Open for discussion (<label>); no agent work is queued β€” claim it to take it on), the "not a gate" / precedence wording in stage-labels.md:98 matches unclaimedIssueStage in derive_issue.go, and governor-thresholds.md:5 states the queue-depth decision #17150 asked for explicitly. The #17054 title-only limitation is stated honestly in stage-engine-plan.md ("reads labels only, never titles").

One advisory gap, low:

ADR-0025 has no 018 extension record. src/docs/adr/0025-central-stage-engine.md:420-426 ("Scope and extension points") records every post-epic stage addition β€” 017 has its own paragraph there β€” and the ADR's line 11 points readers at that exception list. 018 is the same kind of addition and #17150 asks to update "any stage-tracker / stage-label reference". Suggested paragraph after line 426:

 Leaving 017 for 010 or closed is never a regression.
+
+**Open for discussion (`stage/018-open-for-discussion`, #17150).** Added
+after the epic: an issue-only stage between 017 and 020 with no dwell.
+Unlike 017 it is derived, not written by a gate: `DeriveIssue` returns it
+for an open issue labelled `proposal` or `kind/design` with no live claim
+(`IssueFacts.DiscussionLabel`, resolved in `pkg/github`), reason
+`open for discussion: <label>`. It is not a suppress: the claim gate is
+unchanged and a claim stages 020/030. `040 β†’ 018` under
+`hive/partially-addressed` is progress; leaving 018 is never a regression.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Review follow-ups (below review.backlog.min_severity: P2)

Non-blocking findings below the backlog filing line are listed here instead of as issues, one comment per PR, updated in place. Tick them off as they are fixed; set review.backlog.min_severity: P3 to file every finding.

  • P3 info style β€” discussionLabels vocabulary is hard-coded in pkg/github while the sibling umbrella vocabulary is config-driven (src/pkg/github/issue_stage_labels.go:306): var discussionLabels = []string{"proposal", "kind/design"} is a fixed list resolved by issueDiscussionLabel (issue_stage_labels.go:310-320), whereas the adjacent umbrella rule it mirrors reads it…

@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from adjudicator-4 (folded here because this head already carries its hive review):

Intent alignment (#17150) β€” read at head 91e8bfb.

The diff implements the issue's proposed rule faithfully: unclaimedIssueStage (src/pkg/stageengine/derive_issue.go, new func after issueProgress) returns 018 only when IssueFacts.DiscussionLabel is set and the issue is in the actionable/reporter-triage bucket or is an unstaged umbrella claim; claimed/covered buckets are untouched, so claims still stage 020/030. issueProgress books 040 β†’ 018 under hive/partially-addressed as progress; issue_claim_gate.go is untouched; 018 is correctly absent from stageTrackerNeedsHumanStages (src/pkg/dashboard/stage_tracker_build.go:620), so it won't raise a spurious human-attention row. Docs cover the governor-depth decision explicitly, as the issue asked.

One advisory on acceptance criterion 5 ("both #17054 and #17020 land on the new stage"):

β€” hive review: perspective=intent-alignment backend=omp model=anthropic/claude-opus-5-5

Review findings from adjudicator (folded here because this head already carries its hive review):

Correctness review (head 91e8bfbad)

The engine, store and transition-table changes check out: unclaimedIssueStage (src/pkg/stageengine/derive_issue.go:276-281) only runs where the issue would otherwise sit unclaimed, parks/holds/blocked/covering PR still take precedence (derive_issue.go:153-205), IsRegression treats leaving 018 as a park exit (src/pkg/stagelabels/store.go:1216), and the 015↔018 hops the table does not draw are still Expected because they are not regressions (src/pkg/stageengine/transition.go:36-40). Goldens and TestDeriveIssueTable cover the four issue-ACs.

1. Four Node harnesses fail: STAGE_TRACKER_OPEN_FOR_DISCUSSION is not defined (in-scope, blocks CI)

src/pkg/dashboard/static-src/js/tracker-row-anchor.js:51 and tracker-row.js:19 now evaluate cur === STAGE_TRACKER_OPEN_FOR_DISCUSSION for every cur that is not 45/15/17. The PR lifted the new constant into the Go jsConstLine harnesses but not into the standalone node --test files that hand-roll their globals, so runtime-tests, test (dashboard 2/4, 4/4, shuffle 1/3, 2/3) are red with ReferenceError from stageTrackerAnchor / stageTrackerSegments:

  • src/pkg/dashboard/stage_tracker_activity.test.js:22
  • src/pkg/dashboard/stage_tracker_remediation_chevron.test.js:27
  • src/pkg/dashboard/stage_tracker_adopted_column.test.js:30
  • src/pkg/dashboard/stage_tracker_fixing_column.test.js:36

stage_tracker_activity.test.js:22 and stage_tracker_remediation_chevron.test.js:27:

const STAGE_TRACKER_ISSUE_DECISION_COLUMN = 10, STAGE_TRACKER_TRIAGE_NEEDED = 15, STAGE_TRACKER_POSSIBLY_EXISTS = 17, STAGE_TRACKER_OPEN_FOR_DISCUSSION = 18;

stage_tracker_adopted_column.test.js:30 and stage_tracker_fixing_column.test.js:36, add after the POSSIBLY_EXISTS pick:

  pick(/const STAGE_TRACKER_POSSIBLY_EXISTS = \d+;/, 'STAGE_TRACKER_POSSIBLY_EXISTS'),
  pick(/const STAGE_TRACKER_OPEN_FOR_DISCUSSION = \d+;/, 'STAGE_TRACKER_OPEN_FOR_DISCUSSION'),

2. #17054 replay AC is not met as labelled today (in-scope, advisory)

#17150 AC: "Both #17054 and #17020, replayed through the engine, land on the new stage." #17054 currently carries help wanted, Epic, approved-direction, stage/040-covered-by-pr β€” no proposal/kind/design β€” so at this head it still derives 010 (pinned by regression/17054-rfc-epic-without-proposal-stays-010, src/pkg/github/issue_stage_goldens_test.go:323-327). The PR body says so openly and the issue's own "Proposed rule" is label-keyed, so I judge this against the rule, not the title heuristic: acceptable, but the issue should be closed with a note that #17054 needs the proposal label applied (or a follow-up for πŸ“-title matching) to actually leave 010.

hive/awaiting-ci: rebased the branch onto current v5 (was behind; the mobile-shots failure on be84e9c predated fa453b5 / #17189, which fixed the tracker-phone-chrome probe on the base). Authors and Signed-off-by trailers preserved, no content changes. CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the engine, label and dashboard changes against v5 at 7e19f30, including the 017 (PossiblyExisting) sites this mirrors. The code is correct as far as I can verify; one intent gap worth a body edit before this closes #17150.

Verified

  • stageengine/derive_issue.go:275-284: unclaimedIssueStage is reached only from the actionable / reporter-triage buckets and the unstaged-umbrella branch (:220, :227), so a live claim (BucketClaimed / BucketInProgress) still derives 020/030 β€” the issue's "mirror the epic behaviour, not stricter" rule holds. issueProgress (:266) books 040 β†’ 018 under hive/partially-addressed as progress.
  • github/issue_stage_facts.go:106 is the only writer of IssueFacts label facts (checked for other UmbrellaLabel = writers β€” none), so the out-of-cycle FactSink path gets DiscussionLabel too.
  • stagelabels.OpenForDiscussion is appended to the enum with Number: 18 exactly as 017 was, so persisted stage ints are stable and Before() orders by number. IsRegression (store.go:1216) and SettlesTriage treat 018 like the other pre-claim parks.
  • Dashboard: every non-test site that special-cases PossiblyExisting either now also handles OpenForDiscussion or is PR-only (stage_tracker_presence.go:121) / a label-modifier switch (stage_tracker_caption.go:81). stage_tracker_human_attention.go:47 omits 018, which is correct because 018 is not in stageTrackerNeedsHumanStages and TestStageTracker_OpenForDiscussionStage pins NeedsHuman == false. stageTrackerBlockedBy now uses >= trackerNumberClaimed (stage_tracker_caption.go:138), a strict widening that admits 018 without changing 010/015/017.
  • JS: STAGE_TRACKER_OPEN_FOR_DISCUSSION = 18 is added to tracker-words-core.js, the shared trackerrow asset, RequiredGlobals and hub activity.js; anchor/detour/words tables all carry 18.

Intent gap (please resolve in the PR body, no code change needed)

#17150's acceptance list says "Both #17054 and #17020, replayed through the engine, land on the new stage rather than 010." The body honestly marks this [~]: #17054 as labelled today stays 010 (regression/17054-rfc-epic-without-proposal-stays-010 pins it), and πŸ“-title matching is deliberately left out. That is a reasonable scope call β€” but the PR says Fixes #17150, which closes the issue on merge with one criterion unmet and no follow-up tracked. Either

  1. keep Fixes #17150 and state that the resolution for πŸ“ RFC: LLM-ranked knowledge advisor (OMP-style)Β #17054 is to add the proposal label to it (and do so / ask a maintainer to), or
  2. change to Refs #17150 (remaining: derive 018 from πŸ“ RFC titles for #17054; needs a title plumbed through enumeration and FactSink).

Note, not a defect: 018 now outranks 015 (unclaimedIssueStage runs for BucketReporterTriage too, derive_issue.go:226). A proposal filed by an untrusted reporter previously read "Triage needed" and counted in the needs-human total (015 is in stageTrackerNeedsHumanStages); it now reads "Open for discussion" and does not count. The needs-triage chip is still kept (SettlesTriage(018) == false), so the signal is not lost, only demoted. The body states this precedence explicitly; flagging it so it is a conscious choice.

Docs (stage-labels table, stage-engine-plan, governor-thresholds "018 still counts toward queue depth", CONTRIBUTING) match the code. CI green.

@Karibhou

Karibhou commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Pushed be84e9ca8 addressing the review:


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether #17150 is fully resolved by a label-only rule (so this PR may Fixes #17150 and #17054 gets a proposal label by hand), or whether πŸ“-title matching must land before the issue closes (then Refs #17150).

Code looks correct to me; one intent question for the issue author.

I read the diff against the v5 tree (merge-base df1061a) plus the callers, not just the patch.

Verified correct

  • src/pkg/stagelabels/stagelabels.go:448 β€” Before() compares Number(), not enum order, so appending OpenForDiscussion to the enum while giving it number 18 keeps SettlesTriage() (:460) returning false for 018, as the body claims.
  • src/pkg/stagelabels/store.go:1213 β€” IsRegression(OpenForDiscussion, *) is false (parking bay). Falls into 018 reuse the existing Claimed/PRInProgress/CoveredByPR cases, so 030β†’018 and 040β†’018 are regressions exactly as 030β†’010 / 040β†’010 are, and issueProgress (derive_issue.go:266) exempts the hive/partially-addressed case. Consistent with the transition-table comments.
  • src/pkg/stageengine/derive_issue.go:155-230 β€” likely-done, hold, blocked, needs-human, 017 and 045 parks all return before unclaimedIssueStage is reached, so the stated precedence holds; umbrella + proposal with a stray claim now derives 018 rather than 010, which matches "mirror the epic behaviour".
  • src/pkg/github/issue_stage_labels.go:306 β€” issueDiscussionLabel is read-only on labels; the claim gate is untouched and the new issue_claim_gate_test.go rows pin that.
  • Dashboard: stageByNumber (stage_tracker.go:1099) walks Table, so 18 resolves; stage_tracker_human_attention.go:47 and stage_tracker_presence.go:121 list 017 but not 018 β€” correct, since 018 always carries a reason and the latter is PR-only. The remaining 017-only references (config/issue_filter.go:66, overview_status.go:467, prior-art gate) are hard-suppress specifics that 018 deliberately does not share.

The question (intent-alignment, not a defect)
#17150's acceptance criteria say "Both #17054 and #17020, replayed through the engine, land on the new stage." The PR body candidly says #17054, as labelled today (Epic, approved-direction, no proposal/kind/design), still derives 010, because titles are not plumbed into IssueStageInput. The code does exactly what the body says; the gap is between the body and the issue. With Fixes #17150 the issue closes on merge with that criterion unmet unless someone adds proposal to #17054. Either outcome is fine β€” it just needs the issue author to pick one.

Also noted: governor-thresholds.md chooses "018 issues still count toward queue depth"; the issue allowed either answer as long as it is stated, and it is.

Nothing here blocks landing from my side. I have not approved, closed or labelled anything.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

CI triage (scanner): the only red check, mobile-shots (run 42440929899, 03:07Z β€” tracker-phone-chrome at 375Γ—667, rowsFullyVisible 0), is the shared incident #17186, not this diff β€” this PR touches no dashboard files. The fix landed on v5 in #17189 at 03:11Z, after that run. No PR-local change is needed: the next push (or a maintainer re-run) picks up the fixed probe from the merge ref and should go green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

mobile-shots red here is base staleness, not this diff (quality triage, head be84e9c).

Failure: Activity browser acceptance failed: 375x667@2 light/dark tracker-phone-chrome (run 42440929899, 03:01Z). Chronology on v5:

Baseline helper verdict: MERGE_BASE (the branch is behind v5; siblings #17170/#17181 rebuilt after #17189 are green on the same check). This PR is from a fork and the update-branch API is denied for this lane, so @Karibhou: merging v5 into be84e9c (or a re-run after a rebase) should clear it β€” nothing in the diff needs changing for this check.

Test review (quality): the added TestDeriveIssueTable cases (unclaimed proposal / kind/design β†’ 018, claim/PR/CoveredByPR/park/umbrella precedence), TestIsRegressionReservationStages (018 ↔ Claimed/Actionable/CoveredByPR) and TestIssueClaimBlockReason (proposal labels stay claimable) all fail without the change β€” no gaps noted.


🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): CI stayed red for 2h after the nudge and the relay nudge went unanswered. The hive will rebase this branch on v5 and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

Karibhou and others added 2 commits November 8, 2026 01:34
…for-discussion

An open issue labelled `proposal` or `kind/design` with no live claim now
derives the new issue-only stage/018-open-for-discussion instead of
stage/010-actionable, so a proposal whose Refs RFC PR merged no longer
reads as idle agent work (hivecommons#17020 fell 040 -> 010).

- stagelabels: OpenForDiscussion (018, open-ended); leaving it is never
  a regression.
- stageengine: IssueFacts.DiscussionLabel; unclaimedIssueStage applies it
  in the actionable/reporter-triage buckets and to an umbrella whose
  claim is not staged; reason "open for discussion: <label>";
  issueProgress books 040 -> 018 under hive/partially-addressed as
  progress; transition table + diagram gain the 018 edges.
- pkg/github resolves the label; claim gate unchanged (proposal,
  kind/design and the 018 label are not refused); goldens replay
  hivecommons#17020/hivecommons#17054.
- dashboard: Actionable column word/caption "Open for discussion",
  shared row asset + hub globals carry STAGE_TRACKER_OPEN_FOR_DISCUSSION.
- docs: stage labels, plan amendment, governor thresholds (018 issues
  still count toward queue depth), activity monitor, CONTRIBUTING.

Fixes hivecommons#17150

Co-authored-by: Andy Anderson <407614+clubanderson@users.noreply.github.com>
Hive-Run: hivecommons#17150
Hive-Plan: stage-engine-plan.md#amendments-after-pr-e
Hive-Spec: hivecommons#17150#proposed-rule
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
… ADR-0025 records 018

Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot force-pushed the fix/17150-design-issue-rfc-landed branch from be84e9c to 1143dcf Compare November 8, 2026 06:34

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the engine, label and dashboard code at 1143dcf before the body. The derivation change looks correct to me; one acceptance-criterion gap the body already declares is worth a maintainer's eyes.

What I verified

  • stageengine/derive_issue.go:276-282 β€” unclaimedIssueStage only short-circuits to 018 when DiscussionLabel is set; every other path falls through to the unchanged actionableIssueStage, so 010/015 derivation for non-proposal issues is untouched. It is wired into exactly the three unclaimed sites (actionable/reporter-triage bucket at :227, unstaged umbrella claim at :220); BucketClaimed/BucketInProgress are not routed through it, so a live claim still stages 020/030.
  • stagelabels/stagelabels.go:448-450 β€” Before compares Number(), not the enum value, so appending OpenForDiscussion to the persisted enum while giving it number 18 keeps SettlesTriage (018 < 020 β†’ false) and the dashboard < trackerNumberClaimed guard (stage_tracker_caption.go:138) consistent.
  • stagelabels/store.go:1216 β€” leaving 018 is never a regression; 040 β†’ 018 is a regression unless issueProgress (derive_issue.go:266-271) sees hive/partially-addressed, matching the issue's AC.
  • github/issue_stage_labels.go:306-317 β€” label match is case-insensitive and returns the issue's spelling, which ReasonDiscussionLabel then surfaces in the caption. issue_claim_gate.go is not in the diff β€” confirmed.
  • Not a defect, noting for completeness: stage_tracker_human_attention.go:47 doesn't list 018 in the actor-reason switch, but 018 is also not in stageTrackerNeedsHumanStages (stage_tracker_build.go:620), so an 018 item never reaches that code.

For the maintainer (@clubanderson, as the issue author)

#17150's acceptance criteria say both #17054 and #17020 should land on the new stage. The PR body is explicit that it keys on labels only, so #17054 (Epic, approved-direction, no proposal/kind/design) still derives 010 until someone adds proposal β€” pinned by golden regression/17054-rfc-epic-without-proposal-stays-010. That is consistent with the issue's own "Proposed rule" (which is label-based), but not with the AC line. If labelling #17054 is acceptable, this is complete; if πŸ“-title matching is required, it needs the title plumbed through IssueStageInput, which the author deliberately left out. Flagging so the choice is deliberate, not accidental. I have not changed anything.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Superseded by hive: re-authored as #17220 with the same commits and sign-off because the hive could not finish it on the contributor's branch. This PR is closed; if #17220 fails, hive reopens it.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Nov 8, 2026
@hivecommons-hive hivecommons-hive Bot closed this Nov 8, 2026
@Karibhou
Karibhou deleted the fix/17150-design-issue-rfc-landed branch November 15, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› stage engine: proposal/kind-design issues read as Actionable after their RFC lands

1 participant