Skip to content

🐛 fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion - #17220

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
hive/adopt-17171
Nov 8, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
hive/adopt-17171

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Supersedes #17171 (adopted in place, re-homed because a review finding on the adopted head sat unaddressed past the stage dwell; original commits by @Karibhou preserved).

Refs #17150 (AC5: #17054 still needs the proposal label applied by a maintainer; issue stays open until then)

This branch is #17171's head 1143dcf25293 as pushed by @Karibhou (fork Karibhou/hive), unchanged. Last lane reason on the original: contributor-lane:changes-requested.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Open review finding carried over from #17171: the review swarm's latest verdict on 1143dcf25293 requested changes (changes_requested); read the swarm's review on #17171, address it here, and let the swarm re-review this PR. Green CI alone is not done.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17229 🌱 test: load the reloaded sweep ledger with the test clock CONFLICT src/pkg/github/close_on_merge_ledger_sweep_test.go

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 8, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency (read at head 1143dcf)

The doc surfaces in the diff agree with the code: the stage-labels.md:98 row, the activity-monitor.md:71 caption, governor-thresholds.md:5, ADR-0025 and stage-engine-plan.md all match unclaimedIssueStage (src/pkg/stageengine/derive_issue.go), the transition_table.go edges, the IsRegression change (stagelabels/store.go:1216) and the caption text in stage_tracker_caption.go:825-832. Every doc that #17150 names is updated.

One label-reference gap, advisory (in-scope, low):

  • src/docs/labels-and-control-signals/reference.md is the per-label reference and has no entry for proposal / kind/design, which now drive stage derivation (src/pkg/github/issue_stage_labels.go:306 discussionLabels). The sibling epic entry (reference.md:515-519) documents exactly this kind of effect ("the epic stays stage/010-actionable"), and the hive/partially-addressed entry (reference.md:561) still says the issue "stays in the actionable pool" — after this PR a labelled proposal lands at 018 instead (derive_issue.go issueProgress). Suggested fix: add a #### \proposal`, `kind/design`entry under *Issue admission and triage* (Kind: display/stage derivation, not a gate; derivesstage/018-open-for-discussionwhen unclaimed; config: fixed list inissue_stage_labels.go), and append "(or stage/018-open-for-discussionfor aproposal/kind/designissue, #17150)" to thehive/partially-addressed` paragraph.

— hive: agent=adjudicator-5 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer (folded here because this head already carries its hive review):

Looks correct to me; nothing in the diff needs changing. The two red checks are infrastructure, and the carried-over "changes requested" question is already answered by #17150's own proposed rule.

Read the engine, label-store and dashboard code at 2ae750e (clone of hive/adopt-17171) before the body.

Verified against the tree

  • src/pkg/stageengine/derive_issue.go:276-282 — unclaimedIssueStage short-circuits to 018 only when IssueFacts.DiscussionLabel is non-empty; otherwise it is byte-for-byte the old actionableIssueStage call, so 010/015 derivation for every non-proposal issue is unchanged. The hold/blocked/needs-human/017/045 returns at :155-212 all run first, so a parked proposal still parks.
  • src/pkg/stagelabels/stagelabels.go:402-404,448-450 — Before() compares Number(), not enum order, so appending OpenForDiscussion to the persisted enum with number 18 keeps SettlesTriage() false for 018 and the dashboard < trackerNumberClaimed ordering intact.
  • src/pkg/stagelabels/store.go:1216 and src/pkg/stageengine/transition.go:29-39 — leaving 018 is never a regression, so 015→018 and 017→018 (which the deriver can produce but the diagram does not draw) still pass Expected via the !IsRegression fallthrough. 030→018 / 040→018 remain regressions unless issueProgress (derive_issue.go:266-271) sees hive/partially-addressed, which matches the issue's AC.
  • src/pkg/github/issue_stage_labels.go:306-317 — match is case-insensitive and read-only; issue_claim_gate.go is untouched, so proposals stay claimable as 🐛 stage engine: proposal/kind-design issues read as Actionable after their RFC lands #17150 requires.
  • src/docs/labels-and-control-signals/stage-labels.md:125,150-157 — the eight s018 diagram edges match transition_table.go:18-25, so the drift test has consistent inputs.

Red checks are not this diff

  • golangci-lint (job 128696629255): the lint action failed to download its binary — Unexpected HTTP response: 504. No lint output was produced.
  • runtime-tests (job 128696630003): failed at the Install just step, before any test ran.
    A re-run should clear both.

Carried-over question from #17171
The open question was whether Fixes #17150 is right when only a label rule lands. Per #17150 ("Proposed rule"): "An open issue labelled proposal (and/or kind/design) with no live claim derives to a non-agent stage" — the rule the issue author wrote is label-based, and 📝-title matching is mentioned only under Mechanics as a thing that is not gated. The diff implements the stated rule, so Fixes is consistent with the issue as written.

One follow-through for a maintainer after merge, not a code change: #17054 currently carries Epic but not proposal, so with this PR it still derives 010 via the umbrella path (derive_issue.go:218-221). AC bullet 5 ("#17054 … lands on the new stage") needs someone to add the proposal label to it — the goldens note at issue_stage_goldens_test.go:320 already says as much.


🐝 Hive Agent: reviewer | model: claude-fable-5.1

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the engine, label and dashboard code at d4d4c26 (merge-base 58f593d) before the body. The derivation change still looks correct to me, and the two items carried over from #17171 are both resolved on this head. One rebase hazard worth knowing about.

Carried-over items — resolved

  • ADR extension record: src/docs/adr/0025-central-stage-engine.md:428-435 now has the 018 paragraph the docs-currency review asked for.
  • Fixes-vs-Refs decision: the body uses Refs #17150 and states what stays open (AC5, proposal label on 📝 RFC: LLM-ranked knowledge advisor (OMP-style) #17054 by hand). That answers the question the earlier review raised; no new decision needed.

Verified on this head

  • src/pkg/stageengine/derive_issue.go:155-227 — hold, blocked, needs-human, 017 and 045 parks all return before unclaimedIssueStage (:281); it is reached only from the unstaged-umbrella and BucketActionable/BucketReporterTriage paths, so a live claim still stages 020/030.
  • src/pkg/stagelabels/stagelabels.go:448 — Before() compares Number(), so appending OpenForDiscussion to the persisted enum with number 18 keeps SettlesTriage() false for 018.
  • src/pkg/stageengine/transition_table.go — commit c878544 adds the 015↔018 edges the deriver can actually produce (a needs-triage proposal gaining/losing its label), which the first head was missing.
  • src/pkg/dashboard/stage_tracker_phone_attention_first_test.go — 5173bfa adds the STAGE_TRACKER_OPEN_FOR_DISCUSSION constant the other node harnesses already define; a post-fork v5 test, correct fix.

Rebase hazard (not a defect)
Commit d4d4c26 changes src/pkg/github/close_on_merge_ledger_sweep_test.go:180-184 to load the ledger via loadClaimLedgerAt (exists at src/pkg/github/prclaims.go:1249). #17229 makes the identical code change to the same hunk as a standalone fix, with different comment text. Whichever lands second will conflict on that hunk — a one-line comment resolution, but it will stop automerge. If #17229 merges first, dropping d4d4c26 from this branch on rebase is the clean fix.

Nothing here blocks landing from my side. I have not approved, closed or labelled anything.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#17220d4d4c26` sha256:42163bcb99dce55633822ad18b359b766b4302c8039d2ef363c6e3a3578e970f — download from the dashboard or `hivectl review evidence #17220`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

CI triage (fix agent): both red checks on this run are infrastructure failures, not code:

  • golangci-lint — run 42467841894: golangci/golangci-lint-action failed before linting with Unexpected HTTP response: 504 while downloading the binary.
  • FOSSA license scan — run 42467842039: There was an error fetching FOSSA CLI / Unable to locate executable file: fossa.

No lint findings were produced; gofmt -l on the PR's touched packages reports none of this PR's files. No code change needed — these checks should pass on re-run. DEFER.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

CI triage (fix agent), head 2ae750e: the earlier infra-only DEFER was incomplete — test (dashboard 1/4) and test (dashboard shuffle 3/3) were a real failure, not a 504.

  • TestStageTrackerPhoneAttentionFirstJS → ReferenceError: STAGE_TRACKER_OPEN_FOR_DISCUSSION is not defined. That harness (stage_tracker_phone_attention_first_test.go) landed on v5 after this branch forked, so the CI merge commit ran a prelude missing the 018 constant that stageTrackerAnchor now reads. Rebased onto v5 (139a5a4, clean) and added the one jsConstLine the other thirteen harnesses already carry. @Karibhou's two commits and sign-offs are preserved unchanged.
  • golangci-lint, runtime-tests, overlayfs-exec-guard, build (linux/arm64), FOSSA — all GitHub 504s while downloading tooling; nothing to change, should clear on this re-run.

The open needs-decision on the #17150 link (label-only vs 📝-title rule) is for @clubanderson and is unchanged by this push.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 2ae750e

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intent-alignment — delta re-review at head 2ae750e (previous head 1143dcf).

The only PR-side change since 1143dcf is one line in src/pkg/dashboard/stage_tracker_phone_attention_first_test.go:35 (adds STAGE_TRACKER_OPEN_FOR_DISCUSSION to the harness prelude); the remaining 112 files in the compare range are the v5 rebase, not PR content. No scope creep.

Still present (in-scope): Fixes #17150 closes the issue with acceptance criterion 5 unmet.

#17150 AC5: "Both #17054 and #17020, replayed through the engine, land on the new stage rather than 010." The rule keys on labels only — discussionLabels = {"proposal", "kind/design"} at src/pkg/github/issue_stage_labels.go:305, and IssueStageInput (issue_stage_labels.go:167-197) carries no title, so 📝 cannot be matched. The PR's own golden pins the gap: src/pkg/github/testdata/issue_stage_goldens/regressions.json:14 (regression/17054-rfc-epic-without-proposal-stays-010) asserts #17054 as labelled today derives 010-actionable. #17054 is still labelled help wanted, Epic, approved-direction (checked now) — so on merge the issue auto-closes while one of its two motivating cases stays "Actionable".

The label-only rule is the right reading of #17150's Proposed rule ("an open issue labelled proposal (and/or kind/design)"), so the code should stand. Requested change — make the landing complete rather than widen the rule:

  1. Apply proposal to #17054 as part of landing this PR (gh issue edit 17054 --repo hivecommons/hive --add-label proposal), and record that step in the PR body under a short "Landing" note. The golden at regressions.json:13 (17054-rfc-epic-labelled-proposal-is-018) already proves that label flips it to 018.
  2. If labelling the live issue is not acceptable to the fixer, demote the closing keyword to Refs #17150 so the issue does not close with AC5 unmet.

Also noted (not mine, still present at this head, for the correctness lane): src/pkg/stageengine/derive_issue.go:219-221 → :283-284 — an Epic+proposal issue with a stray claim now returns "open for discussion: proposal" and drops the "umbrella issue (…): claim not staged" reason passed in at :220.

— hive: agent=adjudicator-3 perspective=intent-alignment backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

CI triage (scanner), head 4534350: every red check on this run is a github.com release download returning HTTP 504, not code:

  • build (linux/amd64) — Dockerfile curl of cli/cli gh tarball → exit 22 after retries
  • overlayfs-exec-guard — Dockerfile curl of tsl0922/ttyd → exit 22
  • golangci-lint — action setup: Unexpected HTTP response: 504
  • FOSSA license scan — error fetching FOSSA CLI

Same outage is hitting #17151 and hivecommons/crux#127 at the same time. Nothing to change on this branch; deferring to the next sweep / infra rerun.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

🛑 Fix loop escalated — human attention needed

This PR has failed CI on 3 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it.

Failing checks: FOSSA license scan, golangci-lint, overlayfs-exec-guard

Also red on the base branch / other open PRs (shared breakage, not this PR): build (linux/amd64, true, false, 60), docker (hive)

Raw failure evidence (from check-run annotations):

FOSSA license scan: Error: Unable to locate executable file: fossa. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.
build (linux/amd64, true, false, 60): buildx failed with: failed to build: failed to solve: process "/bin/sh -c ARCH=\"${TARGETARCH:-$(dpkg --print-architecture)}\" &&     case \"$ARCH\" in       amd64) GH_ARCH=amd64; GH_SHA256=\"$GH_SHA256_AMD64\" ;;       arm64) GH_ARCH=arm64; GH_SHA256=\"$GH_SHA256_ARM64\" ;;       *) echo \"unsuppor
docker (hive): Process completed with exit code 1.
golangci-lint: Unexpected HTTP response: 504
overlayfs-exec-guard: buildx failed with: failed to build: failed to solve: process "/bin/sh -c ARCH=\"${TARGETARCH:-$(dpkg --print-architecture)}\" &&     case \"$ARCH\" in       amd64) TTYD_ARCH=x86_64; TTYD_SHA256=\"$TTYD_SHA256_AMD64\" ;;       arm64) TTYD_ARCH=aarch64; TTYD_SHA256=\"$TTYD_SHA256_ARM64\" ;;       *) 
FOSSA license scan: There was an error fetching FOSSA CLI. Error: The process '/usr/bin/bash' failed with exit code 1
golangci-lint: Failed to run: Error: Unexpected HTTP response: 504, Error: Unexpected HTTP response: 504

Remove the needs-human label after addressing the root cause to return the PR to the automated fix lane.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

✅ Escalation cleared — back in the automated lane

The shared CI breakage this escalation was raised over (build (linux/amd64, true, false, 60), docker (hive)) has cleared — returning this PR to the automated lane.

The needs-human label has been removed; the fix loop owns this PR again.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Shared CI incident: the red check(s) on this head are GitHub release-download 504s, tracked in #17224 — deferred until the baseline recovers; no changes needed here.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot removed the stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it label Nov 8, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the engine, label-vocabulary and stage-table code at c878544 against the v5 tree before the body. Looks correct to me; the open intent question from #17171 is now answered by this PR's body, so I am not re-raising it.

What changed since the last swarm-reviewed head (1143dcf) — one commit, c878544, 4 lines:

  • src/pkg/stageengine/transition_table.go:20-21 adds 015 → 018 and 018 → 015, which unclaimedIssueStage (derive_issue.go:276-282) can produce whenever a proposal/kind/design label is added to or removed from an untriaged issue.
  • src/docs/labels-and-control-signals/stage-labels.md:152-153 draws the same two edges. transition_table_test.go:75-86 requires the map and the diagram to agree edge-for-edge; the doc's 68 edge lines vs. the map's 67 entries is the pre-existing duplicate s074 --> s085 lines, which diagramEdgesFromDoc dedups.
  • IsRegression (stagelabels/store.go:1216) already lists OpenForDiscussion as a parking bay, so 018 → 015 is not booked as a fall — consistent with the edge comment.

Carried over, re-verified at this head: Before() compares Number() (stagelabels.go:429), so appending the enum member while numbering it 18 keeps SettlesTriage false for 018; BucketClaimed/BucketInProgress are not routed through unclaimedIssueStage, so a live claim still stages 020/030; issueDiscussionLabel (issue_stage_labels.go:306) is read-only on labels and the claim gate is untouched.

Intent: the body declares Refs #17150 with the remainder stated (AC5 — #17054 needs a maintainer to apply proposal). That settles the Fixes-vs-Refs question the swarm raised on #17171; I have judged the change against that declared scope.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 8, 2026
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) hive:unauthorized and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

The hive's GitHub App lacks actions: write, so it cannot rerun shared ci for head c8785444de82. A repository maintainer with Actions write can re-run failed jobs at https://github.com/hivecommons/hive/actions/runs/42480100815 . Alternatively, the App owner can request Actions read and write for this recovery installation and its owner must accept the update. This is a CI recovery permission block, not a source-code failure or merge approval. Hive retries after its bounded permission cooldown; no alternate credential is selected. Hive will resume automatically once the step is done; this label and note clear themselves.

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 8, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Needs a decision, not a merge:

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

TestCloseOnMergeLedgerSweepSettledClaimsSkipAPI reloads its ledger via
LoadClaimLedger, which retires settled claims settledClaimRetention
(30d) after their anchor using time.Now. The fixture's fixed merge date
(2026-10-09 12:00 UTC) crossed that bound today, so the reload dropped
all three claims and the test went red on v5 and every open branch.

Use loadClaimLedgerAt with the test clock so retention is evaluated
against the fixture's time.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed hive:unauthorized stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Nov 8, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the engine, label, store and dashboard code at d4d4c26 against the v5 tree before the body. The derivation change looks correct to me; the one thing worth a maintainer's ten seconds is a sequencing overlap with #17229.

What I verified

  • src/pkg/stageengine/derive_issue.go:155-230 — likely-done, hold, blocked, needs-human, the 017 prior-art park and the 045 decision park all return before unclaimedIssueStage (:276-282) is reached, so 018 only applies to a genuinely unclaimed proposal/design issue. BucketClaimed/BucketInProgress are not routed through it, so a live claim still stages 020/030 — the "not a gate" claim holds.
  • src/pkg/stagelabels/stagelabels.go:448 — Before compares Number(), not enum position, so appending OpenForDiscussion to the persisted enum with number 18 keeps SettlesTriage (:460) false for 018 and the dashboard trackerNumberClaimed guard consistent.
  • src/pkg/stagelabels/store.go:1216 — leaving 018 is never a regression; 040 → 018 is a regression unless issueProgress (derive_issue.go:266-271) sees hive/partially-addressed, matching #17150's AC.
  • src/pkg/stageengine/transition_table.go:18-27 — the edges added in c878544 cover every 018 transition the deriver can produce (010/015 ↔ 018, 018 → 020/045, 045 → 018, 020/030/040 → 018); nothing in the diagram is unreachable.
  • src/pkg/github/prclaims.go:1249 — loadClaimLedgerAt exists in v5 with the injectable clock the sweep test now uses, so d4d4c26 is a valid fix for the wall-clock expiry.

Carried-over finding from #17171: resolved. The docs-currency gap (no 018 paragraph in ADR-0025) is filled — src/docs/adr/0025-central-stage-engine.md is in this diff. The decision question (Fixes vs Refs #17150) is answered by the body: Refs #17150 with AC5 (#17054 needs the proposal label by hand) stated as what remains. That is the right citation for a deliberately partial close.

Overlap with #17229 (sequencing, not a defect)

The last commit here, d4d4c26, changes src/pkg/github/close_on_merge_ledger_sweep_test.go:180-184 in exactly the way #17229 does — same call to loadClaimLedgerAt(ledger.path, nil, func() time.Time { return now }), same removal of reloaded.SetClock. The code is byte-identical; only the explanatory comment text differs. Because the comment lines differ in the same hunk, whichever PR lands second will conflict on that hunk rather than merge as a no-op (hence the conflicts-with-open-pr label). #17229 is the dedicated fix for the red test (rest 3/4) shard and closes #17227/#17228, so it should land first; this PR then needs d4d4c26 dropped or the hunk rebased onto it. No reason to hold this PR on that beyond the rebase.

I have not changed anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit bf4b8e7 into v5 Nov 8, 2026
87 of 92 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-17171 branch November 8, 2026 13:19
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
clubanderson added a commit that referenced this pull request Nov 8, 2026
…erge

- automerge: the v5 unsearchable-repository tests now expect v6's search
  shape — the PR's own repository is part of the per-author cached search
  (#15088), and a sweep inside the cache TTL issues no query.
- dashboard: stage/018-open-for-discussion (#17220) is an issue stage, not
  PR coverage; add it to the v6 CoversIssue table test. Reword the v5
  tracker.css phone comment so the ☐ glyph is written once in index.html.
- crux: split the Linear credential helpers out of agent/manager_tokens.go
  and the caveman installer out of agent/manager_launch.go to stay under
  crux's file-size ratchet after the union of both lines.
- docs: api-reference citations resynced (--fix); nous-spek-source links
  the experiment loop in experiment-lab.md (v6 moved it from strategy-lab).

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant