Skip to content

✨ dashboard: progress pill replaces the chevron strip on phones - #17183

Merged
clubanderson merged 3 commits into
v5from
feat/ham-phone-progress-pill
Nov 8, 2026
Merged

clubanderson merged 3 commits into
v5from
feat/ham-phone-progress-pill

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #17160

Part of #17158

On phones (≤640px, or coarse pointer ≤820px) every Activity monitor row renders a single stage-coloured Step 7/8 · Merge queue · 2h pill in place of the eight-chevron strip, which did not fit a 390px row and left the lit chevron hundreds of pixels off-screen. Tapping the pill opens the full strip, since age, caption and the lit chevron's hover text in a .hive-dialog.modal-sheet. The sticky .ham-cols header is hidden with the strip. Row moves flash the pill once instead of drawing the overlay against a hidden strip.

Outside the phone tier the pill has no box: the desktop strip and the .ham-anim-layer geometry at 1280 are byte-identical (verified by dumping seg/col/head/anim-layer rects before and after).

Changes

  • tracker-row-strip.js: stageTrackerPillHtml (step counted as chevrons drawn, label = active word/detour, since text) and stageTrackerPillSheet (clones the strip row into a sheet via hiveWireDialog).
  • tracker-row-render.js / tracker-row-layout.js: pill emitted after since in the row and nested-PR strip rows.
  • tracker-motion.js: hidden-strip branch of stageTrackerAnimateMove → ham-pill-moved cue.
  • tracker.css: phone-tier block replaces the old 640px scrolling-strip rules; pill colours follow data-motion (amber / needs-human tint / green).
  • Mobile shots gate: tracker-header-geometry grows a phone branch (pill inside row, ≥ tap target, ≥12px, no sideways scroll, needs-human distinct); new tracker-phone-pill probe taps the pill, checks the sheet and plays a move; strip-only probes skip on phones; 390x844 must exercise the pill. TRUSTED_SCRIPTS_TREE re-pinned.
  • stage_tracker_activity.test.js: phone-contract asserts + pill test (38/38 pass locally).
  • Docs (activity-monitor.md) and changelog.d/added-activity-phone-progress-pill.md.

390×844 before — strip overflowing every row, column header visible:

before: chevron strip overflowing a 390px row

390×844 after — pill per row, cols hidden:

after: progress pill per row

Pill sheet — full strip, since, caption:

after: pill sheet with the full strip

Deliberate omissions: decision triggers inside the sheet's cloned strip are static (the Needs human row line is still reachable); phone row height is addressed in #17161.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17179 ✨ dashboard: attention-first Activity monitor ordering and count line on phones same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#17180 ✨ dashboard: 12px text floor for the Activity monitor on phones CONFLICT .github/scripts/integration-governance.cjs
src/scripts/dashboard-mobile-shots.mjs
#17171 🐛 fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion same files src/docs/dashboard-sections/activity-monitor.md
src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/static/index.html
#17193 ✨ Activity monitor: 44px tap targets, row tools in the header, kebab as a sheet on phones CONFLICT .github/scripts/integration-governance.cjs
src/scripts/dashboard-mobile-shots.mjs
#17191 ✨ dashboard: landscape-phone tier for the Activity monitor same files src/docs/dashboard-sections/activity-monitor.md
src/pkg/dashboard/static/index.html
#17181 ✨ dashboard: Activity monitor merged and queue lists open as sheets on phones same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

On phones (≤640px, or coarse pointer ≤820px) every Activity monitor row
renders a single stage-coloured "Step 7/8 · Merge queue · 2h" pill in
place of the eight-chevron strip, which did not fit a 390px row and left
the lit chevron hundreds of pixels off-screen. Tapping the pill opens the
full strip, since age, caption and hover text in a .hive-dialog.modal-sheet.
The sticky column header is hidden with the strip. Row moves flash the
pill once instead of drawing the overlay against a hidden strip.

Outside the phone tier the pill has no box: the desktop strip and the
.ham-anim-layer geometry at 1280 are unchanged.

Mobile shots gate: tracker-header-geometry grows a phone branch (pill
inside the row, ≥ tap target, ≥ 12px, no sideways scroll, needs-human
distinct), a tracker-phone-pill probe taps the pill and plays a move, and
390x844 must exercise the pill. Strip-only probes are skipped on phones.

Fixes #17160
Part of #17158

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…it 375x667

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the feat/ham-phone-progress-pill branch from cc83b53 to c023612 Compare November 8, 2026 03:15
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@clubanderson
clubanderson merged commit 169d480 into v5 Nov 8, 2026
83 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/ham-phone-progress-pill branch November 8, 2026 03:23
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

hivecommons-hive Bot pushed a commit that referenced this pull request Nov 8, 2026
The progress pill (#17183) keeps a compact painted box and widens its
hit area to --tap-target with an absolutely positioned ::before. The
tap-target probe only measured the painted box, so the 390×844 gate
went red once both landed on v5. Measure the union of the element and
its absolute ::before/::after instead.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ dashboard: Activity monitor progress pill replaces the chevron strip on phones

1 participant