Repository navigation
✨ dashboard: progress pill replaces the chevron strip on phones - #17183
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
98ba9c3 to
0ce94b0
Compare
On phones (≤640px, or coarse pointer ≤820px) every Activity monitor row renders a single stage-coloured "Step 7/8 · Merge queue · 2h" pill in place of the eight-chevron strip, which did not fit a 390px row and left the lit chevron hundreds of pixels off-screen. Tapping the pill opens the full strip, since age, caption and hover text in a .hive-dialog.modal-sheet. The sticky column header is hidden with the strip. Row moves flash the pill once instead of drawing the overlay against a hidden strip. Outside the phone tier the pill has no box: the desktop strip and the .ham-anim-layer geometry at 1280 are unchanged. Mobile shots gate: tracker-header-geometry grows a phone branch (pill inside the row, ≥ tap target, ≥ 12px, no sideways scroll, needs-human distinct), a tracker-phone-pill probe taps the pill and plays a move, and 390x844 must exercise the pill. Strip-only probes are skipped on phones. Fixes #17160 Part of #17158 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…it 375x667 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
cc83b53 to
c023612
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
The progress pill (#17183) keeps a compact painted box and widens its hit area to --tap-target with an absolutely positioned ::before. The tap-target probe only measured the painted box, so the 390×844 gate went red once both landed on v5. Measure the union of the element and its absolute ::before/::after instead. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Fixes #17160
Part of #17158
On phones (≤640px, or coarse pointer ≤820px) every Activity monitor row renders a single stage-coloured
Step 7/8 · Merge queue · 2hpill in place of the eight-chevron strip, which did not fit a 390px row and left the lit chevron hundreds of pixels off-screen. Tapping the pill opens the full strip,sinceage, caption and the lit chevron's hover text in a.hive-dialog.modal-sheet. The sticky.ham-colsheader is hidden with the strip. Row moves flash the pill once instead of drawing the overlay against a hidden strip.Outside the phone tier the pill has no box: the desktop strip and the
.ham-anim-layergeometry at 1280 are byte-identical (verified by dumping seg/col/head/anim-layer rects before and after).Changes
tracker-row-strip.js:stageTrackerPillHtml(step counted as chevrons drawn, label = active word/detour, since text) andstageTrackerPillSheet(clones the strip row into a sheet viahiveWireDialog).tracker-row-render.js/tracker-row-layout.js: pill emitted aftersincein the row and nested-PR strip rows.tracker-motion.js: hidden-strip branch ofstageTrackerAnimateMove→ham-pill-movedcue.tracker.css: phone-tier block replaces the old 640px scrolling-strip rules; pill colours followdata-motion(amber / needs-human tint / green).tracker-header-geometrygrows a phone branch (pill inside row, ≥ tap target, ≥12px, no sideways scroll, needs-human distinct); newtracker-phone-pillprobe taps the pill, checks the sheet and plays a move; strip-only probes skip on phones; 390x844 must exercise the pill.TRUSTED_SCRIPTS_TREEre-pinned.stage_tracker_activity.test.js: phone-contract asserts + pill test (38/38 pass locally).activity-monitor.md) andchangelog.d/added-activity-phone-progress-pill.md.390×844 before — strip overflowing every row, column header visible:
390×844 after — pill per row, cols hidden:
Pill sheet — full strip, since, caption:
Deliberate omissions: decision triggers inside the sheet's cloned strip are static (the
Needs humanrow line is still reachable); phone row height is addressed in #17161.