Skip to content

✨ dashboard: sticky compact filter bar for the Activity monitor on phones - #17176

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
am-mobile-compact-filter-bar
Nov 8, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
am-mobile-compact-filter-bar

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

What

On a phone (the .modal-sheet tier: ≤640px, or coarse pointer ≤820px) the Activity monitor's 13-control toolbar and label-chip row are no longer drawn above the list. The sticky bar carries a compact filter row instead — All / PRs / Issues · ⚠ Needs attention · 👤 Waiting on you (count) · ⋯ Filters — beside the Merged pill. ⋯ Filters opens a .hive-dialog.modal-sheet that receives the existing toolbar and label-chip DOM (Repo / search / Since / Author / Decisions / Sort / Group / Per page / sound / labels) and returns it on close (Done, ✕, Esc, backdrop), so every render keeps syncing the same controls. Filters apply live and survive closing; the ⋯ badge counts the filters set in the sheet.

The card body gets overflow: clip on phones so the sticky bar sticks to the viewport instead of being pushed down over the first row by the body's overflow: hidden scroller.

Desktop is untouched: 1280 DOM rects are identical before/after (the only new node is display: none).

Measured (390×844, fixture)

before after
chrome between section header and first row 563px 98px
rows fully visible without scrolling 0 2
sticky stack (.ham-sticky + .ham-cols) 36 + 18 44 + 23

Gate

  • New probe src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js wired into the mobile-shots activity-density state: on portrait phone viewports it asserts compact bar shown / toolbar hidden, chrome ≤ 160px, ≥ 1 row fully visible, sticky + cols ≤ 100px, sheet round-trip (toolbar + labels inside, controls inside viewport, 16px inputs, restored on close). Desktop/landscape return a skip marker. Passes locally at 390x844@3.
  • TRUSTED_SCRIPTS_TREE re-pinned.

Docs: src/docs/dashboard-sections/activity-monitor.md (Filters section).

Fixes #17159
Part of #17158

Screenshots

390x844 before: toolbar fills the screen, no rows visible
390x844 after: compact sticky filter bar, rows visible
390x844 Filters sheet

…ones

On a phone (.modal-sheet tier) the Activity monitor's 13-control toolbar
and label chips are hidden; the sticky bar carries All / PRs / Issues,
⚠ Needs attention, 👤 Waiting on you (with count) and ⋯ Filters, which
moves the full toolbar and label chips into a .hive-dialog.modal-sheet
and returns them on close. The card body uses overflow: clip on phones
so the sticky bar sticks to the viewport instead of being pushed over
the first row. Desktop layout is unchanged.

Adds the tracker-phone-chrome probe to the mobile-shots activity-density
gate (390x844: chrome <= 160px, one row fully visible, sheet round-trip).

Fixes #17159
Part of #17158

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17171 🐛 fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion same files src/docs/dashboard-sections/activity-monitor.md
src/pkg/dashboard/static/index.html

@hivecommons-hive
hivecommons-hive Bot merged commit 3193ce8 into v5 Nov 8, 2026
88 of 94 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the am-mobile-compact-filter-bar branch November 8, 2026 02:25
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1717665aba58` sha256:04e606583ab74568e537153d9368c11480e48a01711945171b5382eb0aff4ecd — download from the dashboard or `hivectl review evidence #17176`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 65aba58.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

clubanderson added a commit that referenced this pull request Nov 8, 2026
The tracker-phone-chrome acceptance added in #17176 asserts that a row is
fully visible at 375x667 with the section header at the top. The density
fixture's first .ham-row is a whole work-item cluster (parent issue, child
PR, decision, notes: ~418px) and never fits the 397px left below the chrome,
so every dashboard PR fails mobile-shots at 375x667 regardless of its diff.

Keep the intent (chrome stays short, a row shows without scrolling) but
accept a first row taller than the remaining viewport when at least 120px
of it is visible. Ignore the scratch Chrome profile the harness creates.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
(cherry picked from commit bffcb8b)
clubanderson added a commit that referenced this pull request Nov 8, 2026
The tracker-phone-chrome acceptance added in #17176 asserts that a row is
fully visible at 375x667 with the section header at the top. The density
fixture's first .ham-row is a whole work-item cluster (parent issue, child
PR, decision, notes: ~418px) and never fits the 397px left below the chrome,
so every dashboard PR fails mobile-shots at 375x667 regardless of its diff.

Keep the intent (chrome stays short, a row shows without scrolling) but
accept a first row taller than the remaining viewport when at least 120px
of it is visible. Ignore the scratch Chrome profile the harness creates.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
(cherry picked from commit bffcb8b)
hivecommons-hive Bot added a commit that referenced this pull request Nov 8, 2026
Rebased onto v5 so the branch carries the tracker-phone-chrome probe
from #17176. The sticky count line sat at the same top as .ham-cols
with a higher z-index and covered the column header while scrolling;
offset the column header by the line's tap height when it is shown.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
clubanderson added a commit that referenced this pull request Nov 8, 2026
…17189)

The tracker-phone-chrome acceptance added in #17176 asserts that a row is
fully visible at 375x667 with the section header at the top. The density
fixture's first .ham-row is a whole work-item cluster (parent issue, child
PR, decision, notes: ~418px) and never fits the 397px left below the chrome,
so every dashboard PR fails mobile-shots at 375x667 regardless of its diff.

Keep the intent (chrome stays short, a row shows without scrolling) but
accept a first row taller than the remaining viewport when at least 120px
of it is visible. Ignore the scratch Chrome profile the harness creates.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ dashboard: sticky compact filter bar for the Activity monitor on phones

1 participant