Repository navigation
✨ dashboard: sticky compact filter bar for the Activity monitor on phones - #17176
Conversation
…ones On a phone (.modal-sheet tier) the Activity monitor's 13-control toolbar and label chips are hidden; the sticky bar carries All / PRs / Issues, ⚠ Needs attention, 👤 Waiting on you (with count) and ⋯ Filters, which moves the full toolbar and label chips into a .hive-dialog.modal-sheet and returns them on close. The card body uses overflow: clip on phones so the sticky bar sticks to the viewport instead of being pushed over the first row. Desktop layout is unchanged. Adds the tracker-phone-chrome probe to the mobile-shots activity-density gate (390x844: chrome <= 160px, one row fully visible, sheet round-trip). Fixes #17159 Part of #17158 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 65aba58. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
The tracker-phone-chrome acceptance added in #17176 asserts that a row is fully visible at 375x667 with the section header at the top. The density fixture's first .ham-row is a whole work-item cluster (parent issue, child PR, decision, notes: ~418px) and never fits the 397px left below the chrome, so every dashboard PR fails mobile-shots at 375x667 regardless of its diff. Keep the intent (chrome stays short, a row shows without scrolling) but accept a first row taller than the remaining viewport when at least 120px of it is visible. Ignore the scratch Chrome profile the harness creates. Signed-off-by: Andrew Anderson <andy@clubanderson.com> (cherry picked from commit bffcb8b)
The tracker-phone-chrome acceptance added in #17176 asserts that a row is fully visible at 375x667 with the section header at the top. The density fixture's first .ham-row is a whole work-item cluster (parent issue, child PR, decision, notes: ~418px) and never fits the 397px left below the chrome, so every dashboard PR fails mobile-shots at 375x667 regardless of its diff. Keep the intent (chrome stays short, a row shows without scrolling) but accept a first row taller than the remaining viewport when at least 120px of it is visible. Ignore the scratch Chrome profile the harness creates. Signed-off-by: Andrew Anderson <andy@clubanderson.com> (cherry picked from commit bffcb8b)
Rebased onto v5 so the branch carries the tracker-phone-chrome probe from #17176. The sticky count line sat at the same top as .ham-cols with a higher z-index and covered the column header while scrolling; offset the column header by the line's tap height when it is shown. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…17189) The tracker-phone-chrome acceptance added in #17176 asserts that a row is fully visible at 375x667 with the section header at the top. The density fixture's first .ham-row is a whole work-item cluster (parent issue, child PR, decision, notes: ~418px) and never fits the 397px left below the chrome, so every dashboard PR fails mobile-shots at 375x667 regardless of its diff. Keep the intent (chrome stays short, a row shows without scrolling) but accept a first row taller than the remaining viewport when at least 120px of it is visible. Ignore the scratch Chrome profile the harness creates. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
What
On a phone (the
.modal-sheettier: ≤640px, or coarse pointer ≤820px) the Activity monitor's 13-control toolbar and label-chip row are no longer drawn above the list. The sticky bar carries a compact filter row instead — All / PRs / Issues · ⚠ Needs attention · 👤 Waiting on you (count) · ⋯ Filters — beside the Merged pill. ⋯ Filters opens a.hive-dialog.modal-sheetthat receives the existing toolbar and label-chip DOM (Repo / search / Since / Author / Decisions / Sort / Group / Per page / sound / labels) and returns it on close (Done, ✕, Esc, backdrop), so every render keeps syncing the same controls. Filters apply live and survive closing; the ⋯ badge counts the filters set in the sheet.The card body gets
overflow: clipon phones so the sticky bar sticks to the viewport instead of being pushed down over the first row by the body'soverflow: hiddenscroller.Desktop is untouched: 1280 DOM rects are identical before/after (the only new node is
display: none).Measured (390×844, fixture)
.ham-sticky+.ham-cols)Gate
src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.jswired into the mobile-shots activity-density state: on portrait phone viewports it asserts compact bar shown / toolbar hidden, chrome ≤ 160px, ≥ 1 row fully visible, sticky + cols ≤ 100px, sheet round-trip (toolbar + labels inside, controls inside viewport, 16px inputs, restored on close). Desktop/landscape return a skip marker. Passes locally at 390x844@3.TRUSTED_SCRIPTS_TREEre-pinned.Docs:
src/docs/dashboard-sections/activity-monitor.md(Filters section).Fixes #17159
Part of #17158
Screenshots