Skip to content

✨ Activity monitor: 44px tap targets, row tools in the header, kebab as a sheet on phones - #17193

Merged
clubanderson merged 1 commit into
v5from
am-mobile-tap-targets
Nov 8, 2026
Merged

clubanderson merged 1 commit into
v5from
am-mobile-tap-targets

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #17163
Part of #17158

What

In the dashboard's .modal-sheet phone tier (max-width: 640px, or coarse pointer ≤ 820px — the same query responsive.css already uses), the activity monitor:

  • remaps --tap-target → new --tap-target-touch (44px, base.css) for its subtree, so chips, selects, the search box, Merged / queue chips, label chips, grip / ? / ⚙ and the ⧉ ⛶ 📺 header tools all reach the Apple HIG / WCAG 2.5.5 floor via the existing token plumbing (tokens only, ADR-0018);
  • moves the per-row select checkbox and ⋯ kebab out of the hover-revealed 12px left gutter into the top-right corner of the row header — always visible, 44×44; the header reserves their width, and a phone-only min-width floor on .ham-title lets a squeezed title drop under the chips instead of wrapping word-per-word (375px fixture rows stay within the viewport — A's tracker-phone-chrome probe is green at 375/390/430);
  • opens the kebab menu as a .hive-dialog.modal-sheet (new stageTrackerOpenSheet helper over hiveWireDialog — Esc / ✕ / backdrop / focus trap for free; the same helper will host the Merged / queue popovers for ✨ dashboard: Activity monitor merged/queue popovers become a modal sheet on phones #17165) with ≥44px items. Same markup, roles and arrow-key model as the desktop popover.

Desktop (1280) does not match the query and is unchanged: harness geometry measurements and the small-control / font-size inventory at 1280 are byte-identical before/after.

Tightly coupled fix

stageTrackerTerminalView read _stageTrackerMergeState[...] while that map is still null (before its first fetch lands), so opening a PR row's ⋯ menu before the merge state arrived threw. This is what kept the kebab from opening in the mobile-shots fixture; it now reads null as "nothing merged yet".

Gate

New probe webstatic/testdata/tracker-phone-ergonomics.js, registered in dashboard-mobile-shots.mjs: at 390×844 asserts zero interactive controls under 44×44, row tools inside the row header and always visible, kebab hosted in .hive-dialog.modal-sheet with ≥44px items and clean close; other viewports report skipped. Exclusions, documented in the probe: inline text links (a.ham-ref, a.ham-pr-ref, prose anchors) which flow with their text, and the chevron-strip word cells (.ham-chevron-info / .ham-decision-trigger inside .ham-chevron-copy) whose height is the row-strip layout (#17162).

Local run of node src/scripts/dashboard-mobile-shots.mjs --viewport 390x844@3 --theme light with the CI density fixture: all probes green (tracker-phone-ergonomics → controls: 74, menu: {sheet: true, items: 8}). WebKit 390 inventory with a 26-row fixture: 104 → 0 controls under 44×44 outside the inline-link exclusion.

Screenshots (WebKit, 390×844)

Before / after attached below: rows + toolbar, and the kebab menu.

Before (390×844, WebKit) After (390×844, WebKit)
before: rows with 12px gutter controls and 23px selects after: 44px controls, select and kebab in the row header
before: anchored kebab popover with ~30px items after: kebab menu as a full-screen sheet with 44px items

Supersedes #17177 (its branch was deleted during a merge-conflict rebase; identical content rebased onto v5 after #17189).

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17180 ✨ dashboard: 12px text floor for the Activity monitor on phones CONFLICT .github/scripts/integration-governance.cjs
src/docs/dashboard-design-system.md
src/scripts/dashboard-mobile-shots.mjs
#17171 🐛 fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion same files src/pkg/dashboard/static/index.html
#17179 ✨ dashboard: attention-first Activity monitor ordering and count line on phones CONFLICT src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#17181 ✨ dashboard: Activity monitor merged and queue lists open as sheets on phones same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-merged.js
src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • mobile-shots

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
…as a sheet on phones

In the .modal-sheet phone tier the activity monitor remaps --tap-target to
a new --tap-target-touch (44px) token for its subtree, so chips, selects,
the search box, Merged / queue chips, label chips, grip / ? / ⚙ and the
⧉ ⛶ 📺 header tools all meet the coarse-pointer floor. The per-row select
checkbox and ⋯ kebab leave the hover-revealed left gutter for the top-right
corner of the row header, always visible and 44×44. The kebab menu opens
as a .hive-dialog.modal-sheet (stageTrackerOpenSheet, reused by the
Merged / queue popovers next) with tap-sized items.

stageTrackerTerminalView now reads the merge state null-safely: it is null
until its first fetch lands, and a PR row's menu could be opened before
then (this is what kept the kebab from opening in the mobile-shots
fixture).

Adds the tracker-phone-ergonomics probe to dashboard-mobile-shots.mjs: at
390×844 it asserts zero controls under 44×44 (inline text links and the
chevron-strip word cells excluded), row tools inside the row header, and
the kebab hosted in a modal sheet; other viewports report skipped so
desktop is a no-diff.

Fixes #17163
Part of #17158

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the am-mobile-tap-targets branch from 262edd9 to 7c958fc Compare November 8, 2026 03:29
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@clubanderson
clubanderson merged commit f0c865d into v5 Nov 8, 2026
82 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the am-mobile-tap-targets branch November 8, 2026 03:39
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ dashboard: Activity monitor tap targets meet --tap-target on phones

1 participant