Repository navigation
✨ Activity monitor: 44px tap targets, row tools in the header, kebab as a sheet on phones - #17193
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
…as a sheet on phones In the .modal-sheet phone tier the activity monitor remaps --tap-target to a new --tap-target-touch (44px) token for its subtree, so chips, selects, the search box, Merged / queue chips, label chips, grip / ? / ⚙ and the ⧉ ⛶ 📺 header tools all meet the coarse-pointer floor. The per-row select checkbox and ⋯ kebab leave the hover-revealed left gutter for the top-right corner of the row header, always visible and 44×44. The kebab menu opens as a .hive-dialog.modal-sheet (stageTrackerOpenSheet, reused by the Merged / queue popovers next) with tap-sized items. stageTrackerTerminalView now reads the merge state null-safely: it is null until its first fetch lands, and a PR row's menu could be opened before then (this is what kept the kebab from opening in the mobile-shots fixture). Adds the tracker-phone-ergonomics probe to dashboard-mobile-shots.mjs: at 390×844 it asserts zero controls under 44×44 (inline text links and the chevron-strip word cells excluded), row tools inside the row header, and the kebab hosted in a modal sheet; other viewports report skipped so desktop is a no-diff. Fixes #17163 Part of #17158 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
262edd9 to
7c958fc
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #17163
Part of #17158
What
In the dashboard's
.modal-sheetphone tier (max-width: 640px, or coarse pointer ≤ 820px — the same queryresponsive.cssalready uses), the activity monitor:--tap-target→ new--tap-target-touch(44px,base.css) for its subtree, so chips, selects, the search box, Merged / queue chips, label chips, grip / ? / ⚙ and the ⧉ ⛶ 📺 header tools all reach the Apple HIG / WCAG 2.5.5 floor via the existing token plumbing (tokens only, ADR-0018);min-widthfloor on.ham-titlelets a squeezed title drop under the chips instead of wrapping word-per-word (375px fixture rows stay within the viewport — A'stracker-phone-chromeprobe is green at 375/390/430);.hive-dialog.modal-sheet(newstageTrackerOpenSheethelper overhiveWireDialog— Esc / ✕ / backdrop / focus trap for free; the same helper will host the Merged / queue popovers for ✨ dashboard: Activity monitor merged/queue popovers become a modal sheet on phones #17165) with ≥44px items. Same markup, roles and arrow-key model as the desktop popover.Desktop (1280) does not match the query and is unchanged: harness geometry measurements and the small-control / font-size inventory at 1280 are byte-identical before/after.
Tightly coupled fix
stageTrackerTerminalViewread_stageTrackerMergeState[...]while that map is stillnull(before its first fetch lands), so opening a PR row's ⋯ menu before the merge state arrived threw. This is what kept the kebab from opening in the mobile-shots fixture; it now readsnullas "nothing merged yet".Gate
New probe
webstatic/testdata/tracker-phone-ergonomics.js, registered indashboard-mobile-shots.mjs: at 390×844 asserts zero interactive controls under 44×44, row tools inside the row header and always visible, kebab hosted in.hive-dialog.modal-sheetwith ≥44px items and clean close; other viewports reportskipped. Exclusions, documented in the probe: inline text links (a.ham-ref,a.ham-pr-ref, prose anchors) which flow with their text, and the chevron-strip word cells (.ham-chevron-info/.ham-decision-triggerinside.ham-chevron-copy) whose height is the row-strip layout (#17162).Local run of
node src/scripts/dashboard-mobile-shots.mjs --viewport 390x844@3 --theme lightwith the CI density fixture: all probes green (tracker-phone-ergonomics→controls: 74, menu: {sheet: true, items: 8}). WebKit 390 inventory with a 26-row fixture: 104 → 0 controls under 44×44 outside the inline-link exclusion.Screenshots (WebKit, 390×844)
Before / after attached below: rows + toolbar, and the kebab menu.
Supersedes #17177 (its branch was deleted during a merge-conflict rebase; identical content rebased onto v5 after #17189).