Skip to content

✨ dashboard: attention-first Activity monitor ordering and count line on phones - #17179

Merged
hivecommons-hive[bot] merged 11 commits into
v5from
scanner/fix-17162
Nov 8, 2026
Merged

hivecommons-hive[bot] merged 11 commits into
v5from
scanner/fix-17162

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

On a phone the rows that need a person sit hundreds of screen-heights down the list, and the Waiting on you chip is buried in the toolbar.

Phones now sort attention rows ahead of the stage column and show a sticky count line that toggles the existing Waiting on you filter. The preference is stored with the other tracker filter fields; desktop ordering and the toolbar are unchanged. static/index.html is regenerated from static-src and the hub's tracker-view copy is kept in step.

Closes #17162

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

Browser proof (Dashboard Mobile Shots, activity-density fixture)

Run 42453283880 (af3ea81d, the PR head) — artifact dashboard-mobile-shots:

  • 390×844@3 — 390x844@3-{light,dark}-activity-density.png / -viewport.png: attention row 🐛 dashboard: repo-card 💬 review pill is clipped by its fixed 1.65rem action slot (💬×N loses the count; v5.60.1) #9004 leads the list and the "⚠ 0 waiting on you · 3 need attention" line sits under the compact bar, inside the viewport at rest. tracker-phone-attention-first probe: {"phone":true,"rows":15,"attentionRows":1,"order":"A------------SS","countLine":"⚠ 0 waiting on you · 3 need attention","failures":[]} (light and dark).
  • Desktop (1024×1200, the harness's widest viewport) — 1024x1200@1-{light,dark}-activity-density-viewport.png: column-first order and toolbar unchanged; the probe returns the skip marker (no count line).

Images could not be embedded directly: the bot identity cannot use the user-attachments upload API.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17171 🐛 fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion same files src/docs/dashboard-sections/activity-monitor.md
src/pkg/dashboard/static-src/js/tracker-words-stage.js
src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green. b00736f: count line now uses stageTrackerWaitingOnYou(d).count (+fixture copy); nav_count_delta.test.js now loads stageTrackerIsPhoneSheet (fixes tests 31-33/35); v5 merged in, bundle regenerated.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 202830f54

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer (folded here because this head already carries its hive review):

Read head af3ea81 against the v5 tree (merge-base is current v5, so the earlier conflict is gone). The code looks correct to me; one earlier-requested change is still outstanding, and one earlier finding on this PR is now stale and should not hold it.

Stale finding — please disregard. The intent-alignment comment posted at this head actually reviewed 500e03f and says dashboard-mobile-shots.mjs is untouched and no probe was added. At af3ea81 both are present: the probe list at src/scripts/dashboard-mobile-shots.mjs:270 includes tracker-phone-attention-first, the 390×844 gate at :530-535 fails the run unless phone === true && attentionRows > 0, and the probe itself is src/pkg/dashboard/webstatic/testdata/tracker-phone-attention-first.js (order check :29-38, count line in viewport at rest :49-51, toggle wiring :55). The #17162 acceptance items that comment listed are met at this head.

Still outstanding (the one real blocker) — src/pkg/dashboard/static-src/js/tracker-filter-render.js:139. The count line still takes d.items.filter(it => it && it.waiting_on_you && !it.nested_under).length. stageTrackerWaitingOnYou(d) at tracker-waiting.js:28-35 is what the sidebar badge, topbar pill and both chips use; it prefers the server's waiting_on_human.count and only falls back to that predicate for older spokes. So the count line is the one surface that can disagree with the chip it toggles whenever the server block and the per-item flags diverge. stageTrackerWaitingOnYou(d).count || 0 here (and in src/scripts/fixtures/dashboard-activity-density.mjs:167) is the requested change from 60754ae; it is a two-line edit. Low severity — today the server computes the same thing — but it is why reviewDecision is still CHANGES_REQUESTED.

What I verified

  • tracker-filter.js:292-310: tierFirst only when opts.phone && f.attentionFirst && sort ∈ {furthest, waiting}, and it wraps the existing comparator (byTier(x, y) || ordered(x, y)); the single opts caller is tracker-filter-render.js:98. Desktop never passes opts, so its order is byte-for-byte unchanged. The Go test at stage_tracker_phone_attention_first_test.go:84-93 pins both orders.
  • .github/scripts/integration-governance.cjs:12: the new TRUSTED_SCRIPTS_TREE is bcab7434…, and git rev-parse pr17179:src/scripts is bcab7434… — the pin matches this branch's src/scripts tree, as the script's own error at :103 requires of any PR editing src/scripts. It is a re-pin, not a trust change.
  • tracker.css:1127-1132 is scoped to the same phone media query as the pill tier; .ham-attn-wrap:empty { display: none } covers the initial empty <div> (tracker.html:62) and setIfChanged(el, '').
  • src/docs/dashboard.md describes the behaviour at this head, including that attentionFirst has no toolbar control yet.

Dead rule (info) — tracker.css:1131 moves .ham-cols down under the count line, but the same media query already sets .ham-cols { display: none; } at tracker.css:946. It can never apply; drop it or leave it, nothing depends on it.

clubanderson your CHANGES_REQUESTED at 25f0d08 was the base-side mobile-shots failure and the rebase; both are done at this head, so once the :139 helper swap lands this should only need your re-review.

Review findings from adjudicator-4 (folded here because this head already carries its hive review):

Style re-review at c137106 (delta since af3ea81: 6 lines in src/docs/dashboard-sections/activity-monitor.md only).

The docs delta is clean. The three style findings from the previous head are unchanged in the code and still block from this perspective:

  1. Duplicated phone-tier helper — src/pkg/dashboard/static-src/js/tracker-filter.js:130-132 adds stageTrackerPhone() with the literal query '(max-width: 640px), ((pointer: coarse) and (max-width: 820px))'. src/pkg/dashboard/static-src/js/tracker-actions.js:817-819 already defines STAGE_TRACKER_SHEET_QUERY with the identical string and stageTrackerIsPhoneSheet(); the two will drift when the tier changes. Call the existing helper (or reuse the constant) instead.
  2. Hard-coded 1px — src/pkg/dashboard/static-src/css/tracker.css:1131 (+ 1px in the .ham-cols top offset) and :1132 (border-bottom: 1px solid var(--border)) bypass the --line-width token the rest of the sheet uses; the offset must also match the border so the token should drive both.
  3. Mis-indented comment — src/pkg/dashboard/static-src/js/tracker-filter-render.js:2 is flush-left while line 1 and the surrounding function are indented four spaces.

Previous findings status: [style] ×3 still present (above). Out of this perspective's lane but noted for the hive: [docs-currency] activity-monitor.md:128 — fixed by this delta; [docs-currency] tracker.html:30 tooltip — tooltip text unchanged, but the doc now states it describes the desktop rule; [intent-alignment] tracker-filter.js:90 held/draft sinking — code unchanged, behaviour now documented as intentional in the delta.

Review findings from adjudicator-2 (folded here because this head already carries its hive review):

Intent alignment (#17162) — reviewed head 500e03f.

The core change matches the issue: stageTrackerSort promotes the attention tier to the top-level group only when opts.phone && f.attentionFirst on the furthest/waiting sorts (static-src/js/tracker-filter.js:294,308-309), the count line is one button on the same hamFilter waitingOnYou toggle action as the toolbar chip (tracker-filter-render.js:5 vs static/index.html:8605, handler at :21690), its waiting count uses the same waiting_on_you && !nested_under filter as the Waiting-on-you badge, and the CSS is scoped to the .modal-sheet media query (tracker.css:1084).

Gap vs the issue's Acceptance/Verification (in-scope):

  • ✨ dashboard: Activity monitor puts 'waiting on you' rows first on phones #17162 requires extending the activity-density state in src/scripts/dashboard-mobile-shots.mjs with a 390×844 assertion ("every stageTrackerNeedsAttention row precedes every non-attention row, and the count line is inside the viewport at rest") and posting 390×844 + 1280 screenshots. Neither was done: dashboard-mobile-shots.mjs is untouched (probe list at :270 is still tracker-header-geometry … tracker-phone-ergonomics), no new probe fixture was added, and the PR body has no screenshots. The new Go test (stage_tracker_phone_attention_first_test.go:84-113) runs the comparator and the HTML string under node with window = {} — it cannot verify sticky placement, viewport presence, or the DOM wiring the acceptance names.
    Requested change: add a tracker-phone-attention-first.js probe beside the existing fixtures (register it in the probes array at dashboard-mobile-shots.mjs:270, required at 390x844@3 like tracker-phone-pill) that asserts row order and that #activity-monitor-attn-line is within innerHeight at rest, and attach the 390×844 + 1280 captures.

Advisory: attentionFirst is persisted (tracker-filter.js:157) but no control flips it; the issue only asks to store it, so this is fine to leave for a follow-up.

Review findings from adjudicator-3 (folded here because this head already carries its hive review):

Intent alignment (#17162) — reviewed head 500e03f.

The core change matches the issue: stageTrackerSort promotes the attention tier to the top-level group only when opts.phone && f.attentionFirst on the furthest/waiting sorts (static-src/js/tracker-filter.js:294,308-309), the count line is one button on the same hamFilter waitingOnYou toggle action as the toolbar chip (tracker-filter-render.js:5 vs static/index.html:8605, handler at :21690), its waiting count uses the same waiting_on_you && !nested_under filter as the Waiting-on-you badge, and the CSS is scoped to the .modal-sheet media query (tracker.css:1084).

Gap vs the issue's Acceptance/Verification (in-scope):

  • ✨ dashboard: Activity monitor puts 'waiting on you' rows first on phones #17162 requires extending the activity-density state in src/scripts/dashboard-mobile-shots.mjs with a 390×844 assertion ("every stageTrackerNeedsAttention row precedes every non-attention row, and the count line is inside the viewport at rest") and posting 390×844 + 1280 screenshots. Neither was done: dashboard-mobile-shots.mjs is untouched (probe list at :270 is still tracker-header-geometry … tracker-phone-ergonomics), no new probe fixture was added, and the PR body has no screenshots. The new Go test (stage_tracker_phone_attention_first_test.go:84-113) runs the comparator and the HTML string under node with window = {} — it cannot verify sticky placement, viewport presence, or the DOM wiring the acceptance names.
    Requested change: add a tracker-phone-attention-first.js probe beside the existing fixtures (register it in the probes array at dashboard-mobile-shots.mjs:270, required at 390x844@3 like tracker-phone-pill) that asserts row order and that #activity-monitor-attn-line is within innerHeight at rest, and attach the 390×844 + 1280 captures.

Advisory: attentionFirst is persisted (tracker-filter.js:157) but no control flips it; the issue only asks to store it, so this is fine to leave for a follow-up.

Review findings from adjudicator-5 (folded here because this head already carries its hive review):

docs-currency — delta re-review at 60754ae (previous head 761f142)

The delta is the origin/v5 merge (v5.192.0–v5.193.1: #17198 phone cards, #17170 KnowledgeAdviser) — no PR-authored change. static/index.html at head contains every line of the six touched static-src files, so the regenerated bundle is in step after the merge.

Both prior docs findings are still present (nothing in src/docs/ changed on the PR's side):

  1. src/docs/dashboard-sections/activity-monitor.md:128-130 — the canonical Activity monitor doc still says "Within each column, attention rows precede plain rows…" and quotes the Sort hint "Attention-first within each column", with no mention of the phone-only top-level attention group or the sticky count line that dashboard.md:615 now documents. Line 126 also already documents a phone compact filter row with a 👤 Waiting on you (with its count) chip; the doc needs to say how the new count line (tracker-filter-render.js stageTrackerAttentionLineHtml) relates to that chip. Add a short phone paragraph here, mirroring dashboard.md:615.

  2. src/docs/dashboard.md:613 — the toolbar enumeration still lists only "a Needs attention toggle"; the new phone paragraph at :615 refers to "the Waiting on you filter" that this section never introduces. Name the Waiting on you chip in the toolbar list (one clause).

Review findings from adjudicator (folded here because this head already carries its hive review):

Correctness re-review at ecc2c488 (delta since 400538ae)

The delta is only Merge remote-tracking branch 'origin/v5' — it brings in #17180 (12px text floor) and #17123 (CLI memory drain). The overlapping hunks in static-src/css/tracker.css:992, static-src/css/responsive.css:44, static/index.html:2335,6021, webstatic/style_ratchet_test.go:30 and scripts/dashboard-mobile-shots.mjs:270 are byte-for-byte what landed on v5; no PR-owned file (tracker-filter-render.js, tracker-filter.js, tracker-phone-attention-first.js) changed. Nothing new to report from the merge.

Previous findings

  • Still present (in-scope): src/pkg/dashboard/webstatic/testdata/tracker-phone-attention-first.js:9-10,55 — the probe is unchanged. It asserts position === 'sticky' on the wrap and that the line is in the viewport at rest, but explicitly declines to check that the line stays pinned while the list scrolls ("not asserted here"). The PR body still promises a sticky count line. Concrete fix: after scrollIntoView, scroll the window by a few .ham-row heights, await frame(), and assert wrap.getBoundingClientRect().top ≈ the computed top of .ham-attn-wrap (tracker.css:1128) within tolerance — same pattern used for .ham-sticky.
  • Style findings (tracker-filter-render.js:1, :139) are also unchanged in this delta; left to the style perspective.
Evidence bundle `#17179b00736f` sha256:9386c55e8771be5ba3890793bd0b462db044c6ab5af70ee35ba004d6f5bffe4e — download from the dashboard or `hivectl review evidence #17179`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

The only red check, mobile-shots at 375×667 tracker-phone-chrome (rowsFullyVisible: 0), is a shared baseline failure every dashboard PR hits since #17176 merged — #17176's own run, #17181 and the #17180 branch report the identical measurement, and this PR's count line is not rendered in that fixture. The probe fix is #17185; once it lands, a base merge clears it here. No PR-local change needed.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Shared-CI incident for the 375×667 tracker-phone-chrome failure: #17186.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson clubanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile-shots fails here only on:

375x667@2 light tracker-phone-chrome; 375x667@2 dark tracker-phone-chrome
failures: ["at least one row is fully visible with the section header at the top of the viewport"]

This is not caused by this PR: the probe landed in #17176 and fails on plain v5 (the density fixture's first .ham-row cluster is ~418px, taller than the 397px left below the chrome at 375x667). The fix is #17189. This branch is also based before #17176 (merge-base d28488017), so please rebase on v5 once #17189 merges and re-check; also note #17177 and #17183 touch tracker.css for the same phone Activity-monitor rows, so expect to re-resolve the sticky-bar/phone tier hunks on rebase.

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from clubanderson. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Rebased onto v5 (now carries the tracker-phone-chrome probe from #17176) and pushed one follow-up: the phone count line stuck at the same top as .ham-cols and would cover the column header while scrolling, so the column header now offsets by the line's tap height when the line is shown.

The mobile-shots failure here is the shared v5 baseline incident, not this branch: the artifact shows chrome: 109px (≤160) and sticky+cols: 67px (≤100) passing, with only rowsFullyVisible: 0 failing at 375×667 — the same measurement pure origin/v5 and #17176's own run produce because the density fixture's first row (~418px) is taller than the space left below the chrome. #17185 / #17189 repair the probe; once either lands, this PR's merge-ref run should go green without further changes.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 9caebfde4

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
…ure edits

src/scripts/dashboard-mobile-shots.mjs and fixtures/dashboard-activity-density.mjs
changed in this PR; pin to git rev-parse HEAD:src/scripts of the merged tree.

Hive-Fix-Attempt: 1/6
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 8, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent alignment (#17162) — reviewed head 500e03f.

The core change matches the issue: stageTrackerSort promotes the attention tier to the top-level group only when opts.phone && f.attentionFirst on the furthest/waiting sorts (static-src/js/tracker-filter.js:294,308-309), the count line is one button on the same hamFilter waitingOnYou toggle action as the toolbar chip (tracker-filter-render.js:5 vs static/index.html:8605, handler at :21690), its waiting count uses the same waiting_on_you && !nested_under filter as the Waiting-on-you badge, and the CSS is scoped to the .modal-sheet media query (tracker.css:1084).

Gap vs the issue's Acceptance/Verification (in-scope):

  • #17162 requires extending the activity-density state in src/scripts/dashboard-mobile-shots.mjs with a 390×844 assertion ("every stageTrackerNeedsAttention row precedes every non-attention row, and the count line is inside the viewport at rest") and posting 390×844 + 1280 screenshots. Neither was done: dashboard-mobile-shots.mjs is untouched (probe list at :270 is still tracker-header-geometry … tracker-phone-ergonomics), no new probe fixture was added, and the PR body has no screenshots. The new Go test (stage_tracker_phone_attention_first_test.go:84-113) runs the comparator and the HTML string under node with window = {} — it cannot verify sticky placement, viewport presence, or the DOM wiring the acceptance names.
    Requested change: add a tracker-phone-attention-first.js probe beside the existing fixtures (register it in the probes array at dashboard-mobile-shots.mjs:270, required at 390x844@3 like tracker-phone-pill) that asserts row order and that #activity-monitor-attn-line is within innerHeight at rest, and attach the 390×844 + 1280 captures.

Advisory: attentionFirst is persisted (tracker-filter.js:157) but no control flips it; the issue only asks to store it, so this is fine to leave for a follow-up.

— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 8, 2026
…tivity-monitor.md

The section doc still described column-first ordering on every device and
omitted the sticky count line that the phone tier now draws; align it with
the Phones paragraph in dashboard.md.

Hive-Fix-Attempt: 2/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 8, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read head c137106 against the v5 tree. The new commit is docs-only (src/docs/dashboard-sections/activity-monitor.md, 3 lines) and the text is accurate: stageTrackerSort promotes the tier only when opts.phone && f.attentionFirst && sort ∈ {furthest, waiting} (static-src/js/tracker-filter.js:294,309), so Newest/Number are indeed unchanged, and .ham-cols is hidden in the phone tier (tracker.css:946), so "bar → count line → rows" is the real sticky stack. Docs are now in step with dashboard.md:615. Branch is MERGEABLE again.

Still outstanding — the change requested at 60754ae is not in this head

  • static-src/js/tracker-filter-render.js:139 still computes the count as d.items.filter(it => it && it.waiting_on_you && !it.nested_under).length rather than stageTrackerWaitingOnYou(d).count, so the count line remains the one surface that bypasses the server's waiting_on_human block that the badge, pill and chips use. Same copy at src/scripts/fixtures/dashboard-activity-density.mjs:167.
  • tracker-filter-render.js:1-2 comment indentation is unchanged.

Both are small; once they land this looks ready to me. I am keeping the earlier verdict rather than opening a new one.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
…e --line-width token on the phone count line

Review follow-ups for #17179: stageTrackerPhone() now delegates to
stageTrackerIsPhoneSheet() instead of repeating its media-query literal,
the .ham-attn-line border and the matching .ham-cols sticky offset both
derive from --line-width, and the misindented comment line in
tracker-filter-render.js is aligned with the file. The node fixture test
pulls in the helper the function now depends on; static/index.html is
regenerated.

Hive-Fix-Attempt: 3/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
hivecommons-hive Bot and others added 2 commits November 8, 2026 01:57
…r tests

The phone count line (renderer and activity-density fixture) now takes its waiting count from stageTrackerWaitingOnYou(d).count, the same server waiting_on_human block the badge, pill and chips use. nav_count_delta.test.js loads stageTrackerIsPhoneSheet, which stageTrackerPhone now delegates to (fixes ReferenceError in tests 31-33, 35). Re-pins TRUSTED_SCRIPTS_TREE for the fixture edit; static/index.html regenerated; merges origin/v5.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read head b00736f against the v5 tree (not just the diff). Looks correct to me; nothing here that I would block on.

What I verified

  • tracker-filter.js:293-312 — tierFirst is only true for opts.phone && f.attentionFirst && sort ∈ {furthest, waiting}; the wrapped comparator is byTier(x, y) || ordered(x, y), and stageTrackerAttentionTier (tracker-filter.js:88-92) returns sunk > normal > attention, so hold/draft/closed-issue rows still sink last on a phone. The only caller passing opts is tracker-filter-render.js:98; desktop callers never see the tier promoted.
  • tracker-filter-render.js:138-139 — the count line now takes stageTrackerWaitingOnYou(d).count, which addresses the earlier style note; attentionAll is defined at line 127 of the same function before it is used. The button's data-action="hamFilter" data-arg0="waitingOnYou" data-arg1="toggle" is the same tuple as the existing chips in tracker.html:28/52, and tracker-filter-state.js:213 handles 'toggle' for waitingOnYou.
  • stageTrackerPhone → stageTrackerIsPhoneSheet (tracker-actions.js:817-820) guards typeof window/matchMedia, so the node-driven Go test and nav_count_delta.test.js (which now loads it) can evaluate it without a DOM.
  • tracker.css:1123-1133 — the new rules sit at the top level of the stylesheet (not nested in an earlier @media); .ham-attn-wrap:empty { display:none } matches the '' the renderer emits when both counts are zero, and the ~ #activity-monitor-panel .ham-cols offset adds the line's height to the existing .ham-cols sticky top (tracker.css:97).
  • .github/scripts/integration-governance.cjs:12 — the TRUSTED_SCRIPTS_TREE bump looks out of scope for a dashboard PR but is required by the repo's own rule (integration-governance.cjs:102-103, integration-governance.test.cjs:71-75): this PR edits src/scripts/, and git rev-parse <head>:src/scripts is 808dc52204d119b6840b3b90bc788fd25a89ed0b, which is exactly the new literal.
  • trackerview/tracker-view.js:13,25 mirrors the attentionFirst default and normalisation, so the hub copy stays in step.

Status vs. the open change request. @clubanderson's request was to rebase onto v5 once #17189 landed; the branch has since merged origin/v5 (60754ae, ecc2c48, 96174b6) and GitHub reports it mergeable. mobile-shots was still running at this head when I read it, so the probe result is the one thing left for CI to say.

One note, not a defect. stageTrackerPhone() is sampled at render time and there is no resize listener for the phone tier (the only tracker resize hook is tracker-display.js:134, TV mode only). Rotating or resizing across the 640/820px boundary will re-flow the CSS at once but the row order and count line only update on the next render (poll or filter change). Fine for a phone, which rarely crosses it; mentioning so nobody files it later as a mystery.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 8, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit d8e643d into v5 Nov 8, 2026
89 of 92 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-17162 branch November 8, 2026 07:12
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ dashboard: Activity monitor puts 'waiting on you' rows first on phones

1 participant