Skip to content

🐛 fix(dashboard): hide preparation train header for a lone ticket - #17188

Merged
clubanderson merged 2 commits into
v5from
fix/prep-train-single-ticket-header
Nov 8, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/prep-train-single-ticket-header

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #17187

A single base-preparation ticket is the update-branch lock holder, not a train. After its refresh moves the head the ticket is unverified, so the Activity Monitor read Preparation train · 0 confirmed PRs · recorded front: #17151 above one row.

  • tracker-preparation.js: new stageTrackerPreparationHeaderShown — the header (inline, nested and off-page "missing" variants) is drawn only when ≥2 tickets are recorded for the base; unavailable headers are unchanged. Row rail and the owner/waiting · verified/unverified comment are unchanged.
  • Test in stage_tracker_preparation_visual.test.js for the 🐛 fix(automerge): isolate repos GitHub refuses to search in contributor auto-promotion #17151 shape (lone unverified owner, root and nested) and that a second ticket brings the header back.
  • Docs: activity-monitor.md, dashboard.md; changelog fragment.

A single base-preparation ticket is the update-branch lock holder, not a
train. After its refresh moves the head the ticket is unverified, so the
header read 'Preparation train · 0 confirmed PRs · recorded front: #N'
above one row (hive #17151). Draw the header only when two or more
tickets are recorded; the row comment keeps the owner/unverified state.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17177 ✨ Activity monitor: 44px tap targets, row tools in the header, kebab as a sheet on phones CONFLICT .github/scripts/integration-governance.cjs
#17183 ✨ dashboard: progress pill replaces the chevron strip on phones CONFLICT .github/scripts/integration-governance.cjs
#17180 ✨ dashboard: 12px text floor for the Activity monitor on phones CONFLICT .github/scripts/integration-governance.cjs
#17179 ✨ dashboard: attention-first Activity monitor ordering and count line on phones same files src/docs/dashboard.md
src/pkg/dashboard/static/index.html
#17171 🐛 fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion same files src/docs/dashboard-sections/activity-monitor.md
src/pkg/dashboard/static/index.html
#17181 ✨ dashboard: Activity monitor merged and queue lists open as sheets on phones same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • mobile-shots

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

…eparation ticket

Re-pin TRUSTED_SCRIPTS_TREE for the fixture change.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@clubanderson
clubanderson merged commit 3d2a849 into v5 Nov 8, 2026
82 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/prep-train-single-ticket-header branch November 8, 2026 03:08
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Activity Monitor shows a "Preparation train · 0 confirmed PRs" header over a single refreshed ticket

1 participant