Repository navigation
✨ dashboard: card-per-row Activity monitor layout on phones - #17198
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Style / maintainability review (read at head 292ff1c; diff plus tracker.css, tracker-row-strip.js, integration-governance.cjs, and the existing #17160/#17163 phone blocks). Nothing blocking; two cascade/duplication notes the author may want to fold in.
1. Card tier is placed before the block it overrides, so it relies on a specificity hack — src/pkg/dashboard/static-src/css/tracker.css:980
The new card block (lines 971–1002) sits ahead of the #17163 tap-target block (1124–1145), whose #activity-monitor-section .ham-row > .ham-row-head { … min-height: var(--tap-target); } (line 1138) has the same specificity and later source order. The card block only wins because of the doubled .ham-row-head.ham-row-head, and the block comment (971–982) never says that's why the class is repeated. The test at stage_tracker_activity.test.js:673 then pins the hack. Preferred fix: move the card @media block below the #17163 block (phone tiers then override in reading order, like #17160 → #17163 already do), drop the doubled class, and adjust the regex at :673. If you'd rather keep placement, at least name the reason:
/* `.ham-row-head.ham-row-head` doubles the class so this tier beats the
later #17163 rule that gives the head `min-height: var(--tap-target)`. */
#activity-monitor-section .ham-row > .ham-row-head.ham-row-head, #activity-monitor-section .ham-sub > .ham-row-head.ham-row-head { display: flex; flex-wrap: wrap; align-items: baseline; column-gap: var(--sp-2); row-gap: var(--sp-1); min-height: 0; line-height: var(--lh-control); }
2. Acceptance thresholds live in two places — src/scripts/dashboard-mobile-shots.mjs:279-280, 527
CARD_MAX_MEDIAN_ROW_PX = 96 / CARD_MIN_ROWS_IN_VIEW = 6 duplicate MAX_MEDIAN_ROW_HEIGHT / MIN_ROWS_IN_VIEW in tracker-phone-card.js:12-13, and the probe already throws when either is missed (tracker-phone-card.js:78), so result.ok is false before the .mjs re-check runs. The neighbouring pill gate (:520) only asserts shape (phone === true && pills > 0). Matching that keeps one source of truth:
if (probe.name === 'tracker-phone-card' && vp.name === PILL_REQUIRED_VIEWPORT && !(result.ok && result.result && result.result.phone === true && result.result.rows > 0)) {
activityFailures.push(vp.name + ' ' + theme + ' card rows must pass the tracker-phone-card acceptance (median ≤ 96px, ≥ 6 rows in view) at 390x844');
}
(and drop the two constants at 279–280).
Checked and fine: static/index.html mirrors static-src per manifest.txt; the TRUSTED_SCRIPTS_TREE re-pin (integration-governance.cjs:12) is required because the PR edits src/scripts and matches HEAD:src/scripts (066d4e1e…); the card tier uses the same media query and tokens-only rule as #17160/#17163.
— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Docs-currency review (head 292ff1c). Two small places where the text drifts from what the CSS does; neither blocks.
Advisory: Review findings from Intent-alignment review at head Needs-human note is not actually one-line on the card (low, in-scope) (If you'd rather not clamp it, drop the "to one" claim from the comment at Advisory: the "≥ 6 rows inside the viewport once scrolled past the header" check is measured as the densest consecutive window anywhere in the list ( @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Correctness pass at 292ff1c — read the diff plus Stacked 44px hit areas can steal each other's taps ( (the ergonomics probe would then read ~30px for each — it would need to accept a one-sided pad, so this is a judgement call, not a blocker). Checked and fine: Review findings from Intent-alignment, delta re-review at 6532b1c (vs ebcee57, judged against #17161). Previous notes: the One gap between the issue/comments and the CSS (low): #17161 proposes folding the needs-human reason into "the pill tint plus a one-line amber note", and (and the same line in Minor: Review findings from HUMAN DECISION NEEDED — Security delta re-review of Still present (in-scope, requires a human): Note: #17180 (open) pins Clean in the delta: Previous findings at this head: correctness "mergeability stale" — no longer applies (GitHub now reports MERGEABLE); intent "pin conflict with #17180" — still present (see above); security "re-pin on a trust surface" — still present with a new pin value that now matches the head tree. Review findings from Correctness re-review at 6532b1c (delta from ebcee57). Prior correctness note (index.html / stale mergeability) is resolved: GitHub reports One advisory, in scope for #17161 ("a one-line amber note"): Needs-human note is not clamped on phones, but the code says it is. .ham-row > .ham-current-stage, .ham-sub > .ham-current-stage { margin: 0; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
+ /* The needs-human reason keeps one line too; the pill sheet carries it in full. */
+ .ham-row > .ham-human-context > span, .ham-sub > .ham-human-context > span { min-width: 0; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
} |
292ff1c to
ebcee57
Compare
Phone tier only (#17161): row tools move into the card header, the head is one inline run clamped to two lines (three with an issue title plus PR ref), chips and the lead action render inline, the "no linked issue" placeholder is dropped and the current-stage caption keeps its lead clause on one line. The pill sheet carries the full title and needs-human note. New tracker-phone-card probe asserts median .ham-row ≤ 96px and ≥ 6 rows per viewport with the density fixture at 390x844. 1280 markup and geometry unchanged. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…e heights Signed-off-by: Andrew Anderson <andy@clubanderson.com>
ebcee57 to
6532b1c
Compare
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm the TRUSTED_SCRIPTS_TREE re-pin in .github/scripts/integration-governance.cjs:12 (6067449a → 066d4e1e); it equals git rev-parse ebcee57:src/scripts and the src/scripts delta is one probe name plus the card thresholds in dashboard-mobile-shots.mjs.
Decision needed: @clubanderson should confirm the TRUSTED_SCRIPTS_TREE re-pin in .github/scripts/integration-governance.cjs:12 (6067449a → 066d4e1e) — it equals git rev-parse ebcee57:src/scripts, and the src/scripts delta is one probe name plus the two card thresholds in dashboard-mobile-shots.mjs:270,279-280,525-529.
Read at head ebcee57 against v5. The code looks correct to me; routing only because .github/scripts is a trust surface. Two practical notes below.
What I verified
tracker-row-strip.js:668-674— the sheet's extra text comes from selectors that match the real markup::scope > .ham-human-contextis a direct child of.ham-row(tracker-row-render.js:180emits${humanNote}between the strip row and.ham-current-stage), and both note shapes are handled —<p class="cue-event ham-human-context"><span class="cue-event-text">(tracker-motion.js:393) and the fallback<div class="cue-event ham-human-context"><span>(tracker-human-attention.js:131)..ham-pr-titleand.ham-no-issue-texist intracker-row.js. Everything goes throughesc().tracker.css:1006— the new hit-area pseudos are.ham-repo-chip::afterand.ham-lead-act::before; neither was in use (.ham-lead-act::afterat:899carries the▸glyph and is untouched).tracker.css:954— the pill's::beforeinset grows by--sp-1on each side; only enlarges the tap target.tracker-phone-ergonomics.js:38-49— this branch is based on7f604c2(#17199), so it extends the layout-size/only-growshitRectrather than fighting it;outonly advances when both dimensions are ≥ the current best.:has()is already used five times intracker.css, so no new browser floor.
Merge state — GitHub shows CONFLICTING, but git merge-tree --write-tree origin/v5@09cbdaa ebcee57 merges cleanly (exit 0, no conflicted paths). Likely a stale mergeability cache; worth a refresh before anyone rebases for it.
Sequencing — #17180 also re-pins TRUSTED_SCRIPTS_TREE, to c0197bc4…. Whichever of the two lands second fails integration-governance.test.cjs:71 until it re-pins against the merged src/scripts.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
…ext floor After #17198 (card-per-row Activity monitor layout) merged into v5, the tracker-phone-card probe measured a median .ham-row height of 97px against the 96px cap once combined with this PR's 12px text floor. Trim the phone-tier .ham-row vertical padding by 1px top and bottom (2px per card); every phone font-size stays at or above 12px. Regenerated static/index.html. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
* ✨ dashboard: 12px text floor for the Activity monitor on phones Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> * 🔧 governance: re-pin TRUSTED_SCRIPTS_TREE for dashboard-mobile-shots text-floor probe Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * 🐛 fix(dashboard): the Merged odometer digits honour the 12px phone text floor --ham-odo-digit is declared on :root as var(--fs-xs), so it is resolved there and the #activity-monitor-section --fs-xs override never reaches the .ham-merged-n digits (10.88px in the text-floor probe). Override the token itself in the same phone tier. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Hive-Fix-Attempt: 1/6 * 🐛 dashboard: keep phone card rows at the 96px median under the 12px text floor After #17198 (card-per-row Activity monitor layout) merged into v5, the tracker-phone-card probe measured a median .ham-row height of 97px against the 96px cap once combined with this PR's 12px text floor. Trim the phone-tier .ham-row vertical padding by 1px top and bottom (2px per card); every phone font-size stays at or above 12px. Regenerated static/index.html. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * 🐛 dashboard: phone card row padding via --sp-3 token, ratchet rawColors 134 The 1px trim landed as calc(var(--sp-4) - 1px), which carries a raw px literal: the card-tier tokens-only assertion in stage_tracker_activity.test.js and TestStyleRatchet's raw-padding count both rejected it. --sp-3 (6px) keeps every card at or under the 96px median cap without a literal. The ratchet also reports this branch at 134 raw colors, one below the operator baseline, so the baseline follows it down. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes #17161
Part of #17158
On phones (
max-width: 640px/ coarse pointer ≤ 820px) each Activity monitor row renders as a ~90px card:#ref+ title clamped to two lines; the covering PR on one line below when an issue row names one (a PR-only row's PR text hangs beside its icon and chip); badges / lead action wrap onto their own line, in which case the title drops to one line so the card height stays put. The muted no linked issue placeholder and the linked-issue icon are not drawn.ham-current-stage) is one ellipsised line.::after/::before; the pill's::beforeinset gainsvar(--sp-1)so a 21px animated pill still measures ≥ 44.Acceptance: new probe
tracker-phone-card.js(wired intodashboard-mobile-shots.mjs, asserted at 390×844) — median.ham-rowin the density fixture ≤ 96px (92 locally), ≥ 6 rows per screen (9, densest consecutive window since the fixture opens with tall nested groups), no title wider than its container, no sideways scroll, clamped head → sheet title matches.tracker-phone-ergonomics.js(#17195) learns to count::afterhit areas as well as::before, so the inline chips pass its 44×44 floor. Desktop:.ham-cols, strips and.ham-anim-layergeometry at 1280 are byte-identical (measured via the probe JSON; only the time-dependent "since" text differs). Node tests + 390/375/1440 gates green locally; CSS is tokens-only.Deliberate omissions: no markup changes (Go tests assert exact row HTML), so the layout is CSS (
display: contentswrappers) plus additive JS in the sheet; the toolbar/filter/order code (agent A) and tap-target/font code (agent C) are untouched beyond the probe extension above.