Repository navigation
✨ Activity monitor: 44px tap targets, row tools in the header, kebab as a sheet on phones - #17177
clubanderson wants to merge 4 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from This PR commits a Chrome browser profile (499 files under How it got there: Consequence: the cookie / login / session SQLite databases are binary, so I cannot tell from the diff whether they hold a live GitHub or dashboard session from the local run. That is an open question for Suggested fix: drop On the code itself, read against
I have not changed or closed anything; flagging for the author / a maintainer to strip the profile before this is considered further. |
d8d94b4 to
bffd24f
Compare
bffd24f to
00ff8e5
Compare
|
The 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
…as a sheet on phones In the .modal-sheet phone tier the activity monitor remaps --tap-target to a new --tap-target-touch (44px) token for its subtree, so chips, selects, the search box, Merged / queue chips, label chips, grip / ? / ⚙ and the ⧉ ⛶ 📺 header tools all meet the coarse-pointer floor. The per-row select checkbox and ⋯ kebab leave the hover-revealed left gutter for the top-right corner of the row header, always visible and 44×44. The kebab menu opens as a .hive-dialog.modal-sheet (stageTrackerOpenSheet, reused by the Merged / queue popovers next) with tap-sized items. stageTrackerTerminalView now reads the merge state null-safely: it is null until its first fetch lands, and a PR row's menu could be opened before then (this is what kept the kebab from opening in the mobile-shots fixture). Adds the tracker-phone-ergonomics probe to dashboard-mobile-shots.mjs: at 390×844 it asserts zero controls under 44×44 (inline text links and the chevron-strip word cells excluded), row tools inside the row header, and the kebab hosted in a modal sheet; other viewports report skipped so desktop is a no-diff. Fixes #17163 Part of #17158 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
The tracker-phone-chrome acceptance added in #17176 asserts that a row is fully visible at 375x667 with the section header at the top. The density fixture's first .ham-row is a whole work-item cluster (parent issue, child PR, decision, notes: ~418px) and never fits the 397px left below the chrome, so every dashboard PR fails mobile-shots at 375x667 regardless of its diff. Keep the intent (chrome stays short, a row shows without scrolling) but accept a first row taller than the remaining viewport when at least 120px of it is visible. Ignore the scratch Chrome profile the harness creates. Signed-off-by: Andrew Anderson <andy@clubanderson.com> (cherry picked from commit bffcb8b)
.chrome-dashboard-mobile-shots/ is the headless-Chrome profile the mobile-shots harness creates; it is now gitignored. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
00ff8e5 to
3c434de
Compare
…ueeze it on phones With the two 44px row tools reserved in the header, a narrow phone (375px) left the title cell ~30px wide and wrapped it word-per-word, pushing the first fixture row past the viewport. A phone-only min-width floor on .ham-title makes it drop under the chips instead. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Blocking: this PR commits a Chrome user-data profile (~500 files) alongside the change.
Of the 509 files in this PR, 499 are under .chrome-dashboard-mobile-shots/ — the --user-data-dir that src/scripts/dashboard-mobile-shots.mjs:48 creates at process.cwd() (PROFILE_DIR = path.join(process.cwd(), '.chrome-dashboard-mobile-shots')). That directory is not in .gitignore on v5, so a git add -A after running the shots gate picked it up. It includes binary SQLite stores that should never be in a repository regardless of what they currently contain: Default/Cookies, Default/Login Data, Default/Login Data For Account, Default/History, Default/Web Data, Default/Secure Preferences, Default/Trust Tokens, plus Default/Extensions/** and Default/Web Applications/** (≈240 files). The profile was pointed at a live dashboard, so the cookie/session DBs are plausibly populated — a maintainer should treat this as a potential credential leak and consider rotating any dashboard session it may hold, not just dropping the files.
Suggested fix (tightly coupled, so it belongs in this PR): git rm -r --cached .chrome-dashboard-mobile-shots, and add .chrome-dashboard-mobile-shots/ to .gitignore so the shots script cannot do this to the next contributor. If the cookie DB turns out to hold a real session, the branch history should be rewritten rather than fixed forward.
The actual change (10 files) reads correctly to me.
tracker-actions.js: the sheet path handsstageTrackerCloseMenu(true)tohiveWireDialogasresolve, andstageTrackerCloseMenuin turn callshost.hiveDialogClose(). I checked both ends for re-entry:stageTrackerCloseMenunulls_stageTrackerMenubefore anything else (tracker-actions.js:801-804on v5) andhiveWireDialog'scloseis guarded bydone(tooltips-dialogs.js:429-437), so Esc from either keydown listener closes once. Dropping thepointerdown/resize/scrollaway-listeners in sheet mode is right — the backdrop click is the dismissal there.tracker-merged.js:905:const merged = _stageTrackerMergeState || {}— confirmed_stageTrackerMergeStatestartsnulluntil the first fetch, so the pre-fetch kebab open did throw on_stageTrackerMergeState[rowKey]. Good fix..github/scripts/integration-governance.cjs: theTRUSTED_SCRIPTS_TREEbump is the mechanical hash update required when that file changes (adds thetracker-phone-ergonomicsprobe). #17180 and #17183 bump the same literal to different values, so whichever of the three lands second will need to re-pin.
Coordination note, not a defect: the PR body says stageTrackerOpenSheet "will host the Merged / queue popovers for #17165", but #17181 (open, same epic) already implements #17165 with its own hiveWireDialog sheets in tracker-merged.js / tracker-queue.js and also edits tracker.css. Both can't merge cleanly as-is; one should rebase onto the other and share the helper.
I have not approved or closed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
stageTrackerMergedPopDraw/stageTrackerQueuePopDraw ran a document-wide querySelector on every draw tick, even with the popover hidden on desktop, and the Node harness (stage_tracker_cues_test.go) stubs document without querySelector, failing TestStageTrackerCelebrateNode, OdometerAfterBeeNode, FlightTargetNode and MergeSessionNode. Open sheets are now registered in _stageTrackerPopSheets by stageTrackerPopSheetOpen and dropped by the hiveWireDialog resolve callback; stageTrackerPopSheet reads that map, and both draw functions early-return when the popover is hidden and no sheet is open. The querySelector tolerance shim is no longer needed. #17177 (stageTrackerOpenSheet) is closed unmerged, so there is nothing to rebase onto. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…n phones (#17181) * ✨ dashboard: Activity monitor merged and queue lists open as sheets on phones Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> * 🐛 test(dashboard): celebrate node bundle carries the pop-sheet helpers stageTrackerMergedPopDraw now consults stageTrackerPopSheet, so every node test built on stageTrackerCelebrateJS threw ReferenceError before reaching its assertions. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * 🐛 dashboard: pop-sheet lookup tolerates DOM stubs without querySelector stageTrackerPopSheet called document.querySelector unconditionally, which broke the Go-driven node harness (stage_tracker_cues_test.go) whose document stub has no querySelector, failing TestStageTrackerOdometerNode and the merged-chip tests. Also rebased onto v5 to pick up the phone-chrome probe fix (#17189) for mobile-shots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * 🐛 dashboard: pop-sheet draw ticks consult state, not the DOM stageTrackerMergedPopDraw/stageTrackerQueuePopDraw ran a document-wide querySelector on every draw tick, even with the popover hidden on desktop, and the Node harness (stage_tracker_cues_test.go) stubs document without querySelector, failing TestStageTrackerCelebrateNode, OdometerAfterBeeNode, FlightTargetNode and MergeSessionNode. Open sheets are now registered in _stageTrackerPopSheets by stageTrackerPopSheetOpen and dropped by the hiveWireDialog resolve callback; stageTrackerPopSheet reads that map, and both draw functions early-return when the popover is hidden and no sheet is open. The querySelector tolerance shim is no longer needed. #17177 (stageTrackerOpenSheet) is closed unmerged, so there is nothing to rebase onto. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes #17163
Part of #17158
What
In the dashboard's
.modal-sheetphone tier (max-width: 640px, or coarse pointer ≤ 820px — the same queryresponsive.cssalready uses), the activity monitor:--tap-target→ new--tap-target-touch(44px,base.css) for its subtree, so chips, selects, the search box, Merged / queue chips, label chips, grip / ? / ⚙ and the ⧉ ⛶ 📺 header tools all reach the Apple HIG / WCAG 2.5.5 floor via the existing token plumbing (tokens only, ADR-0018);min-widthfloor on.ham-titlelets a squeezed title drop under the chips instead of wrapping word-per-word (375px fixture rows stay within the viewport — A'stracker-phone-chromeprobe is green at 375/390/430);.hive-dialog.modal-sheet(newstageTrackerOpenSheethelper overhiveWireDialog— Esc / ✕ / backdrop / focus trap for free; the same helper will host the Merged / queue popovers for ✨ dashboard: Activity monitor merged/queue popovers become a modal sheet on phones #17165) with ≥44px items. Same markup, roles and arrow-key model as the desktop popover.Desktop (1280) does not match the query and is unchanged: harness geometry measurements and the small-control / font-size inventory at 1280 are byte-identical before/after.
Tightly coupled fix
stageTrackerTerminalViewread_stageTrackerMergeState[...]while that map is stillnull(before its first fetch lands), so opening a PR row's ⋯ menu before the merge state arrived threw. This is what kept the kebab from opening in the mobile-shots fixture; it now readsnullas "nothing merged yet".Gate
New probe
webstatic/testdata/tracker-phone-ergonomics.js, registered indashboard-mobile-shots.mjs: at 390×844 asserts zero interactive controls under 44×44, row tools inside the row header and always visible, kebab hosted in.hive-dialog.modal-sheetwith ≥44px items and clean close; other viewports reportskipped. Exclusions, documented in the probe: inline text links (a.ham-ref,a.ham-pr-ref, prose anchors) which flow with their text, and the chevron-strip word cells (.ham-chevron-info/.ham-decision-triggerinside.ham-chevron-copy) whose height is the row-strip layout (#17162).Local run of
node src/scripts/dashboard-mobile-shots.mjs --viewport 390x844@3 --theme lightwith the CI density fixture: all probes green (tracker-phone-ergonomics→controls: 74, menu: {sheet: true, items: 8}). WebKit 390 inventory with a 26-row fixture: 104 → 0 controls under 44×44 outside the inline-link exclusion.Screenshots (WebKit, 390×844)
Before / after attached below: rows + toolbar, and the kebab menu.