Skip to content

✨ Activity monitor: 44px tap targets, row tools in the header, kebab as a sheet on phones - #17177

Closed
clubanderson wants to merge 4 commits into
v5from
am-mobile-tap-targets
Closed

clubanderson wants to merge 4 commits into
v5from
am-mobile-tap-targets

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Fixes #17163
Part of #17158

What

In the dashboard's .modal-sheet phone tier (max-width: 640px, or coarse pointer ≤ 820px — the same query responsive.css already uses), the activity monitor:

  • remaps --tap-target → new --tap-target-touch (44px, base.css) for its subtree, so chips, selects, the search box, Merged / queue chips, label chips, grip / ? / ⚙ and the ⧉ ⛶ 📺 header tools all reach the Apple HIG / WCAG 2.5.5 floor via the existing token plumbing (tokens only, ADR-0018);
  • moves the per-row select checkbox and ⋯ kebab out of the hover-revealed 12px left gutter into the top-right corner of the row header — always visible, 44×44; the header reserves their width, and a phone-only min-width floor on .ham-title lets a squeezed title drop under the chips instead of wrapping word-per-word (375px fixture rows stay within the viewport — A's tracker-phone-chrome probe is green at 375/390/430);
  • opens the kebab menu as a .hive-dialog.modal-sheet (new stageTrackerOpenSheet helper over hiveWireDialog — Esc / ✕ / backdrop / focus trap for free; the same helper will host the Merged / queue popovers for ✨ dashboard: Activity monitor merged/queue popovers become a modal sheet on phones #17165) with ≥44px items. Same markup, roles and arrow-key model as the desktop popover.

Desktop (1280) does not match the query and is unchanged: harness geometry measurements and the small-control / font-size inventory at 1280 are byte-identical before/after.

Tightly coupled fix

stageTrackerTerminalView read _stageTrackerMergeState[...] while that map is still null (before its first fetch lands), so opening a PR row's ⋯ menu before the merge state arrived threw. This is what kept the kebab from opening in the mobile-shots fixture; it now reads null as "nothing merged yet".

Gate

New probe webstatic/testdata/tracker-phone-ergonomics.js, registered in dashboard-mobile-shots.mjs: at 390×844 asserts zero interactive controls under 44×44, row tools inside the row header and always visible, kebab hosted in .hive-dialog.modal-sheet with ≥44px items and clean close; other viewports report skipped. Exclusions, documented in the probe: inline text links (a.ham-ref, a.ham-pr-ref, prose anchors) which flow with their text, and the chevron-strip word cells (.ham-chevron-info / .ham-decision-trigger inside .ham-chevron-copy) whose height is the row-strip layout (#17162).

Local run of node src/scripts/dashboard-mobile-shots.mjs --viewport 390x844@3 --theme light with the CI density fixture: all probes green (tracker-phone-ergonomics → controls: 74, menu: {sheet: true, items: 8}). WebKit 390 inventory with a 26-row fixture: 104 → 0 controls under 44×44 outside the inline-link exclusion.

Screenshots (WebKit, 390×844)

Before / after attached below: rows + toolbar, and the kebab menu.

Before (390×844, WebKit) After (390×844, WebKit)
before: rows with 12px gutter controls and 23px selects after: 44px controls, select and kebab in the row header
before: anchored kebab popover with ~30px items after: kebab menu as a full-screen sheet with 44px items

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17185 🐛 fix(mobile-shots): phone-chrome probe credits the fixture note when counting visible rows same files src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js
#17179 ✨ dashboard: attention-first Activity monitor ordering and count line on phones same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#17183 ✨ dashboard: progress pill replaces the chevron strip on phones same files .github/scripts/integration-governance.cjs
.gitignore
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js
src/scripts/dashboard-mobile-shots.mjs
#17180 ✨ dashboard: 12px text floor for the Activity monitor on phones same files .github/scripts/integration-governance.cjs
src/docs/dashboard-design-system.md
src/pkg/dashboard/static/index.html
src/scripts/dashboard-mobile-shots.mjs
#17181 ✨ dashboard: Activity monitor merged and queue lists open as sheets on phones same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-merged.js
src/pkg/dashboard/static/index.html
#17191 ✨ dashboard: landscape-phone tier for the Activity monitor same files src/pkg/dashboard/static-src/js/tracker-merged.js
src/pkg/dashboard/static/index.html
src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js
#17171 🐛 fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion same files src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

This PR commits a Chrome browser profile (499 files under .chrome-dashboard-mobile-shots/), including Default/Cookies, Default/Login Data, Default/Login Data For Account, Default/History, Default/Web Data, Default/Sessions/Session_*, Default/Trust Tokens and Local State. It should not land with those files in it.

How it got there: src/scripts/dashboard-mobile-shots.mjs:48 sets PROFILE_DIR = path.join(process.cwd(), '.chrome-dashboard-mobile-shots') and passes it as --user-data-dir (line 242), so a local run of the shots harness writes a full Chromium profile into the repo root. .gitignore on main has no entry for it, and git add -A picked it up. The PR body describes only the tap-target / sheet work; the 10 real files (tracker.css, tracker-actions.js, tracker-merged.js, base.css, index.html, the new tracker-phone-ergonomics.js probe, docs, changelog, the TRUSTED_SCRIPTS_TREE re-pin) are +6184/-28 only because of the profile payload (size/XXL).

Consequence: the cookie / login / session SQLite databases are binary, so I cannot tell from the diff whether they hold a live GitHub or dashboard session from the local run. That is an open question for clubanderson: if that profile was ever signed in to anything, treat the session as exposed and rotate it, because the blobs are now in the PR's commit history on GitHub even after a force-push.

Suggested fix: drop .chrome-dashboard-mobile-shots/ from the branch (git rm -r --cached + force-push over the same commits so the blobs stop being reachable from the PR ref), and either add .chrome-dashboard-mobile-shots/ to .gitignore or have dashboard-mobile-shots.mjs use fs.mkdtempSync under os.tmpdir() so the harness can never leave a profile in the worktree. The second option is the one that stops this recurring for the other mobile-shots PRs.

On the code itself, read against main:

  • tracker-merged.js:905 — reading _stageTrackerMergeState || {} is a correct fix; on main the map is null until the first fetch and stageTrackerTerminalView indexes it unguarded at both call sites (lines 908 and 922). Looks correct to me.
  • tracker-actions.js — the sheet path skips the pointerdown/resize/scroll away-listeners and the Tab close, and closes via host.hiveDialogClose() instead of removing el, so the overlay (not just the inner menu) is torn down. Consistent with how hiveWireDialog dialogs close elsewhere. Looks correct to me.
  • integration-governance.cjs:12 — the TRUSTED_SCRIPTS_TREE re-pin is required by integration-governance.cjs:101-103 whenever src/scripts changes. Note ✨ dashboard: 12px text floor for the Activity monitor on phones #17180 and ✨ dashboard: progress pill replaces the chevron strip on phones #17183 also edit dashboard-mobile-shots.mjs and each pin a different tree; whichever of the three lands second will fail that gate until it is rebased and re-pinned. Not a defect here, just sequencing for whoever merges.

I have not changed or closed anything; flagging for the author / a maintainer to strip the profile before this is considered further.

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@clubanderson
clubanderson force-pushed the am-mobile-tap-targets branch from d8d94b4 to bffd24f Compare November 8, 2026 02:33
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 8, 2026
@clubanderson
clubanderson force-pushed the am-mobile-tap-targets branch from bffd24f to 00ff8e5 Compare November 8, 2026 02:38
@kubestellar-prow kubestellar-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

The mobile-shots failure here (375x667@2 tracker-phone-chrome: at least one row is fully visible…, rowsFullyVisible: 0) is the shared baseline incident #17186 — every dashboard PR since #17176 merged reports the identical measurement, including #17176's own run. Probe fix is #17185; a base merge after it lands clears this. No change needed on this branch for it.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…as a sheet on phones

In the .modal-sheet phone tier the activity monitor remaps --tap-target to
a new --tap-target-touch (44px) token for its subtree, so chips, selects,
the search box, Merged / queue chips, label chips, grip / ? / ⚙ and the
⧉ ⛶ 📺 header tools all meet the coarse-pointer floor. The per-row select
checkbox and ⋯ kebab leave the hover-revealed left gutter for the top-right
corner of the row header, always visible and 44×44. The kebab menu opens
as a .hive-dialog.modal-sheet (stageTrackerOpenSheet, reused by the
Merged / queue popovers next) with tap-sized items.

stageTrackerTerminalView now reads the merge state null-safely: it is null
until its first fetch lands, and a PR row's menu could be opened before
then (this is what kept the kebab from opening in the mobile-shots
fixture).

Adds the tracker-phone-ergonomics probe to dashboard-mobile-shots.mjs: at
390×844 it asserts zero controls under 44×44 (inline text links and the
chevron-strip word cells excluded), row tools inside the row header, and
the kebab hosted in a modal sheet; other viewports report skipped so
desktop is a no-diff.

Fixes #17163
Part of #17158

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
The tracker-phone-chrome acceptance added in #17176 asserts that a row is
fully visible at 375x667 with the section header at the top. The density
fixture's first .ham-row is a whole work-item cluster (parent issue, child
PR, decision, notes: ~418px) and never fits the 397px left below the chrome,
so every dashboard PR fails mobile-shots at 375x667 regardless of its diff.

Keep the intent (chrome stays short, a row shows without scrolling) but
accept a first row taller than the remaining viewport when at least 120px
of it is visible. Ignore the scratch Chrome profile the harness creates.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
(cherry picked from commit bffcb8b)
.chrome-dashboard-mobile-shots/ is the headless-Chrome profile the
mobile-shots harness creates; it is now gitignored.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the am-mobile-tap-targets branch from 00ff8e5 to 3c434de Compare November 8, 2026 02:57
@kubestellar-prow kubestellar-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2026
…ueeze it on phones

With the two 44px row tools reserved in the header, a narrow phone
(375px) left the title cell ~30px wide and wrapped it word-per-word,
pushing the first fixture row past the viewport. A phone-only
min-width floor on .ham-title makes it drop under the chips instead.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: this PR commits a Chrome user-data profile (~500 files) alongside the change.

Of the 509 files in this PR, 499 are under .chrome-dashboard-mobile-shots/ — the --user-data-dir that src/scripts/dashboard-mobile-shots.mjs:48 creates at process.cwd() (PROFILE_DIR = path.join(process.cwd(), '.chrome-dashboard-mobile-shots')). That directory is not in .gitignore on v5, so a git add -A after running the shots gate picked it up. It includes binary SQLite stores that should never be in a repository regardless of what they currently contain: Default/Cookies, Default/Login Data, Default/Login Data For Account, Default/History, Default/Web Data, Default/Secure Preferences, Default/Trust Tokens, plus Default/Extensions/** and Default/Web Applications/** (≈240 files). The profile was pointed at a live dashboard, so the cookie/session DBs are plausibly populated — a maintainer should treat this as a potential credential leak and consider rotating any dashboard session it may hold, not just dropping the files.

Suggested fix (tightly coupled, so it belongs in this PR): git rm -r --cached .chrome-dashboard-mobile-shots, and add .chrome-dashboard-mobile-shots/ to .gitignore so the shots script cannot do this to the next contributor. If the cookie DB turns out to hold a real session, the branch history should be rewritten rather than fixed forward.

The actual change (10 files) reads correctly to me.

  • tracker-actions.js: the sheet path hands stageTrackerCloseMenu(true) to hiveWireDialog as resolve, and stageTrackerCloseMenu in turn calls host.hiveDialogClose(). I checked both ends for re-entry: stageTrackerCloseMenu nulls _stageTrackerMenu before anything else (tracker-actions.js:801-804 on v5) and hiveWireDialog's close is guarded by done (tooltips-dialogs.js:429-437), so Esc from either keydown listener closes once. Dropping the pointerdown/resize/scroll away-listeners in sheet mode is right — the backdrop click is the dismissal there.
  • tracker-merged.js:905: const merged = _stageTrackerMergeState || {} — confirmed _stageTrackerMergeState starts null until the first fetch, so the pre-fetch kebab open did throw on _stageTrackerMergeState[rowKey]. Good fix.
  • .github/scripts/integration-governance.cjs: the TRUSTED_SCRIPTS_TREE bump is the mechanical hash update required when that file changes (adds the tracker-phone-ergonomics probe). #17180 and #17183 bump the same literal to different values, so whichever of the three lands second will need to re-pin.

Coordination note, not a defect: the PR body says stageTrackerOpenSheet "will host the Merged / queue popovers for #17165", but #17181 (open, same epic) already implements #17165 with its own hiveWireDialog sheets in tracker-merged.js / tracker-queue.js and also edits tracker.css. Both can't merge cleanly as-is; one should rebase onto the other and share the helper.

I have not approved or closed anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson

Copy link
Copy Markdown
Member Author

Superseded by #17193 (same content, rebased onto v5 after #17189).

hivecommons-hive Bot added a commit that referenced this pull request Nov 8, 2026
stageTrackerMergedPopDraw/stageTrackerQueuePopDraw ran a document-wide
querySelector on every draw tick, even with the popover hidden on desktop,
and the Node harness (stage_tracker_cues_test.go) stubs document without
querySelector, failing TestStageTrackerCelebrateNode, OdometerAfterBeeNode,
FlightTargetNode and MergeSessionNode. Open sheets are now registered in
_stageTrackerPopSheets by stageTrackerPopSheetOpen and dropped by the
hiveWireDialog resolve callback; stageTrackerPopSheet reads that map, and
both draw functions early-return when the popover is hidden and no sheet
is open. The querySelector tolerance shim is no longer needed.

#17177 (stageTrackerOpenSheet) is closed unmerged, so there is nothing to
rebase onto.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Nov 8, 2026
…n phones (#17181)

* ✨ dashboard: Activity monitor merged and queue lists open as sheets on phones

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* 🐛 test(dashboard): celebrate node bundle carries the pop-sheet helpers

stageTrackerMergedPopDraw now consults stageTrackerPopSheet, so every node
test built on stageTrackerCelebrateJS threw ReferenceError before reaching
its assertions.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* 🐛 dashboard: pop-sheet lookup tolerates DOM stubs without querySelector

stageTrackerPopSheet called document.querySelector unconditionally, which
broke the Go-driven node harness (stage_tracker_cues_test.go) whose document
stub has no querySelector, failing TestStageTrackerOdometerNode and the
merged-chip tests. Also rebased onto v5 to pick up the phone-chrome probe
fix (#17189) for mobile-shots.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* 🐛 dashboard: pop-sheet draw ticks consult state, not the DOM

stageTrackerMergedPopDraw/stageTrackerQueuePopDraw ran a document-wide
querySelector on every draw tick, even with the popover hidden on desktop,
and the Node harness (stage_tracker_cues_test.go) stubs document without
querySelector, failing TestStageTrackerCelebrateNode, OdometerAfterBeeNode,
FlightTargetNode and MergeSessionNode. Open sheets are now registered in
_stageTrackerPopSheets by stageTrackerPopSheetOpen and dropped by the
hiveWireDialog resolve callback; stageTrackerPopSheet reads that map, and
both draw functions early-return when the popover is hidden and no sheet
is open. The querySelector tolerance shim is no longer needed.

#17177 (stageTrackerOpenSheet) is closed unmerged, so there is nothing to
rebase onto.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ dashboard: Activity monitor tap targets meet --tap-target on phones

1 participant