Skip to content

✨ dashboard: Activity monitor merged and queue lists open as sheets on phones - #17181

Merged
hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-17165
Nov 8, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-17165

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

On phones the Merged and merge-queue popovers overhang the card and clip titles, with ~30px rows and tap-outside-only dismissal.
They now open as .hive-dialog.modal-sheet dialogs via hiveWireDialog (✕ / Esc / backdrop, focus returns to the chip), with tap-target rows, 2-line titles, repo chip and merged time.
Phone tier only (max-width: 640px / coarse ≤820px); desktop popovers are unchanged. index.html regenerated from static-src.

Closes #17165

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 8, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read at head 75f53a8 against the v5 tree. The sheet path looks correct to me; one low-severity keyboard edge worth knowing about.

What I verified

  • tracker-merged.js:808-814 / tracker-queue.js:139-147 — on the phone tier the toggle forces pop.hidden = true before opening the sheet. The existing document click handlers (tracker-merged.js:835-842, tracker-queue.js:155-160) early-return on pop.hidden, so a tap inside the body-appended sheet does not fall through to hamMergedToggle(false). Escape and backdrop are handled by hiveWireDialog, and the old Escape handlers are inert for the same reason.
  • stageTrackerMergedPopDraw / stageTrackerQueuePopDraw consult _stageTrackerPopSheets rather than the DOM, so refresh ticks redraw the open sheet body and still no-op when nothing is open.
  • Desktop path (tracker-merged.js:822-828) is byte-for-byte the old toggle.
  • .ham-merged-repo is hidden at desktop (tracker.css:726) and only laid out inside .ham-pop-sheet, so the popover rows are unchanged.

Low — Enter on a focused link closes the sheet instead of navigating

hiveWireDialog's capture-phase keydown handler (tooltips-dialogs.js:441-445) calls e.preventDefault() and submit(close) on Enter for every target that is not a textarea. The sheet passes submit = close => close(), so a keyboard user who tabs to a #NNN anchor in the Merged or queue list and presses Enter dismisses the sheet; the link never opens. Tap/click is unaffected, and the tier is mostly touch, so this is a suggestion, not a blocker: either let submit ignore the event when document.activeElement is an <a>, or teach hiveWireDialog to skip Enter on anchors (which would also benefit the other sheets).

Not blocking on the above; flagging so a maintainer can decide whether it belongs here or in a follow-up.

Evidence bundle `#1718175f53a8` sha256:3992ffd5fcfdc7ce4a3b401424c9d30a4f5673e0fc7219cf5e590a911d4d15c6 — download from the dashboard or `hivectl review evidence #17181`.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17171 🐛 fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion same files src/pkg/dashboard/static/index.html
#17179 ✨ dashboard: attention-first Activity monitor ordering and count line on phones same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#17180 ✨ dashboard: 12px text floor for the Activity monitor on phones same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Pushed 58d2047: the celebrate node-test bundle now includes the pop-sheet helpers (stageTrackerPopSheet*), which is what every failing dashboard shard tripped on (ReferenceError: stageTrackerPopSheet is not defined). The remaining red check, mobile-shots at 375×667 tracker-phone-chrome, is a shared baseline failure every dashboard PR hits since #17176 merged; the probe fix is #17185 — once it lands, a base merge clears it here.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Shared-CI incident for the 375×667 tracker-phone-chrome failure: #17186.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red because of this diff, not infrastructure. All dashboard shards fail the same four Node tests (TestStageTrackerCelebrateNode, TestStageTrackerOdometerAfterBeeNode, TestStageTrackerFlightTargetNode, TestStageTrackerMergeSessionNode) with:

TypeError: document.querySelector is not a function
    at stageTrackerPopSheet
    at stageTrackerMergedPopDraw
    at stageTrackerMergedCountDraw

Mechanism: stageTrackerMergedPopDraw (tracker-merged.js:765) and stageTrackerQueuePopDraw (tracker-queue.js:128) used to return immediately when the popover was hidden; they now call stageTrackerPopSheet(kind) → document.querySelector(...) unconditionally, on every draw tick. The Node harness those tests run under builds its own global.document with only getElementById/createElement (stage_tracker_cues_test.go:460 at this head), and stageTrackerCelebrateJS now splices the new functions into it (stage_tracker_cues_test.go:354-358), so the first stageTrackerMergedCountDraw throws.

Suggested fix, which also avoids a document-wide selector query per celebrate tick on desktop where the sheet can never exist:

const sheet = stageTrackerPopSheetPhone() ? stageTrackerPopSheet('merged') : null;

(and the same in tracker-queue.js). The harness has no matchMedia, so stageTrackerPopSheetPhone() is false there and the pre-PR early return is restored.

Otherwise the sheet wiring reads correctly: hiveWireDialog's close is guarded by done (tooltips-dialogs.js:429-437), the submit callback close => close() matches its submit(close) call on Enter, and hamMergedToggle(false) closing via sheet.hiveDialogClose() runs the chip-refocus callback once.

Coordination: #17177 (same epic) adds a generic stageTrackerOpenSheet helper in tracker-actions.js whose body says it "will host the Merged / queue popovers for #17165" — i.e. this PR. Both edit tracker-merged.js and tracker.css; whichever lands second should rebase and ideally share one helper.

I have not approved or closed anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 8, 2026
…n phones

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
hivecommons-hive Bot and others added 2 commits November 7, 2026 22:22
stageTrackerMergedPopDraw now consults stageTrackerPopSheet, so every node
test built on stageTrackerCelebrateJS threw ReferenceError before reaching
its assertions.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
stageTrackerPopSheet called document.querySelector unconditionally, which
broke the Go-driven node harness (stage_tracker_cues_test.go) whose document
stub has no querySelector, failing TestStageTrackerOdometerNode and the
merged-chip tests. Also rebased onto v5 to pick up the phone-chrome probe
fix (#17189) for mobile-shots.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 8, 2026
stageTrackerMergedPopDraw/stageTrackerQueuePopDraw ran a document-wide
querySelector on every draw tick, even with the popover hidden on desktop,
and the Node harness (stage_tracker_cues_test.go) stubs document without
querySelector, failing TestStageTrackerCelebrateNode, OdometerAfterBeeNode,
FlightTargetNode and MergeSessionNode. Open sheets are now registered in
_stageTrackerPopSheets by stageTrackerPopSheetOpen and dropped by the
hiveWireDialog resolve callback; stageTrackerPopSheet reads that map, and
both draw functions early-return when the popover is hidden and no sheet
is open. The querySelector tolerance shim is no longer needed.

#17177 (stageTrackerOpenSheet) is closed unmerged, so there is nothing to
rebase onto.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Read the diff against v5 and the code it leans on (hiveWireDialog, the document-level click/Esc handlers, the draw ticks).

Verified:

  • tooltips-dialogs.js:428-460 — hiveWireDialog sets overlay.hiveDialogClose and removes the overlay on Esc/backdrop/✕, so the sheet.hiveDialogClose() call in hamMergedToggle/hamQueueToggle and the _stageTrackerPopSheets cleanup in the resolve callback are the right hooks; focus returns to the chip as the body says.
  • tracker-merged.js:835-847 / tracker-queue.js:155-165 — the existing outside-click and Esc handlers early-return when pop.hidden, and the phone branch sets pop.hidden = true before opening the sheet, so there is no double-close path.
  • stageTrackerMergedPopDraw / stageTrackerQueuePopDraw consult the sheet map, so live ticks keep redrawing into the open sheet; tracker-queue.js:117 still closes the sheet when the chip hides.
  • .ham-merged-repo is display:none outside the phone tier (tracker.css:726), so the extra <span> does not disturb the desktop <li> grid.
  • git merge-tree against #17193 (which also edits tracker.css / tracker-merged.js) merges clean — no textual conflict between the two.

One low-severity note, pre-existing in hiveWireDialog rather than introduced here: its keydown handler (tooltips-dialogs.js:443-447) calls preventDefault() on Enter for any non-textarea target and then submit(close), which this PR passes as close => close(). A keyboard user who tabs to a PR link inside the sheet and presses Enter will dismiss the sheet instead of following the link. review-queue.js:373 has the same shape, so this matches the house pattern; if you want Enter to follow links in list-style sheets, that is a hiveWireDialog change, not something to fix in this PR.

I have not approved or labelled anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit d4afc8a into v5 Nov 8, 2026
83 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-17165 branch November 8, 2026 04:04
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ dashboard: Activity monitor merged/queue popovers become a modal sheet on phones

0 participants