Repository navigation
✨ dashboard: Activity monitor merged and queue lists open as sheets on phones - #17181
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Read at head What I verified
Low — Enter on a focused link closes the sheet instead of navigating
Not blocking on the above; flagging so a maintainer can decide whether it belongs here or in a follow-up. Evidence bundle `#1718175f53a8` sha256:3992ffd5fcfdc7ce4a3b401424c9d30a4f5673e0fc7219cf5e590a911d4d15c6 — download from the dashboard or `hivectl review evidence #17181`. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Pushed 58d2047: the celebrate node-test bundle now includes the pop-sheet helpers ( hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Shared-CI incident for the 375×667 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
CI is red because of this diff, not infrastructure. All dashboard shards fail the same four Node tests (TestStageTrackerCelebrateNode, TestStageTrackerOdometerAfterBeeNode, TestStageTrackerFlightTargetNode, TestStageTrackerMergeSessionNode) with:
TypeError: document.querySelector is not a function
at stageTrackerPopSheet
at stageTrackerMergedPopDraw
at stageTrackerMergedCountDraw
Mechanism: stageTrackerMergedPopDraw (tracker-merged.js:765) and stageTrackerQueuePopDraw (tracker-queue.js:128) used to return immediately when the popover was hidden; they now call stageTrackerPopSheet(kind) → document.querySelector(...) unconditionally, on every draw tick. The Node harness those tests run under builds its own global.document with only getElementById/createElement (stage_tracker_cues_test.go:460 at this head), and stageTrackerCelebrateJS now splices the new functions into it (stage_tracker_cues_test.go:354-358), so the first stageTrackerMergedCountDraw throws.
Suggested fix, which also avoids a document-wide selector query per celebrate tick on desktop where the sheet can never exist:
const sheet = stageTrackerPopSheetPhone() ? stageTrackerPopSheet('merged') : null;(and the same in tracker-queue.js). The harness has no matchMedia, so stageTrackerPopSheetPhone() is false there and the pre-PR early return is restored.
Otherwise the sheet wiring reads correctly: hiveWireDialog's close is guarded by done (tooltips-dialogs.js:429-437), the submit callback close => close() matches its submit(close) call on Enter, and hamMergedToggle(false) closing via sheet.hiveDialogClose() runs the chip-refocus callback once.
Coordination: #17177 (same epic) adds a generic stageTrackerOpenSheet helper in tracker-actions.js whose body says it "will host the Merged / queue popovers for #17165" — i.e. this PR. Both edit tracker-merged.js and tracker.css; whichever lands second should rebase and ideally share one helper.
I have not approved or closed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
…n phones Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
stageTrackerMergedPopDraw now consults stageTrackerPopSheet, so every node test built on stageTrackerCelebrateJS threw ReferenceError before reaching its assertions. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
stageTrackerPopSheet called document.querySelector unconditionally, which broke the Go-driven node harness (stage_tracker_cues_test.go) whose document stub has no querySelector, failing TestStageTrackerOdometerNode and the merged-chip tests. Also rebased onto v5 to pick up the phone-chrome probe fix (#17189) for mobile-shots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
58d2047 to
2f8f880
Compare
stageTrackerMergedPopDraw/stageTrackerQueuePopDraw ran a document-wide querySelector on every draw tick, even with the popover hidden on desktop, and the Node harness (stage_tracker_cues_test.go) stubs document without querySelector, failing TestStageTrackerCelebrateNode, OdometerAfterBeeNode, FlightTargetNode and MergeSessionNode. Open sheets are now registered in _stageTrackerPopSheets by stageTrackerPopSheetOpen and dropped by the hiveWireDialog resolve callback; stageTrackerPopSheet reads that map, and both draw functions early-return when the popover is hidden and no sheet is open. The querySelector tolerance shim is no longer needed. #17177 (stageTrackerOpenSheet) is closed unmerged, so there is nothing to rebase onto. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Looks correct to me. Read the diff against v5 and the code it leans on (hiveWireDialog, the document-level click/Esc handlers, the draw ticks).
Verified:
tooltips-dialogs.js:428-460—hiveWireDialogsetsoverlay.hiveDialogCloseand removes the overlay on Esc/backdrop/✕, so thesheet.hiveDialogClose()call inhamMergedToggle/hamQueueToggleand the_stageTrackerPopSheetscleanup in the resolve callback are the right hooks; focus returns to the chip as the body says.tracker-merged.js:835-847/tracker-queue.js:155-165— the existing outside-click and Esc handlers early-return whenpop.hidden, and the phone branch setspop.hidden = truebefore opening the sheet, so there is no double-close path.stageTrackerMergedPopDraw/stageTrackerQueuePopDrawconsult the sheet map, so live ticks keep redrawing into the open sheet;tracker-queue.js:117still closes the sheet when the chip hides..ham-merged-repoisdisplay:noneoutside the phone tier (tracker.css:726), so the extra<span>does not disturb the desktop<li>grid.git merge-treeagainst #17193 (which also editstracker.css/tracker-merged.js) merges clean — no textual conflict between the two.
One low-severity note, pre-existing in hiveWireDialog rather than introduced here: its keydown handler (tooltips-dialogs.js:443-447) calls preventDefault() on Enter for any non-textarea target and then submit(close), which this PR passes as close => close(). A keyboard user who tabs to a PR link inside the sheet and presses Enter will dismiss the sheet instead of following the link. review-queue.js:373 has the same shape, so this matches the house pattern; if you want Enter to follow links in list-style sheets, that is a hiveWireDialog change, not something to fix in this PR.
I have not approved or labelled anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
On phones the Merged and merge-queue popovers overhang the card and clip titles, with ~30px rows and tap-outside-only dismissal.
They now open as
.hive-dialog.modal-sheetdialogs viahiveWireDialog(✕ / Esc / backdrop, focus returns to the chip), with tap-target rows, 2-line titles, repo chip and merged time.Phone tier only (
max-width: 640px/ coarse ≤820px); desktop popovers are unchanged. index.html regenerated from static-src.Closes #17165
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson